D19719: [kpackages] compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R290 KPackage BRANC

D19718: [kiconthemes] compiles without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R302 KIconThemes BR

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

loh.tar added a comment. > currently I find only very few time :( I see, sorry to bother you...once more > Perhaps Dominik has some idea if that is right or not ;=) The biggest question here is these forced center call around 1463. Can you remember why/when this is needed/useful

D19408: [RFC] Avoid deadlock in use of vi mode searchbar

loh.tar added a comment. - Assume you add "qDebug() << keyEvent;" on top of this function - For whatever reason is by Ctrl-F this code running with `KateVi::Completer::completerHandledKeypress: QKeyEvent(KeyPress, Key_Enter) ` - When you you hint return it looks like this... `K

D17162: Harmonize handling of underscore in query parser

bruns added a comment. Ping! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17162 To: bruns, #baloo, #frameworks, ngraham, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17469: applications-games icon for dark theme

ndavis added a comment. @guoyunhe Do you mind if I commandeer this? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17469 To: guoyunhe, #breeze, #vdg, ndavis Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D19696: Add blender thumbnailer

bruns added inline comments. INLINE COMMENTS > blendercreator.cpp:134 > +blendStream.readRawData(imgBuffer, length); > +abgr_to_argb(imgBuffer, length); > +QImage thumbnail((unsigned char*)imgBuffer, x, y, QImage::Format_ARGB32); https://doc.qt.io/qt-5/qimage.html#rgbSwapped-1 REPOS

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

dhaumann added a comment. This needs a more detailed review, and currently I find only very few time :( in general, I once tried to fix this bug, but couldn't find a fix. Now you found one - but given this is a very central place I think this needs to be thought through complete prior to com

D19408: [RFC] Avoid deadlock in use of vi mode searchbar

dhaumann added subscribers: cullmann, dhaumann. dhaumann added a comment. Hm, I currently cannot say anything to this patch. I wonder where the \r comes from. And also, I wonder whether this if now is ever true? ...but if it fixes the issue... @cullmann: objections to a blind commit? REPOSI

D19697: Fixes the build failure when using ECM Android toolchain

sh-zam abandoned this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D19697 To: sh-zam Cc: vkrause, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19367: SearchBar: Don't block GUI when enter incremental pattern

loh.tar edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19367 To: loh.tar, #ktexteditor, dhaumann, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, ngraham, bruns, demsking, sars,

D19367: SearchBar: Don't block GUI when enter incremental pattern

loh.tar updated this revision to Diff 53752. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Fix autotest by add QTest::qWait(0) REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19367?vs=53281&id=53752 REVISION

D19697: Fixes the build failure when using ECM Android toolchain

sh-zam added a comment. I tested it against Android NDK's toolchain and it built fine. So, probably an issue with `ECM/toolchain/Android.cmake` REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D19697 To: sh-zam Cc: vkrause, apol, kde-frameworks-devel, michaelh, ng

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 73 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/73/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Mar 2019 18:28:32 + Build duration: 6 min 34 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/50/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 12 Mar 2019 18:28:32 + Build duration: 5 min 34 sec and counting JUnit Tests Name: (root)

D19575: Add collapse/expand-all, window-shade/unshade

This revision was automatically updated to reflect the committed changes. Closed by commit R266:b128afbbfe62: Add collapse/expand-all, window-shade/unshade (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19575?vs=53746&id=53751 REVIS

D19697: Fixes the build failure when using ECM Android toolchain

vkrause added a comment. Are you sure? pwd.h of the NDK contains the following here: #if __ANDROID_API__ >= 26 struct passwd* getpwent(void) __INTRODUCED_IN(26); void setpwent(void) __INTRODUCED_IN(26); void endpwent(void) __INTRODUCED_IN(26); #endif /* __ANDROID_API

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 81 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/81/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 12 Mar 2019 18:28:31 + Build duration: 1 min 36 sec and counting JUnit Tests Name: p

D19697: Fixes the build failure when using ECM Android toolchain

sh-zam added a comment. When using `API >= 26`, it doesn't find the enclosed functions, so we will have to make them non-static in that case. PS: Making them non-static doesn't break tests. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D19697 To: sh-zam C

D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

kossebau added a comment. @apol Thanks for review. No further comments anyone? Would then proceed to push this next Monday, March 18th, if no-one objects. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19565 To: kossebau, #frameworks Cc: apol, kde-frameworks-d

D19575: Add collapse/expand-all, window-shade/unshade

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Lovely! REPOSITORY R266 Breeze Icons BRANCH arcpatch-D19575 REVISION DETAIL https://phabricator.kde.org/D19575 To: ndavis, #vdg, ngraham, trickyricky26 Cc: ndavis, ngraham, kde-fr

D19575: Add collapse/expand-all, window-shade/unshade

ndavis retitled this revision from "Add collapse-all and expand-all action icons" to "Add collapse/expand-all, window-shade/unshade". ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: ndavis, #vdg, ngraham, tri

D19697: Fixes the build failure when using ECM Android toolchain

vkrause added a comment. I can reproduce with -DCMAKE_ANDROID_API=26 here, while anything below builds fine. This seems to fix it: diff --git a/src/lib/util/kuser_unix.cpp b/src/lib/util/kuser_unix.cpp index c42ea99..216dfb7 100644 --- a/src/lib/util/kuser_unix.cpp +++ b/src

D19575: Add collapse-all and expand-all action icons

ndavis updated this revision to Diff 53746. ndavis added a comment. - Add window-shade/unshade REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19575?vs=53744&id=53746 BRANCH arcpatch-D19575 REVISION DETAIL https://phabricator.kde.org/D19575 AFFEC

D19575: Add collapse-all and expand-all action icons

ndavis updated this revision to Diff 53744. ndavis added a comment. Lower down arrow on expand-all REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19575?vs=53522&id=53744 BRANCH arcpatch-D19575 REVISION DETAIL https://phabricator.kde.org/D19575 A

D19686: don't scale when we are in AA_UseHighDpiPixmaps

mart added a comment. latest version loads again correctly stuff from @2 icon dirs, still, only on integer scaling, as it was doing before (wether that behavior is to be changedis another topic) REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D19686 To: mart, #p

D19686: don't scale when we are in AA_UseHighDpiPixmaps

mart updated this revision to Diff 53740. mart added a comment. - scale the size for lookup on KIconThemePrivate::iconPath REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19686?vs=53727&id=53740 BRANCH phab/iconRendering REVISION DETAIL https://pha

D13150: Add ellipsis where appropriate

aspotashev added a comment. In D13150#428167 , @ngraham wrote: > This results in every item in the menu getting an ellipsis, which isn't appropriate because not all of them require more user action to proceed (the imgur plugin is one such exampl

D19696: Add blender thumbnailer

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > blendercreator.cpp:57 > +QPointer gzFile; > +if(file.peek(2).startsWith("\x1F\x8B")) { // gzip magic (each gzip > member starts with ID1(0x1f) and ID2(0

D19681: IconBorder: Accept drag&drop events

This revision was automatically updated to reflect the committed changes. Closed by commit R39:aa574ba2dac1: IconBorder: Accept drag&drop events (authored by loh.tar, committed by ngraham). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19681?vs=53653&id=53

D19438: Add syntax definition for Elm language to syntax-highlighting

bonghyunkim updated this revision to Diff 53736. bonghyunkim added a comment. Sorry that I forgot to update the actual diff file - this should compile now! REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19438?vs=53180&id=53736 REVISION DETAIL

D19696: Add blender thumbnailer

ngraham added a comment. What would make sense to me is to have a single repo/package that holds all thumbnailers (`kde-thumbnailers`?). Having them in multiple repos/packages doesn't make sense because there's no real reason to want to only exclude certain thumbnailers in the packaging, and

D19508: [kconf_update] move from custom logging tech to qCDebug

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R237:516f558742df: [kconf_update] move from custom logging tech to qCDebug (authored by sitter). REPOSITORY R237 KConfig

D19686: don't scale when we are in AA_UseHighDpiPixmaps

mart updated this revision to Diff 53727. mart added a comment. - don reset the scale that gets passed around REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19686?vs=53670&id=53727 BRANCH phab/iconRendering REVISION DETAIL https://phabricator.kde.

D19686: don't scale when we are in AA_UseHighDpiPixmaps

mart added a comment. In D19686#429343 , @broulik wrote: > I'm confused. Doesnt this undo the use of @2x icons and return to the old behavior of just loading a larger icon? hmm, perhaps, so probablythat check is to be done in kiconloader

D19697: Fixes the build failure when using ECM Android toolchain

sh-zam added a comment. Yes, that is confusing. I tried recreating the CI system, but it still doesn't compile. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D19697 To: sh-zam Cc: vkrause, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19697: Fixes the build failure when using ECM Android toolchain

vkrause added a comment. The CI is building this successfully though, with API level 21: https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.12/ REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D19697 To: sh-zam Cc: vkrause, apol, kde-fra

D19696: Add blender thumbnailer

ltoscano added a comment. In D19696#429476 , @broulik wrote: > Since this one is a bit more specific, perhaps it should indeed go into kdegraphics-thumbnailers, don't really mind. I think I have asked this often before but is kdegraphics-thumbna

D19438: Add syntax definition for Elm language to syntax-highlighting

nibags added a comment. It isn't possible to compile, because the `elm.xml` file has multiple issues :( The script "data/schema/validatehl.sh" serves to verify the XML files: cd syntax-highlighting/data/schema/ ./validatehl.sh ../syntax/elm.xml Output: ../syntax/elm.xm

D19697: Fixes the build failure when using ECM Android toolchain

sh-zam added a comment. Removing them doesn't help either. We could use conditionals, but then I was using API 21 and it failed with that. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabr

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/34/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 12 Mar 2019 09:19:06 + Build duration: 13 min and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/46/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 12 Mar 2019 09:19:06 + Build duration: 6 min 32 sec and counting JUnit Tests Nam

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/42/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Mar 2019 09:19:06 + Build duration: 5 min 5 sec and counting BUILD ARTIFACTS abi-co

D19698: Remove crash in plasmashell

This revision was automatically updated to reflect the committed changes. Closed by commit R242:ebae2d630336: Remove crash in plasmashell (authored by mlaurent). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19698?vs=53707&id=53712 REVISIO

D19697: Fixes the build failure when using ECM Android toolchain

vkrause added a comment. Are we sure this doesn't need to be conditional on the API level? Ie. only have those dummy declarations available on API levels before they were introduced on Android? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D19697 To: sh-zam Cc

D19698: Remove crash in plasmashell

mlaurent updated this revision to Diff 53707. mlaurent added a comment. Fix coding style REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19698?vs=53703&id=53707 BRANCH remove_crash_bug_405351 (branched from master) REVISION DETAIL ht

D19698: Remove crash in plasmashell

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH remove_crash_bug_405351 (branched from master) REVISION DETAIL https://phabricator.kde.org/D19698 To: mlaurent, dfaure, #frameworks, #plasma, broulik Cc: brou

D19696: Add blender thumbnailer

broulik added a comment. Since this one is a bit more specific, perhaps it should indeed go into kdegraphics-thumbnailers, don't really mind. I think I have asked this often before but is kdegraphics-thumbnailers a thing that is installed out of the box in most distros? REPOSITORY R320 KI

D19699: [DataModel] Add nullptr check

broulik abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19699 To: broulik, #plasma, mlaurent, arojas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19698: Remove crash in plasmashell

broulik requested changes to this revision. broulik added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > datamodel.cpp:67 > { > -return sourceModel()->roleNames(); > +if (sourceModel()) > + return sourceModel()->roleNames(); Coding style, braces

D19699: [DataModel] Add nullptr check

arojas added a comment. There's D19698 already REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19699 To: broulik, #plasma, mlaurent, arojas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19699: [DataModel] Add nullptr check

broulik created this revision. broulik added reviewers: Plasma, mlaurent, arojas. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Regression introduced by 9fc663d9f0edf41acd098b7c6c7b090d2c7b5aea

D19602: [KParts] Fix compilation for Qt 5.13

mlaurent accepted this revision. mlaurent added a comment. Could you commit it ?:) REPOSITORY R306 KParts BRANCH master REVISION DETAIL https://phabricator.kde.org/D19602 To: matthieugras, apol, mlaurent Cc: mlaurent, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19418: Make it compiles without deprecated method

broulik reopened this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > datamodel.cpp:67 > +{ > +return sourceModel()->roleNames(); > +} Likely culprit here, `sourceModel()` being `null` REPOSITORY R242 Plasma Framework (Library)

D19418: Make it compiles without deprecated method

broulik requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19418 To: mlaurent, dfaure, apol, broulik Cc: broulik, arojas, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/54/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Mar 2019 07:08:19 + Build duration: 33 min and counting BUILD ARTIFACTS abi-compatibility-result

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/40/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 12 Mar 2019 07:08:19 + Build duration: 15 min and counting BUILD ARTIFACTS abi-compatibility-result

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 58 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/58/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 12 Mar 2019 07:08:19 + Build duration: 9 min 16 sec and counting JUnit Tests Name: projectroo

D19692: openwithdialog: use recursive flag in proxy filter

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a7d59e121b15: openwithdialog: use recursive flag in proxy filter (authored by simgunz). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19692?vs=53689&id=53704 REVISION