D19193: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H

dhaumann added a comment. >> I think that may also fix the case example in https://bugs.kde.org/show_bug.cgi?id=398731 > > @dhaumann No comment to this? @cullmann May you? Yes, that is a good idea. The only issue I see is that with Ctrl+H you don't have a clear starting point. May

D19263: Add more highlighting for nested languages in markdown.

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH nested (branched from master) REVISION DETAIL https://phabricator.kde.org/D19263 To: vandenoever, #framework_syntax_highlighting, dhaumann Cc: dhaumann, kwrite-deve

D19263: Add more highlighting for nested languages in markdown.

dhaumann added a comment. Looks good to me, thanks. Before committing, could you increase the kateversion="5.0" in the language xml element as well? Otherwise KDE 4 users could get this via the download dialog as well, without getting the depending files due to 5.0 requirements in the o

D19193: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H

loh.tar added a subscriber: cullmann. loh.tar added a comment. >> For my taste is that hint not really right/useful. That should not be shown when the document begin/end was wrapped but when the initially staring point reached. > > I think that may also fix the case example in https://b

D19258: Do not print indent lines

loh.tar accepted this revision. loh.tar added a comment. This revision is now accepted and ready to land. Just my 2Cents INLINE COMMENTS > katerenderer.cpp:552 > Currently missing features: > - draw indent lines > */ Hm... > katerenderer.cpp:659 > > // Draw selection or ba

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/9/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 24 Feb 2019 02:08:26 + Build duration: 10 min and counting BUILD ARTIFACTS abi-compatibility

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/13/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 24 Feb 2019 02:08:26 + Build duration: 4 min 28 sec and counting BUILD ARTIFACTS abi-compat

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/15/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 24 Feb 2019 02:08:26 + Build duration: 3 min 29 sec and counting JUnit Tests Name: pr

D19202: Skip base64 encoding of QDataStream, avoid temporary QByteArray

bruns added a comment. Does not really depend on D19268 , but avoids errors due to a incomplete PATH REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D19202 To: bruns, #frameworks, #baloo, astippich, ngraham Cc: domson, ashapo

D19268: Let tests use the baloo_filemetadata_temp_extractor from the build dir

bruns added a dependent revision: D19202: Skip base64 encoding of QDataStream, avoid temporary QByteArray. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D19268 To: bruns, #frameworks, #baloo, ngraham, astippich, poboiko Cc: domson, ashaposhnikov, astippich, spoor

D19202: Skip base64 encoding of QDataStream, avoid temporary QByteArray

bruns added a dependency: D19268: Let tests use the baloo_filemetadata_temp_extractor from the build dir. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D19202 To: bruns, #frameworks, #baloo, astippich, ngraham Cc: domson, ashaposhnikov, astippich, spoorun, abraha

D19268: Let tests use the baloo_filemetadata_temp_extractor from the build dir

bruns created this revision. bruns added reviewers: Frameworks, Baloo, ngraham, astippich, poboiko. Herald added a project: Baloo. bruns requested review of this revision. REVISION SUMMARY Without adding the build directory to the PATH, QStandardPaths::findExecutable will return the temp extra

D19256: [RFC] height or width of FrameSvgItem can be set to a negative number, handle it..

apol added a comment. +1 makes sense to me REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19256 To: benjaminrobin, #plasma Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19251: Make it compiles without foreach

mlaurent added inline comments. INLINE COMMENTS > dfaure wrote in krcc.cpp:147 > move to temp var to avoid detaching? dir is const. Will it detach ? REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D19251 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham

D19263: Add more highlighting for nested languages in markdown.

vandenoever added a comment. Even folding works inside fenced blocks. After running `./autotests/update-reference-data.sh` `autotests/folding/example.rmd.fold` changed. I did not commit that change. The language version is now updated and I added a few more languages. REPOSITORY R

D19263: Add more highlighting for nested languages in markdown.

vandenoever updated this revision to Diff 52410. vandenoever added a comment. - added more languages, - updated language version - updated test files REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19263?vs=52395&id=52410 BRANCH nested (br

D16579: Remove support for non-standard APE tag field names

smithjd added a comment. > Anyway, most of this special handling of mimetypes goes away with D18826 , where TagLib will do the conversion automatically. The test files should reflect the most common tag fieldnames; 'albumartist' is used in the APEv2 t

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/24/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 23 Feb 2019 20:36:13 + Build duration: 2 min 5 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/29/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 23 Feb 2019 20:36:13 + Build duration: 2 min 9 sec and counting BUILD ARTIFACTS abi-compa

D19109: [Extractor] Add metadata to extractors

This revision was automatically updated to reflect the committed changes. Closed by commit R286:de81ddb651b1: [Extractor] Add metadata to extractors (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19109?vs=52402&id=52403 REVISION DET

D19109: [Extractor] Add metadata to extractors

bruns updated this revision to Diff 52402. bruns added a comment. add AppImage extractor metadata REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19109?vs=51936&id=52402 BRANCH baseline REVISION DETAIL https://phabricator.kde.org/D19109 AFFECTED

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

bruns updated this revision to Diff 52401. bruns marked an inline comment as done. bruns added a comment. add support for multiple integer values add multiple integer test REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19087?vs=51928&id=52401 BRANCH subm

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

bruns added inline comments. INLINE COMMENTS > astippich wrote in propertydata.cpp:80 > Please incorporate support for stringlists. > All clients currently rely on having string lists (or variantlists) as output > for multiple entries. It is also what is advertised in KFileMetaData. > None of th

D19193: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H

This revision was automatically updated to reflect the committed changes. Closed by commit R39:7d9bc72a1bb1: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka… (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D19193: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19193 To: loh.tar, #ktexteditor, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, brun

D19193: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H

dhaumann added a comment. Looks good to me - thanks. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19193 To: loh.tar, #ktexteditor Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D19263: Add more highlighting for nested languages in markdown.

dhaumann added a comment. Could you extend autotests/input/test.markdown ? Then call ./autotests/update-reference-data.sh in the build folder to copy the changes into the src folder, and update this patch. PS: And increase the "version" in the langauge xml element at the beginning of t

D19170: Fix crash while moving files

dfaure added a comment. I think it's an unwanted fact that the chmod job runs in parallel with the del job. A "return" after creating the chmod job would fix all this. But of course it should be possible to have two concurrent subjobs (one on dest, one on src), this whole issue just ma

D19109: [Extractor] Add metadata to extractors

bruns edited the summary of this revision. REPOSITORY R286 KFileMetaData BRANCH extractor_properties REVISION DETAIL https://phabricator.kde.org/D19109 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, domson, ashaposhnikov, michaelh, astippich, spoorun

D19251: Make it compiles without foreach

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > krcc.cpp:147 > { > -Q_FOREACH (const QString &fileName, dir.entryList()) { > +for (const QString &fileName : dir.entryList()) { > const QStri

D19263: Add more highlighting for nested languages in markdown.

vandenoever retitled this revision from "yAdd more highlighting for nested languages in markdown." to "Add more highlighting for nested languages in markdown.". REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19263 To: vandenoever, #framework_syntax_highlig

D19263: yAdd more highlighting for nested languages in markdown.

vandenoever added a reviewer: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19263 To: vandenoever, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann,

D19263: yAdd more highlighting for nested languages in markdown.

vandenoever created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. vandenoever requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH nested (branched from master) REVISION DETAIL https://phabrica

D19202: Skip base64 encoding of QDataStream, avoid temporary QByteArray

bruns added a comment. In D19202#418088 , @astippich wrote: > This causes at least one failure in all tests except filemetadatadisplaytest here? the properties are not properly retrieved somehow > and the warning > "Trying to construct an

D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

dhaumann added a comment. I think this, since it removes visual clutter. I think this should be configurable... Question is how to properly add an option in the config widget, since in the code I can see that this feature changes several options: tabs + trailing spaces + nonprintable ch

D19258: Do not print indent lines

dhaumann created this revision. dhaumann added a reviewer: loh.tar. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY Avoid printing indentation lines when "[x] Show indentation line

D19256: [RFC] height or width of FrameSvgItem can be set to a negative number, handle it..

benjaminrobin edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19256 To: benjaminrobin, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19256: [RFC] height or width of FrameSvgItem can be set to a negative number, handle it..

benjaminrobin added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19256 To: benjaminrobin, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19256: [RFC] height or width of FrameSvgItem can be set to a negative number, handle it..

benjaminrobin created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. benjaminrobin requested review of this revision. REVISION SUMMARY As explained in the bug report this is maybe not the right fix. It's hide the true problem. In the case o

D11987: [CopyJob] Pass resolved URL to finalDestUrl so looking up trash filename works

ngraham added a comment. Herald added a subscriber: kde-frameworks-devel. Ping, any update on this? @dfaure, could you lend a hand maybe, when you have some time? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11987 To: broulik, #frameworks, dfaure Cc: kde-frameworks-d

D18664: Baloo engine: treat every non-success code as a failure

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > poboiko wrote in postingdb.cpp:238 > Can it happen that `rc == MDB_NOTFOUND` just after some iterations of > `MDB_NEXT` operation (i.e. we've reached the end of

D19202: Skip base64 encoding of QDataStream, avoid temporary QByteArray

astippich added a comment. This causes at least one failure in all tests except filemetadatadisplaytest here? the properties are not properly retrieved somehow and the warning "Trying to construct an instance of an invalid type, type id: 21123393" is given. REPOSITORY R824 Baloo Widge

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

pino added a comment. In D18798#418082 , @anemeth wrote: > @pino also please consider that the same fix in another place was submitted, reviewed, accepted and landed, months ago I already said something about this. "we added crap, so let'

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

pino added a comment. In D18798#418072 , @ngraham wrote: > In D18798#418056 , @pino wrote: > > > Also, please do not resort to psychological tricks like "torture our users", as if this is any worse t

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

anemeth added a comment. In D18798#418072 , @ngraham wrote: > In D18798#418056 , @pino wrote: > > > Also, please do not resort to psychological tricks like "torture our users", as if this is any wors

D19255: WIP: Alternate approach to D19253

davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. TEST PLAN Done nothing yet, hence WIP REPOSITORY R127 KWayland BRANCH master

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

ngraham added a comment. In D18798#418056 , @pino wrote: > Also, please do not resort to psychological tricks like "torture our users", as if this is any worse than any behaviour issues there. There is no psychological trick. This is simp

D17302: Add test for adding properties to result

astippich added a comment. In D17302#417646 , @bruns wrote: > In D17302#410231 , @astippich wrote: > > > In D17302#410189 , @bruns wrote: > > > > > Cur

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/23/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 23 Feb 2019 15:30:37 + Build duration: 6 min 4 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/28/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 23 Feb 2019 15:30:37 + Build duration: 2 min 25 sec and counting BUILD ARTIFACTS abi-comp

D12950: add test which checks the property types

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R286:24359a020a1a: add test which checks the property types (authored by astippich). REPOSITORY R286 KFileMetaData CHANG

D16579: Remove support for non-standard APE tag field names

astippich added a comment. In D16579#416446 , @smithjd wrote: > I realise that with all the fields referenced here having at least one standard fieldname parsed now that complaining may seem to be flogging a dead horse, but I'd like to re-iterat

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

astippich added inline comments. INLINE COMMENTS > bruns wrote in propertydata.cpp:80 > Actually, I am not sure **if** we need the stringlists as a separate type.. > What is the difference between multiple strings in a stringlist, and multiple > strings as individual dict entries? > > What is

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

pino added a comment. Let me add also this: this behaviour seems triggered only when using breeze so far; hence, I see two possible explanations: 1. it is a bug in breeze 2. it is a bug in Qt, that somehow breeze manages to trigger In case it's (1), why was this behaviour even adde

D19109: [Extractor] Add metadata to extractors

astippich added a comment. also T8079 REPOSITORY R286 KFileMetaData BRANCH extractor_properties REVISION DETAIL https://phabricator.kde.org/D19109 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, domson, ashaposh

D19254: [RFC] KateRenderer: Show tabs and space characters the smart way

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY The original bug says: Show tabs and space characters only on s

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

pino added a comment. In D18798#418024 , @ngraham wrote: > In D18798#414082 , @ngraham wrote: > > > @Pino, can you help fix us the root cause then? The reason why we've resorted to these workarounds

D19109: [Extractor] Add metadata to extractors

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. I would also like to remove the aliasing mimetypes. But I guess due to the implementation where the mimetype is given as QString, and there is no guarantee that it is obtained from QM

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

ngraham added a comment. In D18798#414082 , @ngraham wrote: > @Pino, can you help fix us the root cause then? The reason why we've resorted to these workarounds is because nobody's been able to adequately understand the root cause or implement a

D18664: Baloo engine: treat every non-success code as a failure

poboiko added a comment. I've looked through the patch (quite large indeed), apart from the single note I think it's good to go. INLINE COMMENTS > postingdb.cpp:238 > mdb_cursor_close(cursor); > -if (termIterators.isEmpty()) { > +if (rc || termIterators.isEmpty()) { > r

D19249: Improve highlighting of TypeScript (and React) and add more tests for PHP

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH update-ts REVISION DETAIL https://phabricator.kde.org/D19249 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel,

D19251: Make it compiles without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REPOSITORY R243 KArchive BRANCH compile_without_foreach (branched from master) REVISION DETAIL

D19248: Make it compiles without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R270:0b4c5f3c9748: Make it compiles without foreach (authored by mlaurent). REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19248?vs=52369&id=52373 REVISION DETAIL htt

D19249: Improve highlighting of TypeScript (and React) and add more tests for PHP

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Add more examples in the PHP

D19248: Make it compiles without foreach

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R270 KCodecs BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19248 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18731: Replace KIconThemes dependency with equivalent QIcon usage

This revision was automatically updated to reflect the committed changes. Closed by commit R294:d29a5d644913: Replace KIconThemes dependency with equivalent QIcon usage (authored by vkrause). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18731?vs=50870&id=

D19248: Make it compiles without foreach

mlaurent added a reviewer: dfaure. REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D19248 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19248: Make it compiles without foreach

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Allow to compile it without foreach REPOSITORY R270 KCodecs BRANCH compile_without_foreach (branched from master

D19054: Port cross-compilation support to KF5_HOST_TOOLING

This revision was automatically updated to reflect the committed changes. Closed by commit R238:d6ccdc0fff46: Port cross-compilation support to KF5_HOST_TOOLING (authored by vkrause). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19054?vs=51797&id=52360 RE

D19200: Return sorted definitions for file names and mime types

dhaumann added a comment. Cool, thanks! ...which now leads us to the point where the only missing part is a unit test for the two new public functions :-) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19200 To: davschul, cullmann, vkrause Cc: dhaumann,