D18611: [appimage thumbnailer] Rely on imported cmake target libappimage

kossebau updated this revision to Diff 52353. kossebau added a comment. Use 0.1.10 as min version for libappimage, which is the first to provide working cmake config files REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18611?vs=50537&id=52353 BRANCH

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/22/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 23 Feb 2019 00:56:23 + Build duration: 7 min 5 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/27/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 23 Feb 2019 00:56:23 + Build duration: 6 min 34 sec and counting BUILD ARTIFACTS abi-comp

D18450: Add extractor for AppImage files

This revision was automatically updated to reflect the committed changes. Closed by commit R286:1aa7f9168d51: Add extractor for AppImage files (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18450?vs=51934&id=52352#toc REPOSITORY R286 KFileMetaData CHANGES SINCE

T3689: Add abi compliance checker to CI

bcooksley added a comment. With the exception of D19222 all of those have now been integrated. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss, bcooksley Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettc

D17302: Add test for adding properties to result

bruns added a comment. In D17302#410231 , @astippich wrote: > In D17302#410189 , @bruns wrote: > > > Currently, both > > `Result::add(prop, "value1"); Result::add(prop, "value2");` > > and > >

D19193: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H

loh.tar added a comment. > For my taste is that hint not really right/useful. That should not be shown when the document begin/end was wrapped but when the initially staring point reached. I think that may also fix the case example in https://bugs.kde.org/show_bug.cgi?id=398731 REPOSIT

D19163: Make it possible to show all spaces in the document

apol updated this revision to Diff 52320. apol added a comment. Fix tabs REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19163?vs=52319&id=52320 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19163 AFFECTED FILES autotests/src/vimode/

D19163: Make it possible to show all spaces in the document

apol updated this revision to Diff 52319. apol added a comment. Use an enum instead of two booleans REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19163?vs=52260&id=52319 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19163 AFFECTED FI

D19103: Middle-elide very long filenames in error strings

ngraham added a comment. Ping. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19103 To: ngraham, #frameworks, #dolphin Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D18125: KateStatusBar: Add dictionary button

loh.tar updated this revision to Diff 52307. loh.tar added a comment. - Remove '-w_accents -variant_0' and such from dict-code to keep it small and clean - Fix to show correct dict when cursor is at end of a range - Add signal caretChangedRange to ViewPrivate, much less overhead this way t

D19075: Fix FindEGL

dfaure added a comment. If anyone hits a cmake error about "/usr/include/EGL/EGL/egl.h" after updating ECM (e.g. in kwayland or plasma-framework), remove the cache in the builddir and rerun cmake. This commit is actually correct, it's just incompatible with existing caches. REPOSITORY R24

D19224: Only report DocBookXML as found if it was actually found

This revision was automatically updated to reflect the committed changes. apol marked an inline comment as done. Closed by commit R238:acf8d5352402: Only report DocBookXML as found if it was actually found (authored by apol). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabri

D19224: Only report DocBookXML as found if it was actually found

ltoscano accepted this revision. ltoscano added a comment. This revision is now accepted and ready to land. Right, sorry. REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL https://phabricator.kde.org/D19224 To: apol, #frameworks, ltoscano Cc: kde-frameworks-devel, kde-doc-englis

D19224: Only report DocBookXML as found if it was actually found

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > ltoscano wrote in FindDocBookXML4.cmake:88 > Isn't ${found_dir} undefined at this point? no, this is an argument to the function and it has to contain the output variable, as used in the line 86. REPOSITORY

D19223: Fix releaseme checkout when this is included in a sub-directory

This revision was automatically updated to reflect the committed changes. Closed by commit R240:6daec3f14576: Fix releaseme checkout when this is included in a sub-directory (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1922

D19224: Only report DocBookXML as found if it was actually found

ltoscano added a comment. Sorry, I forgot to save a comment. INLINE COMMENTS > FindDocBookXML4.cmake:88 > +else() > +message(WARNING "${found_dir}: Could not find docbookx.dtd in > ${CMAKE_SYSTEM_PREFIX_PATH} with suffixes ${DTD_PATH_LIST}") > +endif() Isn't ${found_dir} und

D19223: Fix releaseme checkout when this is included in a sub-directory

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D19223 To: vkrause, apol Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19224: Only report DocBookXML as found if it was actually found

apol added a comment. @ltoscano you said that you want changes to happen but didn't mention what needs changing? REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19224 To: apol, #frameworks, ltoscano Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngra

D19224: Only report DocBookXML as found if it was actually found

ltoscano requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19224 To: apol, #frameworks, ltoscano Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19224: Only report DocBookXML as found if it was actually found

apol updated this revision to Diff 52296. apol added a comment. Include a warning about how it wasn't found REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19224?vs=52293&id=52296 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19224 AFFE

D19170: Fix crash while moving files

hallas added a comment. In D19170#417274 , @dfaure wrote: > Let's find out :-) > > Note that SlaveBase already has a warning in case a slave emits finished() or error() twice; on the other hand this might not be the issue here, it could be t

D19224: Only report DocBookXML as found if it was actually found

apol created this revision. apol added a reviewer: Frameworks. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Otherwise we generate files with paths such as "searched_dir

D19223: Fix releaseme checkout when this is included in a sub-directory

vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This fixes the Marble build on binary factory. REPOSITORY R240 Extra CMake Modules BRAN

T3689: Add abi compliance checker to CI

knauss added a comment. Please merge the commits in following order: D19219 D19220 D19221 D19222 D19218

T3689: Add abi compliance checker to CI

knauss added a revision: D19218: create-abi-dump: small cleanup. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a revision: D19221: create-abi-dump: Let make it possible for create-abi-dump to break a build.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kanin

T3689: Add abi compliance checker to CI

knauss added a revision: D19222: create-abi-dump/check-abi: implement new accMetadata.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a revision: D19220: create-abi-dump: match new jenkings log format.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a revision: D19219: create-abi-dumps: do more debugging.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

D15910: Implement wl_surface::damage_buffer

romangg added a comment. Will be pushed after 5.56 branched off. REPOSITORY R127 KWayland BRANCH damageBuffer REVISION DETAIL https://phabricator.kde.org/D15910 To: romangg, #kwin, davidedmundson Cc: davidedmundson, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

T3689: Add abi compliance checker to CI

bcooksley added a comment. Build logs from our Docker images can be found at https://build.kde.org/job/Administration/ In this case, the image last changed 26 days ago. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss, bcooksley Cc: danders, davidedmundson, dfaure, kde-frameworks

T3689: Add abi compliance checker to CI

knauss added a comment. In T3689#175858 , @danders wrote: > Afaiu abi-dumper is the new way of creating dumps. From home page: > "This new way is based on the analysis of the debug-info from binary objects. It's more reliable, faster and simple

D19170: Fix crash while moving files

dfaure added a comment. Let's find out :-) Note that SlaveBase already has a warning in case a slave emits finished() or error() twice; on the other hand this might not be the issue here, it could be the job itself being buggy (and then it would be in a single location). But yeah I'd r

D19156: port to findcanberra from ECM

This revision was automatically updated to reflect the committed changes. Closed by commit R289:9964b8044974: port to findcanberra from ECM (authored by sitter). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19156?vs=52066&id=52274 REVISION DETAIL h

D19170: Fix crash while moving files

hallas added a comment. In D19170#417235 , @dfaure wrote: > Great analysis, thanks! Now this makes a lot more sense ;-) > > The thing that I don't get, is why the subjob would emit anything after result(). I.e. step 7 is not supposed to happe

D19170: Fix crash while moving files

dfaure added a comment. Great analysis, thanks! Now this makes a lot more sense ;-) The thing that I don't get, is why the subjob would emit anything after result(). I.e. step 7 is not supposed to happen, at all. cfeck: I think you're referring to warning(), which does pop up a messageb