D18895: AsciiDoc: Add folding for sections

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I think this change is ok. Although, adding many RegExprs is slow compared to other rules. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18895 T

D18864: FlatBuffers schema syntax highlighting

dhaumann accepted this revision. REPOSITORY R216 Syntax Highlighting BRANCH flatbuffers (branched from master) REVISION DETAIL https://phabricator.kde.org/D18864 To: harald, dhaumann, cullmann Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, d

D18864: FlatBuffers schema syntax highlighting

cullmann accepted this revision. cullmann added a comment. I think that is ok ;=) Thanks for the contribution, and nice to read from you Harald, too ;=) REPOSITORY R216 Syntax Highlighting BRANCH flatbuffers (branched from master) REVISION DETAIL https://phabricator.kde.org/D18864 T

D18915: Fix batchrename changing extension to lower case

chinmoyr added inline comments. INLINE COMMENTS > abalaji wrote in batchrenamejob.cpp:64 > I wonder if just getting rid of `.toLower()` fixes this bug I agree with @abalaji here. Modifying the code around this line should fix the bug and also address my previous comment. REPOSITORY R241 KIO

D18915: Fix batchrename changing extension to lower case

abalaji added a comment. Added a couple inline comments for you to address. Also, please use four spaces instead of tabs, and keep the spacing consistent (spaces around `+`, space between `if ()` and the `{). I have yet to run and test this, but if you check the comment on the left side of t

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

chinmoyr updated this revision to Diff 51383. chinmoyr marked 4 inline comments as done. chinmoyr added a comment. Fixed all issues. Added test case for suspend. > so the user knows that there data is gone *their REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricato

D18915: Fix batchrename changing extension to lower case

chinmoyr added a comment. @cfoster Thanks for the patch :) There's one more mass-rename related bug here: 1. Create two files; one with a known extension (.cpp) and the other with a random extension (.xyz, anything not in mime db) 2. Rename both. 3. The extension (.xyz) is remove

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

chinmoyr added a comment. @ngraham The destination file is corrupted as soon as the user clicks overwrite. This patch deletes that file. Is that file supposed to be preserved (to prevent user panic)? My suggestion is to append ".part" or some similar extension when an overwrite starts, so th

D18915: Fix batchrename changing extension to lower case

ngraham edited the summary of this revision. ngraham added reviewers: Dolphin, Frameworks, abalaji. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18915 To: cfoster, #dolphin, #frameworks, abalaji Cc: kde-frameworks-devel, michaelh, ngraham, bruns

T3689: Add abi compliance checker to CI

knauss added a comment. To create a dump by hand this isn't that easy. see sysadmins/ci-tooling/helpers/create-abi-dump.py. > I was unsuccesful using abi-dumper So far I understood abi-dumper is something different - I use abi-complience-checker to create those dumps. As you ne

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/19/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 10 Feb 2019 23:27:55 + Build duration: 9 min 1 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/14/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 10 Feb 2019 23:27:55 + Build duration: 4 min 2 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/12/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 10 Feb 2019 23:25:30 + Build duration: 4 min 49 sec and counting BUILD ARTIFACTS abi-compatibilit

D18877: Optimize Baloo::File copy assign operator, fix Baloo::File::load(url)

This revision was automatically updated to reflect the committed changes. Closed by commit R293:c6fd08d4c3c9: Optimize Baloo::File copy assign operator, fix Baloo::File::load(url) (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18877?vs=51260

D18900: Avoid side effects due to stale errno value

This revision was automatically updated to reflect the committed changes. Closed by commit R286:7cce4c7f7b47: Avoid side effects due to stale errno value (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18900?vs=51320&id=51373 REVISIO

D18915: Fix batchrename changing extension to lower case

cfoster created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cfoster requested review of this revision. REVISION SUMMARY Files renamed with Dolphins batch rename would have their file extensions always converted to lower case. New met

D18913: ECMGeneratePkgConfigFile API dox: fix "Since" for DESCRIPTION arg

kossebau created this revision. kossebau added a reviewer: cgiboudeaux. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Also place "Since" next to both argument and argu

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/13/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 10 Feb 2019 22:17:10 + Build duration: 5 min 28 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/18/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 10 Feb 2019 22:17:10 + Build duration: 2 min 19 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/17/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 10 Feb 2019 21:47:48 + Build duration: 8 min 14 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/12/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 10 Feb 2019 21:47:48 + Build duration: 4 min 29 sec and counting BUILD ARTIFACTS abi-comp

D18910: Use Kformat for bit and sample rate

This revision was automatically updated to reflect the committed changes. Closed by commit R286:e1fa79b30da2: Use Kformat for bit and sample rate (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18910?vs=51346&id=51367 REVISION DE

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 11 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/11/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 10 Feb 2019 21:26:53 + Build duration: 5 min 36 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.11 - Build # 88 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/88/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 10 Feb 2019 21:26:53 + Build duration: 3 min 35 sec and counting JUnit Tests

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 16 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/16/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 10 Feb 2019 21:26:53 + Build duration: 2 min 9 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 17 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/17/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 10 Feb 2019 21:26:53 + Build duration: 1 min 50 sec and counting JUnit Tests Name: p

D18910: Use Kformat for bit and sample rate

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ah yes. REPOSITORY R286 KFileMetaData BRANCH format_samplerate REVISION DETAIL https://phabricator.kde.org/D18910 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, a

D18911: Add units to framerate and gps data

This revision was automatically updated to reflect the committed changes. Closed by commit R286:a14030bf7182: Add units to framerate and gps data (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18911?vs=51353&id=51359 REVISION DE

D18910: Use Kformat for bit and sample rate

astippich added a comment. The unit will be corrected (it is _bit_rate) and three significant digits will always be shown: 123 400 will be displayed as 123 kbit/s 1 234 000 will be displayed as 1.23 Mbit/s 12 345 000 will be displayed as 12.3 Mbit/s REPOSITORY R286 KFileMetaData REVI

D18901: Add device icons for drones

rooty accepted this revision. REPOSITORY R266 Breeze Icons BRANCH drone-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D18901 To: trickyricky26, #vdg, hein, ngraham, rooty Cc: ngraham, hein, kde-frameworks-devel, michaelh, bruns

D18911: Add units to framerate and gps data

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH format_units REVISION DETAIL https://phabricator.kde.org/D18911 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun

D18901: Add device icons for drones

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ooh, that is much nicer. REPOSITORY R266 Breeze Icons BRANCH drone-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D18901 To: trickyricky26, #vdg, hein, n

D18910: Use Kformat for bit and sample rate

ngraham added a comment. No, I just want to get a sense of what the user-facing changes will be. :) REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18910 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun

D18911: Add units to framerate and gps data

astippich updated this revision to Diff 51353. astippich added a comment. - remove unrelated new lines REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18911?vs=51352&id=51353 BRANCH format_units REVISION DETAIL https://phabricator.kde.org/D18911

D18911: Add units to framerate and gps data

astippich created this revision. astippich added reviewers: ngraham, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Add units to some of the properties of kfilemetadata. This

D18901: Add device icons for drones

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18901 To: trickyricky26, #vdg, hein Cc: ngraham, hein, kde-frameworks-devel, michaelh, bruns

D18901: Add device icons for drones

trickyricky26 updated this revision to Diff 51351. trickyricky26 added a comment. - Use a circular design for the rotor to make it more recognisable REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18901?vs=51323&id=51351 BRANCH drone-icons (branched

D18910: Use Kformat for bit and sample rate

astippich added a comment. I actually have not started porting Dolphin to the new feature yet, since this will require Kf 5.56 and is probably stuff for 19.08. If a screenshot is a must I will adjust priorities :) REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

ngraham added a comment. Hmm actually maybe I take it back... is this in fact intended to fix 125102? Because the destination file is still destroyed when an overwrite operation is canceled in the middle. That's not what we want; we want the destination file to be left //untouched// when the

D18910: Use Kformat for bit and sample rate

ngraham added a comment. Any chance you can attach a screenshot of what this looks like now in Dolphin's information panel? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18910 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, mic

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

ngraham added a comment. Woohoo! Please add: BUG: 125102 FIXED-IN: 5.56 To the Summary section. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18904 To: chinmoyr, dfaure, dmitrio Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D18910: Use Kformat for bit and sample rate

astippich created this revision. astippich added reviewers: ngraham, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Format bit and sample rate to 3 significant digits REPOSITOR

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

dfaure added inline comments. INLINE COMMENTS > jobtest.cpp:2019 > +QSignalSpy spyCancelCopy(this, &JobTest::cancelCopy); > +connect (copyJob, &KIO::Job::processedSize, this, [this](KJob *job, > qulonglong processedSize) { > +if (processedSize > 0) { no space after `connect` >

D18317: Display an error message if loading a dictionary fails

ahmadsamir added a comment. I've split the changes to the Loader in https://phabricator.kde.org/D18907. And will hopefully try to handle the Ui part in this current diff. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D18317 To: ahmadsamir, sandsmark, loh.tar Cc:

D18907: Handle the case if createSpeller is passed an unavailable language

ahmadsamir created this revision. ahmadsamir added reviewers: sandsmark, cullmann, dhaumann. ahmadsamir added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY In Loader::createSpeller, retun early if lang isn't one of the available languages(); otherwise a

D18900: Avoid side effects due to stale errno value

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D18900 To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich Cc: kde-frameworks-devel, ashaposhnikov, michaelh,

D18877: Optimize Baloo::File copy assign operator, fix Baloo::File::load(url)

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yep, makes sense. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D18877 To: bruns, #baloo, #frameworks, ngraham, poboiko Cc: kde-frameworks-devel,

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

chinmoyr created this revision. chinmoyr added reviewers: dfaure, dmitrio. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY This patch borrows code from D10663 .

D18864: FlatBuffers schema syntax highlighting

harald marked 2 inline comments as done. harald added a comment. In D18864#408305 , @dhaumann wrote: > Hi Harald, nice hearing from you. Patch looks good and can almost go in as is. But could you address the two comments and also add a test file

D18864: FlatBuffers schema syntax highlighting

harald updated this revision to Diff 51331. harald added a comment. Added test, license and highlighting of attributes REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18864?vs=51217&id=51331 BRANCH flatbuffers (branched from master) REVISION

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 10 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/10/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 10 Feb 2019 17:36:06 + Build duration: 43 sec and counting CONSOLE OUTPUT [...truncated 25

KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.11 - Build # 87 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/87/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 10 Feb 2019 17:36:06 + Build duration: 34 sec and counting CONSOLE OUTPUT [.

D17245: Add string formatting function to property info

This revision was automatically updated to reflect the committed changes. Closed by commit R286:4bedfd6609c6: Add string formatting function to property info (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17245?vs=51271&id=51330

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 16 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/16/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 10 Feb 2019 17:36:06 + Build duration: 19 sec and counting CONSOLE OUTPUT [...trunca

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 15 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/15/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 10 Feb 2019 17:36:06 + Build duration: 42 sec and counting CONSOLE OUTPUT [...truncated 25

D18873: add baloo engine debugging category

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D18873 To: valeriymalov, #baloo, mlaurent, bruns Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, s

D18664: Baloo engine: treat every non-success code as a failure

bruns added a comment. Also, remove the second paragraph from the summary - a commit message is not a TODO list. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18664 To: valeriymalov, #baloo, bruns, poboiko Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo,

D18901: Add device icons for drones

trickyricky26 planned changes to this revision. trickyricky26 added a comment. In D18901#409255 , @ngraham wrote: > From a distance, I wonder if those stationary rotors really connote the right thing. How hard would it be to make them look spinni

D18664: Baloo engine: treat every non-success code as a failure

bruns added a comment. Also, these should only be CCBUG, as it is only an assumption it fixes any of these. Actually, I have seen the database return corrupt data, not caused by a failed call, but because the entry did contain garbage. REPOSITORY R293 Baloo REVISION DETAIL https://

D18894: [RFC] General config interface

loh.tar added a comment. Contrary to my announcement to use an enum as key I chosed the string for maximum simplicity. Yes, this way you notice a typo only at runtime, but in any case you have to know how some stuff has to be written. An enum key offer not only complile time checks but al

D18901: Add device icons for drones

ngraham added a comment. From a distance, I wonder if those stationary rotors really connote the right thing. How hard would it be to make them look spinning, by replacing them with circles instead? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18901 To: tri

D18901: Add device icons for drones

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added reviewers: VDG, hein. trickyricky26 added a subscriber: hein. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18901 To: trickyricky26, #vdg,

D18901: Add device icons for drones

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH drone-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D189

D18664: Baloo engine: treat every non-success code as a failure

bruns added a comment. looks almost good to me, can someone else please crosscheck? INLINE COMMENTS > documenturldb.h:140 > +qWarning() << "DocumentUrlDB::del" > + << "This folder still has > sub-files in its cache. It cannot b

D18900: Avoid side effects due to stale errno value

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY UserMetaData::hasAttribute and isSupported use

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/9/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 10 Feb 2019 15:00:41 + Build duration: 2 min 12 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/14/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 10 Feb 2019 15:00:41 + Build duration: 2 min 14 sec and counting BUILD ARTIFACTS abi-comp

D18891: Avoid leaking a QObject in ExternalExtractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:73d5fbbf5fb0: Avoid leaking a QObject in ExternalExtractor (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18891?vs=51298&id=51316 REVISI

D18891: Avoid leaking a QObject in ExternalExtractor

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH submit REVISION DETAIL https://phabricator.kde.org/D18891 To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich Cc: dhaumann, kde-frameworks-devel, ashaposhnikov, mi

D18891: Avoid leaking a QObject in ExternalExtractor

bruns added a comment. In D18891#409003 , @dhaumann wrote: > That looks reasonable, if ExtractorPlugin even has `QObject * parent = nullptr` I'd even remove nullptr as well. No, no default value ... REPOSITORY R286 KFileMetaData REVIS

D18895: AsciiDoc: Add folding for sections

andreasgr created this revision. andreasgr added reviewers: Framework: Syntax Highlighting, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. andreasgr requested review of this revision. REVISION SUMMARY As D18516

D18788: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e)

This revision was automatically updated to reflect the committed changes. Closed by commit R39:b9a52834ec45: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e) (authored by shubham). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18788?vs=5110

D18894: [RFC] General config interface

dhaumann added a subscriber: mwolff. dhaumann added a comment. This approach spreads they key "Word Wrap Column" across many files. You have to know the key and avoid typos. Currently we have this hard-coded and therefore statically checked by the compiler, which is very good. In grneral

D18770: [KStatusNotifierItem] use fallback sizes when none is available

pino added a subscriber: davidedmundson. pino added a comment. @davidedmundson any idea about this? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D18770 To: pino Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D18883: Add PDF thumbnailer

broulik added inline comments. INLINE COMMENTS > dhaumann wrote in pdfcreator.cpp:62 > Does this also give nice results with high dpi displays? KIO Thumbnailer doesn't support high dpi at all at this point. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18883 To:

D18894: [RFC] General config interface

loh.tar created this revision. loh.tar added reviewers: cullmann, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - Remove unneeded bool configIsRunning, add m_ pref

D18873: add baloo engine debugging category

mlaurent accepted this revision. mlaurent added a comment. Now it's ok for me :) Thanks REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18873 To: valeriymalov, #baloo, mlaurent, bruns Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spo

D18883: Add PDF thumbnailer

dhaumann added inline comments. INLINE COMMENTS > pdfcreator.cpp:62 > +// Compute a dpi that results in a thumbnail roughly the size we > requested > +const qreal fakeDpiX = width / page->pageSizeF().width() * 72.0; > +const qreal fakeDpiY = height / page->pageSizeF().height() * 72.0

D18891: Avoid leaking a QObject in ExternalExtractor

dhaumann added a comment. ThT looks reasonable, if ExtractorPlugin even has `QObject * parent = nullptr` I'd even remove nullptr as well. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18891 To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich Cc: dhau

D18878: Force NT1 protocol when listing smb:// network

mikhailnov edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18878 To: mikhailnov, #dolphin, #frameworks, sitter, broulik Cc: ngraham, acrouthamel, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales