D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18698 To: poboiko, #baloo, #frameworks, ngraham, bruns Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astip

D18829: [balooctl] Normalize include/exclude pathes before using it for the config

bruns marked an inline comment as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18829 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18829: [balooctl] Normalize include/exclude pathes before using it for the config

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > ngraham wrote in configcommand.cpp:43 > Does this need to be a `while`? Why not a regular old `if`? Are you trying to > handle the case where it ends with multiple trailing slashes? Exactly REPOSITORY R293

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/9/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 08 Feb 2019 23:48:04 + Build duration: 3 min 36 sec and counting BUILD ARTIFACTS abi-compatibility

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/7/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 08 Feb 2019 23:46:44 + Build duration: 2 min 11 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/12/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 08 Feb 2019 23:46:44 + Build duration: 2 min 19 sec and counting BUILD ARTIFACTS abi-comp

D18833: Get rid of mostly unused filePathToStat overload

This revision was automatically updated to reflect the committed changes. Closed by commit R293:ad4d29c4b170: Get rid of mostly unused filePathToStat overload (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18833?vs=51143&id=51232 REVISION D

D18835: Handle as container element in SVG

This revision was automatically updated to reflect the committed changes. Closed by commit R286:f86639982645: Handle as container element in SVG (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18835?vs=51145&id=51231 REVISION DET

D17287: Enable sharing URLs via email

This revision was automatically updated to reflect the committed changes. Closed by commit R495:73ea50ef1af2: Enable sharing URLs via email (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17287?vs=46639&id=51230#toc REPOSITORY R495 Purpose Library CHANGES SI

D17287: Enable sharing URLs via email

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH emailUrl REVISION DETAIL https://phabricator.kde.org/D17287 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17305: Add KDE Connect SMS plugin

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH kdeconnectsms REVISION DETAIL https://phabricator.kde.org/D17305 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18864: FlatBuffers schema syntax highlighting

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Hi Harald, nice hearing from you. Patch looks good and can almost go in as is. But could you address the two comments and also add a test file for unit testing? It can be short, is not

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

Hi David, Unfortunately it seems that the issue is still occurring as it has reappeared and blocked a Linux builder for ~22 hours. Same behaviour as last time i'm afraid - the kioslave processes had been directly launched by the test and were hanging as they were previously. Any ideas? Cheers, B

D18846: allow to compile without Q_FOREACH support

dhaumann added a comment. Btw, could we add a cmake definition to disallow foreach? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18846 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann

D18865: Change C/C++ header/source mimetype icons to circle/line style

This revision was automatically updated to reflect the committed changes. Closed by commit R266:fdf910145bef: Change C/C++ header/source mimetype icons to circle/line style (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18865?vs=5121

D18865: Change C/C++ header/source mimetype icons to circle/line style

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Oh so much better! REPOSITORY R266 Breeze Icons BRANCH text-x-c (branched from master) REVISION DETAIL https://phabricator.kde.org/D18865 To: ndavis, #vdg, ngraham Cc: ngraham, kd

D18865: Change C/C++ header/source mimetype icons to circle/line style

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18865 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18865: Change C/C++ header/source mimetype icons to circle/line style

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH text-x-c (branched from master) REVISION DETAIL https://phabricator

D18830: Handle folders matching substrings of included/excluded folders correctly

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D18830 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, n

D18612: Cache the default KColorScheme configuration

This revision was automatically updated to reflect the committed changes. Closed by commit R265:c0cc6b8a200a: Cache the default KColorScheme configuration (authored by mwolff). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18612?vs=50541&id=51212#toc REPOSITORY R265 KConfigWidgets CH

D18837: Fix missing shadows on C/C++ header mimetype icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:0eea3019324f: Fix missing shadows on C/C++ header mimetype icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18837?vs=51150&id=51205

D18835: Handle as container element in SVG

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks for the test. :) REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D18835 To: bruns, #baloo, #frameworks, astippich, poboiko, ngraham

D18612: Cache the default KColorScheme configuration

mwolff added a comment. pushed this now with a proper benchmark too, shows a ~10x performance win when a non-empty PATH is set REPOSITORY R265 KConfigWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D18612 To: mwolff, #kate, #kdevelop, dfaure, broulik Cc: broulik, kd

D18829: [balooctl] Normalize include/exclude pathes before using it for the config

ngraham added inline comments. INLINE COMMENTS > configcommand.cpp:43 > +{ > +while (path.endsWith(QLatin1Char('/'))) { > +path.chop(1); Does this need to be a `while`? Why not a regular old `if`? Are you trying to handle the case where it ends with multiple trailing slashes? REPOS

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

ngraham added a comment. @anemeth can provide the details, but IIRC we did wind up concluding that we needed this workaround in various places. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D18798 To: anemeth, #frameworks, kde-frameworks-devel, ngraham

D18833: Get rid of mostly unused filePathToStat overload

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D18833 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, n

D18813: Filter out invalid content in lists

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D18813 To: leinir, #knewstuff, ngraham Cc: ngraham, apol, kde-frameworks-devel, michaelh, ZrenBot, bruns

D18864: FlatBuffers schema syntax highlighting

harald created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. harald requested review of this revision. REVISION SUMMARY Support for FlatBuffers schema, for grammar see https://google.github.io/flatbuffers/flatbuffers_gramm

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20FreeBSDQt5.12/9/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 08 Feb 2019 18:53:23 + Build duration: 1 min 15 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 SUSEQt5.12 - Build # 4 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20SUSEQt5.12/4/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 08 Feb 2019 18:53:23 + Build duration: 10 min and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 SUSEQt5.10 - Build # 8 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20SUSEQt5.10/8/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 08 Feb 2019 18:53:22 + Build duration: 2 min 28 sec and counting BUILD ARTIFACTS abi-comp

D18702: Remove monochrome font preferences icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:b5c94b245d1a: Remove monochrome font preferences icon (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18702?vs=51167&id=51200 REVISION DETA

D18702: Remove monochrome font preferences icon

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH remove-monochrome-font-preferences-icon-and-improve-font-selection-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D18702 To: GB_2, #vdg, ngraham C

D18855: Improve font selection icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:11e51771626b: Improve font selection icon (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18855?vs=51195&id=51196 REVISION DETAIL https:/

D18855: Improve font selection icon

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH improve-font-selection-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D18855 To: GB_2, #vdg, ngraham Cc: kde-frameworks-devel, #vdg, michaelh, ngra

D18837: Fix missing shadows on C/C++ header mimetype icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice. Next can you improve the hideous pixellated "c" and "h" characters for the C and C++ source and header files? F6601734: Screenshot_20190208_093323.png

D18855: Improve font selection icon

GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Improves the font selection icon by making the three dots black/white instead of orange. F65848

D18853: Fix sharing files with spaces or quotes in names via Telegram

mikhailru added a reviewer: apol. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D18853 To: mikhailru, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18853: Fix sharing files with spaces or quotes in names via Telegram

mikhailru created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mikhailru requested review of this revision. REVISION SUMMARY At present, when one tries to share files with certain names via Telegram using Dolphin's share menu, Dolphin cr

D18739: Sync QML module padding to reflect system setting pages

This revision was automatically updated to reflect the committed changes. Closed by commit R295:ab33762a6a60: Sync QML module padding to reflect system setting pages (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18739?vs=51174&id=51185#toc REPOSITORY R295

D16735: Implement text_input_unstable_v3

zzag added inline comments. INLINE COMMENTS > test_text_input.cpp:545-548 > +QFETCH(bool, clientCommits); > +if (clientCommits) { > +textInput->commit(); > +} Personal opinion: tests have to be easy to follow, it's okay if we copy some code. I'd prefer to have a specialized

D18739: Sync QML module padding to reflect system setting pages

ngraham added a comment. Looks like this also fixes https://bugs.kde.org/show_bug.cgi?id=396942 REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D18739 To: davidedmundson, #plasma, broulik Cc: ngraham, zzag, broulik, vpilo, kde-frameworks-devel, micha

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/8/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 08 Feb 2019 14:21:45 + Build duration: 3 min 45 sec and counting BUILD ARTIFACTS abi-compatibility

D18804: Workaround for the bug 393630 - Framework part

ngraham removed a dependent revision: D18805: Workaround for the bug 393630 - SystemTray part. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18804 To: trmdi, broulik, davidedmundson, fvogt, anthonyfieroni, ngraham, #plasma Cc: kde-frameworks-devel,

D18851: [Extractor] Exclude GPG encrypted data from being indexed

This revision was automatically updated to reflect the committed changes. Closed by commit R293:3aa911d4a0ac: [Extractor] Exclude GPG encrypted data from being indexed (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18851?vs=51183&id=51184 R

D18851: [Extractor] Exclude GPG encrypted data from being indexed

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D18851 To: bruns, #baloo, #frameworks, ngraham, poboiko Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, n

D18851: [Extractor] Exclude GPG encrypted data from being indexed

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY application/pgp-encrypted may be encoded as base64 and thu

D18813: Filter out invalid content in lists

ngraham added a comment. Conceptually this makes sense, provided we can rely on `content.isValid()` returning valid results. :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D18813 To: leinir, #knewstuff Cc: ngraham, apol, kde-frameworks-devel, michaelh, ZrenBot,

D18849: [KPropertiesDialog] Fix group combobox

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18849 To: cfeck, #frameworks, #dolphin, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18849: [KPropertiesDialog] Fix group combobox

cfeck created this revision. cfeck added reviewers: Frameworks, Dolphin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cfeck requested review of this revision. REVISION SUMMARY `groupList` was never initialized with `KUser::groupNames()`, causing the subse

D18768: Extend Open Document thumbnailer to Open Packaging Conventions format

This revision was automatically updated to reflect the committed changes. Closed by commit R320:c6da4dabf635: Extend Open Document thumbnailer to Open Packaging Conventions format (authored by broulik). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18768?v

D18846: allow to compile without Q_FOREACH support

This revision was automatically updated to reflect the committed changes. Closed by commit R216:b1ecf6aa60c2: allow to compile without Q_FOREACH support (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18846?vs=51171&id=51177#toc REPOSITORY R216 Syntax Highlightin

D18768: Extend Open Document thumbnailer to Open Packaging Conventions format

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18768 To: broulik, #plasma, #vdg, #frameworks, davidedmundson Cc: davidedmundson, acrouthamel, kde-frameworks-devel, kfm-devel, alex

D18739: Sync QML module padding to reflect system setting pages

zzag added inline comments. INLINE COMMENTS > kcmultidialog.cpp:40-41 > #include > +#include > +#include > It looks like includes are sorted. Maybe keep it that way? REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D18739 To: davidedmundson, #pla

D18846: allow to compile without Q_FOREACH support

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18846 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars

D18739: Sync QML module padding to reflect system setting pages

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D18739 To: davidedmundson, #plasma, broulik Cc: broulik, vpilo, kde-frameworks-devel, michaelh, ngraham, bruns

D18768: Extend Open Document thumbnailer to Open Packaging Conventions format

broulik retitled this revision from "Extend Open Document thumbnailer to Office Open XML" to "Extend Open Document thumbnailer to Open Packaging Conventions format". broulik edited the summary of this revision. broulik edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISIO

D18739: Sync QML module padding to reflect system setting pages

davidedmundson updated this revision to Diff 51174. davidedmundson added a comment. more hacks REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18739?vs=51165&id=51174 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18739 AFFECTED FILES s

D18768: Extend Open Document thumbnailer to Office Open XML

broulik updated this revision to Diff 51173. broulik added a comment. - Read thumbnail location from `rels` - Add `.xps` file format (used in Windows for printing, I believe) which also follows the spec and qualifies as "office document" REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDA

D18846: allow to compile without Q_FOREACH support

cullmann updated this revision to Diff 51171. cullmann added a comment. Missed 2 Q_FOREACH variants REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18846?vs=51168&id=51171 REVISION DETAIL https://phabricator.kde.org/D18846 AFFECTED FILES au

D18768: Extend Open Document thumbnailer to Office Open XML

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. It seems we can get the correct path via the _rels file as per https://en.wikipedia.org/wiki/Open_Packaging_Conventions which avoids guessing, and allows us t

D18813: Filter out invalid content in lists

leinir updated this revision to Diff 51169. leinir marked an inline comment as done. leinir added a comment. Swap the logic around a bit, makes for an easier to read patch and whatnot. REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18813?vs=51099&id=51169

D18813: Filter out invalid content in lists

leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS > apol wrote in atticaprovider.cpp:277 > Maybe it would be easier to read if we had a `if (!content.isValid()) > continue; ...`. Hmm... the patch certainly would, i'll swap that around a bit. Generally don't

D18846: allow to compile without Q_FOREACH support

cullmann created this revision. cullmann added a reviewer: vkrause. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY replaces Q_FOREACH with C++11 for TEST PLAN make && make test

D18702: Remove monochrome font preferences icon

GB_2 retitled this revision from "Remove monochrome font preferences icon and improve font selection icon" to "Remove monochrome font preferences icon". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18702 To: GB_2, #vdg Cc: ngraham, ndavis, kde-frameworks-devel,

D18702: Remove monochrome font preferences icon and improve font selection icon

GB_2 updated this revision to Diff 51167. GB_2 added a comment. Revert font selection icon change REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18702?vs=50782&id=51167 BRANCH remove-monochrome-font-preferences-icon-and-improve-font-selection-icon

D18702: Remove monochrome font preferences icon and improve font selection icon

GB_2 edited the summary of this revision. GB_2 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18702 To: GB_2, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D18739: Sync QML module padding to reflect system setting pages

davidedmundson added a comment. Running kcmshell5 icons style was a good suggestion. We have to change an internal layout and only one of the edges - which leads to this monstrosity :/ REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D18739 To: davidedmundson, #

D18739: Sync QML module padding to reflect system setting pages

davidedmundson updated this revision to Diff 51165. davidedmundson added a comment. remove hardcoded value REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18739?vs=51163&id=51165 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18739 AFFECT

D18739: Sync QML module padding to reflect system setting pages

davidedmundson updated this revision to Diff 51163. davidedmundson edited the summary of this revision. davidedmundson edited the test plan for this revision. davidedmundson added a comment. update REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18739?vs=50

D18813: Filter out invalid content in lists

apol added a comment. I guess the patch makes sense overall. INLINE COMMENTS > atticaprovider.cpp:277 > +for (const Content &content : contents) { > +if (content.isValid()) { > +if (checker.filterAccepts(content.tags())) { Maybe it would be easier to read if we had a

D18834: Change glowbar.svgz to smoother style

zzag added a comment. Also, it's worth to mention glowbar from Oxygen theme (plasma-framework/src/desktoptheme/oxygen/widgets/glowbar.svgz). REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18834 To: ndavis, #vdg, rooty Cc: zzag, rooty, rapiteanu,

D18834: Change glowbar.svgz to smoother style

zzag added a comment. In D18834#407533 , @ndavis wrote: > I had a look through the Screen Edge effect code and while I'm no expert, I didn't see anything that would obviously make the corners large. The screen edge effect scales corner ti

D18739: Sync QML module padding to reflect system setting pages

vpilo added a comment. In D18739#407649 , @broulik wrote: > If you open multiple KCMs switching between QML- and Widget-ones leads to awkward outside margin changes with this patch. > > kcmshell5 icons style > > > Switch between the t

Re: CI for prison: missing dependency

On Fri, Feb 8, 2019 at 5:57 AM Volker Krause wrote: > > On Saturday, 2 February 2019 19:15:36 CET Ben Cooksley wrote: > > On Sun, Feb 3, 2019 at 12:02 AM David Faure wrote: > > > On samedi 2 février 2019 11:20:28 CET CI System wrote: > > > > -- The following REQUIRED packages have not been found:

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.11 - Build # 13 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/13/ Project: kf5-qt5 AndroidQt5.11 Date of build: Fri, 08 Feb 2019 09:54:10 + Build duration: 1 min 4 sec and counting

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.11 - Build # 12 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/12/ Project: kf5-qt5 AndroidQt5.11 Date of build: Fri, 08 Feb 2019 09:37:11 + Build duration: 1 min 57 sec and counting CONSOLE OUTPUT [...truncat

D18739: Sync QML module padding to reflect system setting pages

broulik added a comment. If you open multiple KCMs switching between QML- and Widget-ones leads to awkward outside margin changes with this patch. kcmshell5 icons style Switch between the two and observe how the sidebar dances (this is likely the same issue as when doing the same

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/8/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 08 Feb 2019 08:57:29 + Build duration: 11 min and counting BUILD ARTIFACTS abi-compatib

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/16/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 08 Feb 2019 08:57:29 + Build duration: 4 min 44 sec and counting BUILD ARTIFACTS abi-c

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/20/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 08 Feb 2019 08:57:29 + Build duration: 2 min 35 sec and counting JUnit Tests Nam

D18834: Change glowbar.svgz to smoother style

This revision was automatically updated to reflect the committed changes. Closed by commit R242:054b494bb3f2: Change glowbar.svgz to smoother style (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18834?vs=51144&id=51154

D18834: Change glowbar.svgz to smoother style

ndavis added a comment. Well, there's nothing wrong within the patch itself, so I'll land it. REPOSITORY R242 Plasma Framework (Library) BRANCH fix-glowbar (branched from master) REVISION DETAIL https://phabricator.kde.org/D18834 To: ndavis, #vdg, rooty Cc: rooty, rapiteanu, kde-frame

D18804: Workaround for the bug 393630 - Framework part

trmdi abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18804 To: trmdi, broulik, davidedmundson, fvogt, anthonyfieroni, ngraham, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18837: Fix missing shadows on C/C++ header mimetype icons

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Some shadow objects had no fill because the gradients they referenced were missing. BU