D18834: Change glowbar.svgz to smoother style

ndavis added a comment. In D18834#407534 , @rooty wrote: > You could make it smaller? It looks fine to me at the corners, it's the actual sidebar that's a little thick. > > I still like this diff though, I think that the master's too stipple

D18834: Change glowbar.svgz to smoother style

rooty added a comment. You could make it smaller? It looks fine to me at the corners, it's the actual sidebar that's a little thick. I still like this diff though, I think that the master's too stippled/dotted. REPOSITORY R242 Plasma Framework (Library) BRANCH fix-glowbar (branched

D18834: Change glowbar.svgz to smoother style

ndavis added a comment. I suppose it's this, but it's somehow even worse with this patch: https://bugs.kde.org/show_bug.cgi?id=337712 I had a look through the Screen Edge effect code and while I'm no expert, I didn't see anything that would obviously make the corners large. REPOSITORY

D18834: Change glowbar.svgz to smoother style

rooty added a comment. In D18834#407529 , @ndavis wrote: > For some reason, this version looks much larger in the corners. Was there a change to how the screen edge effect works? I didn't change the size of the corners in the SVGZ. F6599

D18834: Change glowbar.svgz to smoother style

ndavis added a comment. For some reason, this version looks much larger in the corners. Was there a change to how the screen edge effect works? I didn't change the size of the corners in the SVGZ. REPOSITORY R242 Plasma Framework (Library) BRANCH fix-glowbar (branched from master) REVI

D18834: Change glowbar.svgz to smoother style

rooty added a comment. Sure thing. This seems straightforward enough to me though REPOSITORY R242 Plasma Framework (Library) BRANCH fix-glowbar (branched from master) REVISION DETAIL https://phabricator.kde.org/D18834 To: ndavis, #vdg, rooty Cc: rooty, rapiteanu, kde-frameworks-devel,

D18834: Change glowbar.svgz to smoother style

ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH fix-glowbar (branched from master) REVISION DETAIL https://phabricator.kde.org/D18834 To: ndavis, #vdg, rooty Cc: rooty, rapiteanu, kde-frameworks-d

D18834: Change glowbar.svgz to smoother style

ndavis added a comment. In D18834#407524 , @rooty wrote: > Wait I can do that? I didn't know I could do that :D Yes, but I should have said make sure you've given patches you want to approve a good look first. Use `arc patch D` so you can

D18834: Change glowbar.svgz to smoother style

rooty accepted this revision. rooty added a comment. This revision is now accepted and ready to land. Wait I can do that? I didn't know I could do that :D REPOSITORY R242 Plasma Framework (Library) BRANCH fix-glowbar (branched from master) REVISION DETAIL https://phabricator.kde.org/D1

D18834: Change glowbar.svgz to smoother style

ndavis added a comment. If you like it, don't be afraid to hit "Approve" ;) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18834 To: ndavis, #vdg Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

ndavis edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18834 To: ndavis, #vdg Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

rooty added a comment. In D18834#407518 , @rapiteanu wrote: > This looks really good! > With this the bug 391343 will be fixed. I like it too, +1. Can you also CC the BUG so it gets closed? REPOSITORY R242 Plasma Framework (Librar

D18834: Change glowbar.svgz to smoother style

rapiteanu added a comment. This looks really good! With this the bug 391343 will be fixed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18834 To: ndavis, #vdg Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18834 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18834 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18834 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18835: Handle as container element in SVG

bruns created this revision. bruns added reviewers: Baloo, Frameworks, astippich, poboiko, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY is a container element as , so handle both the

D18834: Change glowbar.svgz to smoother style

ndavis added a comment. JFYI, the whole embedded stylesheet thing doesn't work on gradients, so it doesn't matter if colors are hardcoded. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18834 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, n

D18834: Change glowbar.svgz to smoother style

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The old style was weird. When the screen edge feature was enabled for the sides of screens,

D18824: Implement wl_eglstream_controller Server Interface

ekurzinger added a dependent revision: D18570: EGLStream DRM Backend Initial Implementation. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18824 To: ekurzinger, romangg, davidedmundson, zzag, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18824: Implement wl_eglstream_controller Server Interface

ekurzinger removed a dependency: D18570: EGLStream DRM Backend Initial Implementation. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18824 To: ekurzinger, romangg, davidedmundson, zzag, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18833: Get rid of mostly unused filePathToStat overload

bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY It is only used in one place to retrieve the device ID, wh

D18822: Fix Windows build [hopefully]

aacid added a subscriber: albertvaka. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D18822 To: aacid Cc: albertvaka, kossebau, vonreth, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/7/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 07 Feb 2019 23:10:32 + Build duration: 7 min 29 sec and counting BUILD ARTIFACTS abi-compatibility

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/6/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 07 Feb 2019 23:01:18 + Build duration: 9 min 13 sec and counting BUILD ARTIFACTS abi-compatibility

D18828: [balooctl] Actually abort a malformed command instead of just saying so

This revision was automatically updated to reflect the committed changes. Closed by commit R293:a040c71e353d: [balooctl] Actually abort a malformed command instead of just saying so (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18828?vs=511

D18827: [balooctl] Add missing help for "config set", normalize string

This revision was automatically updated to reflect the committed changes. Closed by commit R293:3a31a7ed0e29: [balooctl] Add missing help for "config set", normalize string (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18827?vs=51129&id=511

D18825: Replace recursive isDirHidden with iterative one, allow const argument

This revision was automatically updated to reflect the committed changes. Closed by commit R293:38698b1a4c9e: Replace recursive isDirHidden with iterative one, allow const argument (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18825?vs=5112

D18824: Implement wl_eglstream_controller Server Interface

ekurzinger added a dependency: D18570: EGLStream DRM Backend Initial Implementation. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18824 To: ekurzinger, romangg, davidedmundson, zzag, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

elvisangelaccio added a comment. Wait, do we need to add this workaround to every popup menu around? What about 3d-party apps? Can't we fix the actual bug in Qt/breeze/whatever instead? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D18798 To: anem

D17245: Add string formatting function to property info

bruns added a comment. `src/formatstrings.h` should be named `src/formatstrings_p.h` REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17245 To: astippich, broulik, bruns, mgallien, #frameworks Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, a

D18822: Fix Windows build [hopefully]

kossebau added a comment. Looks fine to me from quick reading, everything done I would have thought of (whatever that is worth :P ) +1 REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D18822 To: aacid Cc: kossebau, vonreth, kde-frameworks-devel, michaelh, ngraham, bru

D18828: [balooctl] Actually abort a malformed command instead of just saying so

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ridiculous! REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D18828 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashap

D18827: [balooctl] Add missing help for "config set", normalize string

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D18827 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, n

D18819: Use content to determine mime type

ngraham added a comment. Thanks, +1 shipit! REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D18819 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18830: Handle folders matching substrings of included/excluded folders correctly

bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY FileIndexerConfig::shouldFolderBeIndexe(...) calls folderI

D18829: [balooctl] Normalize include/exclude pathes before using it for the config

bruns added a dependent revision: D18830: Handle folders matching substrings of included/excluded folders correctly. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18829 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, a

D18829: [balooctl] Normalize include/exclude pathes before using it for the config

bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY A directory can be added multiple times to the config by j

D18827: [balooctl] Add missing help for "config set", normalize string

bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The "contentIndexing" command was not listed for "balooctl

D18828: [balooctl] Actually abort a malformed command instead of just saying so

bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY A single directory entry can either be included or exclude

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

astippich edited the test plan for this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18826 To: astippich, ngraham, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

astippich created this revision. astippich added reviewers: ngraham, bruns, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Rewrite the taglib extractor to use taglib's Prop

D18819: Use content to determine mime type

astippich added a comment. In D18819#407360 , @ngraham wrote: > The default match mode tries both file extension and content ; this would make it just do content. So I guess if they don't

D18819: Use content to determine mime type

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. The default match mode tries both file extension and content ; this would make it just do content. So I guess if they don't match

D18825: Replace recursive isDirHidden with iterative one, allow const argument

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit2 REVISION DETAIL https://phabricator.kde.org/D18825 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun,

D18825: Replace recursive isDirHidden with iterative one, allow const argument

bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The non-unix implementation modifies its QDir argument to

D18824: Implement wl_eglstream_controller Server Interface

ekurzinger created this revision. ekurzinger added reviewers: romangg, davidedmundson, zzag, KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ekurzinger requested review of this revision. REVISION SUMMARY This implements a wrapper class for the wl_eglstr

D18822: Fix Windows build [hopefully]

aacid added subscribers: vonreth, kossebau. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D18822 To: aacid Cc: kossebau, vonreth, kde-frameworks-devel, michaelh, ngraham, bruns

D18822: Fix Windows build [hopefully]

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R283 KAuth BRANCH master REVISION DETAIL https://phabricator.kde.org/D18822 AFFECTED FILES autotests/BackendsManager.h

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.11 - Build # 11 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/11/ Project: kf5-qt5 AndroidQt5.11 Date of build: Thu, 07 Feb 2019 17:52:08 + Build duration: 48 sec and counting CONSOLE OUTPUT [...truncated 248

D18702: Remove monochrome font preferences icon and improve font selection icon

ngraham added a comment. Nah, that has no effect on anything. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18702 To: GB_2, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D18702: Remove monochrome font preferences icon and improve font selection icon

GB_2 added a comment. In D18702#407259 , @ngraham wrote: > Can you improve the font selection icon in a separate patch please? Is it bad that the branch name is wrong then though? REPOSITORY R266 Breeze Icons REVISION DETAIL https://

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.11 - Build # 10 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/10/ Project: kf5-qt5 AndroidQt5.11 Date of build: Thu, 07 Feb 2019 17:42:12 + Build duration: 1 min 42 sec and counting CONSOLE OUTPUT [...truncat

D18702: Remove monochrome font preferences icon and improve font selection icon

ngraham added a comment. Can you improve the font selection icon in a separate patch please? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18702 To: GB_2, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.11 - Build # 9 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/9/ Project: kf5-qt5 AndroidQt5.11 Date of build: Thu, 07 Feb 2019 17:33:58 + Build duration: 35 sec and counting CONSOLE OUTPUT [...truncated 51 l

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.11 - Build # 8 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/8/ Project: kf5-qt5 AndroidQt5.11 Date of build: Thu, 07 Feb 2019 17:23:50 + Build duration: 1 min 58 sec and counting CONSOLE OUTPUT [...truncate

D18819: Use content to determine mime type

astippich created this revision. astippich added reviewers: ngraham, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Determine the mime type for the extractors based on the con

Re: CI for prison: missing dependency

On Saturday, 2 February 2019 19:15:36 CET Ben Cooksley wrote: > On Sun, Feb 3, 2019 at 12:02 AM David Faure wrote: > > On samedi 2 février 2019 11:20:28 CET CI System wrote: > > > -- The following REQUIRED packages have not been found: > > > > > > * QRencode, The QRencode library, > > > > Can th

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

rooty closed this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18794 To: rooty, #vdg, ndavis, GB_2, ngraham Cc: GB_2, ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH gnumeric-font-16px (branched from master) REVISION DETAIL https://phabricator.kde.org/D18794 To: rooty, #vdg, ndavis, GB_2, ngraham Cc: GB_2, ngraham, ndavis, kde-frameworks

D18804: Workaround for the bug 393630 - Framework part

ngraham added a dependent revision: D18805: Workaround for the bug 393630 - SystemTray part. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18804 To: trmdi, broulik, davidedmundson, fvogt, anthonyfieroni, ngraham, #plasma Cc: kde-frameworks-devel, mi

D18804: Workaround for the bug 393630 - Framework part

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18804 To: trmdi, broulik, davidedmundson, fvogt, anthonyfieroni, ngraham, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/19/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 07 Feb 2019 15:38:52 + Build duration: 9 min 7 sec and counting JUnit Tests Name

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/15/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 07 Feb 2019 15:38:52 + Build duration: 7 min 32 sec and counting BUILD ARTIFACTS abi-c

D18487: Do background contrast fallback at runtime

This revision was automatically updated to reflect the committed changes. Closed by commit R242:7ca1f01ea91a: Do background contrast fallback at runtime (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18487?vs=51085&id=

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/7/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 07 Feb 2019 15:38:52 + Build duration: 3 min 42 sec and counting BUILD ARTIFACTS abi-co

D18487: Do background contrast fallback at runtime

mart accepted this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18487 To: broulik, #plasma, ngraham, mart Cc: mart, ngraham, kde-frameworks-devel, michaelh, bruns

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

ngraham accepted this revision. ngraham added a comment. +1 shipit! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18794 To: rooty, #vdg, ndavis, GB_2, ngraham Cc: GB_2, ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

GB_2 accepted this revision. GB_2 added a comment. Great! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18794 To: rooty, #vdg, ndavis, GB_2 Cc: GB_2, ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D18487: Do background contrast fallback at runtime

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works for me! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18487 To: broulik, #plasma, ngraham Cc: mart, ngraham, kde-frameworks-devel, mic

D18788: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e)

shubham updated this revision to Diff 51102. shubham added a comment. Accept and ignore the event REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18788?vs=51039&id=51102 BRANCH arcpatch-D18788 REVISION DETAIL https://phabricator.kde.org/D18788 AFFE

D18739: Sync QML module padding to reflect system setting pages

vpilo added a comment. As mentioned in D18458 , a KCM not based on KCM.GridViewKCM & friends (e.g. a KCM based on Kirigami.Page) will now get extra padding (on Breeze, no scaling, it's of 6px), both on KCMShell and SystemSettings. REPOSITORY R295 KCMUti

D18813: Filter out invalid content in lists

leinir created this revision. leinir added a reviewer: KNewStuff. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY Prior to this change, if the ocs server being queri

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

rooty updated this revision to Diff 51092. rooty added a comment. Implement GB_2's suggestion and use gtk-select-font as template for new icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18794?vs=51074&id=51092 BRANCH gnumeric-font-16px (branche

D18763: [client] Fix typos

davidedmundson added a comment. Ship it. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18763 To: zzag, #kwin Cc: davidedmundson, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

GB_2 added a comment. @rooty just copy a different 16px font icon like `format-font-size-more` and remove the other things than the A and align it in the horizontal center. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18794 To: rooty, #vdg, ndavis Cc: GB_2,

D18487: Do background contrast fallback at runtime

broulik updated this revision to Diff 51085. broulik retitled this revision from "Reparse background contrast settings when colors changed" to "Do background contrast fallback at runtime". broulik edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAS

D18804: Workaround for the bug 393630 - Framework part

trmdi added a comment. In D18804#406918 , @davidedmundson wrote: > Can you explain what you're working around? If SystemTray's ConfigEntries.qml accesses plasma.rootItem -> the bug happens (*) My workaround is to get plasma.rootItem.pr

D18804: Workaround for the bug 393630 - Framework part

davidedmundson added a comment. Can you explain what you're working around? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18804 To: trmdi, broulik, davidedmundson, fvogt, anthonyfieroni, ngraham, #plasma Cc: kde-frameworks-devel, michaelh, ngraha

D18804: Workaround for the bug 393630 - Framework part

trmdi retitled this revision from "Workaround for the bug 393630" to "Workaround for the bug 393630 - Framework part". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18804 To: trmdi, broulik, davidedmundson, fvogt, anthonyfieroni, ngraham, #plasma Cc

D18804: Workaround for the bug 393630

trmdi edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18804 To: trmdi, broulik, davidedmundson, fvogt, anthonyfieroni, ngraham, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

rooty added a comment. Is this ok? I had to stretch it out a lil bit at the top and bottom F6594583: image.png In my previous comment I just moved it and I realized it had four pixels above and three below it... REPOSITORY R266 Breeze Icons

D18487: Reparse background contrast settings when colors changed

mart added inline comments. INLINE COMMENTS > mart wrote in theme_p.cpp:754 > They can be supplied from the theme too (or used to be) even though most of > the themes don't err, forget everything i said, i misunderstood your comment :) using qgray on the theme backgroundcolor instead of a magi

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

rooty added a comment. Is this acceptable? I had to make it shorter to align to the grid F6594549: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18794 To: rooty, #vdg, ndavis Cc: ngraham, ndavis, kde-framew

D18487: Reparse background contrast settings when colors changed

mart added inline comments. INLINE COMMENTS > broulik wrote in theme_p.cpp:754 > If the theme does not supply background contrast values, they are > auto-determined from the background color (dark or light), or what do you > mean? They can be supplied from the theme too (or used to be) even th

D18738: Add ebook thumbnailer

broulik closed this revision. broulik added a comment. https://cgit.kde.org/kio-extras.git/commit/?id=db7e30823b8a26b1f8bec721f2079bed6132a155 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18738 To: broulik, #plasma, #vdg, elvisangelaccio Cc: elvisangelaccio, a

D18804: Workaround for the bug 393630

trmdi added a comment. In D18804#406887 , @anthonyfieroni wrote: > Did you understand why it happen? Unfortunately no. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18804 To: trmdi, broulik

D18804: Workaround for the bug 393630

anthonyfieroni added a comment. Did you understand why it happen? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18804 To: trmdi, broulik, davidedmundson, fvogt, anthonyfieroni, ngraham, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18804: Workaround for the bug 393630

fvogt added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18804 To: trmdi, broulik, davidedmundson, fvogt, anthonyfieroni, ngraham, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns