D18804: Workaround for the bug 393630

trmdi added a reviewer: ngraham. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18804 To: trmdi, broulik, davidedmundson, fvogt, anthonyfieroni, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18804: Workaround for the bug 393630

trmdi created this revision. trmdi added reviewers: broulik, davidedmundson, fvogt, anthonyfieroni. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trmdi requested review of this revision. REVISION SUMMARY I know this may be a stupid workaround, but I think i

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18794 To: rooty, #vdg, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

ndavis added a comment. Now that I've had a look at the icon, it's not aligned with the pixel grid. The original icon wasn't very well aligned either, but at least the top and bottom were. Shrinking down from one monochrome size to another without adjusting to fit the grid generally doesn't

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

rooty added a comment. Wow thanks @ndavis, scour shrinks it even more than svgcleaner does and doesn't enforce a fill color. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18794 To: rooty, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D18776: Make sure only directories are added to the inotify watcher

This revision was automatically updated to reflect the committed changes. Closed by commit R293:ee7ea5b55de9: Make sure only directories are added to the inotify watcher (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18776?vs=51008&id=51072

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

anthonyfieroni added a reviewer: davidedmundson. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D18798 To: anemeth, #frameworks, kde-frameworks-devel, ngraham, davidedmundson Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18788: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e)

shubham added inline comments. INLINE COMMENTS > sars wrote in kateviewinternal.cpp:2718 > Where did e->accept() / e->ignore() go? There is a reason they are there... Btw no need to explicitly accept() the event, because isAccepted() function returns true by default. But surely, event should be

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

ndavis added a comment. In D18794#406854 , @rooty wrote: > Wow thanks @ndavis, scour shrinks it even more than svgcleaner does Not in my experience, but I'm glad it works well for you. REPOSITORY R266 Breeze Icons REVISION DETAIL htt

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

rooty marked 2 inline comments as done. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18794 To: rooty, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

rooty updated this revision to Diff 51074. rooty added a comment. Optimize and remove hardcoded colors REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18794?vs=51052&id=51074 BRANCH gnumeric-font-16px (branched from master) REVISION DETAIL https:/

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/5/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 07 Feb 2019 03:26:08 + Build duration: 4 min 2 sec and counting BUILD ARTIFACTS abi-compatibility-

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

bruns added inline comments. INLINE COMMENTS > kinotify.h:198 > + * and installs watches for all subdirectories (including @param path) > + */ > +void handleDirCreated(const QString& path); Can you add a note created events are only emitted if the file/directory is not exclude by t

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

bruns added a comment. In D18698#406755 , @poboiko wrote: > Something like that? I've decided not to emit `created` signal from inside the function, just to have a bit less branching in the code (and documented this behavior, since it might be a

D18788: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e)

shubham added a comment. @dhaumann I don't think using switch when there is only a single case good thought INLINE COMMENTS > sars wrote in kateviewinternal.cpp:2702 > does this even compile on OSX? Why did you change this? I can't tell, I don't have one. Btw Q_OS_OSX is deprecated. > sar

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

ndavis added inline comments. INLINE COMMENTS > gnumeric-font.svg:60 > + + > style="color:#eff0f1;fill:currentColor;fill-opacity:1;stroke:none;stroke-width:0.7002" > + d="M 7.273454,3.33362 5.0638074,9.7294853 4.9817757,10.00032 4,12.667 H > 5.1054743 L 6.188813,9.7086519 H 9.8112

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

ndavis added a comment. Hmm somehow I missed this. Here's a way to optimize it with a utility that's available in most distro repos (`scour`, `python-scour`): scour input.svg output.svg --enable-viewboxing --enable-id-stripping --enable-comment-stripping --shorten-ids --remove-descript

KDE CI: Frameworks » kauth » kf5-qt5 WindowsMSVCQt5.11 - Build # 24 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kauth/job/kf5-qt5%20WindowsMSVCQt5.11/24/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 06 Feb 2019 23:05:14 + Build duration: 1 min 23 sec and counting CONSOLE OUTPUT [...

D18610: Introduce KF5AuthCore

aacid closed this revision. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D18610 To: aacid, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18610: Introduce KF5AuthCore

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R283 KAuth BRANCH arcpatch-D18610 REVISION DETAIL https://phabricator.kde.org/D18610 To: aacid, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

poboiko added a comment. Something like that? I've decided not to emit `created` signal from inside the function, just to have a bit less branching in the code (and documented this behavior, since it might be a bit confusing) Actually, I think this race condition is now handled properly,

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

poboiko updated this revision to Diff 51062. poboiko edited the summary of this revision. poboiko added a comment. Added recursive iteration over all contents for `Create` event as well REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18698?vs=50967&id=51062 B

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

ngraham added a comment. Sounds good. It's the same thing that's done in other places, so I don't expect there'll be any problem. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D18798 To: anemeth, #frameworks, kde-frameworks-devel, ngraham Cc: ngraham,

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

anemeth added a comment. I will wait for someone from the frameworks team to review this before landing it. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D18798 To: anemeth, #frameworks, kde-frameworks-devel, ngraham Cc: ngraham, kde-frameworks-devel,

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D18798 To: anemeth, #frameworks, kde-frameworks-devel, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

anemeth retitled this revision from "Fix file and folder drag and drop popup menu transparency" to "[KIO/drag and drop] Fix file and folder drag and drop popup menu transparency". anemeth added a reviewer: kde-frameworks-devel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org

D18798: Fix file and folder drag and drop popup menu transparency

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added a reviewer: Frameworks. anemeth added a subscriber: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18798 To: anemeth, #frameworks Cc: ngraham, kde-frameworks-

D18798: Fix file and folder drag and drop popup menu transparency

anemeth created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. anemeth requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D18798 AFFECTED FILES src/widgets/dropjob.cpp To:

D18788: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e)

dhaumann added a comment. I am with Kåre here: this change does not fix any issue nor does it improve the current state significantly. In fact, there is a risk of introducing a regression by removing the accept/reject calls. I don't think this should go in as is. Shubham, on bugs.kd

D18738: Add ebook thumbnailer

elvisangelaccio accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18738 To: broulik, #plasma, #vdg, elvisangelaccio Cc: elvisangelaccio, abetts, ngraham, kde-frameworks-devel, kfm-devel, alexde, f

D18788: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e)

sars added inline comments. INLINE COMMENTS > kateviewinternal.cpp:2702 > // Move cursor to end (or beginning) of selected word > +#ifndef Q_OS_MACOS > if (view()->selection()) { does this even compile on OSX? Why did you change this? > kateviewinternal.cpp:2718 > - > -

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

rooty added a comment. In D18794#406656 , @ngraham wrote: > Ask and ye shall receive, eh!? > > To channel @ndavis, it would be nice if you could run these through an optimizer. :) Haha it just took me a while to figure out how to resi

D18794: [breeze-icons] Add 16px versions of gnumeric-font and link gnumeric font to font.svg

ngraham added subscribers: ndavis, ngraham. ngraham added a reviewer: VDG. ngraham added a comment. Ask and ye shall receive, eh!? To channel @ndavis, it would be nice if you could run these through an optimizer. :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kd

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

rooty retitled this revision from "[breeze-icons] Add 16px versions of gnumeric-font and link gnumeric font to font.svg" to "[breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg". rooty edited the summary of this revision. REPOSITORY R266 Breeze Icons R

D18794: [breeze-icons] Add 16px versions of gnumeric-font and link gnumeric font to font.svg

rooty created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. rooty requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH gnumeric-font-16px (branched from master) REVISION DETAIL https://phabricator.kde.org/D18794 AFFEC

D18793: Handle text completion with block selection mode

ahmadsamir created this revision. ahmadsamir added reviewers: KTextEditor, cullmann, dhaumann. Herald added projects: Kate, Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Handle text completion with block selection mode BUG: 359763 FIXED-IN: 5.56 TEST PLAN W

D18778: [KRun] Fall back to reading text/html in mimeapps.list if others aren't there

ngraham added a comment. Well in that case we need to figure out what's wrong in https://bugs.kde.org/show_bug.cgi?id=403499. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18778 To: ngraham, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18778: [KRun] Fall back to reading text/html in mimeapps.list if others aren't there

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18778 To: ngraham, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18791: QuotedPrintableDecoder::decode: return false on error instead of asserting

vkrause added a comment. This looks ok to me. The documentation doesn't really specify what should happen on error esp. regarding the return value, but asserting is clearly the wrong approach. REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D18791 To: aacid Cc: vkra

D18791: QuotedPrintableDecoder::decode: return false on error instead of asserting

aacid added a comment. N, i commited this by mistake. Can anyone still please review and tell me if it's wrong and i'll revert? REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D18791 To: aacid Cc: vkrause, kde-frameworks-devel, michaelh, ngraham,

D18791: QuotedPrintableDecoder::decode: return false on error instead of asserting

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R270:26cee94dc4f3: QuotedPrintableDecoder::decode: return false on error instead of asserting (authored by aacid). REPOSITO

D18791: QuotedPrintableDecoder::decode: return false on error instead of asserting

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY let's the fuzzying process continue forward REPOSITORY R270 KCodecs BRANCH master REVISION DETAIL https://phabricat

D18762: Add support for portals in KRun

GeeXT updated this revision to Diff 51047. GeeXT added a comment. Add check for external browser enablement status REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18762?vs=51017&id=51047 BRANCH flatpak_open_url (branched from master) REVISION DETAIL https:

D18772: Mark KCodecs::uuencode does nothing

This revision was automatically updated to reflect the committed changes. Closed by commit R270:ce82869ecc23: Mark KCodecs::uuencode does nothing (authored by aacid). REPOSITORY R270 KCodecs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18772?vs=50998&id=51046 REVISION DETAIL htt

D17932: Improvements to completion

cullmann accepted this revision. cullmann added a comment. Then I will apply this. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17932 To: thomassc, #ktexteditor, #kdevelop, mwolff, cullmann Cc: dhaumann, apol, kfunk, brauch, mwolff, cullmann, kwrite-devel, kde

D18738: Add ebook thumbnailer

ngraham added a comment. do we have a shipit? Looks good to me too! REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18738 To: broulik, #plasma, #vdg Cc: elvisangelaccio, abetts, ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarr

D18702: Remove monochrome font preferences icon and improve font selection icon

GB_2 added a dependency: D18785: Use different Font Management KCM "All Fonts" icon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18702 To: GB_2, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D18788: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e)

shubham created this revision. shubham added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. shubham requested review of this revision. REVISION SUMMARY Removed unncessary switch and replaced it with simple if, more eff

D18738: Add ebook thumbnailer

broulik updated this revision to Diff 51037. broulik added a comment. - Use proper cmake thing REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18738?vs=50896&id=51037 REVISION DETAIL https://phabricator.kde.org/D18738 AFFECTED FILES thumbnail/CMakeL

D18702: Remove monochrome font preferences icon and improve font selection icon

GB_2 removed a dependent revision: D18785: Use different Font Management KCM "All Fonts" icon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18702 To: GB_2, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D18702: Remove monochrome font preferences icon and improve font selection icon

GB_2 added a dependent revision: D18785: Use different Font Management KCM "All Fonts" icon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18702 To: GB_2, #vdg Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/15/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 06 Feb 2019 09:52:20 + Build duration: 6 min 6 sec and counting JUnit Tests Name: projec

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/14/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 06 Feb 2019 09:52:20 + Build duration: 6 min 14 sec and counting BUILD ARTIFACTS abi-compatibil

D15421: [server] Add surface data proxy mechanism

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:0b33f078bd1d: [server] Add surface data proxy mechanism (authored by romangg). CHANGED PRIOR TO COMMIT https://phabr

T3689: Add abi compliance checker to CI

danders added a comment. Hmmm. do not know how to proceed with this without the actual libs available. I have tried building against a new lib and runing with old lib, with no problems. I was unsuccesful using abi-dumper on the old lib, so cannot check if it gives the same output as for

D15023: [server] Add selectionChanged signal

This revision was automatically updated to reflect the committed changes. Closed by commit R127:8caff837109c: [server] Add selectionChanged signal (authored by romangg). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15023?vs=48513&id=51022#toc REPOSITORY R127 KWayland CHANGES SINCE L

D18772: Mark KCodecs::uuencode does nothing

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Right, this can go away as soon as it's allowed, encoding into a rarely used legacy format from the 90s makes no sense. REPOSITORY R270 KCodecs BRANCH master REVISION DETAIL https

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 13 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/13/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 06 Feb 2019 08:31:09 + Build duration: 15 min and counting BUILD ARTIFACTS abi-compatibility-r

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/14/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 06 Feb 2019 08:31:10 + Build duration: 5 min 17 sec and counting JUnit Tests Name: proje

D18762: Add support for portals in KRun

dfaure added a comment. This should only be done if KRun::setEnableExternalBrowser(false) wasn't called, otherwise it will break KParts' BrowserRun subclass and Konqueror's KonqRun (who use KRun to actually find out the mimetype of the file, not to launch another browser). T his means ad

D18778: [KRun] Fall back to reading text/html in mimeapps.list if others aren't there

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. This makes no sense to me. The whole point of " based on the contents of the URL " is to open images in an image viewer, PDFs in a PDF viewer, etc. So hardcoding text/html breaks