D17122: RFC: Use wl_display_add_socket_auto by default

fvogt added a comment. In D17122#395537 , @romangg wrote: > I don't think we need a second variable effectiveSocketName. Just test if socketName is empty. If it is call wl_display_add_socket_auto, otherwise call wl_display_add_socket. I

D18345: Fix python binding generation for classes with deleted copy constructors

aacid added subscribers: skelly, cgiboudeaux. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18345 To: aacid Cc: cgiboudeaux, skelly, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18137: delete copy constructor and assignment operator of some public classes

aacid added a comment. The magic to generate sip files was not magic enough https://phabricator.kde.org/D18345 REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D18137 To: aacid, mpyne Cc: cgiboudeaux, mpyne, kde-frameworks-devel, michaelh, ngraham, bruns

D18345: Fix python binding generation for classes with deleted copy constructors

aacid created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. aacid requested review of this revision. TEST PLAN kcoreaddons compiles again REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL

D17122: RFC: Use wl_display_add_socket_auto by default

romangg added a comment. I don't think we need a second variable effectiveSocketName. Just test if socketName is empty. If it is call wl_display_add_socket_auto, otherwise call wl_display_add_socket. According to description some autotest fails. Which one exactly? REPOSITORY R127 KWa

D18317: Don't fail if defaultLanguage dictionary can't be loaded

pino added a comment. In D18317#395513 , @pino wrote: > This makes a "core" library grow a dependency on widgets -- not really a good idea, considering there is the sonnetui library for that. In addition to the above, there are also reall

D18317: Don't fail if defaultLanguage dictionary can't be loaded

pino added a comment. This makes a "core" library grow a dependency on widgets -- not really a good idea, considering there is the sonnetui library for that. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D18317 To: ahmadsamir, sandsmark, loh.tar Cc: pino, kde-framew

D18317: Don't fail if defaultLanguage dictionary can't be loaded

ngraham added a reviewer: loh.tar. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D18317 To: ahmadsamir, sandsmark, loh.tar Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 49754. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Fix to pass autotest 97% tests passed, 2 tests failed out of 67 Total Test time (real) = 137.70 sec The following tests FAILED: 24 - kat

D18010: Fix failing test of exiv gps data

astippich retitled this revision from "Allow zero altitude/longitude/latitude exiv gps data" to "Fix failing test of exiv gps data". astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData BRANCH fix_zero_gps REVISION DETAIL https://phabricator.kde.org/D18010 To: ast

D18010: Allow zero altitude/longitude/latitude exiv gps data

astippich updated this revision to Diff 49750. astippich added a comment. - fix gps altitude precision REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18010?vs=49317&id=49750 BRANCH fix_zero_gps REVISION DETAIL https://phabricator.kde.org/D18010

D18205: Test empty and zero gps data

astippich updated this revision to Diff 49749. astippich added a comment. - update REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18205?vs=49377&id=49749 BRANCH gps_tests REVISION DETAIL https://phabricator.kde.org/D18205 AFFECTED FILES autot

D18329: Remove the AndroidX support library dependency

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Turns out we don't actually need that, the version checks in the Java code accomplish the same. More importantly, it d

D11236: [KCrash] Establish socket to allow change of ptracer

ossi added a comment. the 3rd line is still wrong ... REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D11236 To: croick, #frameworks, ossi Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, ngraham, bruns

D18308: Ignore all non-storage deviceAdded signals from Solid

This revision was automatically updated to reflect the committed changes. bruns marked an inline comment as done. Closed by commit R293:c0b57ee70ea2: Ignore all non-storage deviceAdded signals from Solid (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18308?vs=49686&id

D11236: [KCrash] Establish socket to allow change of ptracer

ossi added a comment. right, threads, i didn't think of that. i suppose it might make sense to pthread_kill() from within kcrash to freeze the other threads, but that will be non-atomic, and i wonder whether it wouldn't have undesirable interactions with the attached debugger and/or exiting

D18308: Ignore all non-storage deviceAdded signals from Solid

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > broulik wrote in storagedevices.cpp:79 > I think you can also move this check up yes, especially as it is the most trivial check ... REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabric

D18137: delete copy constructor and assignment operator of some public classes

cgiboudeaux added a comment. This is causing an error when building the python bindings: > In file included from /data/kde/build/kcoreaddons/src/lib/pybuild/PyKF5/KCoreAddons/unifiedKCoreAddons.cpp:15: > /data/kde/build/kcoreaddons/src/lib/pybuild/PyKF5/KCoreAddons/sipKCoreAddonsKdeli

D11236: [KCrash] Establish socket to allow change of ptracer

croick edited the summary of this revision. croick edited the test plan for this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D11236 To: croick, #frameworks, ossi Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, ngraham, bruns

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick edited the summary of this revision. croick edited the test plan for this revision. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D11235 To: croick, #plasma_workspaces, #frameworks, ossi Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, jra

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49717. croick added a comment. - swap variable declaration REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=49710&id=49717 BRANCH ptracer REVISION DETAIL https://phabricator.kde.org/D11235 AFFECTED FILES

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick marked an inline comment as done. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D11235 To: croick, #plasma_workspaces, #frameworks, ossi Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D11236: [KCrash] Establish socket to allow change of ptracer

croick added a comment. I think it's quite useful (see BUG 175362). Remaining threads remain quite busy otherwise, especially since KCrash is closing all file descriptors by default, which leads to a lot of polling of non-existant FDs in the background. Maybe you would like to join the disc

D11236: [KCrash] Establish socket to allow change of ptracer

ossi added inline comments. INLINE COMMENTS > kcrash.cpp:658 > +// when launching drkonqi. Note that DrKonqi will SIGSTOP this > process in the meantime > +// and only send SIGCONT when it is about to attach a debugger. > #ifdef Q_OS_LINUX ok. but come to think of it, maybe tha

D11236: [KCrash] Establish socket to allow change of ptracer

croick marked an inline comment as done. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D11236 To: croick, #frameworks, ossi Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, ngraham, bruns

D11235: [DrKonqi] Request change of ptrace scope from KCrash

ossi added a comment. In D11235#395021 , @croick wrote: > What do you mean? The (internal) debugger is a child of the debuggee. yes, that's why you need setPtracer() - if crashtest was *under* gdb, that would be unnecessary. ;) (i'm sti

D18317: Don't fail if defaultLanguage dictionary can't be loaded

ahmadsamir created this revision. ahmadsamir added a reviewer: sandsmark. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY If the files of the the dictionary set in defaultLanguage= can't be loaded, instead of failing silently, try to load the

D17816: Support for xattrs on kio copy/move

cochise added a comment. I'm not sure why the tests fail, and the tests failing are unrelated to xattrs. I think there is some problem in queuing the subjobs and ensuring they all have finished. After the copy job is finished, the copyLocalDirectory test can't find the file inside the copi

D17816: Support for xattrs on kio copy/move

cochise marked an inline comment as done. cochise added a comment. I'm not sure why the tests fail, and the tests failing are unrelated to xattrs. I think there is some problem in queuing the subjobs and ensuring they all have finished. After the copy job is finished, the `copyLocalDirector

D18315: Device: Check object path in interfaces removed slot

drosca created this revision. drosca added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. drosca requested review of this revision. REVISION SUMMARY Only remove Input and MediaPlayer objects when path matches. BUG: 403289 TEST P

D11236: [KCrash] Establish socket to allow change of ptracer

croick updated this revision to Diff 49711. croick marked an inline comment as done. croick added a comment. - invert debugger-debuggee hierarchy in comment REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11236?vs=49650&id=49711 BRANCH ptracer REVISION DE

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/16/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 17 Jan 2019 12:04:59 + Build duration: 30 min and counting JUnit Tests Name: projectr

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick added a comment. > you got the parent-child ordering wrong in the commit message. ^^ What do you mean? The (internal) debugger is a child of the debuggee. $ pstree -pn $(pidof crashtest) crashtest(17220)─┬─{crashtest}(17221) ├─{crashtest}(17222)

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49710. croick added a comment. - swap lines, declare array for response message where needed REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=49705&id=49710 BRANCH ptracer REVISION DETAIL https://phabricator

D11236: [KCrash] Establish socket to allow change of ptracer

ossi added a comment. commit message inverted here as well. INLINE COMMENTS > kcrash.cpp:658 > +// when launching drkonqi. Note that DrKonqi will SIGSTOP this > process in the meantime > +// and only send SIGCONT when it is to be attached by a debugger. > #ifdef Q_OS_LINUX

D18164: Review KateGotoBar

This revision was automatically updated to reflect the committed changes. Closed by commit R39:3b806f3b40f7: Review KateGotoBar (authored by loh.tar, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18164?vs=49665&id=49708 REVISION DE

D11235: [DrKonqi] Request change of ptrace scope from KCrash

ossi added a comment. you got the parent-child ordering wrong in the commit message. ^^ INLINE COMMENTS > ptracer.cpp:61 > +char msg[msize], rmsg[msize]; > +int bytes = 0, r; > +sprintf(msg, "%lld", debuggerpid); this looks stupid, i'd swap the order. REPOSITORY R8

D18164: Review KateGotoBar

cullmann accepted this revision. cullmann added a comment. Yep ;=) Thanks for the improvements, will merge. REVISION DETAIL https://phabricator.kde.org/D18164 To: loh.tar, #ktexteditor, cullmann Cc: dhaumann, cullmann, anthonyfieroni, kwrite-devel, kde-frameworks-devel, #ktexteditor,

D11236: [KCrash] Establish socket to allow change of ptracer

croick edited the summary of this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D11236 To: croick, #frameworks, ossi Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, ngraham, bruns

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49705. croick edited the summary of this revision. croick added a comment. - adjust warning and check for EINTR when polling REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=49651&id=49705 BRANCH ptracer REVIS

D18308: Ignore all non-storage deviceAdded signals from Solid

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > storagedevices.cpp:79 > Entry entry(dev); > if (dev.udi().isEmpty()) > return nullptr; I think you can also move this check up REPOSITORY R293 B