D15367: [Comic Thumbnailer] fix CBR thumbnail generation

fleger added a comment. Please use florian.leg...@gmail.com REPOSITORY R320 KIO Extras BRANCH comicbook-fix-cbr REVISION DETAIL https://phabricator.kde.org/D15367 To: fleger, broulik, #frameworks, elvisangelaccio Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, alexde, sourabhbos

D17342: team-port setting

jgrulich added inline comments. INLINE COMMENTS > teamportsettingtest.cpp:29 > + > +#if !NM_CHECK_VERSION(1, 12, 0) > +#define NM_SETTING_TEAM_PORT_CONFIG"config" Those defines are already in NM 1.10 > teamportsettingtest.cpp:62 > +<< (qint32)1 // queueId > +

D16671: Refactor embedded image extractor for greater extensibility

astippich marked 2 inline comments as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in embeddedimagedata.cpp:134 > Does Taglib signal an error when it fails to parse the file? Or is calling > pictureList() always safe? Docs don't say, so I fed a musepack file into this co

D16671: Refactor embedded image extractor for greater extensibility

astippich updated this revision to Diff 46880. astippich added a comment. - new lines, handle dataPosition == -1 REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16671?vs=46860&id=46880 BRANCH refactor_embedded_image REVISION DETAIL https://phabri

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.11 - Build # 16 - Aborted!

BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.11/16/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 02 Dec 2018 06:21:04 + Build duration: 3 days 0 hr and counting

D17350: Add the missing api for multilevel KCMs to control the columns

jgrulich added a comment. @mart , can you push your changes for plasma-nm so I can try this? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D17350 To: mart, #plasma, jgrulich Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

D17350: Add the missing api for multilevel KCMs to control the columns

jgrulich added a comment. In D17350#371191 , @ngraham wrote: > That plasma-nm QML rewrite is looking totally awesome! How soon can we get it committed? I unfortunately didn't have time to work on that since Akademy so there is no progres

D17351: make use of the new currentIndex api of QML kcms

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY R295 KCMUtils BRANCH phab/missingapi REVISION DETAIL https://phabricator.kde.org/D17351 To: mart, #plasma, jgrulich Cc: kde-frameworks-devel, michae

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 512 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/512/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 05 Dec 2018 04:42:40 + Build duration: 23 min and counting JUnit Tests Name: (root) Failed: 2 test

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 361 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/361/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 05 Dec 2018 04:42:40 + Build duration: 8 min 12 sec and counting JUnit Tests Name: (root) Failed: 2

D17301: add documentation to result class

bruns added a comment. In D17301#371323 , @astippich wrote: > Thanks for your patience :) Thanks for bearing with my nagging ;-) REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17301 To: astippich, #baloo, bruns

D17358: implement cover extraction for asf files

bruns accepted this revision. bruns added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > embeddedimagedata.cpp:273 > } > +QByteArray > +EmbeddedImageData::Private::getFrontCoverFromAsf(TagLib::ASF::Tag* asfTags) > const Nitpick - empty line between function

D16671: Refactor embedded image extractor for greater extensibility

bruns added inline comments. INLINE COMMENTS > embeddedimagedata.cpp:181 > } > +QByteArray > +EmbeddedImageData::Private::getFrontCoverFromMp4(TagLib::MP4::Tag* mp4Tags) > const Nitpick - add an empty line in-between functions REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabric

D17357: extend list of supported mimetypes for embedded image extractor

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Can you mention the file types and their corresponding mimetypes in the Summary? Thx. INLINE COMMENTS > embeddedimagedata.cpp:199 > +if (speexFile.tag()) { > +return > g

D16671: Refactor embedded image extractor for greater extensibility

bruns added inline comments. INLINE COMMENTS > embeddedimagedata.cpp:134 > TagLib::FLAC::File flacFile(&stream, > TagLib::ID3v2::FrameFactory::instance(), true); > -TagLib::List lstPic = > flacFile.pictureList(); > - > -if (!lstPic.isEmpty()) { > -for (TagLi

D17355: Align Plasma QML button content in center if it has an icon

davidedmundson added a comment. Code wise: - Any changes to PlasmaStyle need to happen in the QQC2 (PlasmaComponents3) version too before shipping - Please be sure to run qmlscene tests/components/button.qml - Why do we have nested RowLayouts? > If we changed that so that b

D17355: Align Plasma QML button content in center if it has an icon

apol added inline comments. INLINE COMMENTS > ButtonStyle.qml:41 > label: RowLayout { > -spacing: units.smallSpacing > +RowLayout { > +Layout.alignment: Qt.AlignHCenter | Qt.AlignVCenter This looks wrong, a RowLayout inside another one? REPOSITORY R242 Plasma

D17324: Move internal helper from BasicIndexingJob to anonymous namespace

This revision was automatically updated to reflect the committed changes. Closed by commit R293:2c8d35247cae: Move internal helper from BasicIndexingJob to anonymous namespace (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17324?vs=46758&id=

D17324: Move internal helper from BasicIndexingJob to anonymous namespace

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17324 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spooru

D17358: implement cover extraction for asf files

astippich updated this revision to Diff 46868. astippich added a comment. - fix REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17358?vs=46863&id=46868 BRANCH wma_cover REVISION DETAIL https://phabricator.kde.org/D17358 AFFECTED FILES autotest

D17357: extend list of supported mimetypes for embedded image extractor

astippich added a dependent revision: D17358: implement cover extraction for asf files. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17357 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, br

D17358: implement cover extraction for asf files

astippich added a dependency: D17357: extend list of supported mimetypes for embedded image extractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17358 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spooru

D16671: Refactor embedded image extractor for greater extensibility

astippich added a dependent revision: D17357: extend list of supported mimetypes for embedded image extractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16671 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich

D17357: extend list of supported mimetypes for embedded image extractor

astippich added a dependency: D16671: Refactor embedded image extractor for greater extensibility. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17357 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D17301: add documentation to result class

astippich added a comment. Thanks for your patience :) REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17301 To: astippich, #baloo, bruns Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17301: add documentation to result class

astippich updated this revision to Diff 46864. astippich added a comment. - remove docstring for reimplemented functions REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17301?vs=46750&id=46864 BRANCH result_documentation REVISION DETAIL https://phabricat

D17355: Align Plasma QML button content in center if it has an icon

GB_2 added a comment. It works properly, no matter how big the button is or if have an icon or not. In my opinion we should leave it how it is now. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17355 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, k

D17358: implement cover extraction for asf files

astippich created this revision. astippich added reviewers: bruns, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY implement support for last missing mimetype compared to ta

D17355: Align Plasma QML button content in center if it has an icon

GB_2 updated this revision to Diff 46862. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17355?vs=46856&id=46862 REVISION DETAIL https://phabricator.kde.org/D17355 AFFECTED FILES src/declarativeimports/plasmastyle/ButtonStyle.qml To: G

D17357: extend list of supported mimetypes for embedded image extractor

astippich created this revision. astippich added reviewers: bruns, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY use existing functions to add support for new mimetypes T

D16671: Refactor embedded image extractor for greater extensibility

astippich updated this revision to Diff 46860. astippich added a comment. - rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16671?vs=44982&id=46860 BRANCH refactor_embedded_image REVISION DETAIL https://phabricator.kde.org/D16671 AFFECTED

D17245: Add string formatting function to property info

astippich marked 3 inline comments as done. astippich added a comment. I'm wondering, anything else to do if I add a new dependency to KFileMetaData? INLINE COMMENTS > bruns wrote in propertyinfotest.cpp:63 > I think this should be "44.1 kHz". Insert the correct expected value and make > it

D17245: Add string formatting function to property info

astippich updated this revision to Diff 46859. astippich added a comment. - small fixes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17245?vs=46688&id=46859 BRANCH display_value REVISION DETAIL https://phabricator.kde.org/D17245 AFFECTED FILE

D17355: Align Plasma QML button content in center if it has an icon

ngraham added a comment. Cool! Does this still work properly when the text is so long that the button expands to accommodate it? Now that I think about this a bit, it seems like maybe the problem here is that there's a minimum button width in the first place. If we changed that so

D17355: Align Plasma QML button content in center if it has an icon

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. GB_2 added projects: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Aligns the Plasma QML Button content in the center if it

Re: Transitioning CI builds of all non-Frameworks from Qt 5.9

On Tue, Dec 4, 2018 at 9:45 AM Elvis Angelaccio wrote: > > > > On 03/12/18 09:46, Ben Cooksley wrote: > > Hi all, > > Hi Ben Hi Elvis, > > > > > I've been informed by the PIM developers that they would like to bump > > the dependency of the Qt version they use, from Qt 5.9 which it's on > > curr

D17350: Add the missing api for multilevel KCMs to control the columns

abetts added a comment. Instead of connection name, would it make sense to call it, network name instead? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D17350 To: mart, #plasma, jgrulich Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

D17350: Add the missing api for multilevel KCMs to control the columns

ngraham added a comment. That plasma-nm QML rewrite is looking totally awesome! How soon can we get it committed? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D17350 To: mart, #plasma, jgrulich Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16954: Add find module for Google's libphonenumber

This revision was automatically updated to reflect the committed changes. Closed by commit R240:ebb05ecafb02: Add find module for Google's libphonenumber (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16954?vs=46805&id=46848

D17351: make use of the new currentIndex api of QML kcms

mart edited the summary of this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D17351 To: mart, #plasma, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17351: make use of the new currentIndex api of QML kcms

mart added a reviewer: jgrulich. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D17351 To: mart, #plasma, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17350: Add the missing api for multilevel KCMs to control the columns

mart added a reviewer: jgrulich. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D17350 To: mart, #plasma, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17350: Add the missing api for multilevel KCMs to control the columns

mart added a comment. F6454962: image.png REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D17350 To: mart, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17351: make use of the new currentIndex api of QML kcms

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY sync kcm currentindex with the pagerow's TEST PLAN tested with newtowrkmanager qml rewrite o

D17350: Add the missing api for multilevel KCMs to control the columns

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY - add currentIndex and depth, which would map to the view in SystemSettings using a Kirigami P

D17345: Support Bluetooth batteries

This revision was automatically updated to reflect the committed changes. Closed by commit R245:b983836f05cd: Support Bluetooth batteries (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17345?vs=46834&id=46837#toc REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE

D17345: Support Bluetooth batteries

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D17345 To: broulik, #plasma, bruns, davidedmundson, bshah Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17345: Support Bluetooth batteries

broulik added a dependent revision: D17346: Support Bluetooth batteries. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D17345 To: broulik, #plasma, bruns, davidedmundson, bshah Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17345: Support Bluetooth batteries

broulik added a reviewer: bshah. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D17345 To: broulik, #plasma, bruns, davidedmundson, bshah Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17345: Support Bluetooth batteries

broulik created this revision. broulik added reviewers: Plasma, bruns, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY There's currently no generic Bluetooth device type in UPower, so

D17241: WIP:Disable highlighting for lines longer than 1024 characters.

sars retitled this revision from "Disable highlighting for lines longer than 1024 characters." to "WIP:Disable highlighting for lines longer than 1024 characters.". REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17241 To: sars, cullmann, vkrause, dhaumann, mwolff C

D17241: Disable highlighting for lines longer than 1024 characters.

sars added a comment. I agree, we need to do something about the line length limit (that only wraps the lines at the limit when opening the file). The question is: do we totally remove the option and limit or only the option and raise the limit. You can still edit the document at 20

D17342: team-port setting

pranavgade updated this revision to Diff 46830. pranavgade added a comment. add missing indents CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17342?vs=46829&id=46830 REVISION DETAIL https://phabricator.kde.org/D17342 AFFECTED FILES autotests/settings/CMakeLists.txt autotests

D17342: team-port setting

pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY Added team-port setting according to: https://developer.gnome.org/Network

D17241: Disable highlighting for lines longer than 1024 characters.

mwolff requested changes to this revision. mwolff added a comment. This revision now requires changes to proceed. what sven said, we should also remove the code to disable highlighting altogether when the line limit is reached, no? INLINE COMMENTS > katerenderer.cpp:387 > > +if (textLi

D17317: match and tc setting

This revision was automatically updated to reflect the committed changes. Closed by commit R282:e95bb9bdf98c: match and tc setting (authored by jgrulich). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17317?vs=46826&id=46827 REVISION DETAIL https:/

D17317: match and tc setting

jgrulich accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D17317 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17317: match and tc setting

pranavgade updated this revision to Diff 46826. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17317?vs=46825&id=46826 REVISION DETAIL https://phabricator.kde.org/D17317 AFFECTED FILES autotests/settings/CMakeLists.txt autotests/settings/matchsettingtest.cpp autotests/settings/

D17317: match and tc setting

jgrulich added a comment. It again doesn't apply, rebase it to current master. REVISION DETAIL https://phabricator.kde.org/D17317 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17317: match and tc setting

pranavgade updated this revision to Diff 46825. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17317?vs=46824&id=46825 REVISION DETAIL https://phabricator.kde.org/D17317 AFFECTED FILES autotests/settings/CMakeLists.txt autotests/settings/matchsettingtest.cpp autotests/settings/

D17317: match and tc setting

jgrulich added a comment. In D17317#371010 , @pranavgade wrote: > In D17317#371009 , @jgrulich wrote: > > > The tcsettingtest is failing. > > > Why, exactly? Because it's broken in num

D17317: match and tc setting

pranavgade added a comment. In D17317#371009 , @jgrulich wrote: > The tcsettingtest is failing. Why, exactly? REVISION DETAIL https://phabricator.kde.org/D17317 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, brun

D17317: match and tc setting

jgrulich added a comment. The tcsettingtest is failing. REVISION DETAIL https://phabricator.kde.org/D17317 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17317: match and tc setting

pranavgade updated this revision to Diff 46824. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17317?vs=46792&id=46824 REVISION DETAIL https://phabricator.kde.org/D17317 AFFECTED FILES autotests/settings/CMakeLists.txt autotests/settings/matchsettingtest.cpp autotests/settings/