D17295: BrightScript: Add function/sub folding

dlevin updated this revision to Diff 46667. dlevin added a comment. Increased version number. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17295?vs=4&id=46667 REVISION DETAIL https://phabricator.kde.org/D17295 AFFECTED FILES autotest

D17295: BrightScript: Add function/sub folding

dlevin created this revision. dlevin added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dlevin requested review of this revision. REVISION SUMMARY Global and local function folding, including closures. REPOSITORY

KDE CI: Frameworks » attica » kf5-qt5 WindowsMSVCQt5.11 - Build # 18 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20WindowsMSVCQt5.11/18/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 01 Dec 2018 22:53:36 + Build duration: 6 hr 6 min and counting JUnit Tests Name: (

D17282: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups

ngraham added a comment. Weird, why does Phabricator think `termgeneratortest.cpp` is a binary file? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17282 To: bruns, #baloo, #frameworks, ngraham, astippich Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, s

D17220: Improve symbolism for off and muted status icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:b8d080c4e6a1: Improve symbolism for off and muted status icon (authored by trickyricky26, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D17220: Improve symbolism for off and muted status icon

ngraham added a comment. I notice that there are bunch of action icons that now differ subtly from these. We can probably make them symlinks to the nice new status icons. But that's material for another patch. :) There's plenty of time anyway since this is going into Frameworks 5.54. REPOSI

D17220: Improve symbolism for off and muted status icon

ngraham accepted this revision. ngraham added a comment. This looks great to me too! I'll land this manually since `arc` doesn't like patches that change symlinks to files. REPOSITORY R266 Breeze Icons BRANCH streamline-muted-off (branched from master) REVISION DETAIL https://phabrica

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 90 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/90/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 01 Dec 2018 22:59:31 + Build duration: 1 hr 15 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/46/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 01 Dec 2018 22:59:44 + Build duration: 1 hr 9 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/72/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 01 Dec 2018 22:58:21 + Build duration: 1 hr 2 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/53/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 01 Dec 2018 22:55:38 + Build duration: 1 hr 3 min and counting JUnit Tests Name: (root) F

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 77 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/77/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 01 Dec 2018 22:55:08 + Build duration: 54 min and counting JUnit Tests Name: (root) Failed: 2

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 505 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/505/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 01 Dec 2018 22:55:36 + Build duration: 45 min and counting JUnit Tests Name: (root) Failed: 0 test(

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 276 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/276/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 01 Dec 2018 23:00:20 + Build duration: 38 min and counting BUILD ARTIFACTS compat_rep

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 116 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/116/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 01 Dec 2018 22:59:31 + Build duration: 32 min and counting JUnit Tests Name: (root) Failed: 1

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 58 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/58/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 01 Dec 2018 22:59:44 + Build duration: 30 min and counting BUILD ARTIFACTS compat_reports

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 94 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/94/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 01 Dec 2018 22:58:21 + Build duration: 23 min and counting JUnit Tests Name: (root) Failed: 3

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/36/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 01 Dec 2018 22:57:05 + Build duration: 22 min and counting JUnit Tests Name: (root) Faile

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 78 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/78/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 01 Dec 2018 22:55:38 + Build duration: 18 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 132 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/132/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 01 Dec 2018 22:55:08 + Build duration: 15 min and counting BUILD ARTIFACTS compat_reports/

D16949: Support for TLS 1.3 (part of Qt 5.12)

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d48a506d83e1: Support for TLS 1.3 (part of Qt 5.12) (authored by aacid). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16949?vs=45637&id=46658 REVISION DETAIL https

Re: Increasing KF5 cmake requirement to 3.5?

El dissabte, 17 de novembre de 2018, a les 22:36:03 CET, Albert Astals Cid va escriure: > El dissabte, 17 de novembre de 2018, a les 20:03:37 CET, Wolfgang Bauer va > escriure: > > > -Original Message- > > > I'm going to suggest it to increase it to 3.6, it would still most > > probably b

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 504 - Aborted!

BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/504/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 29 Nov 2018 16:41:48 + Build duration: 2 days 6 hr and counting

D6877: Add Conan files

Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D6877 To: gladhorn, dfaure Cc: kde-frameworks-devel, gregormi, dfaure, apol, cfeck, michaelh, ngraham, bruns, #frameworks

D17220: Improve symbolism for off and muted status icon

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I've checked it out and it looks good! REPOSITORY R266 Breeze Icons BRANCH streamline-muted-off (branched from master) REVISION DETAIL https://phabricator.kde.org/D17220 To: trickyr

D15999: Add icons with added background to system.svgz

ndavis accepted this revision as: ndavis. ndavis added a comment. Looks like you've addressed all of my concerns, so I'll accept this. @ngraham ? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg, ndavis Cc: ndavis,

D16954: Add find module for Google's libphonenumber

cgiboudeaux added inline comments. INLINE COMMENTS > cgiboudeaux wrote in FindPhoneNumber.cmake:85 > phonenumber doesn't install a pkg-config file, this variable is empty Note: this is harmless, but maybe just add set(PhoneNumber_VERSION 0) to make it clear. AFAICS, none of the public header

D16954: Add find module for Google's libphonenumber

cgiboudeaux added inline comments. INLINE COMMENTS > FindPhoneNumber.cmake:27 > +# will be defined. > + > +#= Since 5.53 > FindPhoneNumber.cmake:85 > +VERSION_VAR > +PhoneNumber_VERSION > +HANDLE_COMPONE

D15999: Add icons with added background to system.svgz

pstefan updated this revision to Diff 46655. pstefan added a comment. - Fix transparency of home icon in go.svgz REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15999?vs=46626&id=46655 BRANCH arcpatch-D15999 REVISION DETAIL https://p

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

gregormi retitled this revision from "File menu: Put Save, Print and Export in submenus" to "KTextEditor: File menu: Put Save, Print and Export in submenus". REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To: gregormi, #kate, #kdevelop Cc: kwrite-devel, kde-fr

D15999: Add icons with added background to system.svgz

ndavis added a comment. Is the home button in `go.svgz` meant to be partially transparent? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg, ndavis Cc: ndavis, broulik, filipf, kde-frameworks-devel, michaelh, ngraham

D17256: [KUrlNavigator] Fix firstChildUrl when going back from archive

This revision was automatically updated to reflect the committed changes. Closed by commit R241:84ff71997b30: [KUrlNavigator] Fix firstChildUrl when going back from archive (authored by thsurrel). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17256?vs=46552&id=46

D17285: Add plugin type for sharing URLs

nicolasfella added a dependent revision: D17287: Enable sharing URLs via email. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D17285 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17287: Enable sharing URLs via email

nicolasfella edited the summary of this revision. nicolasfella added a dependency: D17285: Add plugin type for sharing URLs. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D17287 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17287: Enable sharing URLs via email

nicolasfella created this revision. nicolasfella added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Share URLs via email. Add title to input data TEST PLAN Send page via

D17281: Add icon to KBuildSycocaProgressDialog cancel button

GB_2 marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17281 To: GB_2, ngraham, #frameworks, cfeck Cc: elvisangelaccio, ngraham, kde-frameworks-devel, alexde, IohannesPetros, trickyricky26, michaelh, crozbo, ndavis, firef, bruns, skadinna, a

D17281: Add icon to KBuildSycocaProgressDialog cancel button

GB_2 updated this revision to Diff 46637. GB_2 edited the test plan for this revision. GB_2 added a comment. Improved code. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17281?vs=46615&id=46637 REVISION DETAIL https://phabricator.kde.org/D17281 AFFECTED FI

D16949: Support for TLS 1.3 (part of Qt 5.12)

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D16949 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17285: Add plugin type for sharing URLs

nicolasfella added a dependent revision: D17286: Enable page sharing. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D17285 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17285: Add plugin type for sharing URLs

nicolasfella edited the test plan for this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D17285 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17285: Add plugin type for sharing URLs

nicolasfella created this revision. nicolasfella added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Add a plugin type for sharing URLs and adapt KDE Connect plugin to suppor

D16826: Treat uints and doubles the same as integers

bruns added a comment. Yes, UInt should be fine (actually, all our current integral numeric properties **are** unsigned). REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16826 To: astippich, bruns, #baloo Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, micha

D17241: Disable highlighting for lines longer than 1024 characters.

sars updated this revision to Diff 46633. sars retitled this revision from "WIP: Disable highlighting for lines longer than 1024 characters." to "Disable highlighting for lines longer than 1024 characters.". sars edited the summary of this revision. sars added a reviewer: dhaumann. sars added a c

D16826: Treat uints and doubles the same as integers

astippich added a comment. Okay, so there is more work to do for floats. What about then reducing this patch to uints for now, and doubles are added when everything else is in place? I have something in the pipeline for the Result class, which I added for figuring out how string lists are h

D16826: Treat uints and doubles the same as integers

bruns added a comment. I think support for non-integers is useful in general, but there are a few things we should consider: Currently, only integral numbers can be searched. For floats, we definitely want Less/Greater matches to work, exact matches for floats are not very useful. A

D17241: WIP: Disable highlighting for lines longer than 1024 characters.

sars updated this revision to Diff 46632. sars added a comment. Also disable highlighting in selections for lines that are longe than 1024 REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17241?vs=46499&id=46632 BRANCH master REVISION DETAIL https://

D17284: RFC: Add unit test for splitting of numbers in TermGenerator

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Numbers are not handled as numbers, but literal strings.

D17282: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. TEST PLAN ctest no functional changes REPOSITORY R293 Baloo BRANCH

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 89 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/89/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 01 Dec 2018 16:01:03 + Build duration: 42 min and counting JUnit Tests Name: (root) Failed: 1 te

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/45/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 01 Dec 2018 16:03:27 + Build duration: 37 min and counting BUILD ARTIFACTS compat_reports/K

D17199: Add unittest to check if commiting the same change twice works

This revision was automatically updated to reflect the committed changes. Closed by commit R293:f0c68be03694: Add unittest to check if commiting the same change twice works (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17199?vs=46349&id=466

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 71 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/71/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 01 Dec 2018 15:53:44 + Build duration: 33 min and counting JUnit Tests Name: (root) Failed: 3 te

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 76 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/76/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 01 Dec 2018 15:50:06 + Build duration: 37 min and counting BUILD ARTIFACTS compat_reports/KF5

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.11 - Build # 26 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.11/26/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 01 Dec 2018 14:40:28 + Build duration: 1 hr 44 min and counting JUnit Tests N

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/52/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 01 Dec 2018 15:45:54 + Build duration: 35 min and counting JUnit Tests Name: (root) Faile

D15999: Add icons with added background to system.svgz

pstefan updated this revision to Diff 46626. pstefan added a comment. - Fix stylesheet in go.svgz REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15999?vs=46583&id=46626 BRANCH arcpatch-D15999 REVISION DETAIL https://phabricator.kde.

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.9 - Build # 109 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.9/109/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 01 Dec 2018 14:43:09 + Build duration: 1 hr 21 min and counting BUILD ARTIFACTS compat_reports/K

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/44/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 01 Dec 2018 14:42:37 + Build duration: 1 hr 20 min and counting BUILD ARTIFACTS compat_repo

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 88 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/88/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 01 Dec 2018 14:42:26 + Build duration: 1 hr 18 min and counting JUnit Tests Name: (root) Failed:

D16826: Treat uints and doubles the same as integers

ngraham added a reviewer: Baloo. ngraham added a comment. Makes sense to me, but let's let @bruns have the final say. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16826 To: astippich, bruns, #baloo Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D17270: [KUrlNavigator] List subdirs of a parent folder of an archive

elvisangelaccio added inline comments. INLINE COMMENTS > gregormi wrote in kurlnavigatorbutton.cpp:414 > When I click a zip file I get this in the URL bar: > > krarc:/home/gregor/Downloads/kfk_10p.zip/ > > This could mean that "krarc" should be added to this if statement. Or we could use mim

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 70 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/70/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 01 Dec 2018 14:41:34 + Build duration: 1 hr 12 min and counting JUnit Tests Name: (root) Failed:

D16826: Treat uints and doubles the same as integers

astippich added a comment. @bruns do you consider this useful or shall I abandon? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16826 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16826: Treat uints and doubles the same as integers

astippich updated this revision to Diff 46625. astippich added a comment. - rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16826?vs=45314&id=46625 BRANCH uint_double REVISION DETAIL https://phabricator.kde.org/D16826 AFFECTED FILES src/file/ex

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/75/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 01 Dec 2018 14:39:11 + Build duration: 1 hr 10 min and counting BUILD ARTIFACTS compat_report

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/51/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 01 Dec 2018 14:39:32 + Build duration: 1 hr 6 min and counting JUnit Tests Name: (root) F

D16931: Extract more tags from exif metadata

astippich added a reviewer: mgallien. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16931 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16931: Extract more tags from exif metadata

astippich added a comment. ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16931 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17256: [KUrlNavigator] Fix firstChildUrl when going back from archive

elvisangelaccio accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arc_archivefix (branched from master) REVISION DETAIL https://phabricator.kde.org/D17256 To: thsurrel, #frameworks, elvisangelaccio Cc: kde-frameworks-devel, michaelh, ngrah

D16617: fix extraction of GPS altitude for exif data

This revision was automatically updated to reflect the committed changes. Closed by commit R286:ca8c11351fe7: fix extraction of GPS altitude for exif data (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16617?vs=44723&id=46624 RE

D17253: Fix colors for vector image mimetypes

ngraham added a comment. I had never noticed any pattern for the mimetype icons colors. I'd just assumed it was random lol. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17253 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17281: Add icon to KBuildSycocaProgressDialog cancel button

elvisangelaccio added inline comments. INLINE COMMENTS > kbuildsycocaprogressdialog.cpp:71-73 > +QDialogButtonBox dialogButtonBox; > +dialogButtonBox.setStandardButtons(QDialogButtonBox::Cancel); > +setCancelButton(dialogButtonBox.button(QDialogButtonBox::Cancel)); I'm surprised this

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 275 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/275/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 01 Dec 2018 15:11:26 + Build duration: 15 min and counting BUILD ARTIFACTS compat_rep

D17199: Add unittest to check if commiting the same change twice works

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yep, it applies now that the other patch is in. Works great, looks good. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17199 To: bruns, #baloo,

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 57 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/57/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 01 Dec 2018 15:08:30 + Build duration: 16 min and counting BUILD ARTIFACTS compat_reports

D17281: Add icon to KBuildSycocaProgressDialog cancel button

GB_2 added a comment. Ok, thanks for the info :-) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17281 To: GB_2, ngraham, #frameworks, cfeck Cc: ngraham, kde-frameworks-devel, alexde, IohannesPetros, trickyricky26, michaelh, crozbo, ndavis, firef, bruns, skadinna, aaro

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 93 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/93/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 01 Dec 2018 15:04:29 + Build duration: 17 min and counting JUnit Tests Name: (root) Failed: 3

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/35/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 01 Dec 2018 15:00:47 + Build duration: 19 min and counting JUnit Tests Name: (root) Faile

D17199: Add unittest to check if commiting the same change twice works

bruns added a comment. Conceptually, its independent of D17198 , but there is a single line not matching in the context Try again with currennt master REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17199 To: bruns, #baloo, #fr

D17198: Add unit test for position DB

This revision was automatically updated to reflect the committed changes. Closed by commit R293:38925dd92f69: Add unit test for position DB (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17198?vs=46348&id=46622 REVISION DETAIL https://pha

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 274 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/274/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 01 Dec 2018 14:43:01 + Build duration: 28 min and counting BUILD ARTIFACTS compat_rep

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 56 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/56/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 01 Dec 2018 14:42:36 + Build duration: 25 min and counting BUILD ARTIFACTS compat_reports

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 92 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/92/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 01 Dec 2018 14:41:34 + Build duration: 22 min and counting JUnit Tests Name: (root) Failed: 3

D17199: Add unittest to check if commiting the same change twice works

ngraham added a comment. Patch does not apply for me on top of current master: Ignore these untracked files and continue? [y/N] y INFO Base commit is not in local repository; trying to fetch. Created and checked out branch arcpatch-D17199. This diff i

D17198: Add unit test for position DB

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17198 To: bruns, #baloo, #frameworks, ngraham, poboiko Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, n

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/34/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 01 Dec 2018 14:40:34 + Build duration: 20 min and counting JUnit Tests Name: (root) Faile

D17281: Add icon to KBuildSycocaProgressDialog cancel button

ngraham accepted this revision. ngraham added reviewers: Frameworks, cfeck. ngraham added a comment. This revision is now accepted and ready to land. Works and seems reasonable enough. Anyone else have any opinions on the matter? Also @gb_2, please provide your real name and email address

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 77 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/77/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 01 Dec 2018 14:39:32 + Build duration: 17 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 131 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/131/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 01 Dec 2018 14:39:11 + Build duration: 13 min and counting BUILD ARTIFACTS compat_reports/

KDE CI: Frameworks » frameworkintegration » kf5-qt5 WindowsMSVCQt5.11 - Build # 17 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/frameworkintegration/job/kf5-qt5%20WindowsMSVCQt5.11/17/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 01 Dec 2018 14:38:23 + Build duration: 13 min and counting JUnit Tests

D16832: fix empty runner list after switching to new locale

shaforostoff added inline comments. INLINE COMMENTS > davidedmundson wrote in runnermanager.cpp:274 > what does deadRunners have to do with this? if deadRunners is empty then there is no sense rerunning this method, and it even could cause endless recursion REPOSITORY R308 KRunner REVISION

KDE CI: Frameworks » attica » kf5-qt5 WindowsMSVCQt5.11 - Build # 17 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20WindowsMSVCQt5.11/17/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 01 Dec 2018 14:38:03 + Build duration: 4 min 47 sec and counting JUnit Tests Name:

D17281: Add icon to KBuildSycocaProgressDialog cancel button

GB_2 created this revision. GB_2 added a project: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY The cancel button in the KBuildSycocaProgressDialog (showing that the system configuration is upda

D17273: Extend unit tests to check comparisons of multi-digit numeric properties

This revision was automatically updated to reflect the committed changes. Closed by commit R293:8a390e188be2: Extend unit tests to check comparisons of multi-digit numeric properties (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17273?vs=46

D17274: Remove duplicated code for rating property

This revision was automatically updated to reflect the committed changes. Closed by commit R293:49d08db3b943: Remove duplicated code for rating property (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17274?vs=46594&id=46619 REVISION DETAIL

D17272: Fix searches for rating 10 (5 stars)

This revision was automatically updated to reflect the committed changes. Closed by commit R293:e1045c4f7891: Fix searches for rating 10 (5 stars) (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17272?vs=46593&id=46617 REVISION DETAIL http

D17160: Remove extra spaces from Debug output, insert delimiters between fields

This revision was automatically updated to reflect the committed changes. Closed by commit R293:619547cbfefe: Remove extra spaces from Debug output, insert delimiters between fields (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17160?vs=462

D17252: ovs-patch and ovs-port setting

jgrulich added inline comments. INLINE COMMENTS > ovspatchsetting.cpp:73 > +} > + > +} Remove this space. > ovspatchsetting.h:29 > + > +#if !NM_CHECK_VERSION(1, 10, 0) > +#define NM_SETTING_OVS_PATCH_SETTING_NAME "ovs-patch" Move this please out of the header file and copy these defines

D16949: Support for TLS 1.3 (part of Qt 5.12)

aacid added a comment. Ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16949 To: aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16954: Add find module for Google's libphonenumber

vkrause added a comment. ping? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D16954 To: vkrause, #build_system, #frameworks Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

  1   2   >