D16350: Allow KHelpCenter to open the right pages of KDE help when KHelpClient is invoked with an anchor

2018-10-23 Thread Laurent Montel
mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. seems ok for me REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D16350 To: yurchor, #documentation, #frameworks, mlaurent Cc: mlaurent, kde-frameworks-de

D16395: Update the "About KDE" text

2018-10-23 Thread Andres Betts
abetts added a comment. > KDE has created the friendly and powerful Plasma desktop environment KDE has created the most friendly and powerful desktop environment, Plasma. > KDE is a cooperative enterprise in which no single entity KDE is a disaggregated development community not

D15002: Allow to install syntax files instead of having them in a resource

2018-10-23 Thread Christoph Cullmann
cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. If you have ideas how, patches are welcome. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15002 To: cullmann, vkrause, dhaumann Cc: kfunk, dhauma

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 173 - Failure!

2018-10-23 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/173/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 24 Oct 2018 03:58:25 + Build duration: 25 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 122 - Fixed!

2018-10-23 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/122/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 24 Oct 2018 03:58:33 + Build duration: 8 min 8 sec and counting JUnit Tests Name: (root) Failed

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 248 - Still Unstable!

2018-10-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/248/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 24 Oct 2018 03:58:24 + Build duration: 8 min 39 sec and counting JUnit Tests Name: (r

D16395: Update the "About KDE" text

2018-10-23 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D16395 To: ngraham, #vdg, #plasma, #frameworks, #kde_applications Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16395: Update the "About KDE" text

2018-10-23 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma, Frameworks, KDE Applications. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This text had not been updated in a while, and menti

D15194: Draw a line separating PlasmaComponents tab bar from its content area

2018-10-23 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. Not needed; we can and arguably should do all of this only in Kickoff since this style isn't guaranteed to look good everywhere. We'll do everything in D15206 . REPOSITORY R242 Plasma Framework (L

D16392: [Config] Remove KDE4 config support, stop writing arbitrary config files

2018-10-23 Thread Nathaniel Graham
ngraham added a comment. Looks good, but what's our transition plan? Does this need any special handling for people who already have old config files? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16392 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-framew

D15002: Allow to install syntax files instead of having them in a resource

2018-10-23 Thread Kevin Funk
kfunk added inline comments. INLINE COMMENTS > CMakeLists.txt:3 > macro(generate_php_syntax_definition targetFile srcFile) > -add_custom_command( > -OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/${targetFile} > -COMMAND ${PERL_EXECUTABLE} > ${CMAKE_CURRENT_SOURCE_DIR}/generators/genera

D16385: [sftp] reformat to 4 space indentation

2018-10-23 Thread Aleix Pol Gonzalez
apol accepted this revision. REPOSITORY R320 KIO Extras BRANCH sftp-4space REVISION DETAIL https://phabricator.kde.org/D16385 To: sitter, asn, ngraham, apol Cc: asn, kde-frameworks-devel, kfm-devel, broulik, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andreb

D16392: [Config] Remove KDE4 config support, stop writing arbitrary config files

2018-10-23 Thread Stefan Brüns
bruns edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16392 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16392: [Config] Remove KDE4 config support, stop writing arbitrary config files

2018-10-23 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The KDE4 baloofilerc was only used by dolphin in the KDE4

D16350: Allow KHelpCenter to open the right pages of KDE help when KHelpClient is invoked with an anchor

2018-10-23 Thread Yuri Chornoivan
yurchor updated this revision to Diff 44126. yurchor added a comment. Save some clazy's kittens by using overloaded arg(). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16350?vs=44014&id=44126 REVISION DETAIL https://phabricator.kde.org/D16350 A

D15443: [server] Allow multiple touch interfaces per client

2018-10-23 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH refactorSeatTouch REVISION DETAIL https://phabricator.kde.org/D15443 To: romangg, #kwin, #frameworks, davidedmundson Cc: davidedmundson, kde-frameworks-devel, michaelh,

D16084: Add Media and MediaEndpoint API header generation

2018-10-23 Thread David Rosca
This revision was automatically updated to reflect the committed changes. Closed by commit R269:a65823a9aa43: Add Media and MediaEndpoint API header generation (authored by mweichselbaumer, committed by drosca). REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1

D16084: Add Media and MediaEndpoint API header generation

2018-10-23 Thread David Rosca
drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D16084 To: mweichselbaumer, drosca Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16387: [sftp] put request chunk debugging into own category

2018-10-23 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH sftp-trace-level REVISION DETAIL https://phabricator.kde.org/D16387 To: sitter, asn, broulik, ngraham Cc: kde-frameworks-devel, kfm-devel, sourabhboss, feverfew, michaelh, sp

D16387: [sftp] put request chunk debugging into own category

2018-10-23 Thread Andreas Schneider
asn added a comment. LGTM REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D16387 To: sitter, asn, broulik, ngraham Cc: kde-frameworks-devel, kfm-devel, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D16387: [sftp] put request chunk debugging into own category

2018-10-23 Thread Harald Sitter
sitter created this revision. sitter added reviewers: asn, broulik, ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY it's excessively verbose and not necessarily useful unles

D16385: [sftp] reformat to 4 space indentation

2018-10-23 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH sftp-4space REVISION DETAIL https://phabricator.kde.org/D16385 To: sitter, asn, ngraham Cc: asn, kde-frameworks-devel, kfm-devel, broulik, sourabhboss, feverfew, michaelh, s

D16385: [sftp] reformat to 4 space indentation

2018-10-23 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: asn. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY while that generates history noise it's also much easier on the eyes and

D16265: [Scheduler] Use flag to track when a runner is going idle

2018-10-23 Thread Stefan Brüns
bruns edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16265 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 247 - Still Unstable!

2018-10-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/247/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 23 Oct 2018 10:19:16 + Build duration: 3 min 3 sec and counting JUnit Tests Name: (ro

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 172 - Still Unstable!

2018-10-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/172/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 23 Oct 2018 10:19:16 + Build duration: 3 min 25 sec and counting JUnit Tests Name: (roo

D7909: Add syntax support for Crystal Programming Language

2018-10-23 Thread Faustino Aguilar
faguilar added a comment. In D7909#346328 , @cullmann wrote: > Ping? ;=) Hi, I'm still here, I need some more time to get it working well. :) REPOSITORY R40 Kate REVISION DETAIL https://phabricator.kde.org/D7909 To: faguilar, dhauman