D11768: Add Desktop and Downloads to the default list of Places

ngraham added a comment. It was done in the interests of getting something in rather than nothing, since my initial larger list was controversial. I would favor adding Documents too, FWIW. Seems like others felt similarly. Wanna submit a patch? :) REPOSITORY R241 KIO REVISION DETAIL htt

D11768: Add Desktop and Downloads to the default list of Places

acrouthamel added a comment. Herald added a subscriber: kde-frameworks-devel. Hey Nate, is there a reason why Documents was not added with this patch? I always end up adding it. I was reading through D10245#201638 and the discussion seemed in favor

D15194: Draw a line separating PlasmaComponents tab bar from its content area

ngraham added a comment. Also, if it's preferable to position the item with anchors rather than specifying with x and y, I can do that too: anchors { left: tabPosition == Qt.LeftEdge ? undefined : buttonCutter.left right: tabPosition == Qt.RightEdge ? undefined : b

D15194: Draw a line separating PlasmaComponents tab bar from its content area

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15194 To: ngraham, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15194: Draw a line separating PlasmaComponents tab bar from its content area

ngraham added a comment. I implemented this with the `horizontal-line`/`vertical-line` SVG items to follow the general pattern that I noticed, but I'm not super thrilled with the resulting legibility; it seems a bit too light, and was almost invisible at 1px tall. I also tried a 1px tall `Re

D15194: Draw a line separating PlasmaComponents tab bar from its content area

ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This patch implements one of the ideas we came up with in D15011

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.11 - Build # 5 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.11/5/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 31 Aug 2018 22:08:51 + Build duration: 2 hr 8 min and counting JUnit Tests

D15070: Bindings: Query the install directory from python

bruns added a comment. In D15070#318493 , @bcooksley wrote: > We could, however that would not help people installing it as a regular user, rather than as root. > If I run this right now, as an unprivileged user, I get the following path ret

D15070: Bindings: Query the install directory from python

bcooksley added a comment. We could, however that would not help people installing it as a regular user, rather than as root. If I run this right now, as an unprivileged user, I get the following path returned: >>> sysconfig.get_python_lib( plat_specific=True,standard_lib=False )

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.9 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.9/26/ Project: Frameworks kwindowsystem kf5-qt5 SUSEQt5.9 Date of build: Fri, 31 Aug 2018 22:25:07 + Build duration: 1 hr 8 min and counting JUnit Tests

D15070: Bindings: Query the install directory from python

bruns added a comment. If you can change PYTHONPATH for execution, why can't you specify GPB_PYTHONx_SITEARCH? I would expect if I do not specify a path manually, it should be installed in the default location. This btw. **does** honor PREFIX/EXEC_PREFIX, see https://docs.python.org/3/d

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 48 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/48/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.9 Date of build: Fri, 31 Aug 2018 22:23:47 + Build duration: 59 min and counting JUnit Tests Name: (ro

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.9 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.9/19/ Project: Frameworks kimageformats kf5-qt5 SUSEQt5.9 Date of build: Fri, 31 Aug 2018 22:22:33 + Build duration: 51 min and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 78 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/78/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Fri, 31 Aug 2018 22:24:56 + Build duration: 46 min and counting JUnit Tests Name: (

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.9/36/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 Date of build: Fri, 31 Aug 2018 22:21:07 + Build duration: 49 min and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 390 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/390/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 31 Aug 2018 22:22:44 + Build duration: 46 min and counting JUnit Tests Name: (root) Fai

Re: KDE apps have missing icons when not on Breeze

El dissabte, 1 de setembre de 2018, a les 1:02:00 CEST, Dominik Haumann va escriure: > ...so should we revert the hack we did in Kate? Well, this won't be available until wuite some time in the future (Qt 5.12) so I'd say for now leave it in. Cheers, Albert > > Greetings > Dominik > > > A

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/53/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Fri, 31 Aug 2018 22:20:39 + Build duration: 47 min and counting JUnit Tests Nam

Re: KDE apps have missing icons when not on Breeze

...so should we revert the hack we did in Kate? Greetings Dominik Albert Astals Cid schrieb am Di., 28. Aug. 2018, 22:45: > El dijous, 16 d’agost de 2018, a les 15:19:36 CEST, Albert Astals Cid va > escriure: > > Missatge de Albert Vaca del dia dj., 16 d’ag. > 2018 a > > les 13:57: > > > > >

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/38/ Project: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 Date of build: Fri, 31 Aug 2018 22:25:07 + Build duration: 33 min and counting JUnit Tests

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 206 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/206/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Fri, 31 Aug 2018 22:25:40 + Build duration: 29 min and counting JUnit Te

D8256: Add _XOPEN_SOURCE to C definitions

bcooksley added subscribers: FreeBSD, bcooksley. bcooksley added a comment. This change appears to have resulted in a severe regression of builds on FreeBSD. Any ideas? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8256 To: awilcox, alexmerry, dfaure

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 70 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/70/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Fri, 31 Aug 2018 22:23:47 + Build duration: 25 min and counting JUnit Tests Name: (

KDE CI: Frameworks threadweaver kf5-qt5 FreeBSDQt5.11 - Build # 2 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20FreeBSDQt5.11/2/ Project: Frameworks threadweaver kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 31 Aug 2018 22:26:22 + Build duration: 18 min and counting CONSOLE OUTPU

KDE CI: Frameworks solid kf5-qt5 FreeBSDQt5.11 - Build # 3 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20solid%20kf5-qt5%20FreeBSDQt5.11/3/ Project: Frameworks solid kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 31 Aug 2018 22:26:02 + Build duration: 18 min and counting CONSOLE OUTPUT [...tr

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.10 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.10/25/ Project: Frameworks kimageformats kf5-qt5 SUSEQt5.10 Date of build: Fri, 31 Aug 2018 22:22:33 + Build duration: 15 min and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.11 - Build # 2 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.11/2/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 31 Aug 2018 22:24:56 + Build duration: 12 min and counting CONSOLE OUTPUT

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 62 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/62/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Fri, 31 Aug 2018 22:21:07 + Build duration: 14 min and counting JUnit Tests

KDE CI: Frameworks kdoctools kf5-qt5 SUSEQt5.10 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/54/ Project: Frameworks kdoctools kf5-qt5 SUSEQt5.10 Date of build: Fri, 31 Aug 2018 22:21:35 + Build duration: 13 min and counting JUnit Tests Name:

KDE CI: Frameworks kiconthemes kf5-qt5 FreeBSDQt5.11 - Build # 3 - Failure!

Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38): ${JELLY_SCRIPT,template="html_gmail"} ^ hudson.remoting.ChannelClosedException: Channel "unknown": Remo

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 108 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/108/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Fri, 31 Aug 2018 22:20:38 + Build duration: 11 min and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.11 - Build # 13 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.11/13/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 31 Aug 2018 22:22:44 + Build duration: 7 min 40 sec and counting CONSOLE OUTPUT [..

KDE CI: Frameworks kjs kf5-qt5 FreeBSDQt5.11 - Build # 2 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kjs%20kf5-qt5%20FreeBSDQt5.11/2/ Project: Frameworks kjs kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 31 Aug 2018 22:23:12 + Build duration: 8 min 8 sec and counting CONSOLE OUTPUT [...t

D15070: Bindings: Query the install directory from python

bcooksley added a comment. All we do is set PYTHONPATH, to ensure that the directory we install additional things to is searched by Python. It is imperative however that things are not installed outside of CMAKE_INSTALL_PREFIX otherwise they will be missed by the capture process, and wi

KDE CI: Frameworks kinit kf5-qt5 FreeBSDQt5.11 - Build # 2 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kinit%20kf5-qt5%20FreeBSDQt5.11/2/ Project: Frameworks kinit kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 31 Aug 2018 22:22:39 + Build duration: 6 min 49 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks khtml kf5-qt5 FreeBSDQt5.11 - Build # 3 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20khtml%20kf5-qt5%20FreeBSDQt5.11/3/ Project: Frameworks khtml kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 31 Aug 2018 22:22:07 + Build duration: 6 min 55 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kunitconversion kf5-qt5 AndroidQt5.11 - Build # 13 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20AndroidQt5.11/13/ Project: Frameworks kunitconversion kf5-qt5 AndroidQt5.11 Date of build: Fri, 31 Aug 2018 22:24:45 + Build duration: 38 sec and counting CONSOL

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.11 - Build # 3 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.11/3/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 31 Aug 2018 22:21:07 + Build duration: 4 min 23 sec and counting C

KDE CI: Frameworks kdesu kf5-qt5 FreeBSDQt5.11 - Build # 2 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kdesu%20kf5-qt5%20FreeBSDQt5.11/2/ Project: Frameworks kdesu kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 31 Aug 2018 22:21:18 + Build duration: 4 min 36 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kpackage kf5-qt5 AndroidQt5.11 - Build # 15 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20AndroidQt5.11/15/ Project: Frameworks kpackage kf5-qt5 AndroidQt5.11 Date of build: Fri, 31 Aug 2018 22:23:47 + Build duration: 58 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kcrash kf5-qt5 FreeBSDQt5.11 - Build # 2 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20FreeBSDQt5.11/2/ Project: Frameworks kcrash kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 31 Aug 2018 22:20:44 + Build duration: 3 min 20 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.11 - Build # 5 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.11/5/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 31 Aug 2018 22:20:38 + Build duration: 3 min 13 sec and counting CONSOLE O

D15070: Bindings: Query the install directory from python

bruns added a comment. @bcooksley Of course I can not guarantee it does not break CI, but as long as it follows generic python standards and rules (i.e. properly setup distutils) it should work. On the other hand, I can guarantee it currently is broken for a number of distributions. RE

D14915: Bindings: Check if bindings can be generated for a specific python version

This revision was automatically updated to reflect the committed changes. Closed by commit R240:4275cfc3f75d: Bindings: Check if bindings can be generated for a specific python version (authored by bruns). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.

D14914: Bindings: Use python version matching the found clang python module

This revision was automatically updated to reflect the committed changes. Closed by commit R240:451bc7609c2d: Bindings: Use python version matching the found clang python module (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14914?vs=39951&id=40794#toc REPOSITORY R

D14912: Bindings: Make generator forward compatible with Python 3

This revision was automatically updated to reflect the committed changes. Closed by commit R240:b6e4e645dac6: Bindings: Make generator forward compatible with Python 3 (authored by bruns). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14912?vs=403

D11945: Improve highlighting of SELinux CIL policies & file contexts

nibags closed this revision. nibags added a comment. Corresponds to the commit: https://phabricator.kde.org/R216:498f72d49a66ec05c71f3ec614698a6cb63c513f REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D11945 To: nibags, dhaumann, cullmann, #framework_syn

D11945: Improve highlighting of SELinux CIL policies & file contexts

nibags added a commit: R216:498f72d49a66: Add syntax highlighting for SELinux kernel policy language. REPOSITORY R216 Syntax Highlighting BRANCH add-selinux REVISION DETAIL https://phabricator.kde.org/D11945 To: nibags, dhaumann, cullmann, #framework_syntax_highlighting Cc: kwrite-devel,

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

anthonyfieroni added inline comments. INLINE COMMENTS > anthonyfieroni wrote in krun.cpp:1319 > You cannot remove it, since it can be a local file, remote file with scheme > that differs http and should be redirect then. So you can make it like that > > if (!job->url().scheme().startsWith("ht

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

anthonyfieroni added inline comments. INLINE COMMENTS > krun.cpp:1319 > -// Update our URL in case of a redirection > -setUrl(job->url()); > - You cannot remove it, since it can be a local file, remote file with scheme that differs http and should be redirect then. So you can ma

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

achauvel updated this revision to Diff 40784. achauvel edited the test plan for this revision. achauvel added a comment. Previous was incorrect, this one works. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15189?vs=40782&id=40784 REVISION DETAIL https://ph

D15089: Add syntax highlighting for SELinux kernel policy language

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15089 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhauman

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

ngraham added reviewers: Frameworks, dfaure, cfeck. ngraham added a comment. Can you change `Fix https://bugs.kde.org/show_bug.cgi?id=354246` to `BUG: 354246`? Thanks! See https://community.kde.org/Infrastructure/Phabricator#Add_special_keywords It would also be nice if you could update

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

achauvel created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. achauvel requested review of this revision. REVISION SUMMARY Fix https://bugs.kde.org/show_bug.cgi?id=354246 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/

D15180: kioexecd: watch for creations or modifications of the temporary files

jtamate added inline comments. INLINE COMMENTS > broulik wrote in kioexecd.cpp:58 > If you can be sure kioexec creates a folder per temp file (it might does), > then this is probably fine. > Also check kioexec what it does when the process closes, if it also > recursively removes the temp dir

D15180: kioexecd: watch for creations or modifications of the temporary files

jtamate updated this revision to Diff 40779. jtamate marked 3 inline comments as done. jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a comment. I'm not sure if I have to keep compatibility in the dbus calls, therefore the old one is

D11776: Make use of upstream CMake infrastructure to detect the compiler toolchain

Martchus added a comment. @vkrause Thanks for confirming this. So it is not a local issue. Could you find a workaround (beside reverting these changes)? As I already mentioned, I'm not so familiar. However, for me the way CMake populates `CMAKE_CXX_STANDARD_LIBRARIES` doesn't look comple

D14946: [DialogShadows] Use 0 offset for disabled borders on Wayland

zzag added a comment. I suppose it has to go in 5.51 (tagging will be tomorrow). REPOSITORY R242 Plasma Framework (Library) BRANCH wayland-shadows REVISION DETAIL https://phabricator.kde.org/D14946 To: zzag, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14807: [AppStream Runner] Also search when there were errors during Pool::load

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0ec3f76810b7: [AppStream Runner] Also search when there were errors during Pool::load (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1

D11776: Make use of upstream CMake infrastructure to detect the compiler toolchain

vkrause added a comment. It's the same issue I have here, but after our discussion at Akademy I assumed this to be local setup issue. Similar versions here, on Tumbleweed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D11776 To: apol, #frameworks, #buil

D15089: Add syntax highlighting for SELinux kernel policy language

nibags updated this revision to Diff 40769. nibags added a comment. - Small correction in a comment REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15089?vs=40763&id=40769 BRANCH add-selinux REVISION DETAIL https://phabricator.kde.org/D1508

D11776: Make use of upstream CMake infrastructure to detect the compiler toolchain

Martchus added a comment. @apol I'm not that familiar with Android, but I guess the variable `CMAKE_CXX_STANDARD_LIBRARIES` is not limited to contain only a single library (note the plural in the variable name). So I think we should handle that. BTW, I'm just testing with the `accelbubbl

D11945: Improve highlighting of SELinux CIL policies & file contexts

nibags updated this revision to Diff 40766. nibags added a comment. - Update according to the latest change of "selinux.xml" (only single-line strings and better MLS/MCS levels detection). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11945?vs

D11776: Make use of upstream CMake infrastructure to detect the compiler toolchain

apol added a comment. @Martchus sounds like your CMAKE_CXX_STANDARD_LIBRARIES gets initialized wrong somehow, no? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D11776 To: apol, #frameworks, #build_system, vkrause Cc: kde-frameworks-devel, kde-buildsyste

D14807: [AppStream Runner] Also search when there were errors during Pool::load

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. whatever. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14807 To: bruns, #plasma, #frameworks, apol Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesl

D14807: [AppStream Runner] Also search when there were errors during Pool::load

bruns added a comment. As I said, that violates https://community.kde.org/Policies/Commit_Policy#Commit_complete_changesets and I prefer to keep these apart. This one fixes the behaviour, and has a separate bug report. The other ones change logging and are quite independent. REPOSI

D14915: Bindings: Check if bindings can be generated for a specific python version

arojas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14915 To: bruns, #frameworks, arojas Cc: arojas, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14914: Bindings: Use python version matching the found clang python module

arojas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14914 To: bruns, #frameworks, arojas Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D11776: Make use of upstream CMake infrastructure to detect the compiler toolchain

Martchus added a comment. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. This change produces invalid JSON in my setup: "stdcpp-path":" "/opt/android-ndk/sources/cxx-stl/gnu-libstdc++/4.9/libs/arm64-v8a/libgnustl_shared.so" -nodefaultlibs -lgcc -lc -lm -ldl", So

D14912: Bindings: Make generator forward compatible with Python 3

arojas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14912 To: bruns, #frameworks, arojas Cc: arojas, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14807: [AppStream Runner] Also search when there were errors during Pool::load

apol added a comment. Ugh, like I said, can you please squash them into a commit? They are good changes in general. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14807 To: bruns, #plasma, #frameworks Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, le

D14912: Bindings: Make generator forward compatible with Python 3

bruns added a comment. So, tested on Arch, openSUSE TW and Leap 15.0 ... @arojas - can you accept, also for the two other reviews? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14912 To: bruns, #frameworks Cc: arojas, kde-frameworks-devel, kde-buildsy

D14807: [AppStream Runner] Also search when there were errors during Pool::load

bruns removed a reviewer: apol. bruns removed a subscriber: apol. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14807 To: bruns, #plasma, #frameworks Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, a

D15089: Add syntax highlighting for SELinux kernel policy language

nibags updated this revision to Diff 40763. nibags added a comment. - Update I checked the highlight in several policies and made some changes: - I verify that SELinux does not support multi-line strings (neither line continuation escapes). - Small improvements in the detection of

D15177: Emit signals when a package is installed/uninstalled

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in packagejob.cpp:93 > Can `packageType` contain characters not allowed in DBus? Technically, yes, it's a string in the metadata of the package type so could. By convention format X-KDE-ServiceTypes is always in the format Fo

D15177: Emit signals when a package is installed/uninstalled

broulik added a comment. +1 INLINE COMMENTS > packagejob.cpp:93 > +for (auto packageType: serviceTypes) { > +auto msg = > QDBusMessage::createSignal(QStringLiteral("/KPackage/") + packageType, > QStringLiteral("org.kde.plasma.kpackage"), > QStringLiteral("packag

D15180: kioexecd: watch for creations or modifications of the temporary files

broulik added inline comments. INLINE COMMENTS > jtamate wrote in kioexecd.cpp:58 > Why not? > It should be just removing the temporary file copy and it's backups. If you can be sure kioexec creates a folder per temp file (it might does), then this is probably fine. Also check kioexec what it d

Re: New framework: KF5Syndication

On Fri, Aug 31, 2018 at 6:35 AM Volker Krause wrote: > > On Thursday, 30 August 2018 18:04:56 CEST Christoph Feck wrote: > > On 18.08.2018 15:38, Volker Krause wrote: > > > The KIO dependency has been refactored away, so [KF5Syndication] is now a > > > tier 2 functional framework. > > > > Any idea

D15180: kioexecd: watch for creations or modifications of the temporary files

jtamate marked 2 inline comments as done. jtamate added inline comments. INLINE COMMENTS > broulik wrote in kioexecd.cpp:58 > I'm not sure that's a good idea Why not? It should be just removing the temporary file copy and it's backups. > broulik wrote in kioexecd.cpp:73 > You never unwatch the

Re: ECM Behaviour: Setting QT_PLUGIN_PATH on Windows

On Tue, Aug 28, 2018 at 10:35 PM Ben Cooksley wrote: > > Hi all, Hi all, > > We currently have a severe bug in ECM's AddTest macro due to it's > behaviour around the setting of QT_PLUGIN_PATH. On Windows it would > appear that the code in ECMAddTest mangles the environment variable, > removing c

D8256: Add _XOPEN_SOURCE to C definitions

This revision was automatically updated to reflect the committed changes. Closed by commit R240:6684cb99bdf4: Add _XOPEN_SOURCE to C definitions (authored by awilcox, committed by dfaure). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8256?vs=2062

[extra-cmake-modules] modules: Disable alteration of QT_PLUGIN_PATH by ECM when running tests.

Git commit 7d6d5b1e705f54a216f8d5235b66bbf2035d7448 by Ben Cooksley. Committed on 31/08/2018 at 08:46. Pushed by bcooksley into branch 'master'. Disable alteration of QT_PLUGIN_PATH by ECM when running tests. On Windows at least this is simply broken and leads to tests failing because plugins fr

D15180: kioexecd: watch for creations or modifications of the temporary files

broulik added inline comments. INLINE COMMENTS > kioexecd.cpp:58 > qCDebug(KIOEXEC) << "About to delete" << parentDir << "containing" > << info.fileName(); > -QFile::remove(it.key()); > -QDir().rmdir(parentDir); > +QDir(parentDir).removeRecursively(); > } I

D15180: kioexecd: watch for creations or modifications of the temporary files

jtamate created this revision. jtamate added reviewers: Frameworks, broulik, ngraham, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY When a non KIO friendly program opens a non local file, t

D15146: RFC: Don't consider KDiskFreeSpaceInfo valid if all relevant statvfs fields are zero

fvogt added a comment. With a few modification the patch is correct and necessary though. statfs (not statvfs!) has in the documentation: `Fields that are undefined for a particular filesystem are set to 0.`. Currently KIO just returns garbage in that case. The KMountPoint calls abo

D8256: Add _XOPEN_SOURCE to C definitions

dfaure added a comment. Ah, found it in bugzilla :-) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8256 To: awilcox, alexmerry, dfaure Cc: kde-frameworks-devel, kde-buildsystem, mpyne, dfaure, michaelh, ngraham, bruns

D8256: Add _XOPEN_SOURCE to C definitions

dfaure added a comment. Let's push this then ;) You don't seem to have a developer account? I can push this but I need your email address for the git authorship. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8256 To: awilcox, alexmerry, dfaure Cc:

D15146: RFC: Don't consider KDiskFreeSpaceInfo valid if all relevant statvfs fields are zero

broulik abandoned this revision. broulik added a comment. It seems by adding gvfsd support for `KMountPoint` this has become obsolete. $ df /run/user/1000/gvfs/ Filesystem 1K-blocks Used Available Use% Mounted on gvfsd-fuse 0 0 0- /run/user/1000/g

D15141: [KSambaShareData] Accept spaces in ACL host name

This revision was automatically updated to reflect the committed changes. Closed by commit R241:469b6cec127d: [KSambaShareData] Accept spaces in ACL host name (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15141?vs=40730&id=40736 REVISION D

D15141: [KSambaShareData] Accept spaces in ACL host name

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15141 To: broulik, dfaure, fvogt Cc: ngraham, bruns, kde-frameworks-devel, michaelh

D15146: RFC: Don't consider KDiskFreeSpaceInfo valid if all relevant statvfs fields are zero

dfaure accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15146 To: broulik, dfaure, ngraham, fvogt Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15161: [KFileItemListProperties] Use mostLocalUrl for capabilities

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d8a0cbc2b1a0: [KFileItemListProperties] Use mostLocalUrl for capabilities (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15161?vs=40686&id=40734

D15154: Also check smb-share for whether it's an SMB mount

This revision was automatically updated to reflect the committed changes. Closed by commit R241:97b8d5f1ec47: [KMountPoint] Also check "smb-share" for whether it's an SMB mount (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15154?vs=40671&id=40733#toc REPOSITORY

D15153: RFC: Resolve gvfsd mounts

This revision was automatically updated to reflect the committed changes. Closed by commit R241:5fb35a3c105d: [KMountPoint] Resolve gvfsd mounts (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15153?vs=40670&id=40732 REVISION DETAIL https:

D15141: [KSambaShareData] Accept spaces in ACL host name

broulik updated this revision to Diff 40730. broulik added a comment. - Fix include guard - Fix include REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15141?vs=40705&id=40730 REVISION DETAIL https://phabricator.kde.org/D15141 AFFECTED FILES autotests/CM

D15141: [KSambaShareData] Accept spaces in ACL host name

broulik added a comment. In D15141#317900 , @ngraham wrote: > Does this patch help with https://bugs.kde.org/show_bug.cgi?id=398079? I don't know but without this patch I failed to configure permissions in the "Share" tab, e.g. "Allow gue

D15146: RFC: Don't consider KDiskFreeSpaceInfo valid if all relevant statvfs fields are zero

broulik added a comment. Ping :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15146 To: broulik, dfaure, ngraham, fvogt Cc: kde-frameworks-devel, michaelh, ngraham, bruns