D13643: Add LabPlot project file icon

mtrescott added a comment. Bump REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13643 To: mtrescott, #labplot, #vdg, #breeze, ngraham Cc: abetts, asemke, ngraham, kde-frameworks-devel, michaelh, bruns

D14894: [RFC] Fix block mode for multi-cursor branch

lepagevalleeemmanuel created this revision. lepagevalleeemmanuel added a reviewer: brauch. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. lepagevalleeemmanuel requested review of this revision. REVISION SUMMARY This is a rough patch to allo

D14826: inline note interface wip #2

brauch closed this revision. brauch added a comment. commit 4ea5fee0afe5c76bbee07563c23ede808aa059de Author: Sven Brauch Date: Tue Aug 14 12:31:31 2018 +0200 Add inline note interface Original patch by Michal Srb. The inline note interface provides a way to rende

D14890: Remove QSaveFile in favor of plain old file saving

cfeck retitled this revision from "remove QSaveFile in favor of plain old file saving rational: for many use cases that e.g. have acls, complex other extended attributes, static links e.g. the rename() doesnt do the trick it should other ways would be start to add workarounds to..." to "Remove Q

D13797: Only add actual documents to Recent Documents

ngraham abandoned this revision. ngraham added a comment. You're right, Kai. I've submitted a more appropriate patch: D14893: [recentdocuments:/] Filter out files that can't be browsed with a file manager . REPOSITORY R241 KIO REVISION DETAIL https://

D14893: [recentdocuments:/] Filter out files that can't be browsed with a file manager

ngraham created this revision. ngraham added reviewers: broulik, Dolphin, Frameworks. ngraham requested review of this revision. REVISION SUMMARY This is a more appropriate version of D13797: Only add actual documents to Recent Documents . Basically we filter

D14826: inline note interface wip #2

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Avoiding the QObject inheritance requires some ugly QObject casts, therefore we keep that ATM. We merge it that way and talk tomorrow morning once more about that detail. REPOSITORY

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

elvisangelaccio added a comment. No need to apologize, that's what code reviews are for :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13804 To: ngraham, broulik, #dolphin, #frameworks, cfeck Cc: elvisangelaccio, cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

ngraham abandoned this revision. ngraham added a comment. Hmm, I can't reproduce it now either. I could have sworn that the issue reproduced for me when I originally tested the bug and submitted the patch, so maybe it was fixed by something else in the meantime. Or maybe I tested it wrong in

D14826: inline note interface wip #2

cullmann added a comment. I think the Provider needs not to be an QObject, just an interface, IMHO. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14826 To: brauch, michalsrb, dhaumann, cullmann Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, michaelh, ke

D14826: inline note interface wip #2

brauch updated this revision to Diff 39889. brauch added a comment. update license text REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14826?vs=39888&id=39889 BRANCH inlinenotes REVISION DETAIL https://phabricator.kde.org/D14826 AFFECTED FILES s

D12662: Add InlineNoteInterface

cullmann commandeered this revision. cullmann added a reviewer: michalsrb. cullmann added a comment. Hi, we will process further things of this request in Sven's copy D14826 : inline note interface wip #2. REPOSITORY R39 KTextEditor REVISION DETAIL h

D12662: Add InlineNoteInterface

cullmann abandoned this revision. cullmann added a comment. Head over to D14826 : inline note interface wip #2. for the current state. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12662 To: cullmann, #ktexteditor, michalsrb

D14826: inline note interface wip #2

brauch updated this revision to Diff 39888. brauch marked 21 inline comments as done. brauch added a comment. Implement Dominik's suggestions REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14826?vs=39815&id=39888 BRANCH inlinenotes REVISION DETAIL

D14890: remove QSaveFile in favor of plain old file saving rational: for many use cases that e.g. have acls, complex other extended attributes, static links e.g. the rename() doesnt do the trick it sh

cullmann added a comment. That sounds reasonable. The hint is actually very good, at the moment in the best case the user get some "saving failed" message like: The document could not be saved, as it was not possible to write to /XML-slowdown-KWRITE.xml. Check that you have wri

D14890: remove QSaveFile in favor of plain old file saving rational: for many use cases that e.g. have acls, complex other extended attributes, static links e.g. the rename() doesnt do the trick it sh

dfaure added a comment. I just tested how vim handles this. No QSaveFile-like behaviour (direct write, says strace), and in case of partition full, this error message appears: "myfile" E514: write error (file system full?) WARNING: Original file may be lost or damaged don't quit th

D14890: remove QSaveFile in favor of plain old file saving rational: for many use cases that e.g. have acls, complex other extended attributes, static links e.g. the rename() doesnt do the trick it sh

cullmann added a comment. Actually, that the application crashs during that actions is highly unlikely, I can't remember any crash during save being reported in the last 5 years. The partition full is more ugly, that is true. (and in any case, for sure is direct writing more unsafe than th

D14890: remove QSaveFile in favor of plain old file saving rational: for many use cases that e.g. have acls, complex other extended attributes, static links e.g. the rename() doesnt do the trick it sh

dfaure added a comment. But what about the issue where you try to save over an existing file, and the partition is full (or the app crashes), and the user loses the file? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14890 To: cullmann, dhaumann Cc: dfaure, kwr

D14890: remove QSaveFile in favor of plain old file saving rational: for many use cases that e.g. have acls, complex other extended attributes, static links e.g. the rename() doesnt do the trick it sh

cullmann added a comment. Relevant bugs bug 379818 bug 333577 bug 366583 bug 354405 bug 358457 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14890 To: cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,

D14890: remove QSaveFile in favor of plain old file saving rational: for many use cases that e.g. have acls, complex other extended attributes, static links e.g. the rename() doesnt do the trick it sh

cullmann created this revision. cullmann added a reviewer: dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY ...all cases, which is hard, e.g. if that is something shared v

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

intelfx added a comment. @cullmann So, how do you propose to port Solarized to Kate/KDevelop then? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5802 To: intelfx, #kdevelop, #ktexteditor, #kate, mwolff Cc: cullmann, kde-frameworks-devel, brauch, dhaumann, mwolff

D14826: inline note interface wip #2

dhaumann added a comment. I think one more iteration, and this can be merged. Can you look into this again? INLINE COMMENTS > CMakeLists.txt:5 >AnnotationInterface CodeCompletionModelControllerInterface MovingCursor > Range TextHintInterface > - Cursor MarkInterface MovingInterface > +

Re: KDE CI: Dependency Build Extragear kf5-qt5 SUSEQt5.9 - Build # 121 - Still Failing!

We discussed this in a BOF. Conclusion was that anyone using plasma-workspace in extragear is always wrong and won't be supported by us. Mycroft: Not actually used, now fixed! plasma-sdk: Not actually used, now fixed! Apper: Uses kworkspace to shutdown Could direct QDBus? This needs doing by so

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

aacid added a comment. In D14779#309943 , @habacker wrote: > With the drawback that the qm file need to be generated on each build and the po file needs to be updated on any translations change in the test app > > BTW: I tried your approach

Re: KDE apps have missing icons when not on Breeze

Missatge de Albert Vaca del dia dj., 16 d’ag. 2018 a les 13:57: > Hi everyone, > > If we want to reach more potential users, we have to make sure KDE > apps look properly in every desktop. Take a look at how KDE apps look > in Gnome, you will see there are lots of missing icons. > > https://imgur

Re: KDE apps have missing icons when not on Breeze

On Thu, Aug 16, 2018 at 2:41 PM Dominik Haumann wrote: > Just yesterday Kåre worked around a similar issue when running > Kate in Gnome. See fix: https://phabricator.kde.org/D14856 > The solution for Kate solves a more specific problem. If they can't find the icon "games-config-options", then the

Re: KDE apps have missing icons when not on Breeze

Hi, On Thu, Aug 16, 2018 at 2:33 PM, David Faure wrote: > On jeudi 16 août 2018 12:43:47 CEST Albert Vaca wrote: >> Hi everyone, >> >> If we want to reach more potential users, we have to make sure KDE >> apps look properly in every desktop. Take a look at how KDE apps look >> in Gnome, you will

Re: KDE apps have missing icons when not on Breeze

On jeudi 16 août 2018 12:43:47 CEST Albert Vaca wrote: > Hi everyone, > > If we want to reach more potential users, we have to make sure KDE > apps look properly in every desktop. Take a look at how KDE apps look > in Gnome, you will see there are lots of missing icons. > > https://imgur.com/a/nk

D13813: Make this test work again with new uds implementation

bcooksley added a comment. That would have happened locally, shouldn't be anything to do with our systems - especially given it's a Travis CI name/address being mentioned. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13813 To: jtamate, #dolphin, #frameworks, elvi

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

elvisangelaccio added a comment. Same, there is only one entry there. Not sure what's going on, maybe somewhere else we are already filtering out duplicates? REPOSITORY R241 KIO BRANCH more-liberal-recent-document-duplicate-detection (branched from master) REVISION DETAIL https:/

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

ngraham added a comment. In D13804#310036 , @elvisangelaccio wrote: > I cannot reproduce the linked bug. If open the same file in both kate and kwrite I get only one entry in krunner (despite the file having two different `X-KDE-LastOpenedWith`

KDE apps have missing icons when not on Breeze

Hi everyone, If we want to reach more potential users, we have to make sure KDE apps look properly in every desktop. Take a look at how KDE apps look in Gnome, you will see there are lots of missing icons. https://imgur.com/a/nkeiryb It think it is important to get this fixed, as it can make peo

D13813: Make this test work again with new uds implementation

elvisangelaccio added a comment. In D13813#310067 , @jtamate wrote: > In D13813#310047 , @cfeck wrote: > > > Authored by a Bot? > > > Somehow my name and email address in .gitconfig got changed.

D13813: Make this test work again with new uds implementation

jtamate added a comment. In D13813#310047 , @cfeck wrote: > Authored by a Bot? Somehow my name and email address in .gitconfig got changed. How? No idea. Should revert and push again with the right name? REPOSITORY R318 Dolphin REVIS

D13813: Make this test work again with new uds implementation

elvisangelaccio added subscribers: nalvarez, bshah, bcooksley. elvisangelaccio added a comment. In D13813#310047 , @cfeck wrote: > Authored by a Bot? Yeah I was about to ask the same question. @bshah @bcooksley @nalvarez ? REPOSITORY

D13813: Make this test work again with new uds implementation

cfeck added a comment. Authored by a Bot? REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13813 To: jtamate, #dolphin, #frameworks, elvisangelaccio Cc: cfeck, dfaure, aacid, ngraham, bruns, elvisangelaccio, kfm-devel, spoorun, navarromorales, firef, andrebarros, emm

D13813: Make this test work again with new uds implementation

This revision was automatically updated to reflect the committed changes. Closed by commit R318:2104d18a6760: Make this test work again with new uds implementation (authored by Travis CI Bot ). REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D13813: Make this test work again with new uds implementation

elvisangelaccio accepted this revision. elvisangelaccio added a comment. This revision is now accepted and ready to land. Right. Then let's ship it as is for now, thanks! REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13813 To: jtamate, #dolphin, #frameworks, elvisa

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

elvisangelaccio added a comment. I cannot reproduce the linked bug. If open the same file in both kate and kwrite I get only one entry in krunner (despite the file having two different `X-KDE-LastOpenedWith` values in .`local/share/RecentDocuments/`). REPOSITORY R241 KIO BRANCH more-lib

D11649: Fix crash in the file slave

aacid planned changes to this revision. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11649 To: aacid, #frameworks, dfaure Cc: kde-frameworks-devel, #kde_connect, michaelh, ngraham, bruns

D11604: kdirlistertest doesn't fail at random

jtamate updated this revision to Diff 39836. jtamate marked 3 inline comments as done. jtamate added a comment. Restored all the signalSpy wait wrongly deleted. Removed the use of qmimedatabase. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11604?vs=39801&id

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

habacker added a comment. With the drawback that the qm file need to be generated on each build and the po file needs to be updated on any translations change in the test app BTW: I tried your approach by 1. downloaded po file from https://websvn.kde.org/trunk/l10n-kf5/en/messages/