D14530: Fix crash when save a QImage to the eps format file

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I don't see much point in this patch, Qt already tells you that a QCoreApplication is missing (as you can see in the bug report). You have to create a QCoreApplication in any Qt p

D14504: Save few string allocations

pino added a comment. TBH I had the idea of making `splitLocale()` public, since it was a public API in `KLocale`. I still see a couple of users of it, and in the past I remember people working around the lack of `splitLocale()` by doing the same job on their own, when porting away from kdel

D14530: Fix crash when save a QImage to the eps format file

zccrs created this revision. zccrs added reviewers: mlaurent, kossebau, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. zccrs requested review of this revision. REVISION SUMMARY fix the bug: https://bugs.kde.org/show_bu

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 190 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/190/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 01 Aug 2018 03:52:13 + Build duration: 4 min 19 sec and counting JU

D14528: Android: Make sure we're looking for .mo files in the right path

apol added a reviewer: ckertesz. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D14528 To: apol, #frameworks, ilic, ckertesz Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14528: Android: Make sure we're looking for .mo files in the right path

apol created this revision. apol added reviewers: Frameworks, ilic. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY QStandardPaths won't be giving us the file we need, in

D14526: AppArmor: update syntax and various improvements/fixes

nibags added reviewers: Framework: Syntax Highlighting, Kate. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14526 To: nibags, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cul

D14526: AppArmor: update syntax and various improvements/fixes

nibags created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY I have updated and checked the syntax highlighting of AppArmor with vari

D14524: Fix compiler warning -Wimplicit-fallthrough

winterz added a comment. agree that Q_FALLTHROUGH(); is a better idea. it doesn't duplicate code and it informs the reader that the fallthrough is intentional REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14524 To: dhaumann, vkrause Cc: winterz, aaci

D14503: Android: also fall-back to using QLocale

aacid added a comment. Aleix means https://phabricator.kde.org/D14508 REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D14503 To: apol, #frameworks, ilic, aacid, vkrause Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14524: Fix compiler warning -Wimplicit-fallthrough

aacid added a comment. Maybe it makes more sense to replace it with the magic words? // fall-through REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14524 To: dhaumann, vkrause Cc: aacid, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngr

D14520: Open `skipPager` functionality

sharvey marked an inline comment as done. sharvey added a comment. Hopefully `.arclint` is gone for good this time. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14520 To: sharvey, #plasma_on_wayland, hein, #plasma, romangg, davidedmundson Cc: zzag, kde-frameworks

D14520: Open `skipPager` functionality

sharvey updated this revision to Diff 38877. sharvey added a comment. - Whitespace fix & remove .arclint REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14520?vs=38863&id=38877 BRANCH arcpatch-D14516 REVISION DETAIL https://phabricator.kde.org/D14520

D14434: add functions to access keywords

asemke added a comment. In D14434#300211 , @dhaumann wrote: > @asemke Are you sure you reference the correct Task? I cannot find anything about keyword lists in your link. @dhaumann yes, I'm sure this is the correct task. That task is abo

D14524: Fix compiler warning -Wimplicit-fallthrough

This revision was automatically updated to reflect the committed changes. Closed by commit R216:7312f52e2753: Fix compiler warning -Wimplicit-fallthrough (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14524?vs=38873&id=38874

D14524: Fix compiler warning -Wimplicit-fallthrough

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH removeWarnings (branched from master) REVISION DETAIL https://phabricator.kde.org/D14524 To: dhaumann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevi

D14524: Fix compiler warning -Wimplicit-fallthrough

dhaumann added a comment. If there is a better / more readable fix, please let me know. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14524 To: dhaumann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, c

D14524: Fix compiler warning -Wimplicit-fallthrough

dhaumann created this revision. dhaumann added a reviewer: vkrause. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY syntax-highlighting/src/lib/defi

D14499: Use in-class member initialization where possible

This revision was automatically updated to reflect the committed changes. Closed by commit R216:e7c7184209c5: Use in-class member initialization where possible (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14499?vs=38808&id

D14499: Use in-class member initialization where possible

dhaumann added a comment. Yes, only private classes were changed intentionally. Public classes don't have members anyways besides the d-pointer. And the d-pointer requires a non-trivial constructor/destructor. REPOSITORY R216 Syntax Highlighting BRANCH useMemberInit (branched from maste

D14270: CoffeeScript: fix templates in embedded JavaScript code & add escapes

nibags added a comment. Now I have access to commits... but apparently, you have to accept the latest revision to do so :( REPOSITORY R216 Syntax Highlighting BRANCH jsemb-coffeescript REVISION DETAIL https://phabricator.kde.org/D14270 To: nibags, dhaumann, cullmann, #framework_synta

D14360: Remove custom icon selection for trash

pino added a comment. In D14360#301497 , @cfeck wrote: > If it's not public, it doesn't need a `@since` tag. No idea, it was not me to suggest that. > Why isn't the header called *_p.h ...? No idea either. REPOSITORY R241 KIO

D11945: AppArmor: update syntax and various improvements/fixes

nibags retitled this revision from "Optimize AppArmor & SELinux highlighting and improve regex" to "AppArmor: update syntax and various improvements/fixes". nibags edited the summary of this revision. nibags added a reviewer: Framework: Syntax Highlighting. nibags changed the visibility from "No O

D14360: Remove custom icon selection for trash

cfeck added a comment. If it's not public, it doesn't need a `@since` tag. Why isn't the header called *_p.h ...? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14360 To: shubham, ngraham, broulik, #dolphin, #frameworks, pino Cc: cfeck, pino, kde-frameworks-devel,

D14520: Open `skipPager` functionality

zzag added a comment. Please checkout .arclint from master (git checkout master -- .arclint). INLINE COMMENTS > plasmashell_interface.h:192-194 > + > + > + Unrelated change. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14520 To: sharvey, #plasma_on_wayland, he

D14360: Remove custom icon selection for trash

shubham updated this revision to Diff 38868. shubham added a comment. revert back REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14360?vs=38852&id=38868 REVISION DETAIL https://phabricator.kde.org/D14360 AFFECTED FILES src/filewidgets/kfileplaceeditdialog

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 185 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/185/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Tue, 31 Jul 2018 17:55:34 + Build duration: 15 min and counting JUnit Tests Name: (root) Faile

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 338 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/338/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 31 Jul 2018 17:55:34 + Build duration: 6 min 39 sec and counting JUnit Tests Name: (roo

D14360: Remove custom icon selection for trash

pino added a comment. In D14360#301270 , @cfeck wrote: > I still would like to understand why it needs to be public API, instead of just an `@internal` method. This is not a public API, since `KFilePlaceEditDialog` is a private class whi

D14360: Remove custom icon selection for trash

pino requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14360 To: shubham, ngraham, broulik, #dolphin, #frameworks, pino Cc: cfeck, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14501: Top-align labels in properties dialog

rkflx added a comment. Just realized this actually fixes a problem present in KDE 3 already (KDE 2 did not have the second line yet, as far as I could tell in a short but very interesting test). In D14501#301044 , @cfeck wrote: > Bonus poin

D14501: Top-align labels in properties dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R241:9829d0ef9e74: Top-align labels in properties dialog (authored by rkflx). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14501?vs=38811&id=38865 REVISION DETAIL https

D14520: Open `skipPager` functionality

ngraham added reviewers: Plasma, romangg, davidedmundson. ngraham added a comment. I don't think you meant to check in a total deletion of the `arclint` file... REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14520 To: sharvey, #plasma_on_wayland, hein, #plasma, rom

D14520: Open `skipPager` functionality

sharvey added a comment. Okay, a clean copy. Apologies for the mess. I can do the coding, but the infrastructure is another story... REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14520 To: sharvey, #plasma_on_wayland, hein Cc: kde-frameworks-devel, ngraham, micha

D14520: Open `skipPager` functionality

sharvey updated this revision to Diff 38863. sharvey added a comment. - Remove wrongly committed files REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14520?vs=38862&id=38863 BRANCH arcpatch-D14516 REVISION DETAIL https://phabricator.kde.org/D14520 A

D14520: Open `skipPager` functionality

sharvey created this revision. sharvey added reviewers: Plasma on Wayland, hein. sharvey added a project: Frameworks. sharvey requested review of this revision. REVISION SUMMARY Open `skipPager` functionality, same as `skipTaskbar` REVIEWER NOTE: Several of the autotests are failing, although

D14516: Open `skipPager` functionality

sharvey abandoned this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14516 To: sharvey, hein, #plasma_on_wayland Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14516: Open `skipPager` functionality

sharvey added a comment. There's no functionality to remove files. I'll submit a new diff. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14516 To: sharvey, hein, #plasma_on_wayland Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14516: Open `skipPager` functionality

sharvey updated this revision to Diff 38859. sharvey added a comment. Remove untracked `.arclint` and `CMakeLists.txt.user` REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14516?vs=38854&id=38859 BRANCH add-skip-pager (branched from master) REVISION DET

D14516: Open `skipPager` functionality

sharvey added a comment. In D14516#301385 , @ngraham wrote: > Changes to `.arclint` look unintended, and I'm not sure you meant to check in `CMakeLists.txt.user`. The changes are intentional - my arc seems to be broken. It wasn't supposed

D14516: Open `skipPager` functionality

ngraham added a comment. Changes to `.arclint` look unintended, and I'm not sure you meant to check in `CMakeLists.txt.user`. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14516 To: sharvey, hein, #plasma_on_wayland Cc: ngraham, kde-frameworks-devel, michaelh, br

D14516: Open `skipPager` functionality

sharvey added a comment. Plasma team: Please help me review and fix the failing autotests. I'm not familiar enough with the internals of KWayland - or autotests - to successfully debug what's happening. The patch builds and compiles without error. Thanks for your help. REPOSITORY R127

D14516: Open `skipPager` functionality

sharvey added a reviewer: Plasma on Wayland. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14516 To: sharvey, hein, #plasma_on_wayland Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14516: Open `skipPager` functionality

sharvey created this revision. sharvey added a reviewer: hein. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. sharvey requested review of this revision. REVISION SUMMARY Open `skipPager` functionality, same as `skipTaskbar`

D14397: Support libcanberra for audio notification

rjvbb added a comment. > I really don't see what the big fuss is all about. Did you read Harald's remark (about raising a neon fuss) to which I replied?! REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D14397 To: broulik, #frameworks, dfaure, davidedmundso

D14360: Remove custom icon selection for trash

shubham updated this revision to Diff 38852. shubham added a comment. Remove helper function isIconEditable() (wasn't required), the check can directly be carried out in if clause for dialog->m_iconButton REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14360?vs

D14397: Support libcanberra for audio notification

apol added a comment. :( please @broulik INLINE COMMENTS > rjvbb wrote in CMakeLists.txt:77 > Preferred choice on Linux and other non-Mac Unix variants (or even only Linux > because as mentioned earlier, libcanberra is only tested there). It can't be > the preferred choice when no native ba

D14397: Support libcanberra for audio notification

rjvbb added inline comments. INLINE COMMENTS > sitter wrote in CMakeLists.txt:77 > I'd prefer if this was moved up, before finding Phonon, and then find phonon > in the else branch of CANBERRA_FOUND. > > The rationale is that (e.g.) all of neon's tech which auto detects missing > cmake depende

D14360: Remove custom icon selection for trash

ngraham added a comment. Yep, I agree. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14360 To: shubham, ngraham, broulik, #dolphin, #frameworks, pino Cc: cfeck, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14397: Support libcanberra for audio notification

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Well, I still think the result handling is more complicated than it needs to be, but whatever. LGTM for landing after 5.49 tagging (expected August 4th IIRC). https://cgit.kde.org/plas

D14397: Support libcanberra for audio notification

broulik updated this revision to Diff 38843. broulik added a comment. - Require Phonon so that a sound system is preferred (it is only searched for if Canberra isn't) REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14397?vs=38842&id=38843 REVISION D

D14360: Remove custom icon selection for trash

shubham added a comment. @cfeck agree with you(it's just a helper) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14360 To: shubham, ngraham, broulik, #dolphin, #frameworks, pino Cc: cfeck, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14397: Support libcanberra for audio notification

broulik updated this revision to Diff 38842. broulik added a comment. MOAAAR error handling REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14397?vs=38841&id=38842 REVISION DETAIL https://phabricator.kde.org/D14397 AFFECTED FILES CMakeLists.txt

D14360: Remove custom icon selection for trash

cfeck added a comment. I still would like to understand why it needs to be public API, instead of just an '@internal' method. If I understand it correctly, the API isn't needed by any application, but only be the dialog itself. Also, if we decide to implement choosing both icons, or have a n

D14397: Support libcanberra for audio notification

broulik updated this revision to Diff 38841. broulik added a comment. - More error handling REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14397?vs=38512&id=38841 REVISION DETAIL https://phabricator.kde.org/D14397 AFFECTED FILES CMakeLists.txt

D14397: Support libcanberra for audio notification

sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. Code looks mostly ok. As discussed on IRC my main concern is that the current code ignores the return values of just about every ca_* method. This is a bit problematic from a diag

D14360: Remove custom icon selection for trash

ngraham added a comment. Space is cheap. :) Verbosity is no problem as long as it communicates important information. How about this: * @returns whether the item's icon is editable, as some icons are not (e.g. the Trash has the capability to display two icons, representing full and emp

D14360: Remove custom icon selection for trash

shubham added a comment. In D14360#301252 , @ngraham wrote: > Almost there! Please implement cfeck's suggestion for additional documentation for this function in the header file, in particular describing why come icons might not be editable.

D14397: Support libcanberra for audio notification

rjvbb added a comment. I have no other objections than the ones above, as long as there's a fallback to NOT using libcanberra which can be enforced without having to patch the code (= via `CMAKE_DISABLE_FIND_PACKAGE_FOO` or a dedicated option). REPOSITORY R289 KNotifications REVISION DETA

D14360: Remove custom icon selection for trash

ngraham added a comment. Almost there! Please implement cfeck's suggestion for additional documentation for this function in the header file, in particular describing why come icons might not be editable. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14360 To: shubha

D14397: Support libcanberra for audio notification

broulik reclaimed this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D14397 To: broulik, #frameworks, dfaure, davidedmundson, sitter, drosca, kfunk, rjvbb Cc: cfeck, alexeymin, ngraham, nicolasfella, kde-frameworks-devel, michaelh, bruns

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

tundracomp added a comment. The target application I'm building has only very minimal dependencies on Qt (just QtCore + QtWidgets + PyQt5) and no real dependencies on KDE. The application only has a size footprint of about 6MiB, the required Qt libraries use about 10MiB of space, the selecte

D14397: Support libcanberra for audio notification

cfeck added a comment. +1 for supporting libcanberra. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D14397 To: broulik, #frameworks, dfaure, davidedmundson, sitter, drosca, kfunk, rjvbb Cc: cfeck, alexeymin, ngraham, nicolasfella, kde-frameworks-devel, michae

D14397: Support libcanberra for audio notification

ngraham added a comment. +1 too; we can always work on upstream Qt improvements later. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D14397 To: broulik, #frameworks, dfaure, davidedmundson, sitter, drosca, kfunk, rjvbb Cc: alexeymin, ngraham, nicolasfella, kd

D14397: Support libcanberra for audio notification

nicolasfella added a comment. +1 for Canberra REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D14397 To: broulik, #frameworks, dfaure, davidedmundson, sitter, drosca, kfunk, rjvbb Cc: alexeymin, ngraham, nicolasfella, kde-frameworks-devel, michaelh, bruns

D14397: Support libcanberra for audio notification

broulik added a comment. So, what shall we do with this? Either we take it or leve it, I won't be the one changing it to QtMultimedia as canberra is *the* way to go. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D14397 To: broulik, #frameworks, dfaure, david

D14435: Fix KTimeComboBox input mask for AM/PM times

mlaurent requested changes to this revision. mlaurent added a comment. This revision now requires changes to proceed. For me it's ok after using QVERIFY... INLINE COMMENTS > ktimecomboboxtest.cpp:198 > +QString mask = m_combo->lineEdit()->inputMask(); > +QCOMPARE(mask.contains(QLatin

D14508: Fix the catalog handling and locale detection on Android

ckertesz closed this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D14508 To: ckertesz, apol, ilic, #frameworks, vkrause Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14162: Figure out the escaped path list on kconfig

anthonyfieroni added inline comments. INLINE COMMENTS > kconfiggroup.cpp:176 > +last = p + 1; > +} else if (data[p] == QLatin1Char('\\')) { > +escapedLast = true; It should be p < data.size() && data[p] == '\\' or you will access not owned memory. Better is to

D14508: Fix the catalog handling and locale detection on Android

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D14508 To: ckertesz, apol, ilic, #frameworks, vkrause Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14162: Figure out the escaped path list on kconfig

apol added a comment. ping? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D14162 To: apol, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14508: Fix the catalog handling and locale detection on Android

apol added a comment. +1 the patch looks good to me, I already implemented half this patch in D14503 which I abandoned in favor of this one. Thanks a lot @ckertesz! REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D14508 To: ck

D14503: Android: also fall-back to using QLocale

apol abandoned this revision. apol added a comment. D14503 is doing the same but more complete REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D14503 To: apol, #frameworks, ilic, aacid, vkrause Cc: kde-frameworks-devel, michaelh, ng

D14508: Fix the catalog handling and locale detection on Android

apol added reviewers: ilic, Frameworks. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D14508 To: ckertesz, apol, ilic, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14508: Fix the catalog handling and locale detection on Android

ckertesz created this revision. ckertesz added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ckertesz requested review of this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D

D14503: Android: also fall-back to using QLocale

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D14503 To: apol, #frameworks, ilic, aacid, vkrause Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14499: Use in-class member initialization where possible

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Moving a default ctor/dtor definition to the header would break ABI for exported classes, but this seems to only touch non-exported ones, so this should be fine. REPOSITORY R216 Syntax