anthonyfieroni updated this revision to Diff 38153.
anthonyfieroni added a comment.
First tests looks good, i'll make more later
REPOSITORY
R245 Solid
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13869?vs=37129&id=38153
REVISION DETAIL
https://phabricator.kde.org/D13869
AFFE
anthonyfieroni added a comment.
It's deleted in
https://phabricator.kde.org/source/kio/browse/master/src/core/slaveinterface_p.h$47
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14253
To: jtamate, dfaure, #frameworks, ngraham
Cc: anthonyfieroni, apol, kde-frameworks-d
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/61/
Project:
Frameworks purpose kf5-qt5 SUSEQt5.9
Date of build:
Sat, 21 Jul 2018 03:33:51 +
Build duration:
2 min 0 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/84/
Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
Date of build:
Sat, 21 Jul 2018 03:33:51 +
Build duration:
2 min 9 sec and counting
JUnit Tests
Name
apol added inline comments.
INLINE COMMENTS
> slave.cpp:148
> delete slaveconnserver;
> +delete connection;
> }
Good catch, maybe it should be a QScopedPointer?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14253
To: jtamate, dfaure, #frameworks, n
apol added a subscriber: andreask.
apol added a comment.
Can someone from the breeze team confirm the issue? If so I'll help find a
solution.
@andreask?
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D14218
To: apol, andreaska, mart, vkrause, #framework_sy
mpyne added a comment.
The patch looks OK but I'm a bit worried about trying to lock the cache at
the same time we're potentially trying to delete a KSharedDataCache so I'm
going to recompile and do some stress and sanity tests first.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://
aacid added a comment.
If the increased image memory is payed only when the dialog is shown i don't
see it as a problem tbh.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D14237
To: ngraham, broulik, cfeck, #frameworks
Cc: aacid, bruns, kde-frameworks-devel, michae
jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks, ngraham.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.
REVISION SUMMARY
Delete the connection that has bee
bruns added a comment.
Try zopflipng ...
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D14237
To: ngraham, broulik, cfeck, #frameworks
Cc: bruns, kde-frameworks-devel, michaelh, ngraham
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:9dd578b12d40: Improve API docs a bit (authored by
gladhorn).
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14240?vs=38116&id=38145
REVISION DETAIL
https://
apol added a comment.
ping
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D14162
To: apol, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/327/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Fri, 20 Jul 2018 14:47:33 +
Build duration:
14 min and counting
JUnit Tests
Name: (root) Fai
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/174/
Project:
Frameworks kio kf5-qt5 SUSEQt5.9
Date of build:
Fri, 20 Jul 2018 14:47:33 +
Build duration:
5 min 40 sec and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/84/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
Date of build:
Fri, 20 Jul 2018 14:47:33 +
Build duration:
4 min 0 sec and counting
JUnit Tests
Name:
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:d6a17455092a: Slightly faster UDS constructor (authored
by jtamate).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14231?vs=38089&id=38140
REVISION DETAIL
https://p
jtamate updated this revision to Diff 38134.
jtamate marked 6 inline comments as done.
jtamate edited the summary of this revision.
jtamate added a comment.
Hopefully done all the requested changes.
Passed uncristify-kf5.
Removed the classes for simulating the filtering.
Added benchmarks
apol accepted this revision.
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D14240
To: gladhorn, #plasma, dhaumann, apol
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Definitely an improvement, lgtm.
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D14240
To: gladhorn, #plasma, dhaumann
Cc: dhaumann, kde-
mart updated this revision to Diff 38123.
mart added a comment.
- Revert "rename the virtual desktop to Unstable"
- Merge branch 'master' into mart/plasmavirtualdesktop
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12820?vs=38122&id=38123
BRANCH
mart
mart updated this revision to Diff 38122.
mart added a comment.
rever rename
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12820?vs=38017&id=38122
BRANCH
mart/plasmavirtualdesktop
REVISION DETAIL
https://phabricator.kde.org/D12820
AFFECTED FILES
gladhorn created this revision.
gladhorn added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
gladhorn requested review of this revision.
REVISION SUMMARY
Some typos and make some sentences easier to read
22 matches
Mail list logo
