D13899: KMessageWidget: use theme instead of hardcoded colours

ngraham added a comment. This patch works as advertised, and does not imposes any visual regressions when using the Breeze color scheme. And yet, when trying it out with non-default color schemes, I can't help but wonder what we're actually accomplishing here. While the Positive color me

D12233: Avoid manipulation of lists with quadratic complexity

This revision was automatically updated to reflect the committed changes. Closed by commit R293:39944a5e4fa4: Avoid manipulation of lists with quadratic complexity (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12233?vs=35068&id=37835 REVIS

D12233: Avoid manipulation of lists with quadratic complexity

bruns added a comment. Sorry for the noise - apparently, if one requests changes, adopt the revision, does the changes, the "Changes requested" flag is not cleared and can not be cleared ... REPOSITORY R293 Baloo BRANCH arcpatch-D12233 REVISION DETAIL https://phabricator.kde.org/D122

D12233: Avoid manipulation of lists with quadratic complexity

bruns edited reviewers, added: Baloo; removed: michaelh. REPOSITORY R293 Baloo BRANCH arcpatch-D12233 REVISION DETAIL https://phabricator.kde.org/D12233 To: bruns, mgallien, mpyne, #frameworks, #baloo Cc: #baloo, mpyne, dhaumann, ngraham, kde-frameworks-devel, jtamate, bruns, ashaposhnik

D12233: Avoid manipulation of lists with quadratic complexity

bruns removed a reviewer: Baloo. This revision is now accepted and ready to land. Restricted Application added a subscriber: Baloo. REPOSITORY R293 Baloo BRANCH arcpatch-D12233 REVISION DETAIL https://phabricator.kde.org/D12233 To: bruns, michaelh, mgallien, mpyne, #frameworks Cc: #baloo,

D12233: Avoid manipulation of lists with quadratic complexity

bruns marked 4 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233 To: bruns, #baloo, michaelh, mgallien, mpyne, #frameworks Cc: mpyne, dhaumann, ngraham, kde-frameworks-devel, jtamate, bruns, ashaposhnikov, michaelh, astippich, spoorun, abraham

D12233: Avoid manipulation of lists with quadratic complexity

bruns marked an inline comment as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233 To: bruns, #baloo, michaelh, mgallien, mpyne, #frameworks Cc: mpyne, dhaumann, ngraham, kde-frameworks-devel, jtamate, bruns, ashaposhnikov, michaelh, astippich, spoorun, abraham

D12233: Avoid manipulation of lists with quadratic complexity

bruns added a reviewer: Frameworks. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233 To: bruns, #baloo, michaelh, mgallien, mpyne, #frameworks Cc: mpyne, dhaumann, ngraham, kde-frameworks-devel, jtamate, bruns, ashaposhnikov, michaelh, astippich, spoorun, abrahams

D14122: KFormat: Replace unicode literal with unicode codepoint to fix MSVC build

dhaumann added inline comments. INLINE COMMENTS > kformatprivate.cpp:121 > { KFormat::UnitPrefix::Nano, 1e-9, bpow(-30), u'n' }, > -{ KFormat::UnitPrefix::Micro, 1e-6, bpow(-20), u'µ' }, > +// Thanks to broken MSVC, we can not use u'µ', but have to use the > unicode c

KDE CI: Frameworks ki18n kf5-qt5 AndroidQt5.11 - Build # 10 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20AndroidQt5.11/10/ Project: Frameworks ki18n kf5-qt5 AndroidQt5.11 Date of build: Sun, 15 Jul 2018 18:13:30 + Build duration: 2 min 23 sec and counting CONSOLE OUTPUT

D12233: Avoid manipulation of lists with quadratic complexity

mpyne accepted this revision. mpyne added a comment. I don't use Baloo directly but I've taken a look from a code sanity perspective and agree with @dhaumann that the change is a proper port of the existing logic. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233

D12271: Don't remove trailing whitespace from cursor line

cullmann commandeered this revision. cullmann edited reviewers, added: sraizada; removed: cullmann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12271 To: cullmann, #ktexteditor, dhaumann, sraizada Cc: cullmann, kwrite-devel, kde-frameworks-devel, dhaumann, anthony

D12271: Don't remove trailing whitespace from cursor line

cullmann abandoned this revision. cullmann added a comment. > as said, we don't want that behavior change, sorry for that. == REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12271 To: cullmann, #ktexted

D14137: CSS: update syntax and fix some errors

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks like a nice update - thanks for your work. Can you 'arc land' yourself? :-) REPOSITORY R216 Syntax Highlighting BRANCH css REVISION DETAIL https://phabricator.kde.org/D141

KDE CI: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10 - Build # 42 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.10/42/ Project: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10 Date of build: Sun, 15 Jul 2018 16:22:40 + Build duration: 8 min 23 sec and counting

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 96 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/96/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Sun, 15 Jul 2018 16:22:40 + Build duration: 6 min 14 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/41/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Sun, 15 Jul 2018 16:22:40 + Build duration: 3 min 35 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/19/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 15 Jul 2018 16:22:40 + Build duration: 3 min 59 sec and counting JUnit T

D14122: KFormat: Replace unicode literal with unicode codepoint to fix MSVC build

This revision was automatically updated to reflect the committed changes. Closed by commit R244:5c3f5eade4cc: KFormat: Replace unicode literal with unicode codepoint to fix MSVC build (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14122?vs=37776&id=37819#toc REPOSITO

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/40/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Sun, 15 Jul 2018 16:12:45 + Build duration: 6 min 58 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/18/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 15 Jul 2018 16:12:57 + Build duration: 5 min 41 sec and counting JUnit T

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 95 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/95/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Sun, 15 Jul 2018 16:12:28 + Build duration: 3 min 18 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/39/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Sun, 15 Jul 2018 16:09:10 + Build duration: 3 min 33 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10 - Build # 41 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.10/41/ Project: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10 Date of build: Sun, 15 Jul 2018 16:10:55 + Build duration: 1 min 40 sec and counting

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/17/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 15 Jul 2018 16:09:10 + Build duration: 3 min 44 sec and counting JUnit T

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 94 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/94/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Sun, 15 Jul 2018 16:09:10 + Build duration: 3 min 16 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10 - Build # 40 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.10/40/ Project: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10 Date of build: Sun, 15 Jul 2018 16:09:10 + Build duration: 1 min 1 sec and counting C

D14121: KFormat: Add unit tests for mili/micro SI prefixes

This revision was automatically updated to reflect the committed changes. bruns marked an inline comment as done. Closed by commit R244:b95bfd7e47a3: KFormat: Add unit tests for mili/micro SI prefixes (authored by bruns). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabrica

D14135: KFormat: fix typo in SI prefix name enum

This revision was automatically updated to reflect the committed changes. Closed by commit R244:2300c57fcd75: KFormat: fix typo in SI prefix name enum (authored by bruns). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14135?vs=37807&id=37816 REVISION DET

D14135: KFormat: fix typo in SI prefix name enum

pino accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH prefix_typo REVISION DETAIL https://phabricator.kde.org/D14135 To: bruns, #frameworks, astippich, pino Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14137: CSS: update syntax and fix some errors

jpoelen created this revision. jpoelen added a reviewer: dhaumann. jpoelen added projects: Frameworks, Framework: Syntax Highlighting. Restricted Application added a project: Kate. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. jpoelen re

D14121: KFormat: Add unit tests for mili/micro SI prefixes

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > astippich wrote in kformattest.cpp:118 > typo: KFormat::UnitPrefix::Mil_l_i . Should be safe to change it since it > hasn't been released in its current state, isn't it? see D14135

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bruns added a comment. In D13583#292480 , @siddharthasahu wrote: > Hi. This commit seems to have introduced a build failure when the optional component PythonModuleGeneration is enabled: https://paste.kde.org/pvh0kutbq/5jo1sl Apparently

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bruns added a dependent revision: D14135: KFormat: fix typo in SI prefix name enum. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13583 To: bruns, #frameworks, astippich Cc: siddharthasahu, bcooksley, kossebau, kde-frameworks-devel, astippich, michaelh, ngraham,

D14135: KFormat: fix typo in SI prefix name enum

bruns added a dependency: D13583: KFormat: Allow usage of quantities beyond bytes and seconds. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14135 To: bruns, #frameworks, astippich Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

siddharthasahu added a comment. Hi. This commit seems to have introduced a build failure when the optional component PythonModuleGeneration is enabled: https://paste.kde.org/pvh0kutbq/5jo1sl On a related note, the CI does not have that component enables, which means it is not getting te

D14121: KFormat: Add unit tests for mili/micro SI prefixes

bruns edited dependencies, added: D14135: KFormat: fix typo in SI prefix name enum; removed: D13583: KFormat: Allow usage of quantities beyond bytes and seconds. REPOSITORY R244 KCoreAddons BRANCH test1 REVISION DETAIL https://phabricator.kde.org/D14121 To: bruns, #frameworks, kossebau,

D14135: KFormat: fix typo in SI prefix name enum

bruns added a dependent revision: D14121: KFormat: Add unit tests for mili/micro SI prefixes. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14135 To: bruns, #frameworks, astippich Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14134: KFormat: fix typo in SI prefix name enum

bruns abandoned this revision. bruns added a comment. duplicate REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14134 To: bruns, #frameworks, astippich, pino Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bruns removed a dependent revision: D14121: KFormat: Add unit tests for mili/micro SI prefixes. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13583 To: bruns, #frameworks, astippich Cc: bcooksley, kossebau, kde-frameworks-devel, astippich, michaelh, ngraham, brun

D14121: KFormat: Add unit tests for mili/micro SI prefixes

bruns updated this revision to Diff 37808. bruns added a comment. update after typo fix REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14121?vs=37775&id=37808 BRANCH test1 REVISION DETAIL https://phabricator.kde.org/D14121 AFFECTED FILES autote

D14134: KFormat: fix typo in SI prefix name enum

bruns requested review of this revision. bruns added a comment. duplicate REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14134 To: bruns, #frameworks, astippich, pino Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14135: KFormat: fix typo in SI prefix name enum

bruns updated this revision to Diff 37807. bruns added a comment. Complete the fix REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14135?vs=37806&id=37807 BRANCH prefix_typo REVISION DETAIL https://phabricator.kde.org/D14135 AFFECTED FILES src/l

D14135: KFormat: fix typo in SI prefix name enum

pino added a comment. Duplicate of D14134: KFormat: fix typo in SI prefix name enum ? If so, please abandon this. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14135 To: bruns, #frameworks, astippich Cc: pino, kde-frameworks

D14134: KFormat: fix typo in SI prefix name enum

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. It must be fixed in `src/lib/util/kformatprivate.cpp` too. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14134 To: bruns, #frameworks, astippich, pino

D14135: KFormat: fix typo in SI prefix name enum

bruns created this revision. bruns added reviewers: Frameworks, astippich. bruns added a project: Frameworks. bruns requested review of this revision. REVISION SUMMARY Its milli, not mili. Change the enum name without any backwards compatibility, as the name is not yet in any release. REPOSIT

D14134: KFormat: fix typo in SI prefix name enum

bruns created this revision. bruns added reviewers: Frameworks, astippich. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Its milli, not mili. Change the enum name with

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

kossebau added a comment. In D13583#292115 , @bcooksley wrote: > You can add #windows to a review, however there still needs to be a degree of responsibility by those who are actually making commits to

KDE CI: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.10 - Build # 12 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.10/12/ Project: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 15 Jul 2018 12:07:40 + Build duration: 1 min 6 sec and counting JUnit T

D14131: Add enum alias Property::Language for typo Property::Langauge

kossebau created this revision. kossebau added a reviewer: mgallien. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. kossebau requested review of this revision. TEST PLAN Unit tests still pass, Dolphin still shows t

KDE CI: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.10 - Build # 11 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.10/11/ Project: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 15 Jul 2018 11:52:35 + Build duration: 5 min 59 sec and counting JUnit

KDE CI: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.10 - Build # 10 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.10/10/ Project: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 15 Jul 2018 11:44:00 + Build duration: 1 min 6 sec and counting JUnit T

D14121: KFormat: Add unit tests for mili/micro SI prefixes

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. test itself is fine, but I spotted a typo. INLINE COMMENTS > kformattest.cpp:118 > + > +QCOMPARE(format.formatValue(0.010, KFormat::Unit::Meter, 1, > KFormat::UnitPrefix::Mili, K

D14124: Fix qtplugins in KStandardDirs

This revision was automatically updated to reflect the committed changes. Closed by commit R239:3ab2e2f5592d: Fix qtplugins in KStandardDirs (authored by arojas). REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14124?vs=37785&id=37794 REVISION DETAIL

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.9/27/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 Date of build: Sun, 15 Jul 2018 09:41:59 + Build duration: 19 min and counting JUnit Tests

how to get the list of keywords in KSyntaxHighlighting

Hi, I'd like to remove the maintenance of syntax keywords in Cantor (e.g. https:// cgit.kde.org/cantor.git/tree/src/backends/maxima/maximakeywords.cpp) and to switch to KSyntaxHighlighting. Cantor uses its own highlighters and I'd need to get the list of keywords from KSyntaxHighlighter for thi

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.10/13/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 15 Jul 2018 09:41:59 + Build duration: 5 min 25 sec and counting

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/53/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Sun, 15 Jul 2018 09:41:59 + Build duration: 3 min 47 sec and counting JUnit

D14124: Fix qtplugins in KStandardDirs

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Interestingly it works for me with and without this patch, because of "%lib/plugins/" later on in the code, but indeed at that point installdir is /d/kde/inst/kde_frameworks/lib64/plugins/p

D14124: Fix qtplugins in KStandardDirs

arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY PLUGIN_INSTALL_DIR already contains the /plugins/ suffix,