D13813: make this test work again with new uds implementation

jtamate updated this revision to Diff 36976. jtamate edited the summary of this revision. jtamate added a comment. Use 3 entries instead of replace(). Now it will work with any kio version. REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13813?vs=36975&id=

D13813: make this test work again with new uds implementation

jtamate updated this revision to Diff 36975. jtamate added a comment. Updated the patch with context. It will not work with kio previous to 5.47, unless there is a way to check the kio version at compile time or runtime. REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phab

KDE CI: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.10 - Build # 105 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.10/105/ Project: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.10 Date of build: Sun, 01 Jul 2018 04:15:24 + Build duration: 19 min and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.9 - Build # 102 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.9/102/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.9 Date of build: Sun, 01 Jul 2018 03:39:28 + Build duration: 9 min 8 sec and counting CONSOL

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/31/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 01 Jul 2018 03:39:28 + Build duration: 4 min 29 sec and counting

D13805: Present error dialog when user tries to create directory named "." or ".."

cfeck added a comment. I think the comment can be omitted. It doesn't add information to the code. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13805 To: tmarshall, #dolphin, #frameworks, ngraham, dfaure Cc: cfeck, elvisangelaccio, dfaure, tmarshall, bruns, ngraham,

D13808: Fix KMainWindow saving incorrect widget settings

maxrd2 added a comment. Unit test is there... and it passes... always... with or without the kmainwindow.cpp patch :-/ Is there some simpler way to initialize/kill QApplication for each mainwindow creation/deletion, other than adding new test that uses QTEST_APPLESS_MAIN instead of QTEST_M

D13808: Fix KMainWindow saving incorrect widget settings

maxrd2 updated this revision to Diff 36973. maxrd2 added a comment. Added unit test REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13808?vs=36938&id=36973 BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808 AFFECTED FILES

D13813: make this test work again with new uds implementation

bruns added a comment. @jtamate , can you please use arc diff to upload patches - arc sucks, but having no patch context sucks even more ... REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13813 To: jtamate, #dolphin, #frameworks Cc: bruns, elvisangelaccio, kfm-deve

D13805: Present error dialog when user tries to create directory named "." or ".."

tmarshall added a comment. @elvisangelaccio The check has to come before the check for `name.startsWith('.')` because that's what launches the "The name starts with a ." dialog. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13805 To: tmarshall, #dolphin, #frameworks

D13808: Fix KMainWindow saving incorrect widget settings

maxrd2 added a comment. The change in qt affects when the window close event is handled in queue, it didn't change when it is fired. With qt 5.11.1 child widgets get destroyed a bit sooner, but it's still gets triggered by same close event - i think that stayed like it always was. Also KMa

D13805: Present error dialog when user tries to create directory named "." or ".."

elvisangelaccio added subscribers: dfaure, elvisangelaccio. elvisangelaccio added a comment. Hmm, shouldn't this check be at the kio_file level @dfaure ? If we put it here, it will still fail when you try to create a folder name "." **not** by using the knewfilemenu in dolphin. REPOSITORY

D13805: Present error dialog when user tries to create directory named "." or ".."

elvisangelaccio added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13805 To: tmarshall, #dolphin, #frameworks, ngraham, dfaure Cc: elvisangelaccio, dfaure, tmarshall, bruns, ngraham, kde-frameworks-devel, michaelh, spoorun, navarromorales, isidorov, f

D13813: make this test work again with new uds implementation

elvisangelaccio added a comment. Will it still work if we link against an old kio version? REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13813 To: jtamate, #dolphin, #frameworks Cc: elvisangelaccio, kfm-devel, spoorun, navarromorales, isidorov, firef, andrebarros,

D13805: Present error dialog when user tries to create directory named "." or ".."

tmarshall added a comment. How am I to provide my name and email? Just in a comment? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13805 To: tmarshall, #dolphin, #frameworks, ngraham Cc: tmarshall, bruns, ngraham, kde-frameworks-devel, michaelh, spoorun, navarromorale

D13798: Port remaining uses of qDebug() to qcDebug(ATTICA)

This revision was automatically updated to reflect the committed changes. Closed by commit R235:892865d441b4: Port remaining uses of qDebug() to qcDebug(ATTICA) (authored by habacker). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13798?vs=36898&id=36967 REVI

D13816: Make KItinerary work as a static library

vkrause added a reviewer: Frameworks. REPOSITORY R1003 KItinerary: Travel Reservation handling library REVISION DETAIL https://phabricator.kde.org/D13816 To: vkrause, #frameworks Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil

D13808: Fix KMainWindow saving incorrect widget settings

wbauer added a comment. I just like to note that VirtualBox has the same problem with Qt 5.11.1, that the toolbar and the status bar disappear on next start if you close the window: http://bugzilla.opensuse.org/show_bug.cgi?id=1099589 So it does not only affect applications using KMainWind

D13808: Fix KMainWindow saving incorrect widget settings

aacid added a comment. Can we get an auto test? REPOSITORY R263 KXmlGui BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808 To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck Cc: aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D13805: Present error dialog when user tries to create directory named "." or ".."

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice, I think this is looking great. +1 on the latest wording. A lovely first patch! To land it for you, we'll need your full name and email address, so it would be great if you coul

D13814: Speedup sort

jtamate added a dependency: D13813: make this test work again with new uds implementation. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13814 To: jtamate, #dolphin, #frameworks Cc: kfm-devel, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp

D13813: make this test work again with new uds implementation

jtamate added a dependent revision: D13814: Speedup sort. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13813 To: jtamate, #dolphin, #frameworks Cc: kfm-devel, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp

D13814: Speedup sort

jtamate created this revision. jtamate added reviewers: Dolphin, Frameworks. Restricted Application added a project: Dolphin. Restricted Application added a subscriber: kfm-devel. jtamate requested review of this revision. REVISION SUMMARY Use a lambda function instead of a class. This way the

D13813: make this test work again with new uds implementation

jtamate created this revision. jtamate added reviewers: Dolphin, Frameworks. Restricted Application added a project: Dolphin. Restricted Application added a subscriber: kfm-devel. jtamate requested review of this revision. REVISION SUMMARY With the new uds implementation, when some data is meant

D13798: Port remaining uses of qDebug() to qcDebug(ATTICA)

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R235 Attica BRANCH master REVISION DETAIL https://phabricator.kde.org/D13798 To: habacker, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13805: Present error dialog when user tries to create directory named "." or ".."

tmarshall marked an inline comment as done. tmarshall added inline comments. INLINE COMMENTS > bruns wrote in knewfilemenu.cpp:873 > Should be QMessageBox::Error in this case I get `newfilemenu.cpp:873:74: error: ‘Error’ is not a member of ‘QMessageBox’` `QMessageBox::Critical` seems to work th

D13805: Present error dialog when user tries to create directory named "." or ".."

tmarshall updated this revision to Diff 36954. tmarshall marked 2 inline comments as done. tmarshall added a comment. Changed `QMessageBox::Warning` to `QMessageBox::Critical` and updated the error message. New: F5981803: image.png REPOSITORY

D13805: Present error dialog when user tries to create directory named "." or ".."

bruns added inline comments. INLINE COMMENTS > ngraham wrote in knewfilemenu.cpp:874 > This message might be a little bit too terse. How about something that helps > explain the reason as well, like this? > > > "" has a special meaning for the operating system and cannot be used > > as the nam

D13805: Present error dialog when user tries to create directory named "." or ".."

bruns added inline comments. INLINE COMMENTS > knewfilemenu.cpp:873 > + > +KMessageBox::createKMessageBox(confirmDialog, buttonBox, > QMessageBox::Warning, > + i18n("Cannot create directory with name > \"%1\"", name), Should be

D13805: Present error dialog when user tries to create directory named "." or ".."

tmarshall updated this revision to Diff 36952. tmarshall added a comment. Fixed a type in the comment and improved the wording of the error message. New: F5981755: image.png REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.

D13805: Present error dialog when user tries to create directory named "." or ".."

ngraham added a reviewer: Frameworks. ngraham added inline comments. INLINE COMMENTS > knewfilemenu.cpp:859 > } else { > +// Test to see if the user has give "." or ".." as a name > +if (name == "." || name == "..") { has give -> has given > knewfilemenu.cpp:874

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

ngraham added a comment. What you say theoretically makes sense, but try it out: the document appears in the Recent Documents menu for both Kate and KWrite, while multi-app aggregator UIs continue to not accumulate duplicates. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.

D13812: Revert "updated Japanese holidays (in Japanese and English)"

phanect added a comment. I found Equinox days culculated by kholidays may be wrong. For example, kholidays says March 22th is Vernal Equinox Day in 2018, but actual Japanese Vernal Equinox Day is March 21th in 2018. I think Equinox Days should be kept. I also want to know how to hi

D13812: Revert "updated Japanese holidays (in Japanese and English)"

phanect added a comment. Fixed. Please review. I know equinox days can be automatically calculated, but in this review request I just revert the commit. REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.org/D13812 To: phanect, #kde_pim, #frameworks, winterz, ml

D13812: Revert "updated Japanese holidays (in Japanese and English)"

phanect updated this revision to Diff 36951. phanect added a comment. Revert "updated Japanese holidays (in Japanese and English)" This reverts commit 49f6abb6035f97c0a98113e3aedf5d2db135bf63 . This c

D13808: Fix KMainWindow saving incorrect widget settings

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Hard to tell if the qt behavior change is a bug or a feature, but the fix makes sense to me. (BTW I've been experiencing this regression in zanshin) REPOSITORY R263 KXmlGui BRANCH

D13812: Revert "updated Japanese holidays (in Japanese and English)"

phanect added a comment. Sorry, something wrong. In this commit only two files should be edited (holiday_jp_en-us and holiday_jp_ja) but tons of files is edited actually. I will fix it. REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.org/D13812 To: phanect, #k

D13812: Revert "updated Japanese holidays (in Japanese and English)"

phanect edited the summary of this revision. REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.org/D13812 To: phanect, #kde_pim, #frameworks, winterz, mlaurent Cc: mlaurent, winterz, kde-pim, dvasin, rodsevich, vkrause, knauss, dvratil

D13812: Revert "updated Japanese holidays (in Japanese and English)"

phanect retitled this revision from "GIT_SILENT: prepare 5.5.1" to "Revert "updated Japanese holidays (in Japanese and English)"". phanect edited the summary of this revision. REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.org/D13812 To: phanect, #kde_pim, #framework

D13812: GIT_SILENT: prepare 5.5.1

phanect created this revision. phanect added reviewers: KDE PIM, Frameworks, winterz, mlaurent. phanect added a project: KDE PIM. Restricted Application added a subscriber: kde-pim. phanect requested review of this revision. REVISION SUMMARY Revert "updated Japanese holidays (in Japanese and Eng

D13808: Fix KMainWindow saving incorrect widget settings

ngraham added reviewers: KDE Applications, dfaure, elvisangelaccio, broulik, cfeck. ngraham added a comment. The bug report indicates that this patch is for adapting to a change in Qt 5.11. Is this patch fully backwards-compatible with older Qt versions? If so, we'll need to guard this behin

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

ngraham added a comment. Thanks for your continued work on this. I continue to believe that in order to move forward, it needs to be broken up into separate atomic commits: - One to add a color parsing function to `KWidgetsAddons` so other local clients can use it - Another to adopt th

D11828: Simplify orPostingIterator and make it faster

bruns updated this revision to Diff 36944. bruns added a comment. remove extra parentheses REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11828?vs=31623&id=36944 BRANCH speedup_orpostingoperator REVISION DETAIL https://phabricator.kde.org/D11828 AFFECT

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

rjvbb marked 8 inline comments as done. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13777 To: rjvbb, ngraham, #frameworks Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

rjvbb updated this revision to Diff 36943. rjvbb added a comment. Turns out it's trivial to check if and what custom theme was activated through the KColorSchemeManager. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13777?vs=36939&id=36943 REVISION DETAIL https://phabricator.kde

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

rjvbb set the repository for this revision to R236 KWidgetsAddons. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13777 To: rjvbb, ngraham, #frameworks Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

rjvbb added a comment. A few examples showing the subtle effect of brightness matching, comparing to the Breeze theme (the brightness reference): Oxygen: F5979829: breeze-vs-oxygen-vs-oxygen-matched.png Obsidian Coast F5979830: breeze-vs-ob

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

rjvbb set the repository for this revision to R236 KWidgetsAddons. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13777 To: rjvbb, ngraham, #frameworks Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

rjvbb updated this revision to Diff 36939. rjvbb added a comment. Using the theme's normal foreground colour for message text for more reliable readability with darker themes. Brightness matching to the fallback colour should never occur here, at least not when the palette text colour is

D13808: Fix KMainWindow saving incorrect widget settings

maxrd2 added a comment. Relative bug is here https://bugs.kde.org/show_bug.cgi?id=395988 REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D13808 To: maxrd2 Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13808: Fix KMainWindow saving incorrect widget settings

maxrd2 updated this revision to Diff 36938. maxrd2 added a comment. Cleaned up indentation. REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13808?vs=36937&id=36938 BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808 AFFECTE

D13808: Fix KMainWindow saving incorrect widget settings

maxrd2 created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. maxrd2 requested review of this revision. REVISION SUMMARY BUG: 395988 In certain cases KMainWindow::saveMainWindowSettings() could have been cal

KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.10 - Build # 10 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.10/10/ Project: Frameworks kconfig kf5-qt5 FreeBSDQt5.10 Date of build: Sat, 30 Jun 2018 08:05:42 + Build duration: 2 min 14 sec and counting JUnit Tests

D13792: Remove unused include

This revision was automatically updated to reflect the committed changes. Closed by commit R237:fa20aaadecf9: Remove unused include (authored by rempt). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13792?vs=36873&id=36935 REVISION DETAIL https://phabricato