KDE CI: Frameworks kservice kf5-qt5 WindowsMSVCQt5.10 - Build # 23 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20WindowsMSVCQt5.10/23/ Project: Frameworks kservice kf5-qt5 WindowsMSVCQt5.10 Date of build: Wed, 20 Jun 2018 00:15:03 + Build duration: 3 min 10 sec and counting JUnit

D13043: Properly sanitize input

apol added a comment. Yep, this was from the old and deprecated modeltest.cpp. I'll have to look into how to do it right :P REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D13043 To: apol, #frameworks, broulik Cc: dfaure, broulik, kde-frameworks-devel, michae

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 147 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/147/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Tue, 19 Jun 2018 22:29:26 + Build duration: 14 min and counting

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 297 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/297/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 19 Jun 2018 22:29:26 + Build duration: 5 min 29 sec and counting JUnit Tests Name: (roo

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/53/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 19 Jun 2018 22:29:26 + Build duration: 5 min 7 sec and counting JUnit Tests Name:

D13554: [Properties dialog] Make all field values on general tab selectable

This revision was automatically updated to reflect the committed changes. Closed by commit R241:025e5e9957ff: [Properties dialog] Make all field values on general tab selectable (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13554?vs=36188&i

D13622: Remove unused entry X-KDE-DBus-ModuleName from kded plugins' metadata

kossebau added a comment. In D13622#280325 , @dfaure wrote: > Note: kcoreaddons, baloo, kservice/autotests, and kdelibs4support mention this key too, you can clean it all up ;) Done. Thanks for quick review :) REPOSITORY R241 KIO REVI

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/36/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Tue, 19 Jun 2018 22:10:31 + Build duration: 1 min 56 sec and counting JUnit Tests N

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.10 - Build # 11 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.10/11/ Project: Frameworks kservice kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 19 Jun 2018 22:10:32 + Build duration: 1 min 28 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/31/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Tue, 19 Jun 2018 22:07:26 + Build duration: 3 min 30 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 86 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/86/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Tue, 19 Jun 2018 22:07:26 + Build duration: 3 min 7 sec and counting JUnit Tests

KDE CI: Frameworks kservice kf5-qt5 WindowsMSVCQt5.10 - Build # 22 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20WindowsMSVCQt5.10/22/ Project: Frameworks kservice kf5-qt5 WindowsMSVCQt5.10 Date of build: Tue, 19 Jun 2018 22:10:31 + Build duration: 15 sec and counting CONSOLE OUTP

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/9/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 19 Jun 2018 22:07:26 + Build duration: 3 min 15 sec and counting JUnit Te

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/49/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Tue, 19 Jun 2018 22:02:01 + Build duration: 4 min 32 sec and counting JUnit

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.9/22/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 Date of build: Tue, 19 Jun 2018 22:02:01 + Build duration: 4 min 14 sec and counting JUnit T

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.10/9/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 19 Jun 2018 22:02:01 + Build duration: 3 min 45 sec and counting

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/52/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 19 Jun 2018 21:49:46 + Build duration: 4 min 7 sec and counting JUnit Tests Name:

D13622: Remove unused entry X-KDE-DBus-ModuleName from kded plugins' metadata

This revision was automatically updated to reflect the committed changes. Closed by commit R241:486c4e86c8d3: Remove unused entry X-KDE-DBus-ModuleName from kded plugins' metadata (authored by kossebau). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13622?vs=3635

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 146 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/146/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Tue, 19 Jun 2018 21:49:46 + Build duration: 12 sec and counting CONSOLE OUTPUT

D13621: KDEDModule servicetype definition: remove unused key X-KDE-DBus-ModuleName

This revision was automatically updated to reflect the committed changes. Closed by commit R297:6b42fefabd2a: KDEDModule servicetype definition: remove unused key X-KDE-DBus-ModuleName (authored by kossebau). REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13621?v

D13622: Remove unused entry X-KDE-DBus-ModuleName from kded plugins' metadata

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Note: kcoreaddons, baloo, kservice/autotests, and kdelibs4support mention this key too, you can clean it all up ;) Thanks! REPOSITORY R241 KIO BRANCH removeModuleNameKey REVISION

D13621: KDEDModule servicetype definition: remove unused key X-KDE-DBus-ModuleName

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Indeed, not used, and not useful. REPOSITORY R297 KDED BRANCH removeModuleNameKey REVISION DETAIL https://phabricator.kde.org/D13621 To: kossebau, dfaure Cc: kde-frameworks-devel, m

D13622: Remove unused entry X-KDE-DBus-ModuleName from kded plugins' metadata

kossebau created this revision. kossebau added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY That entry has never been used, instead the plugin

D13621: KDEDModule servicetype definition: remove unused key X-KDE-DBus-ModuleName

kossebau created this revision. kossebau added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY This key was introduced in 2008 in some places, but

D13554: [Properties dialog] Make all field values on general tab selectable

elvisangelaccio accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH everything-is-selectable (branched from master) REVISION DETAIL https://phabricator.kde.org/D13554 To: ngraham, #frameworks, #dolphin, elvisangelaccio Cc: kde-frameworks-dev

D13571: Correct KFormat::formatBytes examples

bruns added a comment. In D13571#280135 , @apol wrote: > In D13571#279554 , @bruns wrote: > > > In D13571#279550 , @apol wrote: > > > > > > The given exa

D13601: OutputManagement fractional scaling

davidedmundson added a dependent revision: D13617: Support kwin fractional scaling in wayland backend. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13601 To: davidedmundson, #kwin Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13510: Add XDG WM Base support to our XDGShell API

davidedmundson added a dependency: D13530: Add XDG WmBase support. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13510 To: davidedmundson, #kwin Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13495: Fix XDGV6 popup test

davidedmundson added a dependent revision: D13530: Add XDG WmBase support. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13495 To: davidedmundson, #kwin Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D13488: Make XDGShellV5 co-compilable with XDGWMBase

davidedmundson added a dependent revision: D13530: Add XDG WmBase support. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13488 To: davidedmundson, #plasma Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D13494: Fix stupid copy paste bug in XDGShellV6 Client

davidedmundson added a dependent revision: D13530: Add XDG WmBase support. REPOSITORY R127 KWayland BRANCH xdg_squash REVISION DETAIL https://phabricator.kde.org/D13494 To: davidedmundson, #kwin, romangg Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/51/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 19 Jun 2018 14:54:40 + Build duration: 11 min and counting JUnit Tests Name: (root

D13590: Use QUrl < instead of QString.compare

This revision was automatically updated to reflect the committed changes. Closed by commit R241:bba871deced2: Use QUrl < instead of QString.compare (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13590?vs=36283&id=36343 REVISION DETAIL htt

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 59 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/59/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Tue, 19 Jun 2018 14:19:24 + Build duration: 7 min 4 sec and counting JUnit Tests Na

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/21/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 19 Jun 2018 14:19:24 + Build duration: 6 min 50 sec and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/31/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Tue, 19 Jun 2018 14:19:24 + Build duration: 5 min 44 sec and counting JUnit Tests Nam

D13502: Fix compiler warning about hidden virtual overloads

This revision was automatically updated to reflect the committed changes. Closed by commit R127:7b9932e70739: Fix compiler warning about hidden virtual overloads (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13502?vs=36073&id=36

D13552: [Properties dialog] Improve some permissions-related strings

abetts added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13552 To: ngraham, #frameworks, #vdg, #dolphin Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D13571: Correct KFormat::formatBytes examples

apol added a comment. In D13571#279554 , @bruns wrote: > In D13571#279550 , @apol wrote: > > > > The given example is just plain wrong. It does not work, it is just some false prosa. > > > > Fair

D13552: [Properties dialog] Improve some permissions-related strings

ngraham added a comment. Friendly ping! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13552 To: ngraham, #frameworks, #vdg, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13554: [Properties dialog] Make all field values on general tab selectable

ngraham added a comment. Friendly ping! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13554 To: ngraham, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13043: Properly sanitize input

dfaure added a comment. BTW, the commit message refers to ModelTest, but that's the old modeltest.cpp, not the new QAbstractItemModelTester, right? I'm working on QConcatenateTablesProxyModel (https://codereview.qt-project.org/166323) and there QAbstractItemModelTester passes with asser

D13442: Implemented displaying of total lines in kate

shubham added a comment. Cullman,brauch,dhaumann : can you please tell how to have a context menu? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To: shubham, #ktexteditor, cullmann, brauch Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, kde

D13601: OutputManagement fractional scaling

davidedmundson updated this revision to Diff 36330. davidedmundson added a comment. const REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13601?vs=36318&id=36330 BRANCH davidedmundson/scalef REVISION DETAIL https://phabricator.kde.org/D13601 AFFECTED

D13601: OutputManagement fractional scaling

zzag added inline comments. INLINE COMMENTS > outputconfiguration_interface.cpp:194 > +Q_UNUSED(client); > +qreal scale = wl_fixed_to_double(scale_fixed); > + Nitpick: can be const. :-) REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13601 To: davidedmundson,

D13601: OutputManagement fractional scaling

davidedmundson created this revision. davidedmundson added a reviewer: KWin. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY In order to have fractional scaling

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

kossebau added a comment. Some quick feedback, though no in-detail review myself for now, not sure I will be able later, so needs others as well. INLINE COMMENTS > kformat.h:117 > + * @see formatValue > + */ > +enum class Unit { Please add missing "@since 5.48" (as last item, fo

D10716: handle wrong password when using sudo which asks for another password

sitter requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R299 KDESu REVISION DETAIL https://phabricator.kde.org/D10716 To: jriddell, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

sitter added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. ping ping ping REPOSITORY R299 KDESu REVISION DETAIL https://phabricator.kde.org/D10716 To: jriddell, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns, #framewor

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/30/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Tue, 19 Jun 2018 08:16:32 + Build duration: 6 min 15 sec and counting JUnit Tests Nam

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 58 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/58/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Tue, 19 Jun 2018 08:16:32 + Build duration: 6 min 38 sec and counting JUnit Tests N

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/20/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 19 Jun 2018 08:16:32 + Build duration: 6 min 34 sec and counting JUnit Tests

D13500: Honor BUILD_TESTING

This revision was automatically updated to reflect the committed changes. Closed by commit R127:2d06b24a86f2: Honor BUILD_TESTING (authored by zzag). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13500?vs=36068&id=36307 REVISION DETAIL https://phabricator.

D13403: Android: Make it possible to override a target's APK directory

vkrause added inline comments. INLINE COMMENTS > ECMAndroidDeployQt.cmake:58 > +COMMAND LANG=C cmake > -DINPUT_FILE="${QTANDROID_EXPORTED_TARGET}-deployment.json.in2" > -DOUTPUT_FILE="${QTANDROID_EXPORTED_TARGET}-deployment.json" > "-DTARGET=$" > "-DOUTPUT_DIR=$" > "-DEXPORT_DIR=${CM

D13500: Honor BUILD_TESTING

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH honor-build-testing REVISION DETAIL https://phabricator.kde.org/D13500 To: zzag, #kwin, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13500: Honor BUILD_TESTING

zzag added a comment. Ping. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13500 To: zzag, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns