D13482: Implement support for the Voice and Call interfaces

This revision was automatically updated to reflect the committed changes. Closed by commit R281:7b9d2badd52a: Implement support for the Voice and Call interfaces (authored by aleksanderm, committed by jgrulich). REPOSITORY R281 ModemManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde

D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

pino added a comment. In D13585#279400 , @asturmlechner wrote: > The problem with that is cmake picking the wrong dir (first in order is `lib`, while it should be e.g. `lib64`). Sure, and that's why I suggested to drop the usage of `LMDB

D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

asturmlechner added a comment. The problem with that is cmake picking the wrong dir (first in order is `lib`, while it should be e.g. `lib64`). REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13585 To: asturmlechner, #baloo Cc: pino, kde-frameworks-devel, #baloo, asha

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/27/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 18 Jun 2018 03:30:05 + Build duration: 16 min and counting JUn

D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

pino added a comment. Or just drop the two `HINTS` (for `find_path` and `find_library`) altogether, as cmake already looks in standard include/library paths. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13585 To: asturmlechner, #baloo Cc: pino, kde-frameworks-devel

D13460: implement the lyrics tag for taglibextractor

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH lyrics REVISION DETAIL https://phabricator.kde.org/D13460 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngra

D12233: Avoid manipulation of lists with quadratic complexity

bruns added a comment. Still waiting for a final review ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233 To: bruns, #baloo, michaelh Cc: dhaumann, ngraham, kde-frameworks-devel, jtamate, bruns, ashaposhnikov, michaelh, astippich, spoorun, abrahams

D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

asturmlechner added a comment. Not convinved it is the best way but it is some way to make it point to the desired multiarch libdir rather than make it choose a random one. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13585 To: asturmlechner, #baloo Cc: kde-framewo

D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

asturmlechner added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13585 To: asturmlechner, #baloo Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

asturmlechner created this revision. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. asturmlechner requested review of this revision. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bruns added a task: T8500: Add HIG rules about use of units/symbols in (config) UI. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13583 To: bruns, #frameworks Cc: kde-frameworks-devel, astippich, michaelh, ngraham, bruns

D13584: KFormat: Replace byte specific implementation with generic one

bruns added a task: T8500: Add HIG rules about use of units/symbols in (config) UI. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13584 To: bruns, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bruns added a dependent revision: D13584: KFormat: Replace byte specific implementation with generic one. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13583 To: bruns, #frameworks Cc: kde-frameworks-devel, astippich, michaelh, ngraham, bruns

D13584: KFormat: Replace byte specific implementation with generic one

bruns added a dependency: D13583: KFormat: Allow usage of quantities beyond bytes and seconds. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13584 To: bruns, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13584: KFormat: Replace byte specific implementation with generic one

bruns created this revision. bruns added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY There is no need for duplicate implementations. As forma

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bruns created this revision. bruns added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Its useful to allow automatic formatting of quantities l

D13394: C++: update for c++20 and fix some syntax errors

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks good for me! Thanks for the improvements. REPOSITORY R216 Syntax Highlighting BRANCH cpp REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann, cullma