D13554: [Properties dialog] Make all field values on general tab selectable

2018-06-14 Thread Nathaniel Graham
ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13554 To: ngraham, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13554: [Properties dialog] Make all field values on general tab selectable

2018-06-14 Thread Nathaniel Graham
ngraham created this revision. ngraham added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY The Location field was already selectable; this pa

D13552: Improve some permissions-related strings

2018-06-14 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13552 To: ngraham, #frameworks, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13552: Improve some permissions-related strings

2018-06-14 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Frameworks, VDG. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 96714 FIXED-IN: 5.48 Improve some

D13510: Add XDG WM Base support to our XDGShell API

2018-06-14 Thread Roman Gilg
romangg added inline comments. INLINE COMMENTS > registry.cpp:88 > #include > +#include > nitpick: put this include directly below the other xdg-shell ones above. > xdgshell_stable.cpp:195 > + > +uint32_t constraint = 0; > +if > (positioner.constraints().testFlag(XdgPositioner::Co

D13549: Switch KIO::convertSize() to KFormat::formatByteSize()

2018-06-14 Thread Pino Toscano
pino created this revision. pino added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. pino requested review of this revision. REVISION SUMMARY Make KIO::convertSize() use KFormat::formatByteSize(), instead

D13541: Port solid from Qt5::Widgets to Qt5::Gui

2018-06-14 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. const auto would be even nicer, if possible. Besides that, lgtm. REPOSITORY R245 Solid BRANCH gui-instead-of-widgets REVISION DETAIL https://phabricator.kde.org/D13541 To: graes

D13495: Fix XDGV6 popup test

2018-06-14 Thread David Edmundson
davidedmundson added a comment. You can only set the size in the ctor, so needed a new instance. For the rest of the tests we don't need different sizes. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13495 To: davidedmundson, #kwin Cc: romangg, kde-frameworks

D13495: Fix XDGV6 popup test

2018-06-14 Thread Roman Gilg
romangg added a comment. What's with positioner2? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13495 To: davidedmundson, #kwin Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D13535: Do not cancel old clipboard selection if it is same as the new one.

2018-06-14 Thread Fabian Vogt
fvogt added a comment. Yes, a unit test makes sense. I tried to add // replace the data source with itself, ensure that it did not get cancelled // replace the data source with itself, ensure that it did not get cancelled selectionOfferedSpy.clear(); dataSource2->offer(QStrin

D13488: Make XDGShellV5 co-compilable with XDGWMBase

2018-06-14 Thread Roman Gilg
romangg added inline comments. INLINE COMMENTS > xdgshell_v5.cpp:36 > public: > -void setupV5(xdg_shell *shell) override; > +void setupV5(xdg_shell *shell); > void release() override; This should be still an override. > wayland-xdg-shell-v5-client-protocol.h:1 > +/* Generated by w

D13541: Port solid from Qt5::Widgets to Qt5::Gui

2018-06-14 Thread Martin Flöser
graesslin created this revision. graesslin added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. graesslin requested review of this revision. REVISION SUMMARY The only usage of widgets was to get the act

D13535: Do not cancel old clipboard selection if it is same as the new one.

2018-06-14 Thread Martin Flöser
graesslin added a comment. I would appreciate a unit test for the issue. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13535 To: fvogt, #plasma, #frameworks Cc: graesslin, kde-frameworks-devel, michaelh, ngraham, bruns

D13536: Do not cancel old clipboard selection if it is same as the new one.

2018-06-14 Thread Michal Srb
michalsrb abandoned this revision. michalsrb added a comment. Already submitted: https://phabricator.kde.org/D13535 REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13536 To: michalsrb Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13533: Add the arclint file in kwayland

2018-06-14 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH add-arclint REVISION DETAIL https://phabricator.kde.org/D13533 To: bshah, #frameworks, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12820: Add KWayland virtual desktop protocol

2018-06-14 Thread Marco Martin
mart updated this revision to Diff 36161. mart added a comment. - remove release from the protocol - new_id is id REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12820?vs=36052&id=36161 BRANCH mart/plasmavirtualdesktop REVISION DETAIL https://phabri

D13494: Fix stupid copy paste bug in XDGShellV6 Client

2018-06-14 Thread Roman Gilg
romangg accepted this revision. romangg added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > xdgshell_v6.cpp:180 > uint32_t constraint = 0; > + > if > (positioner.constraints().testFlag(XdgPositioner::Constraint::SlideX)) { remove this new line RE

D13536: Do not cancel old clipboard selection if it is same as the new one.

2018-06-14 Thread Michal Srb
michalsrb created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. michalsrb requested review of this revision. REVISION SUMMARY GTK applications seem to call wl_data_device::set_selection multiple times with t

D13535: Do not cancel old clipboard selection if it is same as the new one.

2018-06-14 Thread Fabian Vogt
fvogt created this revision. fvogt added reviewers: Plasma, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY GTK applications seem to call wl_data_device::set

D13533: Add the arclint file in kwayland

2018-06-14 Thread Bhushan Shah
bshah created this revision. bshah added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. bshah requested review of this revision. REVISION SUMMARY - xml linter to make sure that we don't add broken proto

D12820: Add KWayland virtual desktop protocol

2018-06-14 Thread David Edmundson
davidedmundson added a comment. Cool. I'm happy with the protocol, except for one important comment. IMHO worth doing the kwin/plasma code before pushing the frameworks code. INLINE COMMENTS > plasma-virtual-desktop.xml:62 > + > + > + This still isn't deletable, see my comment f