D13222: Use QDateTime for interfacing with QML

fvogt added a comment. In D13222#273334 , @ngraham wrote: > If the behavior changed in Qt 5.11, does the new code need a Qt version check, or is the patch backwards-compatible with earlier Qt versions? The latter, as it says in the test p

D13316: manually set format in jpeg thumbnail creator

ngraham added reviewers: dfaure, elvisangelaccio, Frameworks. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D13316 To: miklosm, dfaure, elvisangelaccio, #frameworks

D13315: Detect mime type of local files based on their contents

apol added inline comments. INLINE COMMENTS > kfileitem.cpp:730 > const QUrl url = mostLocalUrl(&isLocalUrl); > -d->m_mimeType = db.mimeTypeForUrl(url); > +if (isLocalUrl) { > +qDebug() << "determine for local " << url.toLocalFile(); I'm not s

D13308: Filter out duplicate plugins

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D13308 To: elvisangelaccio, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13287: FrameSVG: Delete redundant checks

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH framesvg-redundant-checks REVISION DETAIL https://phabricator.kde.org/D13287 To: zzag, #plasma, #frameworks, apol Cc: kde-frameworks-devel, michaelh, ngraham, br

D13286: FrameSVG: Fix QObject include

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH frameworks-coding-style REVISION DETAIL https://phabricator.kde.org/D13286 To: zzag, #plasma, #frameworks, apol Cc: kde-frameworks-devel, michaelh, ngraham, brun

D13294: baloodb: Make changes to cmdline arg description after rename prune -> clean

This revision was automatically updated to reflect the committed changes. Closed by commit R293:3671d67a7956: baloodb: Make changes to cmdline arg description after rename prune -> clean (authored by aspotashev). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13

D13222: Use QDateTime for interfacing with QML

ngraham added a comment. If the behavior changed in Qt 5.11, does the new code need a Qt version check, or is the patch backwards-compatible with earlier Qt versions? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13222 To: fvogt, #plasma, #frame

D13315: Detect mime type of local files based on their contents

elvisangelaccio added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13315 To: miklosm, #frameworks, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13315: Detect mime type of local files based on their contents

ngraham added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13315 To: miklosm, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13315: Detect mime type of local files based on their contents

miklosm created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. miklosm requested review of this revision. REVISION SUMMARY KFileItem::determineMimeType() is an explicit order to thoroughly detect the file type,

D13294: baloodb: Make changes to cmdline arg description after rename prune -> clean

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH rename-prune-to-clean REVISION DETAIL https://phabricator.kde.org/D13294 To: aspotashev, michaelh, #baloo, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astip

D13294: baloodb: Make changes to cmdline arg description after rename prune -> clean

ngraham added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13294 To: aspotashev, michaelh, #baloo Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D13308: Filter out duplicate plugins

elvisangelaccio edited the summary of this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13308 To: elvisangelaccio, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13124: [RFC] Add Share action to Dolphin context menu

elvisangelaccio removed a reviewer: Dolphin. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol, elvisangelaccio Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh, spoorun, navarromo

D13124: [RFC] Add Share action to Dolphin context menu

elvisangelaccio removed a reviewer: elvisangelaccio. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh, spoorun, navarromorales, is

D13124: [RFC] Add Share action to Dolphin context menu

elvisangelaccio added inline comments. INLINE COMMENTS > CMakeLists.txt:12-13 > +) > +install(TARGETS purposefileitemaction DESTINATION ${PLUGIN_INSTALL_DIR}) > +install(FILES purposesendfile.desktop DESTINATION ${SERVICES_INSTALL_DIR}) Please consider using json metadata and installing the plug

D13308: Filter out duplicate plugins

elvisangelaccio updated this revision to Diff 35472. elvisangelaccio added a comment. - Use auto REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13308?vs=35471&id=35472 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13308 AFFECTED

D13308: Filter out duplicate plugins

elvisangelaccio created this revision. elvisangelaccio added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. elvisangelaccio requested review of this revision. REVISION SUMMARY If purpose is installed both as

D13128: Make sure ungrab keyboard request is processed before emitting shortcut

This revision was automatically updated to reflect the committed changes. Closed by commit R268:706730f9d7a3: Make sure ungrab keyboard request is processed before emitting shortcut (authored by sontolbonggol, committed by elvisangelaccio). REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDA

D12320: [RFC] add ability to read embedded cover files

bruns added a comment. as the remaining issues are formatting only, this is an `accept` by me save the requested changes. @mgallien - if i am late to accept, can you do it? INLINE COMMENTS > embeddedimagedata.cpp:59 > + > +QMap > EmbeddedImageData::imageData(const QString &fileUrl, const

D13146: Drop old QString::null usage

This revision was automatically updated to reflect the committed changes. Closed by commit R241:9d4ccb9836b3: Drop old QString::null usage (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13146?vs=34963&id=35372 REVISION DETAIL http

D12520: [PasteJob] Emit KDirNotify on paste

elvisangelaccio added inline comments. INLINE COMMENTS > paste.cpp:125 > KIO::Job *job = KIO::storedPut(data, url, -1, flags); > +QObject::connect(job, &KIO::Job::result, [url](KJob *job) { > +if (job->error() == KJob::NoError) { Missing `this` as the receiver argument? REPOSI

D10702: Always use a job to delete files to avoid freezing process waiting on IO

meven added a comment. Here is the script I have been using : https://gist.github.com/meven/f0b2a36c61240e1d6e19753afd1d3d68 My benchmark logic is : Create a folder with x files of k sizes. Copy this folder. Delete this folder using kfmclient, measuring the elapsed time I have

D13275: Teach ContainmentInterface::processMimeData how to handle Task Manager drops

hein created this revision. hein added reviewers: davidedmundson, Zren, mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. hein requested review of this revision. REVISION SUMMARY To explicitly confine Task Manager drops to

D13145: Check if destination exists also when pasting binary data

This revision was automatically updated to reflect the committed changes. Closed by commit R241:b73355da3f5b: Check if destination exists also when pasting binary data (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13145?vs=34962&id=

D13215: Update sizes before generating frame svg background

zzag added a comment. In D13215#271983 , @broulik wrote: > Doesn't make a difference in Oxygen's rounded corners on panels but doesn't make it worse either. Could you please share a screenshot? I still don't know what's wrong with Oxygen

D13128: Make sure ungrab keyboard request is processed before emitting shortcut

sontolbonggol added a comment. @elvisangelaccio you can put my email sonbong...@gmail.com. Thanks! REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D13128 To: sontolbonggol, #frameworks, #plasma, mck182, davidedmundson Cc: elvisangelaccio, davidedmundson, fvogt, k

D13285: FrameSVG: Use QMargins

zzag added a comment. I'm not sure whether that's a good idea to use QMargins for measures, maybe, it would be better to have something like struct { QSize left; QSize top; QSize right; QSize bottom; } sizes, fixedSizes; in FrameData, which then

D13128: Make sure ungrab keyboard request is processed before emitting shortcut

elvisangelaccio added a comment. @sontolbonggol What's the email address we should use for the git commit? REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D13128 To: sontolbonggol, #frameworks, #plasma, mck182, davidedmundson Cc: elvisangelaccio, davidedmundson,

D13215: Update sizes before generating frame svg background

zzag added a comment. Answer to my inline question: updateSizes can be omitted (but I would prefer to leave it). Also, `maskFrame->enabledBorders = frame->enabledBorders;` above is redundant (maskFrame->enabledBorders is already equal to frame->enabledBorders; it if wasn't the case, then cac

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 288 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/288/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 03 Jun 2018 16:36:22 + Build duration: 10 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/44/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 03 Jun 2018 16:36:22 + Build duration: 4 min 14 sec and counting JUnit Tests Name:

D12599: KFileOperator: fix apidox of fileHighlighted()

This revision was automatically updated to reflect the committed changes. Closed by commit R241:860ea6f924c4: KFileOperator: fix apidox of fileHighlighted() (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12599?vs=33296&id=35467 REVI

D13285: FrameSVG: Use QMargins

zzag abandoned this revision. zzag added a comment. The diff is crap. I'll abandon it. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13285 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13275: Teach ContainmentInterface::processMimeData how to handle Task Manager drops

hein updated this revision to Diff 35463. hein added a comment. Fix last minute build error. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13275?vs=35371&id=35463 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13275 AF

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 136 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/136/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sun, 03 Jun 2018 15:25:02 + Build duration: 14 min and counting JUnit Tests Name: (root) Failed

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 43 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/43/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 03 Jun 2018 15:25:02 + Build duration: 8 min 4 sec and counting JUnit Tests Name:

D10702: Always use a job to delete files to avoid freezing process waiting on IO

markg added a comment. In D10702#273040 , @meven wrote: > Great suggestion Mark ! > > I am a C++ beginner, I did not consider this neat C++ 14 feature. > > This will necessitate a c++ compiler dependency change though. > Like Kwin did l

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12986 To: ngraham, #dolphin, #frameworks, #vdg, davidedmundson Cc: davidedmundson, abetts, rkflx, kfm-devel, kde-frameworks-devel, michaelh, ngraham, bruns

D10702: Always use a job to delete files to avoid freezing process waiting on IO

meven added a comment. Great suggestion Mark ! I am a C++ beginner, I did not consider this neat C++ 14 feature. This will necessitate a c++ compiler dependency change though. Like Kwin did last July https://github.com/KDE/kwin/commit/ea5d611de1bc33869c13c27d75a7827201a5139d >

D13302: check for needed version of libavcode, libavformat and libavutil

romangg added a comment. I tried this patch on Neon with FFmpeg 2.8.14. KFileMetaData builds now because it detects that the FFmpeg module version numbers are too low. CMake log: P230 Few remarks: - In the log it says 3 times `Could NOT fi

D13124: [RFC] Add Share action to Dolphin context menu

markg added a comment. In D13124#272698 , @nicolasfella wrote: > Friendly ping? ? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, #dolphin, apol, elvisangelaccio Cc: markg, broul

D13302: check for needed version of libavcode, libavformat and libavutil

mgallien updated this revision to Diff 35457. mgallien added a comment. - prefer usage of CHECK_STRUCT_HAS_MEMBER instead of having test code the test is shorter with CHECK_STRUCT_HAS_MEMBER (thanks @adridg for the help) REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https:/

D10702: Always use a job to delete files to avoid freezing process waiting on IO

markg added a comment. In D10702#272901 , @meven wrote: > Here is the script I have been using : https://gist.github.com/meven/f0b2a36c61240e1d6e19753afd1d3d68 > > My benchmark logic is : > Create a folder with x files of k sizes. > Cop

D13302: check for needed version of libavcode, libavformat and libavutil

mgallien retitled this revision from "[WIP] check for needed version of libavcode, libavformat and libavutil" to "check for needed version of libavcode, libavformat and libavutil". mgallien edited the test plan for this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabric

D13302: [WIP] check for needed version of libavcode, libavformat and libavutil

mgallien updated this revision to Diff 35456. mgallien added a comment. - check AVStrean structure have codecpar member working check for codecpar member in AVStream structure should I try to make the result variable be not in the cmake cache ? REPOSITORY R286 KFileMetaData CHANGE

D13302: [WIP] check for needed version of libavcode, libavformat and libavutil

mgallien created this revision. mgallien added reviewers: romangg, adridg. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. mgallien requested review of this revision. REVISION SUMMARY check for needed version of lib

D13285: FrameSVG: Use QMargins

zzag updated this revision to Diff 35453. zzag added a comment. Fix ::margins() and ::fixedMargins() REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13285?vs=35444&id=35453 BRANCH framesvg-modernize REVISION DETAIL https://phabricato

D12745: Unify API for file descriptor sharing

ossi added a comment. \o/ ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12745 To: chinmoyr, dfaure, ossi Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13285: FrameSVG: Use QMargins

zzag updated this revision to Diff 35444. zzag added a comment. Forward-declare QMarginsF. (to be consistent with QRectF, QSizeF, etc) REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13285?vs=35412&id=35444 BRANCH framesvg-modernize RE

D13294: baloodb: Make changes to cmdline arg description after rename prune -> clean

aspotashev created this revision. aspotashev added a reviewer: michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. aspotashev requested review of this revision. REPOSITORY R293 Baloo BRANCH rename-prune-to-