D12858: [KCharSelect] Fix table cell width

rkflx added a comment. Not sure whether that's material for this patch, but for me the vertical spacing is still a bit off, i.e. the boxes are still not square as before: Qt 5.10: F5859388: kcharselect-qt5.10.png Qt 5.11: F5859390: kcharsele

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

rkflx added a comment. In D12986#265231 , @ngraham wrote: > Yeah, that makes sense. Suggestions welcome, of course. Is this any better? > F5859259: After 2.png Hm, I think after the checkbox there

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

abetts added a comment. In D12986#265231 , @ngraham wrote: > Yeah, that makes sense. Suggestions welcome, of course. Is this any better? > F5859259: After 2.png > > Still not super happy with "When lim

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

ngraham added a comment. Yeah, that makes sense. Suggestions welcome, of course. Is this any better? F5859259: After 2.png Still not super happy with "When limit reached: REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12986

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 264 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/264/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 20 May 2018 03:26:48 + Build duration: 12 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 161 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/161/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Sun, 20 May 2018 03:27:18 + Build duration: 11 min and counting JUnit Te

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 114 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/114/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sun, 20 May 2018 03:26:49 + Build duration: 9 min 15 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/13/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 20 May 2018 03:27:18 + Build duration: 4 min 57 sec and counting

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/19/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 20 May 2018 03:26:49 + Build duration: 4 min 33 sec and counting JUnit Tests Name:

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

abetts added a comment. In D12986#265198 , @rkflx wrote: > I don't think putting whole phrases as a label before the checkbox works very well, and I would be surprised if that's what the HIG now recommends. I assume at most a single subject shou

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

rkflx added a comment. I don't think putting whole phrases as a label before the checkbox works very well, and I would be surprised if that's what the HIG now recommends. I assume at most a single subject should be used there? For example, instead of the awkwardly placed checkbox in

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

ngraham added a comment. Right, I think that makes sense. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10663 To: dmitrio, #frameworks, dfaure, ngraham Cc: kde-frameworks-devel, elvisangelaccio, ngraham, anthonyfieroni, meven, #frameworks, michaelh, bruns

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

dmitrio added a comment. Well, I think it would be logical to implement something like that if we intend to make copying cancelable. But we still will have to spoil the destination file if there is no enough space left (which is not always determined correctly, in fact. One example of this i

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

ngraham edited the test plan for this revision. ngraham added a subscriber: kfm-devel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12986 To: ngraham, #dolphin, #frameworks, #vdg Cc: kfm-devel, kde-frameworks-devel, michaelh, ngraham, bruns

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

ngraham created this revision. ngraham added reviewers: Dolphin, Frameworks, VDG. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Clean up and standardize the UI to be

D12728: KFileItemActions: fallback to default mimetype when selecting only files

elvisangelaccio added a comment. Restricted Application added a subscriber: kde-frameworks-devel. Ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12728 To: elvisangelaccio, #frameworks, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12971: Add entities CIFS, NFS, Samba, SMB to general.entities

This revision was automatically updated to reflect the committed changes. Closed by commit R238:8debef405f45: Add entities CIFS, NFS, Samba, SMB to general.entities (authored by lueck). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12971?vs=34452&id=34466