D10803: handle more tags in taglibextractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:7f9de32eedff: handle more tags in taglibextractor (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10803?vs=30956&id=31950#toc REPOSITORY R286 KFileMetaData CHANGES S

D12120: Check if the application androiddeployqt package has a main() symbol

vatra added a comment. +1 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D12120 To: apol, #frameworks, #build_system Cc: vatra, aacid, michaelh, ngraham, bruns

D12133: Correctly encode URL of thumbnails

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Confirmed the fix! It was indeed an amazing bug report. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12133 To: davidedmundson, ngraham Cc: ngraha

D12130: Use the more user-friendly string "File format" in the open/save dialogs

abetts added a comment. +1 REPOSITORY R241 KIO BRANCH file-format-label (branched from master) REVISION DETAIL https://phabricator.kde.org/D12130 To: ngraham, #frameworks, #vdg, bruns Cc: abetts, bruns, michaelh, ngraham

D12130: Use the more user-friendly string "File format" in the open/save dialogs

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. +1 REPOSITORY R241 KIO BRANCH file-format-label (branched from master) REVISION DETAIL https://phabricator.kde.org/D12130 To: ngraham, #frameworks, #vdg, bruns Cc: bruns, michaelh, ng

D12138: Remove FSUtils::getDirectoryFileSystem

bruns created this revision. bruns added reviewers: Baloo, FreeBSD. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY It was only used to determine if the filesystem is BTRFS

D12138: Remove FSUtils::getDirectoryFileSystem

bruns added a dependency: D12136: Avoid hardcoding of filesystems supporting CoW. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12138 To: bruns, #baloo, #freebsd Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12136: Avoid hardcoding of filesystems supporting CoW

bruns added a dependent revision: D12138: Remove FSUtils::getDirectoryFileSystem. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12136 To: bruns, #baloo Cc: #freebsd, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12135: Allow disabling of CoW to fail when not supported by filesystem

bruns updated this revision to Diff 31946. bruns edited the test plan for this revision. bruns added a comment. update function documentation REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12135?vs=31943&id=31946 BRANCH accept_eopnotsupp_on_chattr REVISIO

D12136: Avoid hardcoding of filesystems supporting CoW

bruns added a dependency: D12135: Allow disabling of CoW to fail when not supported by filesystem. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12136 To: bruns, #baloo Cc: #freebsd, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

bruns added a comment. See D12136 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784 To: tcberner, #freebsd, poboiko, bruns Cc: bruns, adridg, kfunk, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D12135: Allow disabling of CoW to fail when not supported by filesystem

bruns added a dependent revision: D12136: Avoid hardcoding of filesystems supporting CoW. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12135 To: bruns, #baloo Cc: #freebsd, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12136: Avoid hardcoding of filesystems supporting CoW

bruns created this revision. bruns added a reviewer: Baloo. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY The correct way to check for CoW support and conditionally disabl

D12135: Allow disabling of CoW to fail when not supported by filesystem

bruns created this revision. bruns added a reviewer: Baloo. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY It is fine to neither support reading of attrs nor setting the NO

D12133: Correctly encode URL of thumbnails

davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. davidedmundson requested review of this revision. REVISION SUMMARY As per the amazingly detailed bug report, the spec says URLs should be percent enc

D12045: Clean up existing documentation

bruns added inline comments. INLINE COMMENTS > michaelh wrote in README.md:36 > - In CI Baloo is fully built and tested for Linux and FreeBSD. > - In CI an untested stub for Windows is build. I think that is to fulfill the > dependencies. > - macOS is not mentioned anywhere (and I don't know any

D12130: Use the more user-friendly string "File format" in the open/save dialogs

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12130 To: ngraham, #frameworks, #vdg Cc: michaelh, ngraham, bruns

D12130: Use the more user-friendly string "File format" in the open/save dialogs

ngraham created this revision. ngraham added reviewers: Frameworks, VDG. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY Time to fix a 14-year old wishlist bug! This patch uses the more user-friendly string "File format" to replace

D12124: Avoid creating duplicate property entries in the cache

bruns added a dependent revision: D12125: Avoid inserting an invalid "Size" property from the Filesystem interface. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D12124 To: bruns, #frameworks Cc: michaelh, ngraham, bruns

D12125: Avoid inserting an invalid "Size" property from the Filesystem interface

bruns added a dependency: D12124: Avoid creating duplicate property entries in the cache. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D12125 To: bruns Cc: #frameworks, michaelh, ngraham, bruns

D12028: taglibextractortest: Add test for files with empty metadata

bruns added inline comments. INLINE COMMENTS > michaelh wrote in taglibextractortest.cpp:231 > This converts the enums to strings. That way it is easier to spot which > properties are responsible for the failure. What he likely meant: `TagLibExtractor plugin{this};` instead of `QScopedPointer p

D12028: taglibextractortest: Add test for files with empty metadata

bruns added a comment. In D12028#244257 , @michaelh wrote: > In D12028#244243 , @mgallien wrote: > > > I need more time. I will try to look at it today. By the way, the stack concept seems very usef

D12028: taglibextractortest: Add test for files with empty metadata

michaelh added inline comments. INLINE COMMENTS > mgallien wrote in taglibextractortest.cpp:231 > Why not use a simple variable here ? > TagLibExtractor plugin; This converts the enums to strings. That way it is easier to spot which properties are responsible for the failure. REPOSITORY R286

D12120: Check if the application androiddeployqt package has a main() symbol

apol added a comment. In D12120#244538 , @aacid wrote: > Is this going to fail on my translated nm output? Well it shouldn't, we're passing `LANG=C` which is what solved it for the other command, I don't see why nm should be any different

D12028: taglibextractortest: Add test for files with empty metadata

michaelh updated this revision to Diff 31934. michaelh added a comment. - Apply suggested change REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12028?vs=31616&id=31934 BRANCH nometa (branched from master) REVISION DETAIL https://phabricator.kde.

D12127: Do not query properties when no interfaces are left

bruns created this revision. bruns added a reviewer: Frameworks. Restricted Application added a project: Frameworks. bruns requested review of this revision. REVISION SUMMARY checkCache is indirectly invoked from DeviceManager::updatebackend(), e.g. after an InterfaceRemoved call. Avoid doing

D12126: Invalidate property cache when an interface is removed

bruns created this revision. bruns added a reviewer: Frameworks. Restricted Application added a project: Frameworks. bruns requested review of this revision. REVISION SUMMARY As we do not know which property belongs to which interface we have to drop the whole cache whenever one or multiples i

D12125: Avoid inserting an invalid "Size" property from the Filesystem interface

bruns created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY UDisks2 added a "Size" property for the Filesystem interface, which may be zero, denoting an unknown

D12124: Avoid creating duplicate property entries in the cache

bruns updated this revision to Diff 31929. bruns added a comment. update, one line was missing REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12124?vs=31928&id=31929 BRANCH unique_properties REVISION DETAIL https://phabricator.kde.org/D12124 AFFECTED F

D12124: Avoid creating duplicate property entries in the cache

bruns created this revision. bruns added a reviewer: Frameworks. Restricted Application added a project: Frameworks. bruns requested review of this revision. REVISION SUMMARY Properties are associated with a specific interface, although the Solid UDisks2 backend merges properties from all inte

D12123: [UDisks] Optimize several property checks

bruns created this revision. bruns added a reviewer: Frameworks. Restricted Application added a project: Frameworks. bruns requested review of this revision. REVISION SUMMARY Use QStringLiteral for hasInterface argument Retrieve MountPoints propery just once when checking mount state. TEST

D12028: taglibextractortest: Add test for files with empty metadata

mgallien requested changes to this revision. mgallien added a comment. This revision now requires changes to proceed. Thanks for this work. Fix the issues and we should be good to go. INLINE COMMENTS > taglibextractortest.cpp:173 > +const auto testpasses = QString(); > +QString failMe

D12120: Check if the application androiddeployqt package has a main() symbol

aacid added a comment. Is this going to fail on my translated nm output? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D12120 To: apol, #frameworks, #build_system Cc: aacid, michaelh, ngraham, bruns

D10803: handle more tags in taglibextractor

dfaure added a comment. No. As soon as the RC1 tags are there, the message freeze is lifted. In case of a bugfix that comes in after RC1, I cherry-pick it into the release branch, so that master doesn't have to stay frozen for a week. REPOSITORY R286 KFileMetaData BRANCH enhance_tag

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/16/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Wed, 11 Apr 2018 18:39:30 + Build duration: 3 min 23 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 64 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/64/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Wed, 11 Apr 2018 18:44:54 + Build duration: 1 min 8 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/72/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Wed, 11 Apr 2018 18:39:30 + Build duration: 6 min 56 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 63 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/63/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Wed, 11 Apr 2018 18:42:52 + Build duration: 1 min 13 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/55/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 11 Apr 2018 18:39:30 + Build duration: 3 min 11 sec and counting JUnit Tes

D12112: Fix compiler warning under Clang

This revision was automatically updated to reflect the committed changes. Closed by commit R244:53f44072c70a: Fix compiler warning under Clang (authored by kfunk). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12112?vs=31888&id=31914 REVISION DETAIL ht

D12120: Check if the application androiddeployqt package has a main() symbol

apol created this revision. apol added reviewers: Frameworks, Build System. Restricted Application added projects: Frameworks, Build System. apol requested review of this revision. REVISION SUMMARY Back in the KDE Edu sprint, we decided we need such a check, otherwise you get rather frustrated

D12112: Fix compiler warning under Clang

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. ☕ REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D12112 To: kfunk, apol Cc: apol, #frameworks, michaelh, ngraham, bruns

D12077: Show view mode buttons in the open/save dialog's toolbar

rkflx added a comment. In D12077#244368 , @ngraham wrote: > I was also planning to change the default for Short View to put the icons on top rather than on the side, to match Dolphin's default behavior. That's gated behind a couple of bugs with

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 61 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/61/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Wed, 11 Apr 2018 17:14:25 + Build duration: 7 min 12 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 191 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/191/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 11 Apr 2018 17:14:25 + Build duration: 6 min 32 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 212 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/212/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 11 Apr 2018 17:14:25 + Build duration: 5 min 26 sec and counting JUnit Tests Name: (roo

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 62 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/62/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Wed, 11 Apr 2018 17:14:25 + Build duration: 2 min 7 sec and counting CONSOLE OUTPUT

D12095: convert setDirLister to the new connect syntax

This revision was automatically updated to reflect the committed changes. Closed by commit R241:940d2763e41b: convert setDirLister to the new connect syntax (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12095?vs=31851&id=31907 REVISION DET

D10803: handle more tags in taglibextractor

mgallien added a comment. In D10803#244389 , @astippich wrote: > ping. Can I push? I'm asking again because I don't want to mess up anything before the frameworks release, and this one contains string changes I am not sure. I tried askin

KDE CI: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.10 - Build # 20 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20WindowsMSVCQt5.10/20/ Project: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.10 Date of build: Wed, 11 Apr 2018 09:52:41 + Build duration: 5 hr 39 min and counting

D10803: handle more tags in taglibextractor

astippich added a comment. ping. Can I push? I'm asking again because I don't want to mess up anything before the frameworks release, and this one contains string changes REPOSITORY R286 KFileMetaData BRANCH enhance_taglib REVISION DETAIL https://phabricator.kde.org/D10803 To: astipp

KDE CI: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.10 - Build # 22 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.10/22/ Project: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.10 Date of build: Wed, 11 Apr 2018 09:52:36 + Build duration: 5 hr 0 min and counting JUnit

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham added a comment. In D12077#244340 , @rkflx wrote: > Okay, did look at the code ;) But please get at least one extra approval from someone else… Yep, was planning on it. In D12077#244339

D12114: Revive 'Description' property

michaelh created this revision. michaelh added reviewers: Baloo, Frameworks. Restricted Application added projects: Frameworks, Baloo. michaelh requested review of this revision. REVISION SUMMARY `Property::Description` did not make it into KF5, `Property::Comment` is used instead . This patc

D12112: Fix compiler warning under Clang

kfunk updated this revision to Diff 31888. kfunk added a comment. Address concerns. I knew why I put this up for review. /me grabs another coffee... REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12112?vs=31878&id=31888 BRANCH master REVISION DETAI

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham added a comment. @sharvey, can you re-base this onto current master? It doesn't want to land. REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure, #frameworks, broulik Cc: #dolphin, cfeck, fabiank, broulik,

D12077: Show view mode buttons in the open/save dialog's toolbar

rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. Okay, did look at the code ;) But please get at least one extra approval from someone else… REPOSITORY R241 KIO BRANCH show-view-mode-toggles-on-open-save-dialog-toolbar (branched from m

D12077: Show view mode buttons in the open/save dialog's toolbar

rkflx added a comment. Hm, seems like the width of the places panel is set in `kdeglobals` (and too small, BTW). After resetting this, without Sorting it's a +1 from my side (did not look at the code, though). --- As for Sorting: If a user does not click on the Configure button whic

D11993: Tweak column widths in tree view of file open/save dialogs

ngraham added a comment. In D11993#244077 , @broulik wrote: > The only downside this has is that you can no longer resize the column wider manually but then you might as well resize the window and actually //see// more :) Precisely! :)

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham added a comment. How's this? F5804311: Default appearance.png Better now? That's with a new fresh user account, so I think we can be sure it's using the default settings. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.o

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham retitled this revision from "Show view mode buttons and a sort menu in the open/save dialog's toolbar" to "Show view mode buttons in the open/save dialog's toolbar". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISI

D12112: Fix compiler warning under Clang

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Otherwise looks good. INLINE COMMENTS > kshareddatacache_p.h:170 > +__attribute__((always_inline, gnu_inline > +#if defined(Q_CC_GNU) && !defined(Q_CC_INTEL) && !defined(Q_CC_CLAN

D12077: Show view mode buttons and a sort menu in the open/save dialog's toolbar

rkflx added a comment. In D12077#244313 , @ngraham wrote: > So the size is remembered per app, but the settings are global. That's... interesting. Not only that, but they are remembered per screen size, which means you can have different

D12077: Show view mode buttons and a sort menu in the open/save dialog's toolbar

ngraham updated this revision to Diff 31884. ngraham added a comment. Remove sorting menu button; will do that in a separate commit REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12077?vs=31848&id=31884 BRANCH show-view-mode-toggles-on-open-save-dialog-toolb

D12077: Show view mode buttons and a sort menu in the open/save dialog's toolbar

ngraham added a comment. In D12077#244309 , @rkflx wrote: > In D12077#244307 , @ngraham wrote: > > > Actually, the file is `~/.config/kdeglobals`, and the pertinent information is in the under the

D11984: Android: Explicitly point at upstream documentation and deprecate duplicated concepts

This revision was automatically updated to reflect the committed changes. Closed by commit R240:4baac2ecae1f: Android: Explicitly point at upstream documentation and deprecate duplicated… (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kd

D12095: convert setDirLister to the new connect syntax

apol accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12095 To: jtamate, dfaure, #frameworks, apol Cc: apol, michaelh, ngraham, bruns

D12077: Show view mode buttons and a sort menu in the open/save dialog's toolbar

rkflx added a comment. In D12077#244307 , @ngraham wrote: > Actually, the file is `~/.config/kdeglobals`, and the pertinent information is in the under the `[KFileDialog Settings]` section. No, that's wrong: > cat ~/.config/katerc

D12077: Show view mode buttons and a sort menu in the open/save dialog's toolbar

ngraham added a comment. In D12077#244140 , @rkflx wrote: > I brought this up before, but let me repeat: It is of utmost importance to test with the default settings, i.e. default font size and default dialog size (remove `~/.config/kate*` for t

D11361: add a version containmentForScreen with activity

davidedmundson added a comment. > tried with an old plasmashell and is perfectly retrocompatible Please make sure that includes comprehensively trying adding and removing screens and activities. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D11361 REVISION DETAIL htt

D11361: add a version containmentForScreen with activity

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D11361 REVISION DETAIL https://phabricator.kde.org/D11361 To: mart, #plasma, davidedmundson Cc: davidedmundson, #frameworks, michaelh, ngraham

D12112: Fix compiler warning under Clang

kfunk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. kfunk requested review of this revision. REVISION SUMMARY Issue: In file included from .../kcoreaddons/src/lib/caching/kshareddatacache.cpp:25: .../kcoreadd

D10747: Implement zwp_linux_dmabuf_v1

fredrik added a comment. In D10747#237235 , @romangg wrote: > Regarding the "drm_fourcc.h" file: do we want to copy it in KWayland's code base or could we use the system one? It's only available on Linux? In this case could we include it as a du

D12028: taglibextractortest: Add test for files with empty metadata

michaelh edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12028 To: michaelh, mgallien, #baloo, #frameworks Cc: astippich, ashaposhnikov, michaelh, spoorun, ngraham, bruns, alexeymin

D12028: taglibextractortest: Add test for files with empty metadata

michaelh added a comment. In D12028#244243 , @mgallien wrote: > I need more time. I will try to look at it today. By the way, the stack concept seems very useful. Thanks Yes, it has its downsides though. It is easy to find oneself in a re

D12028: taglibextractortest: Add test for files with empty metadata

mgallien added a comment. I need more time. I will try to look at it today. By the way, the stack concept seems very useful. Thanks REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12028 To: michaelh, mgallien, #baloo, #frameworks Cc: astippich, ashaposhnikov,

D12029: taglibextractor: Fix empty genre bug

michaelh added a comment. In D12029#244237 , @mgallien wrote: > Sorry for the delay. Thanks No Problem. Thanks you. Have you noticed this is part of a stack? REPOSITORY R286 KFileMetaData BRANCH nometa-pass (branched from master) RE

D12029: taglibextractor: Fix empty genre bug

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Sorry for the delay. Thanks REPOSITORY R286 KFileMetaData BRANCH nometa-pass (branched from master) REVISION DETAIL https://phabricator.kde.org/D12029 To: michaelh, mgallien, #b

D12108: ffmpegextractor: Silence deprecation warnings

michaelh created this revision. michaelh added reviewers: Baloo, Frameworks. Restricted Application added projects: Frameworks, Baloo. michaelh requested review of this revision. TEST PLAN make REPOSITORY R286 KFileMetaData BRANCH ffmpeg_deprecated (branched from master) REVISION DETAIL

D12029: taglibextractor: Fix empty genre bug

michaelh added a comment. Ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12029 To: michaelh, mgallien, #baloo, #frameworks Cc: astippich, ashaposhnikov, michaelh, spoorun, ngraham, bruns, alexeymin

D10078: Add separate lib KF5::DBusRunner

davidedmundson added a comment. > I had promised to do that. I'm just incredibly slow on my promises. I'll get to it unless you beat me to it. That's now done. Unless you disagree with my opinion on config signalling, is there anything else we need? REPOSITORY R308 KRunner REVIS

D10078: Add separate lib KF5::DBusRunner

davidedmundson updated this revision to Diff 31871. davidedmundson added a comment. Rebase REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10078?vs=29364&id=31871 BRANCH dbus_runner REVISION DETAIL https://phabricator.kde.org/D10078 AFFECTED FILES K

KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.9 - Build # 19 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.9/19/ Project: Frameworks krunner kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 11 Apr 2018 10:50:25 + Build duration: 5 min 18 sec and counting JUnit Tests

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.9 - Build # 11 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.9/11/ Project: Frameworks krunner kf5-qt5 SUSEQt5.9 Date of build: Wed, 11 Apr 2018 10:50:25 + Build duration: 3 min 33 sec and counting JUnit Tests Name:

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.10 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/27/ Project: Frameworks krunner kf5-qt5 SUSEQt5.10 Date of build: Wed, 11 Apr 2018 10:50:25 + Build duration: 3 min 38 sec and counting JUnit Tests Nam

D11513: DBus runner servicename wildcard support

This revision was automatically updated to reflect the committed changes. Closed by commit R308:6114612970bc: DBus runner servicename wildcard support (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11513?vs=31865&id=31868#toc REPOSITORY R308 KRunner CHANG

D11513: DBus runner servicename wildcard support

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner BRANCH dbus_runner REVISION DETAIL https://phabricator.kde.org/D11513 To: davidedmundson, broulik Cc: broulik, #frameworks, michaelh, ngraham, bruns

D11513: DBus runner servicename wildcard support

davidedmundson updated this revision to Diff 31865. davidedmundson added a comment. add extra test file REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11513?vs=30077&id=31865 BRANCH dbus_runner REVISION DETAIL https://phabricator.kde.org/D11513 AFFEC

Re: Upcoming CI changes - service disruption

On Tue, Apr 10, 2018 at 10:42 PM, Ben Cooksley wrote: > Hi all, Hi everyone, > > In order to allow for two replacement physical build hosts to be > rotated in and the old ones to be decommissioned, i'm scheduling some > downtime for both the CI system and the Binary Factory tomorrow. > > Assumin

KDE CI: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.10 - Build # 19 - Aborted!

BUILD ABORTED Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20WindowsMSVCQt5.10/19/ Project: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.10 Date of build: Wed, 11 Apr 2018 08:39:12 + Build duration: 46 min and counting

D12082: Don't offer qml plugin as a link target

This revision was automatically updated to reflect the committed changes. Closed by commit R304:469db5c6934b: Don't offer qml plugin as a link target (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12082?vs=31790&id=31859 REVISION DETAI

KDE CI: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.10 - Build # 21 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.10/21/ Project: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.10 Date of build: Wed, 11 Apr 2018 09:05:44 + Build duration: 1 min 25 sec and counting CONS

D12077: Show view mode buttons and a sort menu in the open/save dialog's toolbar

rkflx added a comment. I brought this up before, but let me repeat: It is of utmost importance to test with the default settings, i.e. default font size and default dialog size (remove `~/.config/kate*` for that). Your current version does not look good, despite what you show in your screens

D12016: [ktexteditor] much faster positionFromCursor

jtamate marked an inline comment as done. jtamate added a comment. INLINE COMMENTS > mwolff wrote in kateviewaccessible.h:191 > I know the old code used int already, but shouldn't this better be a quint64 > as it's a file offset? All the methods of QAccesibeTextInrface

D12016: [ktexteditor] much faster positionFromCursor

jtamate updated this revision to Diff 31853. jtamate marked 5 inline comments as done. jtamate added a comment. Included more comments. Addressed style coding. In a callgrind log file with 1606189 lines, at the end of the file, pressing PageUp, using the code included at the end: o

D11610: clang-tidy: modernize-use-default-member-init run

This revision was automatically updated to reflect the committed changes. Closed by commit R39:40d801599549: clang-tidy: modernize-use-default-member-init run (authored by kfunk). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11610?vs=30305&id=31852 REVIS

D11984: Android: Explicitly point at upstream documentation and deprecate duplicated concepts

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Builds fine here, and moving closer to the Android cmake files makes sense IMHO. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D119