D11863: Add virt-manager icons

ndavis added a comment. In D11863#238210 , @ngraham wrote: > Looks good to me! Nice use of the Breeze icon style. @andreaska? Thank! If the other reviewer takes a long time to respond, do I still have to wait for their permission to land

Re: Changes to networkmanager-qt - breakage in plasma-workspace

Hi, On pátek 30. března 2018 15:39:59 CEST you wrote: > krop already fixed that > > On Thursday, March 29, 2018 6:21:41 PM EDT Ben Cooksley wrote: > > Hi Jan, > > > > It seems that as part of your recent changes to networkmanager-qt to > > increase the dependency to 1.0.0 you've made some other

D11838: Turn on line numbers by default

mludwig added a comment. In D11838#238728 , @dhaumann wrote: > Personally, I dislike the idea of passing options in createView for a very simple reason: we have document variables, .kateconfig files, settings on the UI, the command line, the Con

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 197 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/197/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 03 Apr 2018 03:29:30 + Build duration: 33 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/47/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Tue, 03 Apr 2018 03:29:30 + Build duration: 27 min and counting JUnit Tests Name: (root) Failed

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 7 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/7/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Tue, 03 Apr 2018 03:30:06 + Build duration: 26 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.9/11/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 Date of build: Tue, 03 Apr 2018 03:29:15 + Build duration: 26 min and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/34/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 03 Apr 2018 03:29:16 + Build duration: 23 min and counting JUnit T

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.9 - Build # 30 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/30/ Project: Frameworks purpose kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 03 Apr 2018 03:30:06 + Build duration: 22 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 176 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/176/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 03 Apr 2018 03:29:30 + Build duration: 21 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/39/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Tue, 03 Apr 2018 03:29:16 + Build duration: 20 min and counting JUnit Tests

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 57 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/57/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Tue, 03 Apr 2018 03:28:55 + Build duration: 10 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/26/ Project: Frameworks baloo kf5-qt5 SUSEQt5.9 Date of build: Tue, 03 Apr 2018 03:28:56 + Build duration: 9 min 37 sec and counting JUnit Tests Name: (ro

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

ngraham added a comment. Okay, unless I hear any impassioned pleas in favor of these entries, I will commit this patch on Saturday, April 7th. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11767 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg Cc: sharvey, elvisang

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/11/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Tue, 03 Apr 2018 01:30:25 + Build duration: 8 min 57 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/50/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 03 Apr 2018 01:30:25 + Build duration: 4 min 50 sec and counting JUnit Tes

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 67 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/67/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Tue, 03 Apr 2018 01:30:25 + Build duration: 4 min 41 sec and counting JUnit Tests

D11685: Implement single click on line number to select line of text

rkron updated this revision to Diff 31182. rkron added a comment. - Removed two unnecessary lines in patch. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11685?vs=30560&id=31182 BRANCH Bug372503 (branched from master) REVISION DETAIL https://phabr

D6313: Support Icon Scale from Icon naming specification 0.13

ngraham added a comment. In D6313#238605 , @acrouthamel wrote: > I think both of us missed this part at the bottom of @broulik's description: > > > This way you designers can now create dedicated 2x SVGs for those usecases, ie. we can have a

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

sharvey added a comment. +1. Don't use 'em, won't miss 'em. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11767 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg Cc: sharvey, elvisangelaccio, abetts, rizzitello, michaelh, ngraham

D11753: baloodb: Add clean command

bruns added inline comments. INLINE COMMENTS > michaelh wrote in databasesanitizer.cpp:316 > I've tried it. Sadly your suggestion does not work. With `fi = > filePathToStat(info.symlink.toLocal8Bit())` fi._st_dev is == 0 when the > symlink target does not exist. Hence it does tell me **why** th

D11888: Handle adjacent special characters correctly

bruns added inline comments. INLINE COMMENTS > michaelh wrote in advancedqueryparser.cpp:55 > // Parentheses delimit tokens, and are tokens by themselves Why choose a different wording here? Also, the important aspect here is the "end", which commits the current token to the list. > michaelh w

D11838: Turn on line numbers by default

aacid added a comment. In D11838#238742 , @ngraham wrote: > Since the controversy over this patch reveals that KTextEditor clients may have different needs, perhaps we should move towards allowing clients to have independent settings. I

D6376: Fix double delete crash during shutdown

aacid added a comment. I was able to half reproduce it for a while and came up with https://phabricator.kde.org/D11891 which I think is a bit less of a workaround than this code. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D6376 To: cullmann, #frameworks

D11891: Fix crashes in NotifyByAudio when closing applications

aacid created this revision. aacid added reviewers: Frameworks, cullmann. Restricted Application added a project: Frameworks. aacid requested review of this revision. REVISION SUMMARY We have a race between close() and onAudioFinished() that resulted in the same Phonon::MediaObject being added

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

elvisangelaccio added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11767 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg Cc: elvisangelaccio, abetts, rizzitello, michaelh, ngraham

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/25/ Project: Frameworks baloo kf5-qt5 SUSEQt5.9 Date of build: Mon, 02 Apr 2018 20:32:21 + Build duration: 5 min 8 sec and counting JUnit Tests Name: (roo

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/24/ Project: Frameworks baloo kf5-qt5 SUSEQt5.9 Date of build: Mon, 02 Apr 2018 20:27:44 + Build duration: 4 min 36 sec and counting JUnit Tests Name: (ro

D11838: Turn on line numbers by default

ngraham added a comment. Since the controversy over this patch reveals that KTextEditor clients may have different needs, perhaps we should move towards allowing clients to have independent settings. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11838 To: ngra

D11889: Do not retrieve document ID for skipped result entries

This revision was automatically updated to reflect the committed changes. Closed by commit R293:39515a707b73: Do not retrieve document ID for skipped result entries (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11889?vs=31168&id=31175 REVI

D11827: Do not retrieve mtime from database repeatedly when sorting

This revision was automatically updated to reflect the committed changes. bruns marked an inline comment as done. Closed by commit R293:890c0ff46ec9: Do not retrieve mtime from database repeatedly when sorting (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabr

D11889: Do not retrieve document ID for skipped result entries

michaelh accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH searchstore_speedup_2 REVISION DETAIL https://phabricator.kde.org/D11889 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexey

D11889: Do not retrieve document ID for skipped result entries

michaelh accepted this revision as: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11889 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11827: Do not retrieve mtime from database repeatedly when sorting

michaelh accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH searchstore_speedup_1 REVISION DETAIL https://phabricator.kde.org/D11827 To: bruns, #baloo, michaelh Cc: michaelh, #frameworks, ashaposhnikov, astippich, spoorun, ngraham, alexey

D11838: Turn on line numbers by default

dhaumann added a comment. As background: in KF5 world, the KTextEditor settings are shared among applications: enabling line numbers in Kate will enable line numbers in KDevelop, Kile, KWrite, ... Currently, there is no way to show line numbers except in Kile. I can understand that

D11888: Handle adjacent special characters correctly

michaelh requested changes to this revision. michaelh added a comment. This revision now requires changes to proceed. It would be great if you could add tests for `==`, `:=` and `((...)...)` to `autotests/unit/lib/advancedqueryparsertest.cpp` INLINE COMMENTS > advancedqueryparser.cpp:35 >

D10568: Handle privilege operation confirmation prompts in SlaveBase

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D10568 REVISION DETAIL https://phabricator.kde.org/D10568 To: chinmoyr, dfaure Cc: fvogt, #frameworks, michaelh, ngraham

D6313: Support Icon Scale from Icon naming specification 0.13

acrouthamel added a comment. In D6313#238697 , @rkflx wrote: > In D6313#238605 , @acrouthamel wrote: > > > @2x-compatible > > > How will this work for 4x / 2.7x / 1.4x / etc. scaling? Of course w

D6313: Support Icon Scale from Icon naming specification 0.13

rkflx added a comment. In D6313#238599 , @ngraham wrote: > ...Unless I'm misunderstanding something obvious, in which case, feel free to ignore my deluded ramblings! You might be mixing up two separate topics: - Optimizing rendering o

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.9/14/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 Date of build: Mon, 02 Apr 2018 18:26:53 + Build duration: 7 min 39 sec and counting JUnit Test

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 - Build # 31 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.9/31/ Project: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 02 Apr 2018 18:26:53 + Build duration: 5 min 53 sec and counting JUni

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 - Build # 13 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.9/13/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 Date of build: Mon, 02 Apr 2018 18:17:53 + Build duration: 2 min 40 sec and counting CONSOLE OU

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 - Build # 30 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.9/30/ Project: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 02 Apr 2018 18:17:53 + Build duration: 2 min 42 sec and counting CONS

D11846: KColorButtonTest: remove todo code

aacid closed this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D11846 To: aacid, cfeck Cc: #frameworks, michaelh, ngraham

D11683: Make it possible to request a plugin configuration module programatically

albertvaka accepted this revision. albertvaka added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kpluginselector.h:214 > + * Shows the configuration dialog for the plugin @p pluginId if it's > available > + */ > +void showConfiguration(const QSt

D11826: Simplify Term operator&& and ||

bruns added a comment. Fixed coding style REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11826 To: bruns, #baloo Cc: michaelh, #frameworks, ashaposhnikov, astippich, spoorun, ngraham, alexeymin

D11889: Do not retrieve document ID for skipped result entries

bruns updated this revision to Diff 31168. bruns added a comment. Fixed braces REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11889?vs=31163&id=31168 BRANCH searchstore_speedup_2 REVISION DETAIL https://phabricator.kde.org/D11889 AFFECTED FILES src/l

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/23/ Project: Frameworks baloo kf5-qt5 SUSEQt5.9 Date of build: Mon, 02 Apr 2018 17:49:47 + Build duration: 8 min 46 sec and counting JUnit Tests Name: (ro

D11825: Fix unitialized value warning, nullptr access

This revision was automatically updated to reflect the committed changes. Closed by commit R293:982dae74c023: Fix unitialized value warning, nullptr access (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11825?vs=31004&id=31165 REVISION DETA

D11889: Do not retrieve document ID for skipped result entries

bruns created this revision. bruns added reviewers: Baloo, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY Split forwarding to offset and retrieval into distinct s

D11827: Do not retrieve mtime from database repeatedly when sorting

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > michaelh wrote in searchstore.cpp:122 > Please use braces. Hunk omitted, as unrelated REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11827 To: bruns, #baloo, michaelh Cc: michaelh, #

D11827: Do not retrieve mtime from database repeatedly when sorting

bruns updated this revision to Diff 31162. bruns added a comment. Drop unrelated commit squashed by arc ... REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11827?vs=31007&id=31162 BRANCH searchstore_speedup_1 REVISION DETAIL https://phabricator.kde.org/D

D11888: Handle adjacent special characters correctly

bruns created this revision. bruns added reviewers: Baloo, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY The code handled sequences like '((' incorrectly, i.e. t

D11826: Simplify Term operator&& and ||

bruns marked 2 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11826 To: bruns, #baloo Cc: michaelh, #frameworks, ashaposhnikov, astippich, spoorun, ngraham, alexeymin

D11826: Simplify Term operator&& and ||

bruns updated this revision to Diff 31160. bruns added a comment. Fix coding style ({/} on single lines) REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11826?vs=31005&id=31160 BRANCH baloo_term_cleanup REVISION DETAIL https://phabricator.kde.org/D11826

D10568: Handle privilege operation confirmation prompts in SlaveBase

chinmoyr added inline comments. INLINE COMMENTS > dfaure wrote in slavebase.cpp:517 > BTW now that there are 5 duplicated lines below the //reset comment (in error > and finished), it would be worth extracting a reset function... I think it will be better to have a separate commit for that. >

D10568: Handle privilege operation confirmation prompts in SlaveBase

chinmoyr updated this revision to Diff 31156. chinmoyr marked 2 inline comments as done. chinmoyr added a comment. Addressed David's issues. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10568?vs=27316&id=31156 BRANCH arcpatch-D10568 REVISION DETAIL http

D6313: Support Icon Scale from Icon naming specification 0.13

acrouthamel added a comment. I think both of us missed this part at the bottom of @broulik's description: > This way you designers can now create dedicated 2x SVGs for those usecases, ie. we can have a 16px icon as well as a 16px@2x icon rather than it just taking the 32px icon which mig

D6313: Support Icon Scale from Icon naming specification 0.13

ngraham added a comment. In D6313#238595 , @acrouthamel wrote: > I'm just saying if you prefer colored over symbolic line art, that is something for #Breeze or #vdg

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

ngraham added a comment. Any more opinions on this patch? Is anyone particularly attached to these entries? Does anyone actually use them from the Places panel in the first place? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11767 To: ngraham, #dolphin, #gwenview, #f

D6313: Support Icon Scale from Icon naming specification 0.13

acrouthamel added a comment. I'm just saying if you prefer colored over symbolic line art, that is something for #Breeze or #vdg to work out. Not that they are really taking advantage of anything. The bug h

D6313: Support Icon Scale from Icon naming specification 0.13

ngraham added a comment. If Breeze has been taking advantage of a bug in our implementation of this spec, then we really need to fix Breeze before we fix the bug. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To: broulik, kde-frameworks-devel, #plasma, #v

D11838: Turn on line numbers by default

acrouthamel added a comment. I wouldn't mind seeing it on in KDevelop. From using it though, I really don't need them much in it. Especially since when debugging I can just click on an error and it will take me to the line. Kate would be nice to have it on. KWrite, probably not, since it

D6313: Support Icon Scale from Icon naming specification 0.13

acrouthamel added a comment. @ngraham and @hein, while I agree that in some instances I like the colored hi-res icons showing, this issue causes a mixture of icons to be displayed depending on the app. The examples here show a nice homogeneous selection of icons that change from A to B, so I

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 196 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/196/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 02 Apr 2018 13:20:25 + Build duration: 21 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/46/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Mon, 02 Apr 2018 13:20:25 + Build duration: 19 min and counting JUnit Tests Name: (root) Failed

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 175 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/175/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 02 Apr 2018 13:20:25 + Build duration: 10 min and counting JUnit Tests Name: (root)

D11569: Improve consistency of "Open With" UI by always showing top app inline

This revision was automatically updated to reflect the committed changes. Closed by commit R241:3f5c18e7afd8: Improve consistency of "Open With" UI by always showing top app inline (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11569?vs=3094

D11846: KColorButtonTest: remove todo code

cfeck accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D11846 To: aacid, cfeck Cc: #frameworks, michaelh, ngraham

D11838: Turn on line numbers by default

mludwig added a comment. In D11838#238269 , @ngraham wrote: > So what's our path forward here? Is there a way to only turn on line numbers for Kate itself, and not for the katepart? One suggestion would be to extend the method for creatin

D11882: extractortest: Use built executable instead of installed

michaelh created this revision. michaelh added reviewers: elvisangelaccio, Baloo, Frameworks. Restricted Application added a project: Baloo. michaelh requested review of this revision. REPOSITORY R824 Baloo Widgets BRANCH testexe (branched from master) REVISION DETAIL https://phabricator.k

D11880: Add firewalld icons

ndavis added a comment. firewall-applet-panic in use F5781583: Screenshot_20180402_041120.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg Cc: #frameworks, michaelh, ngraham

D11880: Add firewalld icons

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg Cc: #frameworks, michaelh, ngraham

D11880: Add firewalld icons

ndavis added a comment. Screenshot of the icons in use F5781576: Screenshot_20180402_035312.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg Cc: #frameworks, michaelh, ngraham

D11880: Add firewalld icons

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg Cc: #frameworks, michaelh, ngraham

D11880: Add firewalld icons

ndavis edited the summary of this revision. ndavis added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg Cc: #frameworks, michaelh, ngraham

D11880: Add firewalld icons

ndavis added a comment. I did not mean to post this and I have no idea how to delete it REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis Cc: #frameworks, michaelh, ngraham

D11880: Add firewalld icons

ndavis created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH firewalld_icons (branched from master) REVISION DETAIL https://phabricator.