D11838: Turn on line numbers by default

mludwig requested changes to this revision. mludwig added a comment. This revision now requires changes to proceed. I don't think that this is ok for Kile. KatePart is an editor component that needs to fit many different contexts. For Kile, I don't see a need to have line numbers switched

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 174 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/174/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 01 Apr 2018 06:06:09 + Build duration: 21 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/45/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sun, 01 Apr 2018 06:06:09 + Build duration: 17 min and counting JUnit Tests Name: (root) Failed

D11838: Turn on line numbers by default

dhaumann added a subscriber: kfunk. dhaumann added a comment. This looks good from my side. @kfunk is this ok also for KDevelop? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11838 To: ngraham, #kate, #ktexteditor, dhaumann Cc: kfunk, dhaumann, #frameworks,

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 195 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/195/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 01 Apr 2018 06:06:09 + Build duration: 14 min and counting JUnit Tests Name: (root) Fai

D11851: Add syntax highlighting for Logcat

nibags edited the summary of this revision. nibags added a reviewer: Framework: Syntax Highlighting. nibags added a project: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D11851 To: nibags, #framework_syntax_highlighting Cc: #

D11851: Add syntax highlighting for Logcat

nibags created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. nibags requested review of this revision. REVISION SUMMARY Add the XML file for Android Logcat. This syntax highlighting file supports all log formats, in

D11846: KColorButtonTest: remove todo code

aacid created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. aacid requested review of this revision. REVISION SUMMARY It is not our duty to test QColorDialog REPOSITORY R236 KWidgetsAddons BRANCH master REVISION D

D11838: Turn on line numbers by default

ngraham updated this revision to Diff 31064. ngraham added a comment. Don't change things that don't need changing REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11838?vs=31047&id=31064 BRANCH show-line-numbers-by-default (branched from master) REVIS

D11838: Turn on line numbers by default

ngraham marked 3 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11838 To: ngraham, #kate, #ktexteditor, dhaumann Cc: dhaumann, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars

D11838: Turn on line numbers by default

dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. Not yet good enough, let's have another revision. BTW, I am fine with this change, since nowadays screens are typically wider, so horizontal space is usually there. INLIN

D11685: Implement single click on line number to select line of text

ngraham added a comment. +1 behaviorally! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann Cc: richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh, kevinapavew, demsking, cullmann,

D11822: Make the word/char count a global preference

ngraham added a comment. Works for me, and this seems more user-friendly than having to manually toggle it for every document. Also this change makes that huge View many a tiny bit smaller and less intimidating. +1. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/

D11838: Turn on line numbers by default

ngraham added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11838 To: ngraham, #kate, #ktexteditor Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D11838: Turn on line numbers by default

ngraham created this revision. ngraham added a reviewer: Kate. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. ngraham requested review of this revision. REVISION SUMMARY Kate is an advanced, programmer-and-source-code-centric text

D11822: Make the word/char count a global preference

ngraham edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11822 To: wsdfhjxc, #ktexteditor, #kate Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham added a comment. Good catch @dfaure, the test does indeed fail after this is patch deployed. I've submitted a fix for the failing test: D11836 , and marked this as a dependency. If and when D11836 is accepted, c

D11569: Improve consistency of "Open With" UI by always showing top app inline

ngraham added a dependent revision: D11836: Fix test failure when D11569 lands. REPOSITORY R241 KIO BRANCH open-with-usability (branched from master) REVISION DETAIL https://phabricator.kde.org/D11569 To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio, abetts Cc: mmu

D11753: baloodb: Add clean command

michaelh marked an inline comment as done. michaelh added inline comments. INLINE COMMENTS > bruns wrote in databasesanitizer.cpp:316 > I think it is better to use > QT_FSTAT(info.symlink.toLocal8Bit().constData(), ...) here, avoids lots of > calls to the database, and guarantees more consistent

D11753: baloodb: Add clean command

michaelh updated this revision to Diff 31033. michaelh added a comment. - Apply suggested change REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11753?vs=30737&id=31033 BRANCH sanitize-clean (branched from master) REVISION DETAIL https://phabricator.kde.

D11753: baloodb: Add clean command

michaelh added inline comments. INLINE COMMENTS > bruns wrote in databasesanitizer.cpp:333 > why not just make the removeDocument transaction above depend on dryRun? > removeDocument is expensive ... I did that before, but decided on `--dry-run` to simulate the process as close as possible. A

D11734: Have KIO build for Android

aacid added a comment. In D11734#236186 , @apol wrote: > In D11734#235886 , @aacid wrote: > > > Would it make sense do document the classes/methods that won't work in Android? > > > I was about

D11529: Balooctl: Deindex unfound files with check command.

michaelh added a comment. I'm still not convinced this is a sustainable approach. 1. The user has no control over the process 2. Symlinks pointing to unmounted devices will be removed 3. Database management is partially exposed on dbus 4. Depending on user's setup this covers only ~8

D11826: Simplify Term operator&& and ||

michaelh added a comment. This part of baloo is still unknown territory to me. Please be patient until I understood what is going on here. If you want to, ignore my inline comments. Then this file will violate the coding style rules at least consistently. INLINE COMMENTS > term.cpp:121 >

D11827: Do not retrieve mtime from database repeatedly when sorting

michaelh requested changes to this revision. michaelh added a comment. This revision now requires changes to proceed. Specially with `--limit` this is a considerable speed gain. Thank you. INLINE COMMENTS > searchstore.cpp:122 > > -while (it->next() && (limit < 0 || i < end)) { > +

D11825: Fix unitialized value warning, nullptr access

michaelh accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH fix_warnings REVISION DETAIL https://phabricator.kde.org/D11825 To: bruns, michaelh, #baloo Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin