D10857: Change qSort to std::sort in simplifiedUrlList

jtamate added a comment. In D10857#214607 , @dfaure wrote: > I'm not opposed to the idea, but measuring CPU usage is a rather misleading indicator. What if it takes 10 times longer, because it's progressing much more slowly? ;) > > Please at

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

dmitrio abandoned this revision. dmitrio added a comment. In D10663#213898 , @dfaure wrote: > I don't see any provision for the case I mentioned, where the destination file already exists, and should therefore NOT be deleted? In fact, thi

D10870: [PackageUrlInterceptor] Don't rewrite "inline"

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10870 To: broulik, #plasma, hein Cc: #frameworks, michaelh

D10863: [KRecentDocument] Use QGuiApplication::desktopFileName()

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10863 To: broulik, #frameworks, #plasma, hein, aleksejshilin Cc: michaelh

KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.7 - Build # 17 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.7/17/ Project: Frameworks kxmlgui kf5-qt5 SUSEQt5.7 Date of build: Mon, 26 Feb 2018 22:02:06 + Build duration: 1 min 58 sec and counting JUnit Tests Name:

D10803: handle more tags in taglibextractor

astippich planned changes to this revision. astippich added a comment. In D10803#213783 , @michaelh wrote: > In D10803#213767 , @astippich wrote: > > > I don't know dolphin works, but given how KFile

D10803: handle more tags in taglibextractor

mgallien added a comment. I have created T8079 to work on baloo database update when extractors are modified and returned different data. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D10803 To: astippich, mgallien Cc: dfau

D10694: epubextractor: Handle multiple subjects better

mgallien added a comment. I have created T8079 to work on baloo database update when extractors are modified and returned different data. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D10694 To: michaelh, mgallien, dfaure C

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 146 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/146/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Mon, 26 Feb 2018 19:23:10 + Build duration: 26 min and counting JUnit Tests Name: (root) Faile

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 148 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/148/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 26 Feb 2018 19:23:10 + Build duration: 8 min 30 sec and counting JUnit Tests Name: (roo

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 128 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/128/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 26 Feb 2018 19:23:10 + Build duration: 7 min 21 sec and counting JUnit Tests Name:

D10537: Convert from old connect syntax to new one

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ec296c0ff511: Convert from old connect syntax to new one (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10537?vs=28102&id=28136 REVISION DETAIL

D10826: Introduce DocumentId class

svuorela added inline comments. INLINE COMMENTS > anthonyfieroni wrote in documentid.h:51-52 > Make a d poniter in exported class. it depends on why it is exported. If it is exported just for unit test (and the header file not installed), then we don't need to have the mental and code wise ove

D10857: Change qSort to std::sort in simplifiedUrlList

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I'm not opposed to the idea, but measuring CPU usage is a rather misleading indicator. What if it takes 10 times longer, because it's progressing much more slowly? ;) Please

KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.7 - Build # 16 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.7/16/ Project: Frameworks kxmlgui kf5-qt5 SUSEQt5.7 Date of build: Mon, 26 Feb 2018 18:38:20 + Build duration: 2 min 58 sec and counting CONSOLE OUTPUT [..

D10757: Reset QLocale internals when we have a custom app language

This revision was automatically updated to reflect the committed changes. Closed by commit R263:8361ddef0867: Reset QLocale internals when we have a custom app language (authored by aacid). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10757?vs=28076&id=28132

D10873: Initialize value

This revision was automatically updated to reflect the committed changes. Closed by commit R39:75f86f6e54f7: Initialize value (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10873?vs=28127&id=28130#toc REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://ph

D10873: Initialize value

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Default is 1, in readConfig, given that should overwrite it, leave it 0 or change it to 1 if you like. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricat

D10716: handle wrong password when using sudo which asks for another password

sitter added a comment. In D10716#212174 , @jriddell wrote: > I fear that creating a stub replacement wouldn't be necessarily a reliable recreation. I am not sure what you mean. If you create a stub from what you observe right now then t

D10873: Initialize value

apol created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. apol requested review of this revision. REVISION SUMMARY At the moment it wasn't. I'm not sure what the right value is for starters, pointers would be wel

D10856: Make tests compile, except one

michaelh planned changes to this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10856 To: michaelh, adridg, #baloo, #frameworks Cc: michaelh

D10829: Use DocumentId class

michaelh planned changes to this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10829 To: michaelh, adridg, #baloo, #frameworks Cc: alexeymin, ashaposhnikov, michaelh, spoorun, nicolasfella

D10857: Change qSort to std::sort in simplifiedUrlList

markg added a comment. +1, also for what @apol said. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10857 To: jtamate, #frameworks, dfaure Cc: markg, apol, michaelh

D10537: Convert from old connect syntax to new one

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10537 To: jtamate, #frameworks, dfaure Cc: broulik, michaelh

D10719: Highlighting for OpenSCAD

julianstirling added a comment. `git format-patch HEAD^^` creates two separate patch files... REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10719 To: julianstirling, dhaumann Cc: dhaumann, ngraham, #frameworks, michaelh

D10870: [PackageUrlInterceptor] Don't rewrite "inline"

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. broulik requested review of this revision. REVISION SUMMARY When omitting the third "location" argument of `Qt.createQmlObje

D10863: [KRecentDocument] Use QGuiApplication::desktopFileName()

broulik created this revision. broulik added reviewers: Frameworks, Plasma, hein, aleksejshilin. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY This ensures the application stored in recent documents matches the application's serv

D10719: Highlighting for OpenSCAD

ngraham added a comment. Yeah, all commits need to be in a single patch here.Try doing `git format-patch HEAD^^`, which will include the last two commits. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10719 To: julianstirling, dhaumann Cc: dhaumann, ng

D10719: Highlighting for OpenSCAD

julianstirling added a comment. Oh, I was following the guide here https://community.kde.org/Infrastructure/Github_Mirror So everything I uploaded was a git format-patch, which makes a patch file for each commit I made. I shall look into arc when I get a chance. REPOSITORY R216 Syntax Hi

D10860: Do not allow to configure separator actions via context menu

This revision was automatically updated to reflect the committed changes. Closed by commit R263:67c59d7bb56e: Do not allow to configure separator actions via context menu (authored by mwolff). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10860?vs=28108&id=28110#toc REPOSITORY R263 KX

D10860: Do not allow to configure separator actions via context menu

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D10860 To: mwolff, dfaure, broulik Cc: broulik, #frameworks, michaelh

D10860: Do not allow to configure separator actions via context menu

mwolff updated this revision to Diff 28108. mwolff added a comment. rebase REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10860?vs=28106&id=28108 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10860 AFFECTED FILES src/kmenumenuhandler_p

D9675: Don't show context menu menu if right-clicking outside

This revision was automatically updated to reflect the committed changes. Closed by commit R263:5381b8b4b76c: Don't show context menu menu if right-clicking outside (authored by broulik). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9675?vs=24760&id=28107 R

D10860: Do not allow to configure separator actions via context menu

broulik added a comment. +1, note that action can be null REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D10860 To: mwolff, dfaure Cc: broulik, #frameworks, michaelh

D9675: Don't show context menu menu if right-clicking outside

mwolff accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D9675 To: broulik, #frameworks, dfaure, mwolff Cc: elvisangelaccio, wbauer, michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 77 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/77/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Mon, 26 Feb 2018 13:47:04 + Build duration: 7 min 42 sec and counting JUnit

D10860: Do not allow to configure separator actions via context menu

mwolff created this revision. mwolff added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. mwolff requested review of this revision. REVISION SUMMARY It's not useful to add shortcuts for separators, nor to add them

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 74 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/74/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 26 Feb 2018 13:47:04 + Build duration: 5 min 15 sec and counting JUn

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 50 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/50/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 26 Feb 2018 13:47:04 + Build duration: 1 min 16 sec and counting

D10857: Change qSort to std::sort in simplifiedUrlList

apol added a comment. +1 If there's 11, we better change them all at once? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10857 To: jtamate, #frameworks, dfaure Cc: apol, michaelh

D10537: Convert from old connect syntax to new one

jtamate updated this revision to Diff 28102. jtamate added a comment. Fixed David comments. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10537?vs=27238&id=28102 REVISION DETAIL https://phabricator.kde.org/D10537 AFFECTED FILES src/core/listjob.cpp src

D10857: Change qSort to std::sort in simplifiedUrlList

jtamate created this revision. jtamate added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY qSort is depecreated in Qt5. But qSort is also quite slow compared to std::sort. There are 11 more us

D10848: Templates: consistent naming, fix translation catalog names & more

kossebau added inline comments. INLINE COMMENTS > apol wrote in metadata.desktop:88 > I'm not sure, if a 3rd party makes a plasmoid they would call it otherwise. > Are we assuming these templates are only for KDE? Ideally the kapptemplate system would have support for an organization domain pa

D10856: Make tests compile, except one

michaelh added inline comments. INLINE COMMENTS > iohandlertest.cpp:32 > +//FIXME: Does not link with DocId in ../iohandler.h. Why? > #include "../iohandler.h" > + Error is: [ 34%] Linking CXX executable ../../../../bin/extractorIOTest CMakeFiles/extractorIOTest.dir/iohandlertest.cpp.o

D10851: autotests: Introduce alias DocId

michaelh added a comment. This will be abandoned in favor of D10856 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10851 To: michaelh, adridg, #baloo, #frameworks Cc: ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D10856: Make tests compile, except one

michaelh added a dependency: D10829: Use DocumentId class. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10856 To: michaelh, adridg, #baloo, #frameworks Cc: michaelh

D10829: Use DocumentId class

michaelh added a dependent revision: D10856: Make tests compile, except one. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10829 To: michaelh, adridg, #baloo, #frameworks Cc: alexeymin, ashaposhnikov, michaelh, spoorun, nicolasfella

D10856: Make tests compile, except one

michaelh created this revision. michaelh added reviewers: adridg, Baloo, Frameworks. Restricted Application added a project: Frameworks. michaelh requested review of this revision. TEST PLAN make test REPOSITORY R293 Baloo BRANCH use-class-tests-compile (branched from flexible-docid) REVI

D10848: Templates: consistent naming, fix translation catalog names & more

apol added inline comments. INLINE COMMENTS > metadata.desktop:88 > X-KDE-PluginInfo-Email=%{EMAIL} > -X-KDE-PluginInfo-Name=%{APPNAMELC} > +X-KDE-PluginInfo-Name=org.kde.plasma.%{APPNAMELC} > X-KDE-PluginInfo-Version=1.0 I'm not sure, if a 3rd party makes a plasmoid they would call it otherwi

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

ivan added a comment. The fix needs to be a bit more complex. We can not really rely on the user to fix the database. The current plan is to have kamd backup the important parts of the database from time to time, and to recreate the database when needed. I'll see whether I can roll

D10537: Convert from old connect syntax to new one

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > listjob.cpp:140 > +QObject::connect(job, &ListJob::entries, q, > +[this](KIO::Job *job,const KIO::UDSEntryList &lis

D10235: [server] Add support for the frame semantics of Pointer version 5

bcooksley edited projects, added Plasma; removed Plasma on Wayland. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. REPOSITORY R127 KWayland BRANCH server-pointer-frame-semantics REVISION DETAIL https://phabricator.kde.org/D10235 To: graesslin, #kwin, #pla

D10826: Introduce DocumentId class

anthonyfieroni added inline comments. INLINE COMMENTS > documentid.h:51-52 > +private: > +DeviceId m_device; > +Inode m_inode; > +}; Make a d poniter in exported class. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10826 To: michaelh, adridg, #baloo, #framewor

D10826: Introduce DocumentId class

michaelh added a comment. I have made two errors: 1. Forgot to submit the adapted tests 2. An error in reasoning: I have based this and D10829 on a branch with the adapted tests . As long as the changes are expected to be transparent it is much bet

D10826: Introduce DocumentId class

michaelh updated this revision to Diff 28090. michaelh added a comment. - Revert merge with aliases-test REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10826?vs=28005&id=28090 BRANCH flex-class (branched from flexible-docid) REVISION DETAIL https://phab

D10825: Introduce aliases DocId, DeviceId and Inode

michaelh added a dependent revision: D10851: autotests: Introduce alias DocId. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10825 To: michaelh, adridg, #baloo, #frameworks Cc: ngraham, alexeymin, ashaposhnikov, michaelh, spoorun, nicolasfella

D10851: autotests: Introduce alias DocId

michaelh retitled this revision from "autotests: Introduce aliases DocId, DeviceId and Inode" to "autotests: Introduce alias DocId". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10851 To: michaelh, adridg, #baloo, #frameworks Cc: ashaposhnikov, michaelh, spoorun, nicol

D10851: autotests: Introduce alias DocId

michaelh added a dependency: D10825: Introduce aliases DocId, DeviceId and Inode. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10851 To: michaelh, adridg, #baloo, #frameworks Cc: ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D10851: autotests: Introduce aliases DocId, DeviceId and Inode

michaelh added reviewers: adridg, Baloo, Frameworks. michaelh added a project: Baloo. michaelh removed a subscriber: Frameworks. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10851 To: michaelh, adridg, #baloo, #frameworks Cc: ashaposhnikov, michaelh, spoorun, nicolasfel