D10807: fileindexerconfig: Exclude Vaults by default

michaelh added a comment. I was thinking in the same direction. When the mountpoint of a vault is changed (or new) a warning message about baloo's activity should be displayed. The message should be displayed regardless of baloo's enabled state. There's plenty of space for that in the dialog

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/47/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Feb 2018 04:27:59 + Build duration: 1 hr 6 min and counting J

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 127 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/127/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Feb 2018 04:27:26 + Build duration: 56 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/24/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Feb 2018 04:27:14 + Build duration: 36 min and counting JUnit T

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 145 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/145/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Sun, 25 Feb 2018 04:27:26 + Build duration: 36 min and counting JUnit Tests Name: (root) Faile

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 74 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/74/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Sun, 25 Feb 2018 04:27:59 + Build duration: 21 min and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 147 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/147/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 25 Feb 2018 04:27:26 + Build duration: 20 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 71 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/71/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Sun, 25 Feb 2018 04:27:59 + Build duration: 14 min and counting JUnit Tes

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 - Build # 30 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/30/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 Date of build: Sun, 25 Feb 2018 04:27:14 + Build duration: 14 min and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/39/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 25 Feb 2018 02:19:38 + Build duration: 41 min and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/50/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Sun, 25 Feb 2018 02:19:38 + Build duration: 8 min 24 sec and counting JUnit Tests

D10719: Highlighting for OpenSCAD

julianstirling planned changes to this revision. julianstirling added a comment. I am confused. If I look in the commit history of this revision there are two diffs, the first commit, and then the subsequent commit. Can phabricator not handle both of them sequentially? REPOSITORY R216 Synt

D9211: Iterate over initializer_lists to avoid mem allocs

dhaumann updated this revision to Diff 27963. dhaumann added a comment. - Add and use contains() - Use QLaint1String REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9211?vs=23526&id=27963 BRANCH AvoidAllocs (branched from master) REVISION DETAIL h

D10235: [server] Add support for the frame semantics of Pointer version 5

romangg added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. Shouldn't the sendFrame event sent by the compositor explicitly? The way it's currently send after each event compositors are not able to group these. REPOSITORY R127 KWayland REVISION

D7864: Basic support for PHP and Python fenced code blocks in Markdown

This revision was automatically updated to reflect the committed changes. Closed by commit R216:4f7e020e332d: Basic support for PHP and Python fenced code blocks in Markdown (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D786

D7864: Basic support for PHP and Python fenced code blocks in Markdown

dhaumann added a comment. @vkrause Do you already have something in mind, when you say this does not scale? ... REPOSITORY R216 Syntax Highlighting BRANCH markdown-code-blocks (branched from master) REVISION DETAIL https://phabricator.kde.org/D7864 To: gszymaszek, #framework_syntax_h

D10807: fileindexerconfig: Exclude Vaults by default

alexeymin added a comment. Maybe when a new vault is configured, it should add itself to baloo exceptions. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham, #plasma Cc: alexeymin, plasma-devel, ivan, nicolasfella, ashapo

D10646: Support case-insensitive WordDetect

This revision was automatically updated to reflect the committed changes. Closed by commit R216:933eecb13d9a: Support case-insensitive WordDetect (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10646?vs=27496&id=27959 REVISI

D10646: Support case-insensitive WordDetect

dhaumann added a comment. Ok, good catch. Given the uninitialized variables in the other classes, this is good. Will integrate. REPOSITORY R216 Syntax Highlighting BRANCH word_insensitive REVISION DETAIL https://phabricator.kde.org/D10646 To: jpoelen, dhaumann Cc: dhaumann, #framewor

D10174: Add syntax highlighting for SELinux CIL Policies & File Contexts

This revision was automatically updated to reflect the committed changes. Closed by commit R216:6132c15c0d44: Add syntax highlighting for SELinux CIL Policies & File Contexts (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10174?vs=26240&id=27958#toc REPOSITORY R

D10174: Add syntax highlighting for SELinux CIL Policies & File Contexts

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I'll remove the selColor attributes, since these will not work with dark color schemes. Similar, I will remove all underline, italic, and bold attributes where not needed by default.

D10595: Adding ctp file extension to the PHP syntax highlighting

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Sounds good to me. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10595 To: martonmiklos, #framework_syntax_highlighting, dhaumann Cc: dhaumann, #

D10595: Adding ctp file extension to the PHP syntax highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit R216:1b02007242ec: Adding ctp file extension to the PHP syntax highlighting (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10595?vs=2

D10783: Yacc/Bison: Fix the $ symbol and update syntax for Bison

dhaumann closed this revision. dhaumann added a comment. Done, see commit https://commits.kde.org/syntax-highlighting/f5a32272d26e3b46d4c4201a5d9531de8f23867a REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10783 To: nibags, #framework_syntax_highlightin

D10783: Yacc/Bison: Fix the $ symbol and update syntax for Bison

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me, will integrate. REPOSITORY R216 Syntax Highlighting BRANCH update-yacc-bison (branched from master) REVISION DETAIL https://phabricator.kde.org/D10783 To: niba

D10719: Highlighting for OpenSCAD

dhaumann added a comment. @julianstirling Can you profile the full xml file again? This patch does not contain the .xml file anymore, so in the current form I cannot commit this as is. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10719 To: julianstir

D10807: fileindexerconfig: Exclude Vaults by default

michaelh added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham, #plasma Cc: plasma-devel, ivan, nic

D10807: fileindexerconfig: Exclude Vaults by default

michaelh added a comment. This is not a viable approach. Any vaults created after baloo is configured may be indexed (unless they are inside ~/Vaults, of course). For the near future I see no other way to exclude vaults from being indexed other than this one. :-( REPOSITORY R293 Baloo

D10807: fileindexerconfig: Exclude Vaults by default

michaelh added a comment. In D10807#212953 , @nicolasfella wrote: > I honestly don't know. > > @ivan any idea? Just found it. `~/config/plasmavaultrc` REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To:

D10807: fileindexerconfig: Exclude Vaults by default

nicolasfella added a subscriber: ivan. nicolasfella added a comment. I honestly don't know. @ivan any idea? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham Cc: ivan, nicolasfella, ashaposhnikov, michaelh, kmorwinski

D10142: [server] Properly handle the situation when the DataSource for a drag gets destroyed

romangg accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. REPOSITORY R127 KWayland BRANCH cancel-drag-on-datasource-destroy REVISION DETAIL https://phabricator.kde.org/D10142 To: graess

D10807: fileindexerconfig: Exclude Vaults by default

michaelh added a comment. In D10807#212948 , @nicolasfella wrote: > You have to hit next a couple of times I saw it. Ok, now what? How to find out where the vaults are? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde

D10807: fileindexerconfig: Exclude Vaults by default

nicolasfella added a comment. You have to hit next a couple of times REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham Cc: nicolasfella, ashaposhnikov, michaelh, kmorwinski, spoorun, alexeymin

D10807: fileindexerconfig: Exclude Vaults by default

michaelh added a comment. F5728284: image.png REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham Cc: nicolasfella, ashaposhnikov, michaelh, kmorwinski, spoorun, alexeymin

D10807: fileindexerconfig: Exclude Vaults by default

nicolasfella added a comment. When creating a Vault you can choose any location for it. ~/Vaults is just the default REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham Cc: nicolasfella, ashaposhnikov, michaelh, kmorwinski,

D10807: fileindexerconfig: Exclude Vaults by default

nicolasfella added a comment. F5728282: Screenshot_20180224_212932.png REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham Cc: nicolasfella, ashaposhnikov, michaelh, kmorwinski, spooru

D10807: fileindexerconfig: Exclude Vaults by default

michaelh added a comment. In D10807#212942 , @nicolasfella wrote: > Vault can also be mounted in other directories than ~/Vaults How is that done? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michael

D10807: fileindexerconfig: Exclude Vaults by default

nicolasfella added a comment. Vault can also be mounted in other directories than ~/Vaults REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham Cc: nicolasfella, ashaposhnikov, michaelh, kmorwinski, spoorun, alexeymin

D10810: fileindexerconfigtest: Add vault test

michaelh edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10810 To: michaelh, #baloo, #frameworks, ngraham Cc: ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin

D10810: fileindexerconfigtest: Add vault test

michaelh created this revision. michaelh added reviewers: Baloo, Frameworks, ngraham. michaelh added a project: Baloo. Restricted Application added a project: Frameworks. michaelh requested review of this revision. REPOSITORY R293 Baloo BRANCH vault-test (branched from master) REVISION DETAI

D10809: autotests: Refactor fileindexerconfigtest

michaelh added a dependent revision: D10810: fileindexerconfigtest: Add vault test. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10809 To: michaelh, #baloo, #frameworks, ngraham Cc: ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin

D10810: fileindexerconfigtest: Add vault test

michaelh added a dependency: D10809: autotests: Refactor fileindexerconfigtest. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10810 To: michaelh, #baloo, #frameworks, ngraham Cc: ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin

D10081: Don't assert if used incorrectly from dbus

romangg accepted this revision. REPOSITORY R268 KGlobalAccel BRANCH dont-assert-on-dbus-misusage REVISION DETAIL https://phabricator.kde.org/D10081 To: graesslin, #frameworks, apol, romangg Cc: romangg, michaelh, kmorwinski

D10809: autotests: Refactor fileindexerconfigtest

michaelh created this revision. michaelh added reviewers: Baloo, Frameworks, ngraham. michaelh added a project: Baloo. Restricted Application added a project: Frameworks. michaelh requested review of this revision. REVISION SUMMARY Make use of QTest data REPOSITORY R293 Baloo BRANCH refact

D10807: fileindexerconfig: Exclude Vaults by default

michaelh created this revision. michaelh added reviewers: Baloo, Frameworks, ngraham. michaelh added projects: Baloo, Frameworks. michaelh requested review of this revision. REVISION SUMMARY Quick bug fix BUG:390830 TEST PLAN (upcoming) make test REPOSITORY R293 Baloo BRANCH exclud

D10312: FileUndoManager: don't delete non-existing local files

elvisangelaccio updated this revision to Diff 27940. elvisangelaccio added a comment. - Improved unit test - Replaced slotUnlock() with slotPop() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10312?vs=26542&id=27940 BRANCH undo-deleted-file (branched from

D10803: handle more tags in taglibextractor

astippich added a comment. First of all, please review carefully for ABI compatibility, I do not know what to watch for that. So I decided to walk into the minefield that tags are. Everyone implements it differently. I've implemented some tags that seem to be supported across a wide ran

D10803: handle more tags in taglibextractor

astippich created this revision. astippich added a reviewer: mgallien. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY adds the ability to read more tags through taglib when s

D10702: Always use a job to delete files to avoid freezing process waiting on IO

markg added a comment. In D10702#212753 , @meven wrote: > In D10702#211236 , @markg wrote: > > > While this might give you the expected result, it feels like a workaround. > > > > I'm assuming the

D8532: [WIP] Restrict file extractor with Seccomp

davidk added a comment. Sorry for the late reply and the slow process in general. Reallife keeps me busy... In D8532#198408 , @detlefe wrote: > A whitelist, even if it is broad, would be desirable to reduce the attack surface of the kernel,

D10702: Always use a job to delete files to avoid freezing process waiting on IO

meven added a comment. In D10702#211236 , @markg wrote: > While this might give you the expected result, it feels like a workaround. > > I'm assuming the fast path is there for a reason and is really substantially faster then going through th

D10671: [UDisks] Fix auto-mount regression

ngraham added a comment. Looks like not. Landing it. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10671 To: dkhlestkov, #frameworks, broulik Cc: ngraham, sefaeyeoglu, rikmills, #frameworks, michaelh

D10671: [UDisks] Fix auto-mount regression

This revision was automatically updated to reflect the committed changes. Closed by commit R245:e94ba0619477: [UDisks] Fix auto-mount regression (authored by dkhlestkov, committed by ngraham). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10671?vs=27579&id=2791

D10719: Highlighting for OpenSCAD

ngraham added a comment. Oops, looks like your last update replaced the original change. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10719 To: julianstirling, dhaumann Cc: dhaumann, ngraham, #frameworks, michaelh

D10631: Update links to dependencies, and mark Android as officially supported

This revision was automatically updated to reflect the committed changes. Closed by commit R280:7e1fd64c1166: Update links to dependencies, and mark Android as officially supported (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10631?vs=2

D10603: Make DMTX dependency optional

This revision was automatically updated to reflect the committed changes. Closed by commit R280:361ca88e13c5: Make DMTX dependency optional (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10603?vs=27458&id=27912 REVISION DETAIL https://

D10433: Add QML support for Prison

This revision was automatically updated to reflect the committed changes. Closed by commit R280:6fb9f3f5b21f: Add QML support for Prison (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10433?vs=26950&id=27911 REVISION DETAIL https://pha

D10433: Add QML support for Prison

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D10433 To: vkrause, #frameworks, svuorela Cc: broulik, davidedmundson, michaelh

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

jtamate updated this revision to Diff 27909. jtamate edited the test plan for this revision. jtamate added a comment. The first patch had 12 unit test failing. This one has 2 1/2 unit test failing. I've changed findByUrl, instead of removing the item from the list, tell the item to ref

D10741: Use Locale::name() instead of Locale::bcp47Name()

This revision was automatically updated to reflect the committed changes. Closed by commit R246:49192654fd24: Use Locale::name() instead of Locale::bcp47Name() (authored by vonreth). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10741?vs=27774&id=27907 REVISI

D10757: Reset QLocale internals when we have a custom app language

lueck added a comment. In D10757#212405 , @aacid wrote: > @lueck can you try this new version *without* https://phabricator.kde.org/D10758 and https://phabricator.kde.org/D10759 ? This should be enough to get QLocale to update itself. Do

D10777: Define __ANDROID_API__

This revision was automatically updated to reflect the committed changes. Closed by commit R240:bbf792fc28c2: Define __ANDROID_API__ (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10777?vs=27875&id=27902#toc REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST

D10777: Define __ANDROID_API__

vkrause added a comment. In D10777#212384 , @apol wrote: > I've never seen these so I'm surprised. Good that you figured it out though :) As long as you stick with Qt API this probably doesn't matter, I only ran into this with libc API.