D7954: Fix repaint loop in KToolBar

mardelle abandoned this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D7954 To: mardelle, #frameworks, ilic, dfaure Cc: michaelh

D10661: indexerconfig: Expose canBeSearched function

michaelh added a project: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10661 To: michaelh, #baloo, #dolphin, dfaure Cc: adridg, #frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D10662: indexerconfig: Describe some functions

michaelh added a project: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10662 To: michaelh, #baloo Cc: adridg, #frameworks, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D10712: balooctl monitor: Resume to wait for service

michaelh added a project: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10712 To: michaelh, #baloo, #frameworks, dfaure, alexeymin Cc: ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 143 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/143/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Thu, 22 Feb 2018 04:16:57 + Build duration: 15 min and counting JUnit Tests Name: (root) Faile

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 145 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/145/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 22 Feb 2018 04:16:57 + Build duration: 15 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 125 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/125/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 22 Feb 2018 04:16:57 + Build duration: 10 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.7 - Build # 24 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/24/ Project: Frameworks purpose kf5-qt5 SUSEQt5.7 Date of build: Thu, 22 Feb 2018 04:17:17 + Build duration: 3 min 27 sec and counting JUnit Tests Name:

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/47/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Thu, 22 Feb 2018 02:17:32 + Build duration: 9 min 33 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/52/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Thu, 22 Feb 2018 02:17:32 + Build duration: 7 min 25 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/36/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 22 Feb 2018 02:17:32 + Build duration: 3 min 30 sec and counting JUnit Tes

D10732: Help automoc to find metadata JSON files referenced in the code

apol added inline comments. INLINE COMMENTS > CMakeLists.txt:176 > +endforeach() > +foreach(macro_name ${Plasma_AUTOMOC_MACRO_NAMES_WITH_JSON_ARG3}) > +# tell automoc how to find names of plugin metadata files Can't we reuse this same code from kcoreaddons? Maybe kcoreaddons can

D10724: Help automoc to find metadata JSON files referenced in the code

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense to me. Or as much as such a regex can... REPOSITORY R244 KCoreAddons BRANCH useCMAKE_AUTOMOC_DEPEND_FILTERS REVISION DETAIL https://phabricator.kde.org/D10724 To: kossebau,

D10081: Don't assert if used incorrectly from dbus

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R268 KGlobalAccel BRANCH dont-assert-on-dbus-misusage REVISION DETAIL https://phabricator.kde.org/D10081 To: graesslin, #frameworks, apol Cc: romangg, michaelh

D10733: Help automoc to find metadata JSON files referenced in the code

kossebau added a comment. For more details see comments on D10724 REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D10733 To: kossebau, #frameworks, #build_system, apol Cc: michaelh

D10733: Help automoc to find metadata JSON files referenced in the code

kossebau created this revision. kossebau added reviewers: Frameworks, Build System, apol. Restricted Application added a project: Frameworks. kossebau requested review of this revision. REVISION SUMMARY automoc by itself can only detect metadata files referenced by direct usage of the Q_PLUGIN

D10732: Help automoc to find metadata JSON files referenced in the code

kossebau added a comment. For more details see comments on D10724 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10732 To: kossebau, #frameworks, #build_system, apol Cc: michaelh

D10732: Help automoc to find metadata JSON files referenced in the code

kossebau created this revision. kossebau added reviewers: Frameworks, Build System, apol. Restricted Application added a project: Frameworks. kossebau requested review of this revision. REVISION SUMMARY automoc by itself can only detect metadata files referenced by direct usage of the Q_PLUGIN

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 28 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/28/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Wed, 21 Feb 2018 22:43:21 + Build duration: 26 min and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/29/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 Date of build: Wed, 21 Feb 2018 22:43:21 + Build duration: 22 min and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/23/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 21 Feb 2018 22:43:21 + Build duration: 13 min and counting JUnit T

D10702: Always use a job to delete files to avoid freezing process waiting on IO

markg added a comment. While this might give you the expected result, it feels like a workaround. I'm assuming the fast path is there for a reason and is really substantially faster then going through the job route. If that is the case then the proper fix would be to make that code part

Re: Converting KDE4 projects to KF5

On Wednesday February 21 2018 19:23:06 Luigi Toscano wrote: > Manual inspection is better. Not all of them produces code that can be > compiled immediately. Well, that's something probably a lot easier to see after applying them than before ;) All of them also are not as powerfull as you could

D10591: forcefully activate popup windows when they open

mart added a comment. An alternate idea: - we open it without giging focus - the current show time is 5 seconds - after 2 seconds (1 would be enough?) we check if there was user activity with kidletime - if there was activity, if the notifier doesn't contain the cursor or isn't foc

D10719: Highlighting for OpenSCAD

dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. Thanks for the contribution. Before we integrate this, would you agree to change the license to MIT? This license is preferred for new highlighting files. Also, could you

[Bug 390288] KIO/KDirModel: Kate crash while trying to save a new file to a Samba share

Hi everyone, given the momentum we currently have in KIO fixes, I would like to raise attention to the bug below, which may be 10+ years old. Maybe we have some developers here who can reproduce? Best regards, Dominik Am 20.02.2018 23:38 schrieb "Valdo" : https://bugs.kde.org/show_bug.cgi?id=3

Re: Converting KDE4 projects to KF5

On Wednesday 21 February 2018, Kevin Funk wrote: > On Wednesday, 21 February 2018 14:42:20 CET Robin Atwood wrote: > > I have several old projects that really needed to be updated to KF5. Is > > there a handy guide to doing the conversion? > > Heya Robin, > > note: wrong mailing list. This is the

D10724: Help automoc to find metadata JSON files referenced in the code

kossebau added a comment. See related discussion on CMake issue tracker: https://gitlab.kitware.com/cmake/cmake/issues/17750 Similar patches will be also done to the other Framework modules which need such extra handling. Will see to upload them as well tonight. Given KF 5.44 taggin

Re: Converting KDE4 projects to KF5

On Wednesday, 21 February 2018 19:15:28 CET René J.V. Bertin wrote: > On Wednesday February 21 2018 15:00:56 Kevin Funk wrote: > > And I'd strongly recommend you to use the porting scripts here: > > git://anongit.kde.org/kde-dev-scripts, subdirectory kf5 > > Some kind of integration of KDevelop

D10494: update handle- icons for kirigami

mart reopened this revision. mart added a comment. -1, I don't like it at all REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10494 To: andreask, alex-l, mart Cc: matheusm, mmustac, ngraham, #frameworks, michaelh

D10702: Always use a job to delete files to avoid freezing process waiting on IO

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10702 To: meven, #frameworks, dfaure, ngraham, #dolphin Cc: ngraham, #frameworks, michaelh

D10724: Help automoc to find metadata JSON files referenced in the code

kossebau created this revision. kossebau added reviewers: Frameworks, Build System, apol. Restricted Application added a project: Frameworks. kossebau requested review of this revision. REVISION SUMMARY automoc by itself can only detect metadata files referenced by direct usage of the Q_PLUGIN

D10494: update handle- icons for kirigami

colomar added a comment. Now it has the same icon as the handle for the Context Drawer. On the one hand that's good because they do very similar things, but on the other hand if an app uses both, it could be a bit confusing REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricato

D10494: update handle- icons for kirigami

mart added a comment. i'm fine with simplifying it, but i still want a visual distinction between left and right, which suggests the sliding action (and if on some platform we would decide to make it something else than a slide, we would adapt using a different icon.. just in that case) REP

Re: Converting KDE4 projects to KF5

On Wednesday February 21 2018 15:00:56 Kevin Funk wrote: > And I'd strongly recommend you to use the porting scripts here: > git://anongit.kde.org/kde-dev-scripts, subdirectory kf5 Some kind of integration of KDevelop with those scripts might be nice... Are all those scripts safe noops on code

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/55/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Wed, 21 Feb 2018 18:10:48 + Build duration: 4 min 13 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/52/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 21 Feb 2018 18:11:34 + Build duration: 1 min 51 sec and counting JUnit T

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/54/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Wed, 21 Feb 2018 18:04:50 + Build duration: 5 min 56 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/51/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 21 Feb 2018 18:04:50 + Build duration: 6 min 17 sec and counting JUnit T

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/55/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Wed, 21 Feb 2018 18:07:49 + Build duration: 1 min 56 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/54/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Wed, 21 Feb 2018 18:04:50 + Build duration: 2 min 57 sec and counting JUnit Tests

D10293: remove view-media-playlist from preferences icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:6927b97af007: remove view-media-playlist from preferences icons (authored by astippich). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10293?vs=26499&id=27719

D10279: add 24px media-album-cover icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:ff179872c915: add 24px media-album-cover icon (authored by astippich). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10279?vs=26495&id=27718 REVISION DETAIL

D10292: change 32px icons for playlist shuffle and repeat

astippich added a comment. Thanks for the feedback! So the correct fix would be to change the 22px and 24px icons to use circles around the icons? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10292 To: astippich, #breeze, #vdg, andreaska, andreask Cc: and

D10716: handle wrong password when using sudo which asks for another password

sitter added a comment. As mentioned on IRC I think this would benefit greatly from some unit testing as that line check is dangerously close to requiring mental gymnastics to read. AT a glance, all that's needed is writing stub sudo/su helpers and a test asserting outcome of `SuProcess('us0

D10702: Always use a job to delete files to avoid freezing process waiting on IO

meven updated this revision to Diff 27716. meven added a comment. Always use a job to delete files to avoid freezing process waiting on IOX REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10702?vs=27648&id=27716 BRANCH bug-390748-make-kio-delete-asynchronous

D10702: Always use a job to delete files to avoid freezing process waiting on IO

meven retitled this revision from "BUG: 390748 Always use a job to delete files to avoid freezing process waiting on IO" to "Always use a job to delete files to avoid freezing process waiting on IO". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10702 To: meven, #framewo

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 142 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/142/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Wed, 21 Feb 2018 16:41:19 + Build duration: 43 min and counting JUnit Tests Name: (root) Faile

D10722: other preload microoptimizations

davidedmundson added inline comments. INLINE COMMENTS > svgitem.cpp:50 > > +void SvgItem::componentComplete() > +{ I don't see how this makes any difference. Every setSomeProperty already calls scheduleImageUpdate regardless of whether we're complete or not. and if you don't have any propert

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 124 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/124/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 21 Feb 2018 16:41:19 + Build duration: 36 min and counting JUnit Tests Name: (root)

D10081: Don't assert if used incorrectly from dbus

graesslin added a comment. ping REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D10081 To: graesslin, #frameworks Cc: romangg, michaelh

D10142: [server] Properly handle the situation when the DataSource for a drag gets destroyed

graesslin added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. ping REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10142 To: graesslin, #frameworks, #kwin, #plasma Cc: plasma-devel, michaelh, ZrenBot, lesliezhai, ali-moh

D10235: [server] Add support for the frame semantics of Pointer version 5

graesslin added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. ping REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10235 To: graesslin, #kwin, #plasma, #frameworks Cc: plasma-devel, schernikov, michaelh, ZrenBot, alexeym

D10722: other preload microoptimizations

broulik added inline comments. INLINE COMMENTS > iconitem.h:42 > Q_OBJECT > +Q_INTERFACES(QQmlParserStatus) > `QQuickItem` should do that for you already > svgitem.h:41 > Q_OBJECT > +Q_INTERFACES(QQmlParserStatus) > Same here > ScrollArea.qml:58 > +Component.onComple

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 144 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/144/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 21 Feb 2018 16:41:19 + Build duration: 21 min and counting JUnit Tests Name: (root) Fai

D10722: other preload microoptimizations

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. mart requested review of this revision. REVISION SUMMARY make svgitem schedule a polish right when it's done l

D10325: [KFileWidget] Hide places frame and header

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a3e2b24b17ee: [KFileWidget] Hide places frame and header (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10325?vs=26642&id=27706 REVISION DETAIL

D10702: BUG: 390748 Always use a job to delete files to avoid freezing process waiting on IO

ngraham added a comment. Thanks! Still gotta remove "BUG: 390748" from the title, though. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10702 To: meven, #frameworks, dfaure, ngraham, #dolphin Cc: ngraham, #frameworks, michaelh

D10719: Highlighting for OpenSCAD

julianstirling created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. julianstirling requested review of this revision. REVISION SUMMARY Added XML file to highlight OpenSCAD .scad files. REPOSITORY R216 Syntax Highligh

D10716: handle wrong password when using sudo which asks for another password

jriddell created this revision. jriddell added a reviewer: sitter. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. jriddell requested review of this revision. REVISION SUMMARY handle wrong password when using sudo which asks for another

Re: Converting KDE4 projects to KF5

On Wednesday, 21 February 2018 14:42:20 CET Robin Atwood wrote: > I have several old projects that really needed to be updated to KF5. Is > there a handy guide to doing the conversion? Heya Robin, note: wrong mailing list. This is the mailing list dealing with KDevelop, the IDE :) I've CC'd the

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 70 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/70/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Wed, 21 Feb 2018 13:40:03 + Build duration: 7 min 10 sec and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 67 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/67/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 21 Feb 2018 13:40:03 + Build duration: 6 min 45 sec and counting JUn

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 43 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/43/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 21 Feb 2018 13:40:03 + Build duration: 6 min 40 sec and counting

D10653: Set IconItem default to smooth=true

This revision was automatically updated to reflect the committed changes. Closed by commit R242:bf4facd8c1b9: Set IconItem default to smooth=true (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10653?vs=27528&id=

D10712: balooctl monitor: Resume to wait for service

michaelh created this revision. michaelh added reviewers: Baloo, Frameworks, dfaure, alexeymin. Restricted Application added a project: Frameworks. michaelh requested review of this revision. REVISION SUMMARY Keep monitoring until terminated by ctrl+c TEST PLAN While monitor is running variou

D10662: indexerconfig: Describe some functions

michaelh marked 3 inline comments as done. michaelh added inline comments. INLINE COMMENTS > adridg wrote in indexerconfig.h:45 > This makes it unclear if the entire path is used, (e.g. `\p path`) or whether > some special part of the path (the dir) is used for matching. It *might* be > nice to

D10662: indexerconfig: Describe some functions

michaelh updated this revision to Diff 27673. michaelh added a comment. - indexerconfig: Rephrase description REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10662?vs=27662&id=27673 BRANCH publicdescriptions (branched from master) REVISION DETAIL https:/

D10670: Reduce plasmashell frozen time

jtamate updated this revision to Diff 27672. jtamate edited the summary of this revision. jtamate added a comment. Updated the summary and added a comment REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10670?vs=27576&id=27672 REVISION DE

D10661: indexerconfig: Expose canBeSearched function

michaelh marked 2 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10661 To: michaelh, #baloo, #dolphin, dfaure Cc: adridg, #frameworks, michaelh

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

kpiwowarski added a comment. @ivan When database is broken additionaly kactivitymanagerd is in endless loop of creating and closing processes. Each KF5 application prints to console message: "KActivities: FATAL ERROR: Failed to contact the activity manager daemon" Maybe it would be good

D10661: indexerconfig: Expose canBeSearched function

michaelh updated this revision to Diff 27667. michaelh added a comment. - indexerconfig: Rephrase description REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10661?vs=27551&id=27667 BRANCH expose_canbesearched (branched from master) REVISION DETAIL https

D10543: fix crashing with duplicate entries

sandsmark updated this revision to Diff 27668. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10543?vs=27664&id=27668 REVISION DETAIL https://phabricator.kde.org/D10543 AFFECTED FILES src/karchive.cpp src/kzip.cpp To: sandsmark, dfaure, #frameworks Cc: apol, michaelh

D10551: autotest for crashing in KArchiveDirectory::addEntry

sandsmark updated this revision to Diff 27666. sandsmark added a comment. fix comment from dfaure CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10551?vs=27282&id=27666 REVISION DETAIL https://phabricator.kde.org/D10551 AFFECTED FILES autotests/data/out.epub autotests/karchiv

D10543: fix crashing with duplicate entries

sandsmark updated this revision to Diff 27664. sandsmark marked 7 inline comments as done. sandsmark added a comment. fixes to issues raised REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10543?vs=27286&id=27664 REVISION DETAIL https://phabricator.kde.o

D10662: indexerconfig: Describe some functions

michaelh added inline comments. INLINE COMMENTS > adridg wrote in indexerconfig.h:53 > What does "cached and cleaned up" mean here? (Same applies below) Here, nothing :-) REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10662 To: michaelh, #baloo Cc: adridg, #frameworks,

D10671: [UDisks] Fix auto-mount regression

dkhlestkov retitled this revision from "Fix auto-mount regression" to "[UDisks] Fix auto-mount regression". REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10671 To: dkhlestkov, #frameworks, broulik Cc: ngraham, sefaeyeoglu, rikmills, #frameworks, michaelh

D10662: indexerconfig: Describe some functions

michaelh updated this revision to Diff 27662. michaelh added a comment. - fileindexerconfig: Make descriptions consistent - indexerconfig: Make descriptions consistent REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10662?vs=27552&id=27662 BRANCH publicde

D10661: indexerconfig: Expose canBeSearched function

adridg added inline comments. INLINE COMMENTS > indexerconfig.h:42 > + * Check if \p folder can be searched taking only > + * the includeFolders() into account. > + * This description says only `includeFolders()` is taken into account. The next paragraph says "should be indexed", wh

D10662: indexerconfig: Describe some functions

adridg added inline comments. INLINE COMMENTS > indexerconfig.h:45 > + * match any of the exclude filters. Only the name of the > + * dir itself it checked. > + * This makes it unclear if the entire path is used, (e.g. `\p path`) or whether some special part of the path (the dir) is

D10512: try to preload certain applets in a smart way

broulik added inline comments. INLINE COMMENTS > anthonyfieroni wrote in appletquickitem.cpp:57-68 > But if PLASMA_PRELOAD_POLICY is not setted s_preloadPolicy stays > Uninitialized, no? But since you check against >= Adaptive it's still ok :) https://cgit.kde.org/plasma-framework.git/commit/?i