cfeck edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9672
To: wcpan, dfaure
Cc: cfeck, #frameworks, michaelh, ngraham
cfeck added a comment.
Sorry for the late response, but we currently have no maintainer for the FTP
code in KIO.
From quickly checking, the intention looks good, but if the ERR_* codes are
part of an enum, maybe add the special value -1 with a name there, instead of
hardcoding the -1 va
On 30.01.2018 16:38, Milian Wolff wrote:
This works for me:
https://github.com/KDAB/hotspot/blob/4d1177d1631902dce1dd82f53553e97a7544b1fa/
src/mainwindow.cpp#L162
Thanks, that helped. I was using
restoreGeometry(group.readEntry("geometry").toLatin1()) instead of
restoreGeometry(group.readEntr
michaelh marked 3 inline comments as done.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D10113
To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks
Cc: dhaumann
michaelh added inline comments.
INLINE COMMENTS
> filemetadatawidget.cpp:119
> +slotDataAvailable();
> +emit q->metaDataRequestFinished(m_provider->items());
> +}
test with empty `items()`: This code is reached, but the `moc` doesn't signal.
REPOSITORY
R824 Baloo Widgets
REVISION DE
Hello Hannah,
On mercredi 24 janvier 2018 10:32:17 CET Hannah von Reth wrote:
> Hi Matthieu,
>
> On 21/01/2018 21:19, Matthieu Gallien wrote:
> > Hello,
> >
> > On jeudi 18 janvier 2018 08:45:51 CET Hannah von Reth wrote:
> >> Hi everyone.
> >>
> >> Only some few of you will be aware of KIconTh
michaelh updated this revision to Diff 26222.
michaelh added a comment.
Change commit message
REPOSITORY
R824 Baloo Widgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10113?vs=26218&id=26222
BRANCH
signalavailable (branched from master)
REVISION DETAIL
https://phabricato
chinmoyr updated this revision to Diff 26220.
chinmoyr added a comment.
1. Added null pointer check in place of strlen (in SocketAddress::address())
2. Used QFile::encodeName to convert file path to 8-bit for use in unlink().
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabric
chinmoyr marked 2 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9966
To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh
chinmoyr added a reviewer: ossi.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9966
To: chinmoyr, #frameworks, thiago, dfaure, ossi
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh
michaelh added a comment.
Both test for empty failed because the spy timed out!
IMO they should not, because consumers rely on the `metaDataRequestFinished`
signal.
Please tell me if you disagree.
I don't know why they fail, yet. Because line 371 is reached in
src/filemetadataprovide
michaelh updated this revision to Diff 26218.
michaelh added a comment.
Added test for empty file list
Added test for file list with empty url
Simplified path construction
REPOSITORY
R824 Baloo Widgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10113?vs=26183&id=26218
BRA
On Monday, January 29, 2018 9:17:54 AM CET Alexander Semke wrote:
> resending this to kde-devel...
>
> On 28.01.2018 18:45, Alexander Semke wrote:
> > Hi,
> >
> > KMainWindow takes care of saving/restoring the state of the main
> > window, menus and toolbars.
> > Also, the size of the main window
mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.
the crash may be due to missing context, the three-arg connect shouldn't ever
be used imo
INLINE COMMENTS
> simplejob.cpp:141
>
> -q->connect(slave, SIGNAL(connected()),
>
mwolff added inline comments.
INLINE COMMENTS
> kurlmimedata.cpp:74
> }
> QByteArray ba = mimeData->data(QString::fromLatin1(firstMimeType));
> if (ba.isEmpty()) {
if `firstMimeType == "text/uri-list"` (see above, `PreferLocalUrls`), it's
still going to be slow, no? Should this b
mwolff retitled this revision from "Don't assert on empty names" to "remote:
don't create entries with empty names".
mwolff edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10045
To: mwolff, dfaure
Cc: dhaumann, #frameworks, michaelh
mwolff added inline comments.
INLINE COMMENTS
> remoteimpl.cpp:56
>
> -const QStringList filenames = dir.entryList(QDir::Files |
> QDir::Readable);
> +const QStringList filenames =
> dir.entryList({QStringLiteral("*.desktop")},
> +
mwolff updated this revision to Diff 26203.
mwolff added a comment.
filter out empty entries from remote:/ KIO slave
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10045?vs=25808&id=26203
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10045
A
mwolff added a comment.
OK, that's not enough. It seems like the file can sometimes be read while
it's still empty:
7.098 debug:
RemoteImpl::createEntry[/home/milian/projects/kf5/src/frameworks/kio/src/ioslaves/remote/remoteimpl.cpp:188]:
UDS_NAME "" from "/home/milian/.local/share/re
mwolff added a comment.
41.919 warning:
KConfigIniBackend::parseConfig[/home/milian/projects/kf5/src/frameworks/kconfig/src/core/kconfigini.cpp:253]:
"KConfigIni: In file
/home/milian/.local/share/remoteview/yxcvyxcv.desktop.lock, line 1: " Invalid
entry (missing '=')
41.919 warning:
mwolff accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10172
To: dfaure, mwolff, dhaumann
Cc: elvisangelaccio, ngraham, #dolphin, #frameworks, michaelh
mwolff added a comment.
@apol any hint what to do about KIOSK? any resources I should have a look at?
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10024
To: mwolff, #plasma, dfaure, mart
Cc: ngraham, mart, apol, plasma-devel, #frameworks, michaelh, Zr
michaelh added a comment.
Changed description
Or did you mean the commit messages of 1e3aa22d15d8 and 0f362a3e0de0?
Also, I've committed the accepted revisions to master not Applications/17.1.
Correct?
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D10113
michaelh edited the summary of this revision.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D10113
To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks
Cc: dhaumann
24 matches
Mail list logo
