BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/14/
Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.9
Date of build:
Tue, 30 Jan 2018 04:00:11 +
Build duration:
3 min 35 sec and counting
JUnit Tests
elvisangelaccio added inline comments.
INLINE COMMENTS
> michaelh wrote in filemetadataprovider.cpp:323
> In that case it might be safer to do
>
> IndexedDataRetriever *ret = new IndexedDataRetriever(filePath, this);
> connect(ret, SIGNAL(finished(KJob*)), this,
> SLOT(slotLoadi
elvisangelaccio added a comment.
+1
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10172
To: dfaure, mwolff, dhaumann
Cc: elvisangelaccio, ngraham, #dolphin, #frameworks, michaelh
On Monday January 29 2018 17:09:20 Kevin Funk wrote:
Somebody had too little precious time, apparently.
Apologies for not having added an indication in the subject that this concerns
almost fossile code and is thus aimed at readers with a certain maturity O:-)
michaelh updated this revision to Diff 26183.
michaelh added a comment.
Merge branch 'master' of git://anongit.kde.org/baloo-widgets
Change execution order in setFileItems
REPOSITORY
R824 Baloo Widgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10113?vs=26149&id=26183
BRANC
On Monday, 29 January 2018 11:32:56 CET René J.V. Bertin wrote:
> Hi,
>
> Researching an issue I'm seeing (hang/crash on exit) I found the following
> vestigial out-commented code the KCoreDirListerCache ctor in
> kcoredirlister.cpp:
FYI: Note to the mailing list, before more precious developer t
davidk edited the summary of this revision.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8532
To: davidk, apol, ossi
Cc: ngraham, nicolasfella, #frameworks, michaelh
This revision was automatically updated to reflect the committed changes.
Closed by commit R824:a81ceaeaa963: baloo-widgets: Refactor
filemetadataprovider for better readability (authored by michaelh).
REPOSITORY
R824 Baloo Widgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10105
ngraham added a comment.
I would have deleted the existing `arcpatch-D10105` branch so ad to avoid
`arc` creating a `arcpatch-D10105_1` branch, but yeah, that looks sane.
REPOSITORY
R824 Baloo Widgets
BRANCH
requestfinished (branched from master)
REVISION DETAIL
https://phabricator.kd
michaelh added a comment.
Just to be sure:
$ git checkout -b otto origin/master
$ arc patch D10105
now in branch arcpatch-D10105_1
$ arc checkout dataavail
$ arc rebase arcpatch-D10105_1
$ arc checkout unittest
$ arc rebase dataavail
and so on?
REPOSITOR
ngraham added a comment.
Yes, Arc tracks dependencies on the revision level, not the branch level.
If you're nervous, you don't even need to delete the local branch, either.
Just switch to master and pull down this copy of it with `arc patch D10105`
REPOSITORY
R824 Baloo Widgets
BRANC
michaelh added a comment.
Are you aware of the 3 branches dependent on this one?
REPOSITORY
R824 Baloo Widgets
BRANCH
requestfinished (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D10105
To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #framework
ngraham added a comment.
In cases like that, I usually delete the local branch and re-download the
patch using Arc's version: `arc patch D10105`. Then go onto the
`arcpatch-D10105` branch and `arc land --preview` from there.
REPOSITORY
R824 Baloo Widgets
BRANCH
requestfinished (branched
michaelh added a comment.
Can't land this
Usage Exception: arc can not identify which revision exists on branch
'refactor'.
$ arc branch
arcpatch-D10105 Accepted D10105: baloo-widgets: Refactor
filemetadataprovider for better readability
master
michaelh planned changes to this revision.
michaelh added a comment.
Needs rebasing
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D10113
To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks
Cc: dhaumann
davidk added a comment.
So, are there any more opinions on the whitelist vs. blacklist topic?
Personally I still prefer the blacklist as I fear regressions in the future,
especially because baloo is unmaintained.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8532
davidk edited the summary of this revision.
davidk edited the test plan for this revision.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8532
To: davidk, apol, ossi
Cc: ngraham, nicolasfella, #frameworks, michaelh
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/82/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 29 Jan 2018 12:31:52 +
Build duration:
37 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/13/
Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 29 Jan 2018 12:33:47 +
Build duration:
24 min and counting
JUnit Tests
Name:
On Monday January 29 2018 11:32:56 René J.V. Bertin wrote:
Hi,
> The difference must be in the order in which certain things are deleted
> during the global destruction phase, but which and how to restore the proper
> order.
One obvious difference is the fact that those KF5 applications link
resending this to kde-devel...
On 28.01.2018 18:45, Alexander Semke wrote:
Hi,
KMainWindow takes care of saving/restoring the state of the main
window, menus and toolbars.
Also, the size of the main window is correctly stored and restored.
However, I don't see how
to save and restore the pos
nibags added a project: Framework: Syntax Highlighting.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D10174
To: nibags, #framework_syntax_highlighting
Cc: #framework_syntax_highlighting, #frameworks, michaelh, genethomas,
cullmann, vkrause, dhaumann
nibags edited the summary of this revision.
nibags added a reviewer: Framework: Syntax Highlighting.
nibags added a subscriber: Framework: Syntax Highlighting.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D10174
To: nibags, #framework_syntax_highlighting
Cc
nibags created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
nibags requested review of this revision.
REVISION SUMMARY
SELinux CIL Policies:
The SELinux Common Intermediate Language (CIL) is a language for creating
fredrik created this revision.
fredrik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
fredrik requested review of this revision.
REVISION SUMMARY
Check that the sizes of the color channels i
Hi,
Researching an issue I'm seeing (hang/crash on exit) I found the following
vestigial out-commented code the KCoreDirListerCache ctor in kcoredirlister.cpp:
// Probably not needed in KF5 anymore:
// The use of KUrl::url() in ~DirItem (sendSignal) crashes if the static
for QRegExpEngi
dfaure added a comment.
See https://phabricator.kde.org/D10172 for the fix for the first usability
issue.
However I can't reproduce the assert...
Can you add this to your kio_remote to find out more?
There must be one strange .desktop file around somewhere.
diff --git a/src/ios
dfaure created this revision.
dfaure added reviewers: mwolff, dhaumann.
Restricted Application added a project: Frameworks.
dfaure requested review of this revision.
REVISION SUMMARY
Dolphin enables the KRun feature of asking before executing shell
scripts and desktop files (not really for sec
cgiboudeaux added a comment.
These flags are not in the Clang warnings (list for each version here:
https://github.com/Barro/compiler-warnings)
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D10166
To: aacid
Cc: cgiboudeaux, dhaumann, #frameworks, #build
29 matches
Mail list logo
