Hi,
examples aren't built by default in plasma-framework which probably explains
why they're broken..
Did a patch: https://phabricator.kde.org/D10092
Cheers
Kai Uwe
broulik edited the test plan for this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D10092
To: broulik, #plasma, rjvbb
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/9/
Project:
Frameworks purpose kf5-qt5 WindowsMSVCQt5.9
Date of build:
Thu, 25 Jan 2018 07:00:21 +
Build duration:
8 min 6 sec and counting
CONSOLE OUTP
broulik edited the summary of this revision.
broulik edited the test plan for this revision.
broulik added reviewers: Plasma, rjvbb.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAI
broulik created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
broulik requested review of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D10092
AFFECTED FILES
bcooksley added a comment.
In order for someone to approve this revision, add a reviewer, or subscribe
it is necessary for them to have permission to edit the review.
I have therefore unlocked the edit policy on this review.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://p
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/7/
Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
Date of build:
Thu, 25 Jan 2018 04:04:02 +
Build duration:
9 min 10 sec and counting
JUnit Tests
Name
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/7/
Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.9
Date of build:
Thu, 25 Jan 2018 04:04:02 +
Build duration:
2 min 40 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/8/
Project:
Frameworks purpose kf5-qt5 SUSEQt5.7
Date of build:
Thu, 25 Jan 2018 04:04:02 +
Build duration:
2 min 14 sec and counting
JUnit Tests
Name:
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/8/
Project:
Frameworks purpose kf5-qt5 WindowsMSVCQt5.9
Date of build:
Thu, 25 Jan 2018 04:04:02 +
Build duration:
43 sec and counting
CONSOLE OUTPUT
On Thu, Jan 25, 2018 at 11:08 AM, René J.V. Bertin wrote:
> Hi,
Hi Rene,
>
> I'm getting a build error that seems like it would never have made it into
> an official release:
>
> [ 63%] Building CXX object
> examples/dataengines/simpleEngine/CMakeFiles/plasma_dataengine_example_simpleEngine.d
aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
aacid requested review of this revision.
REVISION SUMMARY
After all we only use smb.conf in a depreated function (and unused according
to lxr.kde.org)
REPOSIT
Hi,
I'm getting a build error that seems like it would never have made it into an
official release:
[ 63%] Building CXX object
examples/dataengines/simpleEngine/CMakeFiles/plasma_dataengine_example_simpleEngine.dir/simpleEngine.cpp.o
jtamate updated this revision to Diff 25907.
jtamate edited the summary of this revision.
jtamate added a comment.
Improved, in my opinion, one comment.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10071?vs=25890&id=25907
BRANCH
firstChildUrl (branched fro
fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> chinmoyr wrote in file_unix.cpp:91
> It is the only case for which this hack seems necessary. For all other cases
> a library call (to perform a file operation)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/35/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
Date of build:
Wed, 24 Jan 2018 17:57:55 +
Build duration:
21 min and counting
JUnit Tests
N
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/36/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
Date of build:
Wed, 24 Jan 2018 17:59:11 +
Build duration:
7 min 50 sec and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:2bed94b6d463: Fix: View jumps when Scroll past end of
document is enabled (authored by dhaumann).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10054?vs=25837&id
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:fbdfe779e46c: KateView unit test: simplify finding
KateViewInternal (authored by dhaumann).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10058?vs=25836&id=25898
chinmoyr marked 2 inline comments as done.
chinmoyr added inline comments.
INLINE COMMENTS
> fvogt wrote in fdreceiver.cpp:60
> A quick question: Is it possible that there are two FdReceivers with the same
> pid?
> In that case they would end up removing each other's sockets.
No. Currently only
chinmoyr updated this revision to Diff 25897.
chinmoyr added a comment.
1.Return nullptr when address() is called for an invalid socket path
2.Create SocketAddress object before socket .
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9966?vs=25839&id=25897
B
graesslin created this revision.
graesslin added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
graesslin requested review of this revision.
REVISION SUMMARY
The component dbus interface allowed to remote kill the wayland session
by sending an incorrect request to
dfaure added a comment.
Actually, maybe parentPath == "/" would be more readable then, otherwise the
next reader will wonder, how it can end with a slash after StripTrailingSlash
was used...
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10071
To: jtamate, #frameworks
davidedmundson added a comment.
> For the future perhaps there could be a XDG D-Bus interface for such
quicksearch plugins, so a separate krunner-independent library would make sense
for that as well.
Gnome does have an equivalent: org.gnome.Shell.SearchProvider2
It's similar
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Ah, OK (yes, this is why you should use `arc diff` to upload patches...) :-)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10071
To: jtamate, #frameworks, dfaure
Cc:
graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> outputdevice.xml:104-107
> + + summary="textual representation of serial number"/>
> + + summary="textual represe
kossebau added inline comments.
INLINE COMMENTS
> broulik wrote in dbusadaptor_p.h:1
> Isn't this file compile-time generated from xml?
It can be, yes. I had switched for reason* to manually written one, but with
the public class API no longer affected by reason* I could/should perhaps
switch
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/28/
Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
Date of build:
Wed, 24 Jan 2018 15:59:40 +
Build duration:
4 min 1 sec and counting
JUnit Tests
Name: (roo
mwolff added a comment.
In https://phabricator.kde.org/D10024#194708, @mart wrote:
> ship it with the extra check Aleix noted
Can you guys explain me more what would be required for KIOSK support?
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.or
mwolff updated this revision to Diff 25891.
mwolff added a comment.
extend apidox, mention empty list == everything allowed
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10024?vs=25764&id=25891
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D1
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/27/
Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
Date of build:
Wed, 24 Jan 2018 15:59:40 +
Build duration:
2 min 45 sec and counting
JUnit Tests
Name: (
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.9/6/
Project:
Frameworks purpose kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 24 Jan 2018 15:13:14 +
Build duration:
31 min and counting
JUnit Tests
Name:
kossebau added a comment.
A first draft of some util code for writing D-Bus KRunner plugins, partially
tested to work. See https://phabricator.kde.org/D10079 for the Baloo krunner
plugin being adapted to it.
Tries to simulate the KRunner::AbstractRunner API a little, to where the
krunne
jtamate added inline comments.
INLINE COMMENTS
> dfaure wrote in urlutil_p.h:69
> s/S/s/ twice
>
> You could also just use adjustedCurrentUrl.path(QUrl::StripTrailingSlash), no?
> Then you wouldn't have to deal with the fact that the path might end with a
> slash
> (and it would also cover the
jtamate updated this revision to Diff 25890.
jtamate marked an inline comment as done.
jtamate added a comment.
replaced two uppercase S
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10071?vs=25883&id=25890
REVISION DETAIL
https://phabricator.kde.org/D10071
broulik added a comment.
Cool! Dunno if this has to be a separate library? But then it would allow for
super thin dependencies as it's just Qt DBus, I don't really mind either.
INLINE COMMENTS
> dbusadaptor_p.h:1
> +/*
> + * Copyright 2018 Friedrich W. H. Kossebau
Isn't this file compile
kossebau added a dependent revision: D10079: Port baloo krunner plugin to
KDBusRunner.
REPOSITORY
R308 KRunner
REVISION DETAIL
https://phabricator.kde.org/D10078
To: kossebau, davidedmundson, broulik
Cc: #frameworks
kossebau created this revision.
kossebau added reviewers: davidedmundson, broulik.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
kossebau requested review of this revision.
REVISION SUMMARY
Enables writing remote-via-D-Bus krunner plug
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/7/
Project:
Frameworks purpose kf5-qt5 SUSEQt5.7
Date of build:
Wed, 24 Jan 2018 15:13:15 +
Build duration:
4 min 24 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/6/
Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
Date of build:
Wed, 24 Jan 2018 15:13:14 +
Build duration:
2 min 44 sec and counting
JUnit Tests
Name
broulik edited the summary of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D10077
To: broulik, #plasma, #vdg
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
broulik created this revision.
broulik added reviewers: Plasma, VDG.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Unset the Label's default height which c
dfaure added a comment.
Heh, see the point of writing unittests that actually test the bug ;) It lead
to a different fix so it was clearly useful ;)
INLINE COMMENTS
> urlutil_p.h:69
> const QString parentPath = adjustedCurrentUrl.path();
> +// if the parent path ends in / (a
cgiboudeaux added inline comments.
INLINE COMMENTS
> CMakeLists.txt:45
>
> -set(KAUTH_HELPER_INSTALL_DIR "${KDE_INSTALL_LIBEXECDIR}/kauth")
> +option(KAUTH_HELPER_INSTALL_DIR "Set directory for kauth helper tool"
> "${KDE_INSTALL_LIBEXECDIR}/kauth")
>
the 3rd parameter is a bool. This chang
jtamate updated this revision to Diff 25883.
jtamate added a comment.
Do the right thing in the case of urls that end in / after the slash
stripping.
This new test fails without the patch.
QCOMPARE(KIO::UrlUtil::firstChildUrl(lUrl("/d"), lUrl("/")), lUrl("/d"));
REPOSITORY
R241 KIO
knauss added a comment.
@skelly: IMO it makes sense to discuss also the needed change in ECM, to
solve the issue popperly.
Just a side note - me personally is not very deep into the cross compilation
topic. That's why I can understand, if you have many questions and do not get
it, why t
knauss added reviewers: Frameworks, skelly.
REPOSITORY
R283 KAuth
REVISION DETAIL
https://phabricator.kde.org/D10075
To: knauss, #frameworks, skelly
Cc: #frameworks
knauss created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
knauss requested review of this revision.
REVISION SUMMARY
kauth-gen-policy appears to be a tool for turning a text file in
qsettings format (similar to .ini
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/55/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Wed, 24 Jan 2018 12:32:59 +
Build duration:
25 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/52/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Wed, 24 Jan 2018 12:32:59 +
Build duration:
9 min 5 sec and counting
JUni
renatoo updated this revision to Diff 25880.
renatoo added a comment.
Updated @since tag
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9332?vs=24605&id=25880
REVISION DETAIL
https://phabricator.kde.org/D9332
AFFECTED FILES
autotests/kfileplacesmodeltest.
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/28/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 24 Jan 2018 12:32:59 +
Build duration:
7 min 47 sec and counting
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f9061787136e: parametrize qqc2 version (authored by mart).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10074?vs=25878&id=25879
REVISION DETAIL
bshah accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
phab/qqcversion
REVISION DETAIL
https://phabricator.kde.org/D10074
To: mart, #plasma, bshah
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-m
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
mart requested review of this revision.
REVISION SUMMARY
for styles in order to work at all they need to impor
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Strange that the "bug report" mentions /d but the unittests doesn't have
anything like that.
In fact, is it just me, or does the "extended" unittest pass without the fix?
My
Hi Matthieu,
On 21/01/2018 21:19, Matthieu Gallien wrote:
> Hello,
>
> On jeudi 18 janvier 2018 08:45:51 CET Hannah von Reth wrote:
>> Hi everyone.
>>
>> Only some few of you will be aware of KIconThemes ability to load binary
>> icon themes automagically.
>>
>> https://cgit.kde.org/kiconthemes.git
jtamate updated this revision to Diff 25872.
jtamate edited the test plan for this revision.
jtamate added a comment.
Added more unit tests with some comments.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10071?vs=25869&id=25872
REVISION DETAIL
https://pha
PureTryOut created this revision.
PureTryOut created this object with edit policy "Only User: PureTryOut (Bart
Ribbers)".
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
PureTryOut requested review of this revision.
REVISION SUMMARY
APK
dfaure added a comment.
IIRC this method is unittested, right? Please extend the unittest.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10071
To: jtamate, #frameworks, dfaure
jtamate created this revision.
jtamate added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
jtamate requested review of this revision.
REVISION SUMMARY
Instead of an assert do as the documentation tells: return an invalid Url.
- In case both URLs are equa
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:978676ee9a20: unset maintainer (authored by sitter).
REPOSITORY
R245 Solid
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10046?vs=25809&id=25870
REVISION DETAIL
https://phabricator.kde.
jtamate marked 3 inline comments as done.
jtamate added inline comments.
INLINE COMMENTS
> dfaure wrote in slavebase.cpp:1054
> Where does this "1" value come from, and it is useful at all?
It was 1 as could have been 0.
It is not needed anymore.
> dfaure wrote in slavebase.cpp:1055
> So when w
jtamate updated this revision to Diff 25867.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9983?vs=25783&id=25867
REVISION DETAIL
https://phabricator.kde.org/D9983
AFFECTED FILES
src/core/slavebase.cpp
To: jtamate, #frameworks, dfaure
Cc: fvogt, ngraham
mwolff added a comment.
In https://phabricator.kde.org/D10045#195097, @dfaure wrote:
> Good point, done.
I did the following:
- in Dolphin, go to remote:/
- add network folder
- allow execution of this script (separate usability issue)
- webdav, then fill out the form fo
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.7/20/
Project:
Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.7
Date of build:
Wed, 24 Jan 2018 10:36:28 +
Build duration:
11 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.9/13/
Project:
Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 24 Jan 2018 10:36:28 +
Build duration:
6 min 20 sec and counting
JUn
dfaure closed this revision.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8908
To: dfaure, cfeck, dvratil, mlaurent
Cc: mlaurent, anthonyfieroni, #frameworks, #kde_pim
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/6/
Project:
Frameworks purpose kf5-qt5 WindowsMSVCQt5.9
Date of build:
Wed, 24 Jan 2018 09:59:44 +
Build duration:
13 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/6/
Project:
Frameworks purpose kf5-qt5 SUSEQt5.7
Date of build:
Wed, 24 Jan 2018 09:06:38 +
Build duration:
24 min and counting
JUnit Tests
Name: (root)
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> slavebase.cpp:1052
> } else if (timeout == 0) {
> -d->nextTimeout = QDateTime::currentDateTime().addSecs(1);//
> Immediate timeout
> +
dfaure added inline comments.
INLINE COMMENTS
> kfilewidget.h:498
> +/**
> + * Set the URL schemes that the file widget should allow navigating to.
> + *
All of these public methods should indicate that the default list is *empty*
and that empty means "all schemes are supported".
I
72 matches
Mail list logo
