KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 73 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/73/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 19 Jan 2018 04:08:15 + Build duration: 18 min and counting JUnit Tests Name: (root)

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

rjvbb added a comment. > That's not applicable. Did you read my actual, original request? If so you'd have seen that it's satisfied by this answer. Also please note the final remark in the author's summary, `Note that the other backends could leverage a similar trick to speed them up.`

D9973: [kwidgetsaddons] Fix tooltip positioning

cfeck added inline comments. INLINE COMMENTS > ktooltipwidget.cpp:32 > #include > +#include > remove unneeded include > ktooltipwidget.cpp:155 > } else { > x = rect.left() - size.width() - margin; > } Does this also need to be adjusted to ' + margin'? Or was

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

markg accepted this revision. markg added a comment. Ship it from my side. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9824 To: mwolff, dfaure, rjvbb, #kdevelop, markg Cc: aaronpuchert, bcooksley, zimmerman, markg, #frameworks

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

dfaure accepted this revision. dfaure added a comment. This patch fixes a O(n) performance issue in the inotify backend using a cache, which makes KDirWatch *better* suited for applications that use KDirWatch heavily. Clearly a step in the right direction. Yes a cache needs memory, like all

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

rjvbb added a comment. > Also we know at least one person that isn't going to forget about this, don't we? If you thought it'd be me *who* would keep nagging about this you can forget about that. > and you don't seem to dispute that it is an improvement Because I simply don

D9973: [kwidgetsaddons] Fix tooltip positioning

michaelh created this revision. michaelh added reviewers: elvisangelaccio, Frameworks, Dolphin, ngraham. Restricted Application added a project: Frameworks. michaelh requested review of this revision. REVISION SUMMARY Partial fix of Bug 388583 Corr

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

aaronpuchert added a comment. In https://phabricator.kde.org/D9824#192793, @rjvbb wrote: > If real-world impact is in the order of a highly significant but millisecond-order reduction of reaction time to file change there may be little reason to commit this improvement now (and then risk

D9966: [KIO] Fix issues with sharing of file descriptor

fvogt added a comment. Thanks for the quick reaction! > 1.Fixes buffer overflow due to strcpy. Looks good, but I would prefer an exception or abort instead of silent truncation. Also note that this makes it possible to delete an arbitrary file on non-linux platforms if `path` i

D9966: [KIO] Fix issues with sharing of file descriptor

chinmoyr created this revision. chinmoyr added reviewers: Frameworks, thiago. Restricted Application added a project: Frameworks. chinmoyr requested review of this revision. REVISION SUMMARY This patch, 1.Fixes buffer overflow due to strcpy. 2.Adds checks for socket credentials. Now a file d

D9958: Parseable output for balooctl status

michaelh added a comment. Just learned it's on the Qt-wishlist. I can live with that. Just wanted to get rid of the 2nd description line. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D9958 To: michaelh, #frameworks, vhanda, smithjd, lbeltrame Cc: broulik, ngraham

D9958: Parseable output for balooctl status

lbeltrame added a comment. In https://phabricator.kde.org/D9958#192860, @michaelh wrote: > > The --format look like a global switch. I don't like that. Couldn't find a(n easy) way to avoid that. Do you know one? > The subcommands are defined as posititional arguments afte

D9959: [baloosearch] Send summary to stderr

michaelh added reviewers: broulik, lbeltrame. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D9959 To: michaelh, #frameworks, vhanda, smithjd, broulik, lbeltrame

D9958: Parseable output for balooctl status

michaelh added a comment. Once I found an example (Qt doc) it was easy. Yesterday was struggling with this command line parsing to much :) BTW, regarding balooctl status -h The --format look like a global switch. I don't like that. Couldn't find a(n easy) way to avoid that. Do y

D9958: Parseable output for balooctl status

lbeltrame added a comment. +1. @broulik How does it look on your side wrt the QJsonDocument usage? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D9958 To: michaelh, #frameworks, vhanda, smithjd, lbeltrame Cc: broulik, ngraham

D9958: Parseable output for balooctl status

michaelh marked 2 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D9958 To: michaelh, #frameworks, vhanda, smithjd, lbeltrame Cc: broulik, ngraham

D9958: Parseable output for balooctl status

michaelh updated this revision to Diff 25591. michaelh added a comment. utilized QJson* output: F5662110: jsonobject REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9958?vs=25579&id=25591 BRANCH formatting REVISI

D9958: Parseable output for balooctl status

michaelh added a comment. > Did you test this change also with filenames with Unicode characters or non-Latin characters? Yes. Example: F5662004: japanese REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D9958 To: michaelh,

A new tier1 for icontheme.rcc handling

Hi everyone. Only some few of you will be aware of KIconThemes ability to load binary icon themes automagically. https://cgit.kde.org/kiconthemes.git/tree/src/kicontheme.cpp#n48 The code looks for a icontheme.rcc and sets it as default theme. On Windows and Mac we rely on that code as it is mor

D9961: [Plasma Theme] Guard against invalid KPluginInfo object

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 389152 TEST PLAN Compiles REPOSITOR

D9793: Fall back to language name for translations lookup if locale name fails

This revision was automatically updated to reflect the committed changes. Closed by commit R240:78443e0f0373: Fall back to language name for translations lookup if locale name fails (authored by wbauer). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D9958: Parseable output for balooctl status

michaelh added a comment. @broulik: My reasons for not using it 1. I was a little lazy: Using all the other Qt-Objects was enough work for me :). 2. I thought not using QJsonDocument was accapteble because the overall structure of the formatters is similar. Should you insist on QJ

D9958: Parseable output for balooctl status

broulik added a comment. > I'm not too fond of assembling JSON by hand, but I guess it was done to avoid dependencies for a tool that's supposed to be simple. Qt's JSON support is in QtCore since Qt 5, there's no additional dependency, so yes, please use `QJsonDocument` et at. REPOSITOR

D9958: Parseable output for balooctl status

lbeltrame added a comment. I'm not too fond of assembling JSON by hand, but I guess it was done to avoid dependencies for a tool that's supposed to be simple. I'll let others weigh in on this. Did you test this change also with filenames with Unicode characters or non-Latin characters? IN

D9958: Parseable output for balooctl status

michaelh added a comment. balooctl status outputs: F5661892: balooctl-status-output REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D9958 To: michaelh, #frameworks, vhanda, smithjd, lbeltrame Cc: ngraham

D9959: [baloosearch] Send summary to stderr

michaelh created this revision. michaelh added reviewers: Frameworks, vhanda, smithjd. michaelh added a project: Frameworks. michaelh requested review of this revision. REVISION SUMMARY - eliminate the need for '... | head -n -1' when piping output TEST PLAN Obviously: $ baloosearch ... 2>/

D9766: Use at least the requested width for the argument hint tree

kfunk added a comment. Whoops. Sorry for accidentally reopening it to begin with. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9766 To: mwolff, #kdevelop, #kate Cc: dhaumann, kfunk, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

rjvbb added a comment. I don't see anything unreasonable to my request, which can also be satisfied by a argued demonstration why the same approach/fix doesn't apply to other backends. AFAIAC I'm just doing my reviewers' service like it's been shown to me how that's done. If the same ap

D9766: Use at least the requested width for the argument hint tree

mwolff abandoned this revision. mwolff added a comment. this was comitted already, closing it again REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9766 To: mwolff, #kdevelop, #kate Cc: dhaumann, kfunk, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullm

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/28/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Thu, 18 Jan 2018 10:13:06 + Build duration: 9 min 22 sec and counting JUnit Tests

D9822: Add benchmarks for KDirWatch

This revision was automatically updated to reflect the committed changes. Closed by commit R244:421e85344db7: Add benchmarks for KDirWatch (authored by mwolff). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9822?vs=25368&id=25583 REVISION DETAIL https:

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 33 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/33/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Thu, 18 Jan 2018 10:13:06 + Build duration: 3 min 56 sec and counting JUnit Tests

D9820: Verify that the file was opened

This revision was automatically updated to reflect the committed changes. Closed by commit R244:311a702fa070: Verify that the file was opened (authored by mwolff). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9820?vs=25167&id=25581 REVISION DETAIL htt

D9823: Optimize: use QMetaObject::invokeMethod with functor

This revision was automatically updated to reflect the committed changes. Closed by commit R244:16e8cf1e6607: Optimize: use QMetaObject::invokeMethod with functor (authored by mwolff). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9823?vs=25366&id=25584

D9821: Use QSignalSpy::wait instead of QTest::wait where possible

This revision was automatically updated to reflect the committed changes. Closed by commit R244:5d91ecc2fb68: Use QSignalSpy::wait instead of QTest::wait where possible (authored by mwolff). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9821?vs=25168&id=2

D9819: Verify that the path is valid and writable

This revision was automatically updated to reflect the committed changes. Closed by commit R244:5fa1aaa2a47b: Verify that the path is valid and writable (authored by mwolff). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9819?vs=25166&id=25580 REVISION D

D9958: Parseable output for balooctl status

lbeltrame added a comment. Examples of each output would be nice. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D9958 To: michaelh, #frameworks, vhanda, smithjd, lbeltrame Cc: ngraham

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/17/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 18 Jan 2018 10:13:06 + Build duration: 3 min 41 sec and counting JUnit Tes

D9958: Parseable output for balooctl status

michaelh created this revision. michaelh added reviewers: Frameworks, vhanda, smithjd, lbeltrame. michaelh added a project: Frameworks. michaelh requested review of this revision. REVISION SUMMARY - added -f|--format option - implemented formatters 'simple', 'json', 'multiline' (=current out

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 22 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/22/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Thu, 18 Jan 2018 08:46:21 + Build duration: 13 min and counting JUnit Tests Name: (root) F

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 23 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/23/ Project: Frameworks baloo kf5-qt5 SUSEQt5.7 Date of build: Thu, 18 Jan 2018 08:46:21 + Build duration: 6 min 29 sec and counting JUnit Tests Name: (ro

D9712: balooctl status: translatable message

This revision was automatically updated to reflect the committed changes. Closed by commit R293:e733c7f72695: balooctl status: translatable message (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9712?vs=25466&id=25576 REVISION DETAIL h