KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 71 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/71/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 17 Jan 2018 03:59:57 + Build duration: 11 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 22 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/22/ Project: Frameworks baloo kf5-qt5 SUSEQt5.7 Date of build: Tue, 16 Jan 2018 23:23:47 + Build duration: 17 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/21/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Tue, 16 Jan 2018 23:23:47 + Build duration: 5 min 32 sec and counting JUnit Tests Name: (

D1231: Add Remote Access interface to KWayland

ngraham added a comment. @graesslin, would you mind reviewing this so we can push forward with the feature? Thanks! REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: romangg, ngraham, alexeymin, #frameworks, davidedmun

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. @ngraham, yes, he didn't review this after changes were made REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: romangg, ngraham, alexeymin, #frameworks, davidedmundson, plasma-devel, leezu, Zr

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

rjvbb added a comment. > i'm assuming the cost would be bigger then the benefit. (just an assumption here, i could be wrong) That's why it has to be measured. I've never seen processing (reaction) times that measure in minutes with either backend (which in turn is assuming that you

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 70 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/70/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 16 Jan 2018 17:59:35 + Build duration: 1 hr 4 min and counting JUnit Tests Name: (ro

Re: Python bindings using cppyy (was: An update on Python bindings)

Hi Luca, On 15 January 2018 at 08:24, Luca Beltrame wrote: > Il giorno Sat, 13 Jan 2018 18:05:45 + > Shaheed Haque ha scritto: > > Hello Shaheed, > > >1. The packaging has advanced to the point where I think ECM-based > >framework-by-framework bindings are a real possibility, with b

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

aacid added a comment. Wonder if QFile really should be giving a warning if the path is empty instead of just returning false to be honest, but i'll leave it to the plasma devs to decide if they want this or if we should try to convince Qt to be less spammy REPOSITORY R242 Plasma Framewor

D1231: Add Remote Access interface to KWayland

ngraham added a comment. What's the status of this? Are we waiting for something other than @graesslin's review? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: romangg, ngraham, alexeymin, #frameworks, davidedmundso

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 89 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/89/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 16 Jan 2018 17:59:35 + Build duration: 6 min 23 sec and counting JUnit Tests Name: (root)

D9863: Fix overlap of the first item in KFilePlacesView

This revision was automatically updated to reflect the committed changes. Closed by commit R241:95f6e4929333: Fix overlap of the first item in KFilePlacesView (authored by fvogt). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9863?vs=25277&id=25493#toc REPOSITORY R241 KIO CHANGES SIN

D9880: Fix build with >=attr-2.4.48

This revision was automatically updated to reflect the committed changes. Closed by commit R286:4bbc7a2f5c77: Fix build with >=attr-2.4.48 (authored by Lars Wendler , committed by asturmlechner). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabric

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

anthonyfieroni added a reviewer: davidedmundson. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9928 To: rkron, #frameworks, davidedmundson Cc: #frameworks

D9880: Fix build with >=attr-2.4.48

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. Sorry for not having checked the correct git repository. REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D9880 To: asturmlechner, #framew

D9863: Fix overlap of the first item in KFilePlacesView

renatoo accepted this revision. renatoo added a comment. This revision is now accepted and ready to land. looks good REPOSITORY R241 KIO BRANCH fixes REVISION DETAIL https://phabricator.kde.org/D9863 To: fvogt, #frameworks, dfaure, renatoo

D9928: Fix one source of log spam referenced in Bug 388389 (Empty filename passed to function)

rkron created this revision. rkron added a reviewer: Frameworks. rkron added a project: Frameworks. rkron requested review of this revision. REVISION SUMMARY I found two places in plasma-framework svg.cpp (Plasma::Svg) that were triggering this message. path variable was not being checked

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/28/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 16 Jan 2018 15:21:27 + Build duration: 1 hr 12 min and counting JUnit Tests

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

markg added a comment. In https://phabricator.kde.org/D9824#191929, @rjvbb wrote: > I am going to assume you would have said so by now if the fix is not applicable to the QFSW backend because it doesn't do the same costly walk. > > > > So please MAKE your PATCH TOUCH the QFSW backen

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/35/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.10 Date of build: Tue, 16 Jan 2018 15:21:27 + Build duration: 4 min 48 sec and counting JUnit Tests N

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

rjvbb added a comment. I am going to assume you would have said so by now if the fix is not applicable to the QFSW backend because it doesn't do the same costly walk. > > So please MAKE your PATCH TOUCH the QFSW backend AND MEASURE THE IMPACT ON ITS PERFORMANCE I don't care a rat'

D9766: Use at least the requested width for the argument hint tree

kfunk reopened this revision. kfunk added a comment. LGTM. Just a had a quick look at the appearance of the popup before vs. after the patch when doing code completion inside the a function call parameter list. Looks more consisten now, thanks! REPOSITORY R39 KTextEditor REVISION DET

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 34 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/34/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 Date of build: Tue, 16 Jan 2018 14:13:41 + Build duration: 8 min 44 sec and counting JUnit Tests

D9766: Use at least the requested width for the argument hint tree

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R39:0d0284e8f8d2: Use at least the requested width for the argument hint tree (authored by mwolff). REPOSITORY R39 KTextE

D9712: balooctl status: produce parseable output

michaelh updated this revision to Diff 25466. michaelh marked 2 inline comments as done. michaelh added a comment. Removed and tags REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9712?vs=25459&id=25466 BRANCH translated REVISION DETAIL https://phabric

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/27/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Tue, 16 Jan 2018 13:50:21 + Build duration: 3 min 58 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/16/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 16 Jan 2018 13:50:21 + Build duration: 2 min 51 sec and counting JUnit Tes

D9925: Keep some messages untranslated

michaelh abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D9925 To: michaelh Cc: #frameworks

D9925: Keep some messages untranslated

michaelh created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. REPOSITORY R293 Baloo BRANCH translated REVISION DETAIL https://phabricator.kde.org/D9925 AFFECTED FILES

D9712: balooctl status: produce parseable output

michaelh added inline comments. INLINE COMMENTS > statuscommand.cpp:109 > > -out << i18n("File: %1", filePath) << endl; > +out << i18n("File: %1", filePath) << endl; > ... overkill? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D9712 To: mi

D9712: balooctl status: produce parseable output

michaelh updated this revision to Diff 25459. michaelh added a comment. Reverted parseablity in preparation for a --format switch Sending error messages to stderr i18n'ed all messages REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9712?vs=24943&id=25459

D9712: balooctl status: produce parseable output

vhanda added a comment. In https://phabricator.kde.org/D9712#191746, @ltoscano wrote: > May I observe that relying on the command line output is fragile in the best case? > Unless the command can produce the output in some formatted way (like the openstack CLI, which can enable a spe

D9766: Use at least the requested width for the argument hint tree

dhaumann added a comment. I would prefer if you commit this soon, since then we still have 3 weeks for testing. To me this look ok, but I cannot say whether there are side-effects or not. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9766 To: mwolff, #kdevelo

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

mwolff added a comment. In https://phabricator.kde.org/D9824#191748, @rjvbb wrote: > So please do measure the impact of your fix on performance with the QFSW backend. It's zero, since this patch only touches the inotify backend. REPOSITORY R244 KCoreAddons REVISION DETAIL ht

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

rjvbb added a comment. > But I won't write mega patches like you seem to prefer. I don't. They happen when it's more cumbersome than self-evident to go back and break up a new feature in baby-step components and justify adding them one at a time. > I try to keep things as minimal as

D9712: balooctl status: produce parseable output

ltoscano added a comment. May I observe that relying on the command line output is fragile in the best case? Unless the command can produce the output in some formatted way (like the openstack CLI, which can enable a special mode to produce output in various formats like csv, table-format

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/23/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 16 Jan 2018 10:57:34 + Build duration: 11 min and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/47/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 16 Jan 2018 10:57:34 + Build duration: 10 min and counting JUnit Tes

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/50/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Tue, 16 Jan 2018 10:57:34 + Build duration: 7 min 37 sec and counting JUnit

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

mwolff added a comment. Yeah, I agree. Let's fix it. But I won't write mega patches like you seem to prefer. I try to keep things as minimal as possible. And I also can't give you an ETA or guarantee on when I'll fix the rest. This patch solves one big issues, and the added benchmark lies th

D9019: [Calendar] Adjust the calendar toolbar anchors

This revision was automatically updated to reflect the committed changes. Closed by commit R242:55efe5ae6357: [Calendar] Adjust the calendar toolbar anchors (authored by akulichalexandr). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9019?v

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/22/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 16 Jan 2018 10:42:51 + Build duration: 10 min and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/49/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Tue, 16 Jan 2018 10:42:51 + Build duration: 9 min 17 sec and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/46/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 16 Jan 2018 10:42:51 + Build duration: 7 min 35 sec and counting JUn

D9712: balooctl status: produce parseable output

lbeltrame added inline comments. INLINE COMMENTS > statuscommand.cpp:111 > + if (tr.hasDocument(id)) { > + out << i18n("Basic indexing done"); > + } else if (cfg.shouldBeIndexed(filePath)) { If we want output of `balooctl status ` to be parseable, then

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

rjvbb added a comment. > @rjvbb why did you request changes to proceed with this patch? The fact that there are more issues in KDirWatch does not mean we should hold up this approach. That should be obvious, no? You identified an issue but only addressed it in a single backend. As far

D9912: [KNewFileMenu] KDirNotify::emitFilesAdded after storedPut

broulik created this revision. broulik added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. broulik requested review of this revision. REVISION SUMMARY Ensures KDirLister is updated immediately when a new file is cre

D8908: KDateComboBox: fix dateChanged() not emitted after typing a date

mlaurent accepted this revision. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D8908 To: dfaure, cfeck, dvratil, mlaurent Cc: mlaurent, anthonyfieroni, #frameworks, #kde_pim

D9766: Use at least the requested width for the argument hint tree

mwolff added a subscriber: kfunk. mwolff added a comment. ping? @kfunk maybe? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9766 To: mwolff, #kdevelop, #kate Cc: kfunk, #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D8908: KDateComboBox: fix dateChanged() not emitted after typing a date

dfaure updated this revision to Diff 25443. dfaure added a comment. add QVERIFY REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8908?vs=22624&id=25443 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8908 AFFECTED FILES autotests/kd

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

mwolff added a comment. @rjvbb why did you request changes to proceed with this patch? The fact that there are more issues in KDirWatch does not mean we should hold up this approach. Also, please note how the fundamental issue described here affects more backends beside inotify, but the

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

mwolff updated this revision to Diff 25441. mwolff added a comment. use QHash::insert instead of operator[] REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9824?vs=25171&id=25441 REVISION DETAIL https://phabricator.kde.org/D9824 AFFECTED FILES src/

D9888: Make kdesu work when PWD is /usr/bin

This revision was automatically updated to reflect the committed changes. Closed by commit R299:86954e039463: Make kdesu work when PWD is /usr/bin (authored by mwolff). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9888?vs=25395&id=25440#toc REPOSITORY R299 KDESu CHANGES SINCE LAST U