aacid closed this revision.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D9899
To: aacid, apol
Cc: apol, vkrause, #frameworks, #build_system
mlaurent added a comment.
Ping ?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: dfaure, #frameworks
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/88/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Tue, 16 Jan 2018 03:52:49 +
Build duration:
31 min and counting
JUnit Tests
Name: (root) Fail
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/69/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Tue, 16 Jan 2018 03:52:49 +
Build duration:
26 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/20/
Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
Date of build:
Tue, 16 Jan 2018 01:23:19 +
Build duration:
4 min 30 sec and counting
JUnit Tests
Name: (
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/21/
Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
Date of build:
Tue, 16 Jan 2018 01:23:19 +
Build duration:
3 min 29 sec and counting
JUnit Tests
Name: (ro
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Never seen this issue, but I'm happy to have it in. If it has regressions we
can revert it.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org
asturmlechner added a comment.
In https://phabricator.kde.org/D9880#191545, @mgallien wrote:
> Are you sure attr/xattr.h is deprecated ?
Yep, it is gone in 2.4.48, but the commit that removed it is from 2015:
http://git.savannah.nongnu.org/cgit/attr.git/commit/?id=7921157890d07858
ngraham added a comment.
FWIW, this change did not fix https://bugs.kde.org/show_bug.cgi?id=252483
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D5199
To: broulik, hein, dfaure
Cc: ngraham, markg, #frameworks
vkrause added a comment.
Sounds familiar: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129
Your patch looks like a viable workaround to me.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D9899
To: aacid
Cc: vkrause, #frameworks, #build_system
mgallien added a comment.
Are you sure attr/xattr.h is deprecated ?
I did look at what debian provides with version 2.4.47 and there seems to
have a valid attr/xattr.h file.
I also did found some partial information by searching the web but nothing
conclusive.
REPOSITORY
R286 KFileMeta
aacid created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
aacid requested review of this revision.
REVISION SUMMARY
Without this i get
In file included from
/home/tsdgeos/Android/Sdk/ndk
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20WindowsMSVCQt5.9/17/
Project:
Frameworks threadweaver kf5-qt5 WindowsMSVCQt5.9
Date of build:
Mon, 15 Jan 2018 14:56:09 +
Build duration:
4 hr 11 min and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/27/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 17:25:42 +
Build duration:
1 hr 34 min and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R288:240a9c1f01d0: Code de-duplication in byteSize(double
size) (authored by jtamate).
REPOSITORY
R288 KJobWidgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9770?vs=25121&id=25411
REVISIO
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/21/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 14:55:42 +
Build duration:
3 hr 10 min and counting
apol added inline comments.
INLINE COMMENTS
> udisksdevice.cpp:614
> +}
> +return "drive-harddisk";
> +} else if (isSwap()) {
return QStringLiteral("drive-harddisk");
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D9894
To: broulik, #vdg, davidedmund
broulik created this revision.
broulik added reviewers: Plasma, VDG, Frameworks.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
This gets rid of all those internal mou
broulik created this revision.
broulik added reviewers: VDG, davidedmundson.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
broulik requested review of this revision.
REVISION SUMMARY
Instead of showing generic "Loop Device" for everyth
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/22/
Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 14:55:12 +
Build duration:
2 hr 55 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/68/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 14:53:47 +
Build duration:
2 hr 53 min and counting
JUnit Tests
Name: (r
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.9/5/
Project:
Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 14:55:02 +
Build duration:
2 hr 48 min and counting
JUnit Tes
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.9/8/
Project:
Frameworks kservice kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 14:54:54 +
Build duration:
2 hr 42 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.9/6/
Project:
Frameworks krunner kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 14:54:49 +
Build duration:
2 hr 40 min and counting
JUnit Tests
N
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.9/5/
Project:
Frameworks kpty kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 14:54:44 +
Build duration:
2 hr 39 min and counting
JUnit Tests
Name: (
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/14/
Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 14:54:26 +
Build duration:
2 hr 37 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/26/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 14:53:53 +
Build duration:
2 hr 31 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/15/
Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 14:52:49 +
Build duration:
2 hr 27 min and counting
JU
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kpeople%20kf5-qt5%20WindowsMSVCQt5.9/16/
Project:
Frameworks kpeople kf5-qt5 WindowsMSVCQt5.9
Date of build:
Mon, 15 Jan 2018 14:54:36 +
Build duration:
2 hr 12 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/34/
Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 14:51:51 +
Build duration:
2 hr 14 min and counting
JUnit Te
dweatherill added a comment.
I don't have commit access but please let me know if anything else is needed
before it can be merged.
(for submission)
Name: Dan Weatherill
email: dan.weather...@cantab.net
REPOSITORY
R284 KCompletion
REVISION DETAIL
https://phabricator.kde.org/D9808
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/19/
Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
Date of build:
Mon, 15 Jan 2018 16:19:01 +
Build duration:
23 min and counting
JUnit Tests
Name: (root) F
I'm wrong. the changes are BC since I'm just moving static functions around.
Moving KHolidays anytime you want is fine with me.
On Sunday, January 14, 2018 2:02:48 PM EST Volker Krause wrote:
> On Sunday, 14 January 2018 16:50:08 CET Sandro Knauß wrote:
> > @Volker: Is there a need to rush releas
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/20/
Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
Date of build:
Mon, 15 Jan 2018 16:19:01 +
Build duration:
9 min 57 sec and counting
JUnit Tests
Name: (ro
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/19/
Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
Date of build:
Mon, 15 Jan 2018 15:36:21 +
Build duration:
34 min and counting
JUnit Tests
Name: (root) Fa
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/36/
Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
Date of build:
Mon, 15 Jan 2018 15:40:11 +
Build duration:
28 min and counting
JUnit Tests
N
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/33/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
Date of build:
Mon, 15 Jan 2018 14:54:59 +
Build duration:
1 hr 9 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/48/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Mon, 15 Jan 2018 14:55:42 +
Build duration:
1 hr 8 min and counting
JUnit T
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kglobalaccel%20kf5-qt5%20WindowsMSVCQt5.9/28/
Project:
Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.9
Date of build:
Mon, 15 Jan 2018 14:53:18 +
Build duration:
1 hr 10 min and counting
J
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
Otherwise all is good. +2 with the QVERIFY(...)
INLINE COMMENTS
> kdatecomboboxtest.cpp:182
> +combo->activateWindow();
> +QTest::qWaitForWindowActive(combo.data());
> +
QVERIF
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.7/12/
Project:
Frameworks kservice kf5-qt5 SUSEQt5.7
Date of build:
Mon, 15 Jan 2018 14:54:54 +
Build duration:
57 min and counting
JUnit Tests
Name: (ro
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.7/14/
Project:
Frameworks krunner kf5-qt5 SUSEQt5.7
Date of build:
Mon, 15 Jan 2018 14:54:49 +
Build duration:
55 min and counting
JUnit Tests
Name: (root
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20SUSEQt5.7/8/
Project:
Frameworks kpty kf5-qt5 SUSEQt5.7
Date of build:
Mon, 15 Jan 2018 14:54:44 +
Build duration:
54 min and counting
JUnit Tests
Name: (root) Failed
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.7/20/
Project:
Frameworks kpackage kf5-qt5 SUSEQt5.7
Date of build:
Mon, 15 Jan 2018 14:54:26 +
Build duration:
53 min and counting
JUnit Tests
Name: (ro
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/21/
Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.7
Date of build:
Mon, 15 Jan 2018 14:52:49 +
Build duration:
54 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/35/
Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.7
Date of build:
Mon, 15 Jan 2018 14:51:51 +
Build duration:
48 min and counting
JUnit Tests
N
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/18/
Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
Date of build:
Mon, 15 Jan 2018 15:01:25 +
Build duration:
32 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/36/
Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
Date of build:
Mon, 15 Jan 2018 15:03:09 +
Build duration:
33 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/12/
Project:
Frameworks kwindowsystem kf5-qt5 SUSEQt5.10
Date of build:
Mon, 15 Jan 2018 14:55:17 +
Build duration:
40 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/18/
Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
Date of build:
Mon, 15 Jan 2018 14:51:45 +
Build duration:
44 min and counting
JUnit Tests
Name: (root) Fa
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/45/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Mon, 15 Jan 2018 14:55:42 +
Build duration:
30 min and counting
JUnit Tes
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/13/
Project:
Frameworks kservice kf5-qt5 SUSEQt5.10
Date of build:
Mon, 15 Jan 2018 14:54:54 +
Build duration:
27 min and counting
JUnit Tests
Name: (
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/14/
Project:
Frameworks krunner kf5-qt5 SUSEQt5.10
Date of build:
Mon, 15 Jan 2018 14:54:49 +
Build duration:
25 min and counting
JUnit Tests
Name: (ro
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/20/
Project:
Frameworks kpackage kf5-qt5 SUSEQt5.10
Date of build:
Mon, 15 Jan 2018 14:54:26 +
Build duration:
23 min and counting
JUnit Tests
Name: (
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/34/
Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
Date of build:
Mon, 15 Jan 2018 14:53:53 +
Build duration:
19 min and counting
JUnit Tests
Name: (
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/20/
Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.10
Date of build:
Mon, 15 Jan 2018 14:52:49 +
Build duration:
18 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/35/
Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
Date of build:
Mon, 15 Jan 2018 14:51:51 +
Build duration:
11 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/17/
Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
Date of build:
Mon, 15 Jan 2018 14:51:45 +
Build duration:
9 min 39 sec and counting
JUnit Tests
Name: (
dfaure added a comment.
Done, kwidgetaddons-5.42.1 is out:
https://download.kde.org/stable/frameworks/5.42/
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D9884
To: sars, #frameworks, mlaurent
Cc: dhaumann, dfaure, ltoscano
dfaure added a comment.
ping?
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8908
To: dfaure, cfeck, dvratil
Cc: anthonyfieroni, #frameworks, #kde_pim
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/25/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 12:28:15 +
Build duration:
1 hr 48 min and counting
JUnit Tests
dhaumann added subscribers: dfaure, dhaumann.
dhaumann added a comment.
@dfaure Can we provide an update to KWidgetAddons? Is this feasible? If not,
we should at least announce this bug on kde-distro-packag...@kde.org, since
this breaks Kate.
Second question: How did this happen in the f
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/20/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 12:09:31 +
Build duration:
1 hr 51 min and counting
This revision was automatically updated to reflect the committed changes.
Closed by commit R824:1dd9509a29f1: [baloo-widgets] Display releaseYear w/o
decimal grouping (authored by michaelh).
REPOSITORY
R824 Baloo Widgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9887?vs=25390&id
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/67/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 11:33:41 +
Build duration:
1 hr 50 min and counting
JUnit Tests
Name: (r
sitter accepted this revision.
sitter added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> suprocess.cpp:122
>
> -QByteArray command;
> -if (d->superUserCommand == QLatin1String("sudo")) {
> -command = __PATH_SUDO;
> -} else {
> -
mwolff updated this revision to Diff 25395.
mwolff retitled this revision from "Let kdesu work when __PATH_SU or
__PATH_SUDO are not defined" to "Make kdesu work when PWD is /usr/bin".
mwolff edited the summary of this revision.
mwolff added a subscriber: sitter.
mwolff added a comment.
cleanu
mwolff added a comment.
FTR:
[13:35] how the hell can kdesu ever work?
https://phabricator.kde.org/D9888 WTF
[13:35] does anyone know if I'm missing something?
[13:35] googling for these macros doesn't show me anything obvious
either
[13:53] milian: dead code I'd say. n
michaelh added a reviewer: smithjd.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D9712
To: michaelh, #frameworks, vhanda, smithjd
Cc: elvisangelaccio, lueck, dfaure, ngraham
jtamate updated this revision to Diff 25391.
jtamate added a comment.
I'm sorry for the inconvenience.
I'm going to divide the patch in two, the first part only changes lastTimeout
and should be safe.
nextTimeout part needs more thinking (if can be done).
REPOSITORY
R241 KIO
CHANGES SI
mwolff edited the summary of this revision.
REPOSITORY
R299 KDESu
REVISION DETAIL
https://phabricator.kde.org/D9888
To: mwolff, dfaure, mpyne
Cc: #frameworks
mwolff created this revision.
mwolff added reviewers: dfaure, mpyne.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
mwolff requested review of this revision.
REVISION SUMMARY
I quite frankly don't understand how this code can ever work.
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R824 Baloo Widgets
BRANCH
releaseYear (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9887
To: michaelh, #frameworks, #dolphin, broulik
Cc: elvisangelaccio, ngraham
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/24/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 10:14:04 +
Build duration:
2 hr 13 min and counting
JUnit Tests
michaelh created this revision.
michaelh added reviewers: Frameworks, Dolphin.
michaelh added a project: Frameworks.
michaelh requested review of this revision.
REVISION SUMMARY
Display release year as e.g. "2010" instead of "2.010"
TEST PLAN
Visual inspection
REPOSITORY
R824 Baloo Widgets
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/86/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Mon, 15 Jan 2018 11:33:41 +
Build duration:
45 min and counting
JUnit Tests
Name: (root) Failed:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/19/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 09:23:28 +
Build duration:
2 hr 45 min and counting
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/86/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Mon, 15 Jan 2018 11:33:41 +
Build duration:
29 min and counting
JUnit Tests
Name: (root) Faile
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:ee34537ff55c: KMultiTabBar: Fix regression in conversion
to new style connect() (authored by sars).
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9884?vs=25
ltoscano reopened this revision.
ltoscano added a comment.
This revision is now accepted and ready to land.
Give it some time. Right now Phabricator is only observing the repositories,
not handling them, and this means that an update can land with some delay.
REPOSITORY
R236 KWidgetsAddons
sars closed this revision.
sars added a comment.
For some reason this review was not closed automatically by the commit.
Closing manually.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D9884
To: sars, #frameworks, mlaurent
fvogt reopened this revision.
fvogt added a comment.
This revision is now accepted and ready to land.
Reverted in master as this broke various important ioslaves, like desktop and
trash.
I believe the issue is that the timeout fires immediately after construction,
without being configure
Git commit 16b21e7223f5bc070dcfd540ede55e5837ccc097 by Fabian Vogt.
Committed on 15/01/2018 at 11:31.
Pushed by fvogt into branch 'master'.
Revert "Don't stat(/etc/localtime) between read() and write() copying files"
This reverts commit f7e00b40a6d35fbfe536cdb99d6f22b643676e5e.
This results in c
dfaure added a comment.
I'm 100% sure the same rules applies, because the "limitations" of operator[]
come from C++ and therefore apply to all associative containers.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9824
To: mwolff, dfaure, rjvbb, #kdevelop
Cc: m
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
indeed good catch
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D9884
To: sars, #frameworks, mlaurent
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/33/
Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
Date of build:
Mon, 15 Jan 2018 10:19:26 +
Build duration:
5 min 4 sec and counting
JUnit Tests
Na
sars created this revision.
sars added reviewers: Frameworks, mlaurent.
Restricted Application added a project: Frameworks.
sars requested review of this revision.
REVISION SUMMARY
The conversion to new style connect introduced a bug. The old connect
properly used the base class signal while th
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/32/
Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
Date of build:
Mon, 15 Jan 2018 10:14:04 +
Build duration:
5 min 20 sec and counting
JUnit Tests
N
markg added inline comments.
INLINE COMMENTS
> dfaure wrote in kdirwatch.cpp:721
> .insert(e->wd, e) is a hair faster, says Effective STL Item 24 :)
m_inotify_wd_to_entry is a QHash, not a std::unordered_map ;)
Not sure if the same rules from that book apply to Qt (i doubt it).
REPOSITORY
R24
jtamate abandoned this revision.
REPOSITORY
R309 KService
REVISION DETAIL
https://phabricator.kde.org/D9840
To: jtamate, #frameworks, dfaure
Cc: ngraham, mmustac
jtamate retitled this revision from "Optimization of byteSize(double size)" to
"Code de-duplication in byteSize(double size)".
jtamate edited the summary of this revision.
jtamate edited the test plan for this revision.
REPOSITORY
R288 KJobWidgets
BRANCH
performance (branched from master)
R
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20FreeBSDQt5.9/12/
Project:
Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 09:03:58 +
Build duration:
1 hr 6 min and counting
broulik abandoned this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4361
To: broulik, #plasma
Cc: bshah, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Oh, right. I see. Still very strange that QTRY_COMPARE_WITH_TIMEOUT behaves
differently (if more signals are coming in than expected, the current (old)
code could have caught them too, duri
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/47/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Mon, 15 Jan 2018 09:33:19 +
Build duration:
18 min and counting
JUnit Tests
mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.
- do not ever profile a debug build, the results are completely bogus
- do not use callgrind, use perf
that said, I'm OK with this patch but the commit message should not talk
about p
broulik closed this revision.
broulik added a comment.
https://cgit.kde.org/kdeclarative.git/commit/?id=84a370ce2c3ac48be9e8745a93cd347bba463323
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D9784
To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenB
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/44/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Mon, 15 Jan 2018 09:39:32 +
Build duration:
3 min 34 sec and counting
JUn
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/66/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Mon, 15 Jan 2018 09:03:20 +
Build duration:
38 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/43/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Mon, 15 Jan 2018 09:23:28 +
Build duration:
16 min and counting
JUnit Tes
1 - 100 of 116 matches
Mail list logo
