mlaurent added a comment.
no news ?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: #frameworks
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/32/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Thu, 28 Dec 2017 03:42:56 +
Build duration:
32 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/52/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Thu, 28 Dec 2017 03:42:56 +
Build duration:
24 min and counting
JUnit Tests
Name: (root) Fail
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/53/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Thu, 28 Dec 2017 03:42:56 +
Build duration:
11 min and counting
JUnit Tests
Name: (root) Failed
anthonyfieroni added a comment.
I don't want to bother you but even last attempt can have race condition. If
slotVerifyChecksums is called while future is not finished read/write cache can
occur.
https://paste.kde.org/pdqu2bywp/sccbzb
I'm not using mutex at all. You can always use a signa
petermajchrak added a comment.
Is there a way to separate this class to its own file? Or is it some
convention in this project to have these huge files?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8536
To: petermajchrak, elvisangelaccio, #vdg, colomar
Cc: colomar, a
petermajchrak added inline comments.
INLINE COMMENTS
> kpropertiesdialog.cpp:2825
> +QMutexLocker locker(&d->mutex);
> +cacheChecksum(checksum, alg);
> +}
If the mutex is locked only around the cacheChecksum function I might as well
put in back inside it
REPOSIT
petermajchrak added a comment.
Won't using the blocking versions block the UI as well?... that's why I chose
to use the non blocking versions and just update the UI once the work is
finished by the other threads.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8536
To:
petermajchrak updated this revision to Diff 24402.
petermajchrak added a comment.
Screen out the cached algorithms beforehand
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8536?vs=24401&id=24402
REVISION DETAIL
https://phabricator.kde.org/D8536
AFFECTED FI
anthonyfieroni added a comment.
Even more future watcher will not needed anymore, if you use blocked mapper.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8536
To: petermajchrak, elvisangelaccio, #vdg, colomar
Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham,
anthonyfieroni added inline comments.
INLINE COMMENTS
> petermajchrak wrote in kpropertiesdialog.cpp:2798-2804
> I can add two critical sections, one for reading the cache and one for
> writing while the hash computation is not in either of them
Basically you need computation only one time when
petermajchrak marked 2 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8536
To: petermajchrak, elvisangelaccio, #vdg, colomar
Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio,
#frameworks
petermajchrak added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kpropertiesdialog.cpp:2798-2804
> You don't understand me, now you have a race condition. cachedChecksum reads
> from cache while cacheChecksum writes. It's a race condition and you need
> mutex here. When you add he
anthonyfieroni added inline comments.
INLINE COMMENTS
> petermajchrak wrote in kpropertiesdialog.cpp:2798-2804
> But adding a mutex for guarding the body of the mapper function will
> serialize the hash computations. The computations themselves are independent
> and parallelizable, only the syn
petermajchrak updated this revision to Diff 24401.
petermajchrak added a comment.
Fix mutex placement and add show cached checksum values when combobox value
is changed
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8536?vs=24390&id=24401
REVISION DETAIL
ht
petermajchrak added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kpropertiesdialog.cpp:2798-2804
> You don't understand me, now you have a race condition. cachedChecksum reads
> from cache while cacheChecksum writes. It's a race condition and you need
> mutex here. When you add he
anthonyfieroni added inline comments.
INLINE COMMENTS
> kpropertiesdialog.cpp:2798-2804
> +const QString cache = cachedChecksum(alg);
> +if (!cache.isEmpty()) {
> +return cache;
> +}
>
> -void KChecksumsPlugin::slotShowSha256()
> -{
> -auto label = new QL
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
REPOSITORY
R127 KWayland
BRANCH
idle-timeout-simulate-user-activity
REVISION DETAIL
https://phabricator.kde.org/D9510
To
petermajchrak added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kpropertiesdialog.cpp:3015
> Mutex is not needed here.
This function is called from the QtConcurrent mapper function and therefore can
be called concurrently by more threads. QMap::insert is not thread safe for
conc
petermajchrak marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8536
To: petermajchrak, elvisangelaccio, #vdg, colomar
Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio,
#frameworks
petermajchrak updated this revision to Diff 24390.
petermajchrak added a comment.
Capture item path by value
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8536?vs=24389&id=24390
REVISION DETAIL
https://phabricator.kde.org/D8536
AFFECTED FILES
src/widgets
anthonyfieroni added inline comments.
INLINE COMMENTS
> kpropertiesdialog.cpp:2795-2805
> +std::function mapper =
> [this](QCryptographicHash::Algorithm alg) {
> +const QString cache = cachedChecksum(alg);
> +if (!cache.isEmpty()) {
> +return cache;
> +}
>
petermajchrak updated this revision to Diff 24389.
petermajchrak added a comment.
Format algorithm values in combobox.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8536?vs=24381&id=24389
REVISION DETAIL
https://phabricator.kde.org/D8536
AFFECTED FILES
s
23 matches
Mail list logo
