mlaurent updated this revision to Diff 23114.
mlaurent marked 4 inline comments as done.
mlaurent added a comment.
- Fix error found by David
REPOSITORY
R309 KService
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9044?vs=23113&id=23114
BRANCH
fix_compile_QT_NO_CAST_FROM_ASCII
mlaurent added inline comments.
INLINE COMMENTS
> dfaure wrote in kbuildsycoca.cpp:248
> `fromLatin1` would do, it's ascii strings like "services" etc.
Yep I was not sure about this one.
It confirms that this one was incorrect.
I will fix all soon.
REPOSITORY
R309 KService
REVISION DETAIL
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/3/
Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.10
Date of build:
Wed, 29 Nov 2017 06:45:35 +
Build duration:
21 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/3/
Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.7
Date of build:
Wed, 29 Nov 2017 06:45:35 +
Build duration:
15 min and counting
JUnit Tests
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
BRANCH
master-nestedTags (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D8098
To: smithjd, #frameworks, vhanda, #dolphin, ngraham, dfaure
Cc: anthonyfieroni, dfaure, n
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R244 KCoreAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9004
To: jtamate, #frameworks, dfaure, anthonyfieroni
Cc: anthonyfieroni
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kbuildservicegroupfactory.cpp:84
>
> -if (menuName != "/") {
> +if (menuName != QStringLiteral("/")) {
> // Make sure parent dir exists.
Us
mlaurent created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
Compile it
REPOSITORY
R309 KService
BRANCH
fix_compile_QT_NO_CAST_FROM_ASCII
REVISION DETAIL
https://phabricator.kde.org/D9044
AFFECTED F
mlaurent added a reviewer: dfaure.
REPOSITORY
R309 KService
REVISION DETAIL
https://phabricator.kde.org/D9044
To: mlaurent, dfaure
Cc: #frameworks
graesslin accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8919
To: davidedmundson, #plasma, graessl
shaheed added inline comments.
INLINE COMMENTS
> turbov wrote in FindPythonModuleGeneration.cmake:217
> As for me, I would remove whole this part of "brute forcing" available clang
> version. I can't see how it could work w/o additional hints due a location
> of `libclang` is not a standard di
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20FreeBSDQt5.7/24/
Project:
Frameworks kunitconversion kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 28 Nov 2017 22:20:10 +
Build duration:
1 min 33 sec and counting
JU
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/12/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Tue, 28 Nov 2017 22:04:28 +
Build duration:
12 min and counting
JUnit Tests
Name: (root) Fail
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/12/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Tue, 28 Nov 2017 22:04:29 +
Build duration:
11 min and counting
JUnit Tests
Name: (root) Failed
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/152/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 28 Nov 2017 22:04:29 +
Build duration:
9 min 36 sec and counting
JUnit Tests
Name:
elvisangelaccio added a comment.
Ping?
In https://phabricator.kde.org/D8698#165475, @ngraham wrote:
> Is the same problem present in the non-test code? I just noticed
https://bugs.kde.org/show_bug.cgi?id=384991, which seems to report a similar or
identical issue.
I replied i
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:549fc81e8e8a: Don't check whether an empty filename
exists (authored by elvisangelaccio).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8697?vs=22035&id=23106
REVISIO
elvisangelaccio updated this revision to Diff 23105.
elvisangelaccio marked 3 inline comments as done.
elvisangelaccio added a comment.
- Addressed comments
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8336?vs=20870&id=23105
BRANCH
master
REVISION
turbov added a comment.
ping
REVISION DETAIL
https://phabricator.kde.org/D7175
To: turbov, dhaumann, #kate, #framework_syntax_highlighting, vkrause
Cc: cullmann, #frameworks
smithjd updated this revision to Diff 23101.
smithjd added a comment.
- Fix tagged directory listing.
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8098?vs=22940&id=23101
BRANCH
master-nestedTags (branched from master)
REVISION DETAIL
https://phabricat
turbov updated this revision to Diff 23100.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7175?vs=6&id=23100
REVISION DETAIL
https://phabricator.kde.org/D7175
AFFECTED FILES
data/generators/cmake-gen.sh
data/generators/cmake.xml.tpl
data/generators/cmake.yaml
data/genera
anthonyfieroni added a comment.
You can discard this one in front of https://phabricator.kde.org/D9004
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9005
To: jtamate, #frameworks, dfaure
Cc: anthonyfieroni, elvisangelaccio
jtamate updated this revision to Diff 23097.
jtamate added a comment.
- Input validation of SubJobs and disconnect signals
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9004?vs=23049&id=23097
BRANCH
master
REVISION DETAIL
https://phabricator.kde.
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20knotifications%20kf5-qt5%20WindowsMSVCQt5.9/17/
Project:
Frameworks knotifications kf5-qt5 WindowsMSVCQt5.9
Date of build:
Tue, 28 Nov 2017 09:45:10 +
Build duration:
8 hr 15 min and counting
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kglobalaccel%20kf5-qt5%20WindowsMSVCQt5.9/17/
Project:
Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.9
Date of build:
Tue, 28 Nov 2017 16:26:56 +
Build duration:
2 min 10 sec and counting
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kglobalaccel%20kf5-qt5%20FreeBSDQt5.7/26/
Project:
Frameworks kglobalaccel kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 28 Nov 2017 16:26:56 +
Build duration:
1 min 18 sec and counting
JUnit Te
ngraham added a comment.
@mwolff, is this good now?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8367
To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent
Cc: mwolff, ngraham, mlaurent, #frameworks
broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> udevmanager.cpp:182
> +const UdevQt::DeviceList deviceList = d->m_client->allDevices();
> +Q_FOREACH (const UdevQt::Device &dev, deviceList) {
> +
davidedmundson edited the summary of this revision.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D8495
To: davidedmundson
Cc: #frameworks
davidedmundson updated this revision to Diff 23086.
davidedmundson added a comment.
Rewrite, changes less stuff.
REPOSITORY
R245 Solid
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8495?vs=21368&id=23086
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8495
AFFEC
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcodecs%20kf5-qt5%20WindowsMSVCQt5.9/10/
Project:
Frameworks kcodecs kf5-qt5 WindowsMSVCQt5.9
Date of build:
Tue, 28 Nov 2017 12:26:05 +
Build duration:
1 min 28 sec and counting
JUnit Test
davidedmundson updated this revision to Diff 23083.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
Add line in docs
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8919?vs=22890&id=23083
BRA
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/151/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 28 Nov 2017 11:40:33 +
Build duration:
38 min and counting
JUnit Tests
Name: (root)
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/11/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Tue, 28 Nov 2017 11:40:33 +
Build duration:
10 min and counting
JUnit Tests
Name: (root) Failed:
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/11/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Tue, 28 Nov 2017 11:40:33 +
Build duration:
6 min 44 sec and counting
JUnit Tests
Name: (root)
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:298c0e734efd: Fix creating a directory via
KNewFileMenu+KIO::mkpath on Qt 5.9.3+ (authored by hein).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9029?vs=23076&id=230
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Yep, this is annoying, we really miss good old addPath()...
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9029
To: hein, dfaure, thiago, elvisangela
ervin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9015
To: franckarrecot, ervin, renatoo, mlaurent, ngraham
Cc: #frameworks
apol added inline comments.
INLINE COMMENTS
> udisksdevicebackend.cpp:67
> if (m_device->isValid()) {
> -QDBusConnection::systemBus().connect(UD2_DBUS_SERVICE, m_udi,
> DBUS_INTERFACE_PROPS, "PropertiesChanged", this,
> -
> SLOT(slotPrope
hein created this revision.
hein added reviewers: dfaure, thiago, elvisangelaccio.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
f62768d04652 in qtbase.git introduced a behavior change in QUrl
causing it to reject UR
hein added a reviewer: Frameworks.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9029
To: hein, dfaure, thiago, elvisangelaccio, #frameworks
Cc: #frameworks
broulik created this revision.
broulik added reviewers: Frameworks, davidedmundson.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
- Avoid double lookup (contains+value)
- Just `delete take()` instead of contains+value+remove+delete
- Delay connecting to DBus change sig
franckarrecot updated this revision to Diff 23072.
franckarrecot marked an inline comment as done.
franckarrecot added a comment.
update
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9015?vs=23026&id=23072
REVISION DETAIL
https://phabricator.kde.org/D9015
cgiboudeaux added inline comments.
INLINE COMMENTS
> cgiboudeaux wrote in CMakeLists.txt:13
> 'kspell' sounds like an old KDE3 thing. Shouldn't that plugin be renamed
> sonnet_enchant ?
Ah, won't be needed, the plugin isn't built.
REPOSITORY
R246 Sonnet
REVISION DETAIL
https://phabricator
cgiboudeaux added inline comments.
INLINE COMMENTS
> CMakeLists.txt:13
>
> -set_target_properties(kspell_enchant PROPERTIES OUTPUT_NAME "enchant")
> install(TARGETS kspell_enchant DESTINATION
> ${KDE_INSTALL_PLUGINDIR}/kf5/sonnet/)
'kspell' sounds like an old KDE3 thing. Shouldn't that plugi
franckarrecot marked 2 inline comments as done.
franckarrecot added inline comments.
INLINE COMMENTS
> ervin wrote in kfileplacesview.cpp:811-813
> This whole change on the if structure there is unrelated to the rest of the
> patch so please remove it. Beside this seems to change the semantic, w
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20knotifications%20kf5-qt5%20WindowsMSVCQt5.9/16/
Project:
Frameworks knotifications kf5-qt5 WindowsMSVCQt5.9
Date of build:
Tue, 28 Nov 2017 08:15:50 +
Build duration:
1 hr 29 min and counting
ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfileplacesview.cpp:811-813
> +if (result != nullptr) {
>
> +if (result == emptyTrash) {
This whole change on the if structure there is unrelated
ervin accepted this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8450
To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent
Cc: mwolff, #frameworks
ervin accepted this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8367
To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent
Cc: mwolff, ngraham, mlaurent, #frameworks
leinir added a comment.
In https://phabricator.kde.org/D9018#172789, @alexeymin wrote:
> So it resulted in something like aspell.dll requiring aspell.dll?
Exactly that, yes... took me running it through Dependency Walker to work
out what was going on :P
> What is the
dfaure accepted this revision.
This revision is now accepted and ready to land.
REVISION DETAIL
https://phabricator.kde.org/D8619
To: mlaurent, #frameworks, ervin, dfaure
Cc: dfaure, ngraham
mlaurent updated this revision to Diff 23071.
mlaurent marked 3 inline comments as done.
mlaurent added a comment.
Fix comment from David
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8619?vs=21828&id=23071
REVISION DETAIL
https://phabricator.kde.org/D8619
AFFECTED FILES
src/f
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:4b4062497afc: Make it compile with QT_NO_CAST_FROM_ASCII
(authored by mlaurent).
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9027?vs=23069&id=23070
REVIS
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R289 KNotifications
BRANCH
make_it_compile_with_QT_NO_CAST_FROM_ASCII
REVISION DETAIL
https://phabricator.kde.org/D9027
To: mlaurent, dfaure
Cc: #frameworks
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20knotifications%20kf5-qt5%20WindowsMSVCQt5.9/15/
Project:
Frameworks knotifications kf5-qt5 WindowsMSVCQt5.9
Date of build:
Tue, 28 Nov 2017 06:24:52 +
Build duration:
1 hr 50 min and counting
56 matches
Mail list logo
