D9027: Make it compile with QT_NO_CAST_FROM_ASCII

mlaurent updated this revision to Diff 23069. mlaurent marked 5 inline comments as done. mlaurent added a comment. - Fix comment found by david REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9027?vs=23062&id=23069 BRANCH make_it_compile_with_QT_NO

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 69 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/69/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 28 Nov 2017 07:28:50 + Build duration: 11 min and counting JUnit Tests

KDE CI: Frameworks kconfigwidgets kf5-qt5 FreeBSDQt5.7 - Build # 39 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kconfigwidgets%20kf5-qt5%20FreeBSDQt5.7/39/ Project: Frameworks kconfigwidgets kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 28 Nov 2017 07:28:50 + Build duration: 10 min and counting JUnit Test

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 152 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/152/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 28 Nov 2017 07:28:50 + Build duration: 10 min and counting JUnit Tests Nam

D9027: Make it compile with QT_NO_CAST_FROM_ASCII

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > knotificationmanager.cpp:87 > if (!runtimeDir.isEmpty()) { > -inSandbox = QFileInfo::exists(QFile::encodeName(runtimeDir) + > QLatin1Stri

D9018: Don't cause circular linking on Windows

alexeymin added a comment. So it resulted in something like aspell.dll reuiring aspell.dll? What is the fastest way to test this? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D9018 To: leinir, #frameworks Cc: alexeymin, apol, #frameworks

D9027: Make it compile with QT_NO_CAST_FROM_ASCII

mlaurent created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN compile execute autotest REPOSITORY R289 KNotifications BRANCH make_it_compile_with_QT_NO_CAST_FROM_ASCII REVISION DETAIL https://phabrica

D9027: Make it compile with QT_NO_CAST_FROM_ASCII

mlaurent added a reviewer: dfaure. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D9027 To: mlaurent, dfaure Cc: #frameworks

KDE CI: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.9 - Build # 49 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20WindowsMSVCQt5.9/49/ Project: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 28 Nov 2017 04:06:34 + Build duration: 56 min and counting JUnit Te

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 3 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/3/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Tue, 28 Nov 2017 04:06:34 + Build duration: 19 min and counting JUnit Tests Nam

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 3 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/3/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 Date of build: Tue, 28 Nov 2017 04:06:34 + Build duration: 18 min and counting JUnit Tests Name:

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 102 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/102/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 28 Nov 2017 04:06:34 + Build duration: 16 min and counting JUnit Tests

KDE CI: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.9 - Build # 39 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.9/39/ Project: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 28 Nov 2017 04:06:14 + Build duration: 13 min and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9 - Build # 119 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.9/119/ Project: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 28 Nov 2017 04:06:00 + Build duration: 3 min 35 sec and counting JUnit T

KDE CI: Frameworks knewstuff kf5-qt5 FreeBSDQt5.7 - Build # 78 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20FreeBSDQt5.7/78/ Project: Frameworks knewstuff kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 28 Nov 2017 04:06:14 + Build duration: 2 min 13 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/6/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.10 Date of build: Tue, 28 Nov 2017 04:06:00 + Build duration: 1 min 24 sec and counting JUnit Tests Nam

D8007: popplerextractor: don't try to guess the title if there isn't one.

anthonyfieroni added a comment. About me it's a good feature after all. It should be simplified e.g. only when title is empty and parse only header of first page. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8007 To: flameeyes, #frameworks, mgallien Cc: ant

KDE CI: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9 - Build # 26 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.9/26/ Project: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9 Date of build: Tue, 28 Nov 2017 02:00:50 + Build duration: 7 min 7 sec and counting JUn

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/9/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Tue, 28 Nov 2017 02:00:50 + Build duration: 6 min 21 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/7/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Tue, 28 Nov 2017 02:00:50 + Build duration: 5 min 56 sec and counting JUnit Tests

D9018: Don't cause circular linking on Windows

apol added a comment. +1 REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D9018 To: leinir, #frameworks Cc: apol, #frameworks

KDE CI: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.9 - Build # 38 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.9/38/ Project: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.9 Date of build: Mon, 27 Nov 2017 21:43:18 + Build duration: 1 hr 3 min and counting JUnit Te

D9012: Revert "Detach before setting the d pointer"

This revision was automatically updated to reflect the committed changes. Closed by commit R304:bcb7dd628811: Revert "Detach before setting the d pointer" (authored by kossebau). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9012?vs=22979&id=23055 REVISION

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 10 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/10/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 27 Nov 2017 21:01:38 + Build duration: 16 min and counting JUnit Tests Name: (root) Faile

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 10 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/10/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Mon, 27 Nov 2017 21:01:38 + Build duration: 14 min and counting JUnit Tests Name: (root) Failed:

D8007: popplerextractor: don't try to guess the title if there isn't one.

mgallien added a comment. @vhanda Thanks a lot to have took time to answer. I really appreciate your help. I took a long time to understand that fixing or modifying the extractors is not enough to get modified data when querying Baloo. I would like to fix that in the future. Do you ha

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 150 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/150/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 27 Nov 2017 21:01:38 + Build duration: 4 min 59 sec and counting JUnit Tests Name: (

KDE CI: Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9 - Build # 18 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20WindowsMSVCQt5.9/18/ Project: Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9 Date of build: Mon, 27 Nov 2017 20:36:23 + Build duration: 11 min and counting CONS

D9004: Input validation of SubJobs

anthonyfieroni accepted this revision. anthonyfieroni added inline comments. INLINE COMMENTS > kcompositejob.cpp:98 > { > +Q_D(KCompositeJob); > // Did job have an error ? This is not needed anymore. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9004 T

D9004: Input validation of SubJobs

jtamate updated this revision to Diff 23049. jtamate added a comment. - Input validation of SubJobs and disconnect signals I can't reproduce the bug. Probably the job already deleted (the crash in the bug) and the signals not disconnected where the problem. It doesn't crash for me even

D9004: Input validation of SubJobs

anthonyfieroni added inline comments. INLINE COMMENTS > kcompositejob.cpp:104 > setErrorText(job->errorText()); > -emitResult(); > +// Finish this KCompositeJob only if it has no subjobs > +if (d->subjobs.isEmpty()) { David mean to finish job on first error, i.e.

D9004: Input validation of SubJobs

jtamate updated this revision to Diff 23046. jtamate added a comment. - Addressed comments by dfaure and anthonyfieroni REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9004?vs=22948&id=23046 BRANCH master REVISION DETAIL https://phabricator.kde.org

D9012: Revert "Detach before setting the d pointer"

leinir accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH unbreakEntryInternalDataSyncing REVISION DETAIL https://phabricator.kde.org/D9012 To: kossebau, whiting, leinir, apol Cc: #frameworks

D9012: Revert "Detach before setting the d pointer"

kossebau added a comment. In https://phabricator.kde.org/D9012#172387, @leinir wrote: > Quicker is better here, i think... Perhaps it is worth adding the documentation we discussed as well in this review? Thinking about making it easier to track the history and whatnot of what happened a

D9019: [Calendar] Adjust the calendar toolbar anchors

davidedmundson added a comment. > but I did not contribute for a long time Good to have you back! REPOSITORY R242 Plasma Framework (Library) BRANCH upstreaming REVISION DETAIL https://phabricator.kde.org/D9019 To: akulichalexandr, #plasma, broulik Cc: davidedmundson, broulik, pla

D9019: [Calendar] Adjust the calendar toolbar anchors

akulichalexandr added a comment. In https://phabricator.kde.org/D9019#172612, @broulik wrote: > Thanks! It's the little things that make it feel polished :) > > Do you have commit access? Yes, I have the access, but I did not contribute for a long time and still have to get us

KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9 - Build # 118 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.9/118/ Project: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9 Date of build: Mon, 27 Nov 2017 15:14:08 + Build duration: 2 hr 5 min and counting JUnit Tes

D9019: [Calendar] Adjust the calendar toolbar anchors

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks! It's the little things that make it feel polished :) Do you have commit access? REPOSITORY R242 Plasma Framework (Library) BRANCH upstreaming REVISION DETAIL https://p

D8858: Fix testWaylandFullscreenShell.

This revision was automatically updated to reflect the committed changes. Closed by commit R127:7cd465a3bad3: Fix testWaylandFullscreenShell. (authored by cgiboudeaux). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8858?vs=22546&id=23037#toc REPOSITORY R127 KWayland CHANGES SINCE LAS

D8367: Hidding place groups implementation in KFilePlacesModel

franckarrecot marked 15 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8367 To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent Cc: mwolff, ngraham, mlaurent, #frameworks

D9019: [Calendar] Adjust the calendar toolbar anchors

akulichalexandr edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9019 To: akulichalexandr, #plasma Cc: plasma-devel, #plasma, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, seba

D8998: Add FindSeccomp to find-modules

cgiboudeaux added a comment. Mostly good. Last question : is the version important ? If yes, please add an additional way to get the version if Seccomp_VERSION is empty. (you can parse seccomp.h to find it, look at the other Find*.cmake modules for examples) INLINE COMMENTS > FindSeccomp.cm

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.7 - Build # 2 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.7/2/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.7 Date of build: Mon, 27 Nov 2017 16:24:22 + Build duration: 10 min and counting JUnit Tests Name: (root

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 2 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/2/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Mon, 27 Nov 2017 16:24:22 + Build duration: 9 min 45 sec and counting JUnit Tests Nam

D8858: Fix testWaylandFullscreenShell.

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D8858 To: cgiboudeaux, graesslin Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-moha

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.7 - Build # 61 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.7/61/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 27 Nov 2017 16:24:23 + Build duration: 8 min 17 sec and counting JUnit Tests

D8367: Hidding place groups implementation in KFilePlacesModel

franckarrecot marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8367 To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent Cc: mwolff, ngraham, mlaurent, #frameworks

D9019: [Calendar] Adjust the calendar toolbar anchors

akulichalexandr retitled this revision from "Plasma: Adjust the calendar toolbar layout" to "[Calendar] Adjust the calendar toolbar anchors". akulichalexandr edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9019 To:

D9019: [Calendar] Adjust the calendar toolbar anchors

akulichalexandr edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9019 To: akulichalexandr, #plasma Cc: plasma-devel, #plasma, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, seba

D9019: Plasma: Adjust the calendar toolbar layout

akulichalexandr updated this revision to Diff 23032. akulichalexandr added a comment. Updating https://phabricator.kde.org/D9019: Plasma: Adjust the calendar toolbar layout The new diff is created via Arcanist REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE http

D9019: Plasma: Adjust the calendar toolbar layout

akulichalexandr created this revision. akulichalexandr added a reviewer: Plasma. akulichalexandr added a project: Plasma. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added a project: Frameworks. REPOSITORY R242 Plasma Framework (Library) REVISION D

D9019: Plasma: Adjust the calendar toolbar layout

akulichalexandr added a task: T7499: Fix plasma calendar applet layout. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9019 To: akulichalexandr, #plasma Cc: plasma-devel, #plasma, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterbe

D9018: Don't cause circular linking on Windows

leinir added a reviewer: Frameworks. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D9018 To: leinir, #frameworks Cc: #frameworks

KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9 - Build # 117 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.9/117/ Project: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9 Date of build: Mon, 27 Nov 2017 12:50:56 + Build duration: 2 hr 23 min and counting JUnit Te

D8007: popplerextractor: don't try to guess the title if there isn't one.

vhanda added a comment. To give some history - Strigi used to do this guessing, and when I implemented KFileMetaData, I decided to do the same. I don't have an opinion on whether it is a good idea or not. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8007 T

D9015: Refactoring the hidding/showing animation use within KFilePlacesView

franckarrecot updated this revision to Diff 23026. franckarrecot added a comment. update REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9015?vs=23000&id=23026 REVISION DETAIL https://phabricator.kde.org/D9015 AFFECTED FILES src/filewidgets/kfileplacesview

D8366: Factoring out lists of url data within KFilePlacesModelTest

This revision was automatically updated to reflect the committed changes. Closed by commit R241:3e537c4dd935: Factoring out lists of url data within KFilePlacesModelTest (authored by franckarrecot, committed by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.o

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 149 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/149/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 27 Nov 2017 14:31:29 + Build duration: 23 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/9/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Mon, 27 Nov 2017 14:35:34 + Build duration: 17 min and counting JUnit Tests Name: (root) Failed:

D8007: popplerextractor: don't try to guess the title if there isn't one.

vhanda added a comment. > @vhanda do you know if there is something to do to update Baloo database when metadata returned by KFileMetaData are changed even if the file itself did not change ? I'm starting to forget the code base and what all I implemented. But I don't think such a thing

D9018: Don't cause circular linking on Windows

leinir created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY When building plugins, don't arbitrarily rename the output files (as this will occasionally result in circular dependencies). In this re

D8367: Hidding place groups implementation in KFilePlacesModel

ngraham added a comment. Can you mark the Not Done comments as Done if they're done now? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8367 To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent Cc: mwolff, ngraham, mlaurent, #frameworks

D8862: Extend KFilePlacesModel API

mlaurent added inline comments. INLINE COMMENTS > kfileplacesmodel.cpp:77 > +if (day > 0) { > +date += QString("-%1").arg(day, 2, 10, QChar('0')); > +} QStringLiteral("-%1").arg(...) > kfileplacesmodel.cpp:96 > +timelineUrl = QUrl(timelinePrefix + timelin

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/9/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 27 Nov 2017 14:27:47 + Build duration: 8 min 31 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 8 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/8/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Mon, 27 Nov 2017 14:19:43 + Build duration: 15 min and counting JUnit Tests Name: (root) Failed:

D9017: Avoid run kfileplacesmodeltest and kfileplacesviewtest in parallel

renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Both tests modify the bookmark file and that can cause test failure TEST PLAN run all kio unit test REPOSITORY R241 KIO BRANCH seria

D9017: Avoid run kfileplacesmodeltest and kfileplacesviewtest in parallel

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH serialize-unit-test REVISION DETAIL https://phabricator.kde.org/D9017 To: renatoo, dfaure Cc: #frameworks

D8367: Hidding place groups implementation in KFilePlacesModel

franckarrecot updated this revision to Diff 23024. franckarrecot added a comment. update - should be landable now REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8367?vs=22998&id=23024 REVISION DETAIL https://phabricator.kde.org/D8367 AFFECTED FILES autote

D8450: User can now hide an entire places group from KFilePlacesView

franckarrecot updated this revision to Diff 23025. franckarrecot marked an inline comment as done. franckarrecot added a comment. update, have to wait to be pushed, since it contains i18n translation, next week: in the first two weeks after the first saturday of the month REPOSITORY R241

D8366: Factoring out lists of url data within KFilePlacesModelTest

franckarrecot updated this revision to Diff 23023. franckarrecot added a comment. update REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8366?vs=22900&id=23023 REVISION DETAIL https://phabricator.kde.org/D8366 AFFECTED FILES autotests/kfileplacesmodeltest.

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 8 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/8/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 27 Nov 2017 14:14:22 + Build duration: 10 min and counting JUnit Tests Name: (root) Failed

D8366: Factoring out lists of url data within KFilePlacesModelTest

franckarrecot added a comment. this one is landable now that its dependencies are pushed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8366 To: franckarrecot, renatoo, ervin, mlaurent Cc: anthonyfieroni, ervin, ngraham, mlaurent, #frameworks

D8947: Expose KFilePlacesModel 'iconName' role

This revision was automatically updated to reflect the committed changes. Closed by commit R241:7be5649a0d9c: Expose KFilePlacesModel 'iconName' role (authored by Renato Araujo Oliveira Filho ). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.o

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/7/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Mon, 27 Nov 2017 14:00:55 + Build duration: 18 min and counting JUnit Tests Name: (root) Failed:

D9017: Avoid run kfileplacesmodeltest and kfileplacesviewtest in parallel

This revision was automatically updated to reflect the committed changes. Closed by commit R241:700c7d3af43b: Avoid run kfileplacesmodeltest and kfileplacesviewtest in parallel (authored by Renato Araujo Oliveira Filho ). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D8862: Extend KFilePlacesModel API

mlaurent added a comment. oh it was abandoned ! ok :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8862 To: renatoo, dfaure, mwolff Cc: mlaurent, mwolff, dfaure, ngraham, #frameworks

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/7/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 27 Nov 2017 14:01:17 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

This revision was automatically updated to reflect the committed changes. Closed by commit R241:531d7759578e: Return a valid bookmark object for any entry in KFilePlacesModel (authored by Renato Araujo Oliveira Filho ). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE h

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/6/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 27 Nov 2017 13:41:46 + Build duration: 19 min and counting JUnit Tests Name: (root) Failed

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/6/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Mon, 27 Nov 2017 13:41:46 + Build duration: 19 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 147 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/147/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 27 Nov 2017 13:46:16 + Build duration: 12 min and counting JUnit Tests Name: (root)

D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c8bd7ad4b296: Created an auxiliary function 'KFilePlacesModel::movePlace' (authored by Renato Araujo Oliveira Filho ). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 146 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/146/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 27 Nov 2017 13:43:24 + Build duration: 2 min 38 sec and counting CONSOLE OUTPUT [...

D8946: Avoid unnecessary 'dataChanged' signal

This revision was automatically updated to reflect the committed changes. Closed by commit R241:62c5d76f17a1: Avoid unnecessary 'dataChanged' signal (authored by Renato Araujo Oliveira Filho ). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D8944: Create a 'KFilePlacesModel::refresh' function

This revision was automatically updated to reflect the committed changes. Closed by commit R241:4186286c16b1: Create a 'KFilePlacesModel::refresh' function (authored by Renato Araujo Oliveira Filho ). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/5/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 27 Nov 2017 13:24:16 + Build duration: 10 min and counting JUnit Tests Name: (root) Failed

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/5/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Mon, 27 Nov 2017 13:24:16 + Build duration: 5 min 41 sec and counting JUnit Tests Name: (root) Fa

D8943: Create 'KFilePlacesModel::convertedUrl' static function

This revision was automatically updated to reflect the committed changes. Closed by commit R241:66682d0df7e6: Create 'KFilePlacesModel::convertedUrl' static function (authored by Renato Araujo Oliveira Filho ). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://ph

D8947: Expose KFilePlacesModel 'iconName' role

renatoo updated this revision to Diff 23013. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8947?vs=22966&id=23013 REVISION DETAIL https://phabricator.kde.org/D8947 AFFECTED FILES autotests/kfileplacesmodelte

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

renatoo updated this revision to Diff 23011. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8945?vs=22964&id=23011 REVISION DETAIL https://phabricator.kde.org/D8945 AFFECTED FILES autotests/kfileplacesmodelte

D8946: Avoid unnecessary 'dataChanged' signal

renatoo updated this revision to Diff 23012. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8946?vs=22965&id=23012 REVISION DETAIL https://phabricator.kde.org/D8946 AFFECTED FILES autotests/kfileplacesmodelte

D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'

renatoo updated this revision to Diff 23014. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8948?vs=22967&id=23014 REVISION DETAIL https://phabricator.kde.org/D8948 AFFECTED FILES autotests/kfileplacesmodelte

D8944: Create a 'KFilePlacesModel::refresh' function

renatoo updated this revision to Diff 23010. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8944?vs=22963&id=23010 REVISION DETAIL https://phabricator.kde.org/D8944 AFFECTED FILES autotests/kfileplacesmodelte

D8943: Create 'KFilePlacesModel::convertedUrl' static function

renatoo updated this revision to Diff 23009. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8943?vs=22962&id=23009 REVISION DETAIL https://phabricator.kde.org/D8943 AFFECTED FILES autotests/kfileplacesmodelte

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 150 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/150/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 27 Nov 2017 12:50:56 + Build duration: 1 min 36 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/5/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.10 Date of build: Mon, 27 Nov 2017 12:50:56 + Build duration: 1 min 45 sec and counting JUnit Tests Nam

D8450: User can now hide an entire places group from KFilePlacesView

franckarrecot marked an inline comment as done. franckarrecot added inline comments. INLINE COMMENTS > ervin wrote in kfileplacesview.cpp:863-866 > Cool, I'll wait for that extra review to appear before accepting that one. So > that we don't forget it. :-) Was that the thing you had in mind ?

D8367: Hidding place groups implementation in KFilePlacesModel

franckarrecot added a dependent revision: D9015: Refactoring the hidding/showing animation use within KFilePlacesView. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8367 To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent Cc: mwolff, ngraham, mlaurent, #framework

D9015: Refactoring the hidding/showing animation use within KFilePlacesView

franckarrecot created this revision. franckarrecot added reviewers: ervin, renatoo, mlaurent, ngraham. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Depends on https://phabricator.kde.org/D8367 Depends on https://pha

D8450: User can now hide an entire places group from KFilePlacesView

franckarrecot added a dependent revision: D9015: Refactoring the hidding/showing animation use within KFilePlacesView. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8450 To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent Cc: mwolff, #frameworks

  1   2   >