BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.9/59/
Project:
Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9
Date of build:
Sat, 18 Nov 2017 00:14:31 +
Build duration:
1 hr 5 min and counting
mpyne accepted this revision.
mpyne added a comment.
This revision is now accepted and ready to land.
+1
REPOSITORY
R237 KConfig
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8871
To: apol, #frameworks, mpyne
Cc: mpyne
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/144/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Sat, 18 Nov 2017 00:14:31 +
Build duration:
11 min and counting
JUnit
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/140/
Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
Date of build:
Sat, 18 Nov 2017 00:14:31 +
Build duration:
5 min 39 sec and counting
J
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:228e15e20a9c: Search all KF5 components as such instead
as separate frameworks (authored by apol).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
cmake
REVISION DETAIL
https://phabricator.kde.org/D8873
To: apol, #frameworks, davidedmundson
apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
cmake
REVISION DETAIL
https://phabricator.kde.org/D8873
AFFECTED FILES
CMakeLists.txt
To: apol, #frameworks
apol updated this revision to Diff 22544.
apol added a comment.
Search all frameworks together as components
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8870?vs=22531&id=22544
BRANCH
master
REVISION DETAIL
https://phabricator.kde
cgiboudeaux updated this revision to Diff 22546.
cgiboudeaux added a comment.
Add message if the executable wasn't found
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8858?vs=22492&id=22546
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D
apol updated this revision to Diff 22545.
apol added a comment.
unrelated things
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8870?vs=22544&id=22545
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8870
AFFECTED FILES
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.9/114/
Project:
Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9
Date of build:
Fri, 17 Nov 2017 18:49:50 +
Build duration:
4 min 1 sec and counting
JUnit Te
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/147/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 17 Nov 2017 18:49:50 +
Build duration:
1 min 33 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/153/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Fri, 17 Nov 2017 18:49:50 +
Build duration:
1 min 8 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.9/113/
Project:
Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9
Date of build:
Fri, 17 Nov 2017 16:54:25 +
Build duration:
5 min 43 sec and counting
JUnit T
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/146/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 17 Nov 2017 16:54:25 +
Build duration:
54 sec and counting
JUnit Tests
Nam
apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Every time we open a configuration file, we are checking if this file is
there.
Since it's a sysadmin setting I'd say it's fine to assume that it's not
appearin
apol added a comment.
Yes, this works, the code in question was in SystemTray, it looks just fine
there.
Also I've been using Heading in Discover for months and never saw this issue.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8870
To: apol,
broulik added a comment.
Are you sure this results in the same "bottom gap" below the item? Perhaps
`bottomPadding` (new in Qt 5.6) could help here?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8870
To: apol, #plasma
Cc: broulik, plasma-devel,
apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Using the height property together with paintedHeight had binding loops.
REPOSITORY
R242 P
apol added inline comments.
INLINE COMMENTS
> mouseeventlistener.h:73
>
> +bool accepted() const { return m_accepted; }
> +void setAccepted(bool accepted) {
`isAccepted`?
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D8864
To: broulik, #plasma, hein
Cc
broulik created this revision.
broulik added reviewers: Plasma, hein.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
This will keep the event from propagating. Accepting a press event will also
not
broulik accepted this revision.
REPOSITORY
R236 KWidgetsAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8851
To: davidedmundson, elvisangelaccio, broulik
Cc: #frameworks
renatoo retitled this revision from "Extend API" to "Extend KFilePlacesModel
API".
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8862
To: renatoo
Cc: #frameworks
renatoo added a dependent revision: D8862: Extend API.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8348
To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff
Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks
renatoo edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8862
To: renatoo
Cc: #frameworks
renatoo edited the summary of this revision.
renatoo added dependencies: D8332: Added baloo urls into places model, D8630:
Created unit test for PlacesItemModel, D8434: Created 'remote' section, D8348:
Add a section for removable devices.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabrica
renatoo edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8862
To: renatoo
Cc: #frameworks
renatoo added a dependent revision: D8862: Extend API.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent, dfaure
Cc: dfaure, elvisangelaccio, mwolff, mlaurent, #frameworks
renatoo added a dependent revision: D8855: Use Kio::KPlacesModel as source
model for PlacesItemModel.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8862
To: renatoo
Cc: #frameworks
renatoo added a dependent revision: D8862: Extend API.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham,
ervin, mlaurent, dfaure
Cc: mwolff, dfaure, ervin, usta, mlaurent, dvratil, ngraham, #f
renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Extend API to make it possible to use by external apps
Make possible to retrieve item bookmark even if that is not a device
Added 'refres
This revision was automatically updated to reflect the committed changes.
Closed by commit R246:5d626287a6cf: Make it possible to crosscompile sonnet
(authored by apol).
REPOSITORY
R246 Sonnet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8795?vs=22281&id=22509
REVISION DETAIL
ht
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.9/35/
Project:
Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.9
Date of build:
Fri, 17 Nov 2017 09:29:48 +
Build duration:
1 hr 34 min and counting
JUnit T
elvisangelaccio accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R236 KWidgetsAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8851
To: davidedmundson, elvisangelaccio
Cc: #frameworks
bcooksley added a comment.
Following other feedback i've received the gears of motion for such a thing
are in motion.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8837
To: elvisangelaccio, dfaure, thiago
Cc: cgiboudeaux, bcooksley, #frameworks
elvisangelaccio added a comment.
In https://phabricator.kde.org/D8837#168682, @bcooksley wrote:
> The reason why I ask is - would it be worth setting up a parallel build
against Qt 5.10 on the CI to see what else breaks test wise?
Imho yes, better CI coverage is always a good thin
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:f4f245325cc0: do not install development tool to
aggregate desktop files (authored by sitter).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8848?vs=22469&id=225
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20XenialQt5.7/61/
Project:
Frameworks kwayland kf5-qt5 XenialQt5.7
Date of build:
Fri, 17 Nov 2017 08:35:58 +
Build duration:
9 min 45 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.7/60/
Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 17 Nov 2017 08:35:58 +
Build duration:
7 min 34 sec and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:7cb71d002b72: Expose wl_display_set_global_filter as a
virtual method (authored by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8050?vs=20560&id=22503#toc
REPOSITORY
R127
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.9/34/
Project:
Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.9
Date of build:
Fri, 17 Nov 2017 06:28:10 +
Build duration:
1 hr 40 min and counting
JUnit T
41 matches
Mail list logo