D8683: Only prevent the name to update if it's empty

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8683 To: apol, #frameworks, dfaure

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kopenwithdialog.cpp:463 > > -if (d->appModel && !d->appModel->isDirectory(current)) { > -QString exec = d->appModel->execFor(current); > +QMo

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

dfaure added a comment. Yes, feel free to kill the hidden setting for completion, especially if the default value isn't the one that gives the best user experience. REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz

D8696: Don't autoremove empty temp file

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH fix-empty-qtemporaryfile REVISION DETAIL https://phabricator.kde.org/D8696 To: elvisangelaccio, dfaure Cc: #frameworks

D8697: Don't check whether an empty filename exists

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH fix-empty-exists REVISION DETAIL https://phabricator.kde.org/D8697 To: elvisangelaccio, dfaure Cc: #frameworks

D8705: Remove Qt5::Widgets as a dependency

anthonyfieroni added a comment. One more place -> kselectionowner.cpp:37 Dropping can't be done before KF6 :) REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D8705 To: apol, #frameworks Cc: anthonyfieroni

D8708: [WIP] Introduce AbstractAnnotationItemDelegate for more control by consumer

kossebau added a comment. Example for custom rendering in KDevelop as currently proposed with the matching KDevelop patch https://phabricator.kde.org/D8709: F5481057: Screenshot_20171108_013745.png REPOSITORY R39 KTextEditor REVISION DETAIL https

D8710: Fix VI-Mode buffer commands

croick created this revision. croick added a reviewer: KTextEditor. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY - :tabclose currently makes kate crash. - Switching tabs with commands like :bp or :tabp only wor

D8708: [WIP] Introduce AbstractAnnotationItemDelegate for more control by consumer

kossebau added a dependent revision: D8709: [WIP] Add VcsAnnotationItemDelegate, for control of rendering, menus and tooltip. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D8708 To: kossebau Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D8708: [WIP] Introduce AbstractAnnotationItemDelegate for more control by consumer

kossebau created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The AbstractAnnotationItemDelegate is modelled after QAbstractItemDelegate and should allow consumers of the annotation interfaces to

D8705: Remove Qt5::Widgets as a dependency

apol created this revision. apol added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY Make it a private dependency for now, until we can possibly drop it from the library TEST PLAN Built the rest of projects, including plasma, will send few patc

D7272: [DropJob] Enable drag and drop in a read-only folder

ngraham added a comment. How are we doing here? REVISION DETAIL https://phabricator.kde.org/D7272 To: chinmoyr, #frameworks, dfaure Cc: ngraham

D7430: Add unit test

ngraham added a comment. How are we doing here? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7430 To: chinmoyr, dfaure Cc: ngraham, #frameworks

D8332: Added baloo urls into places model

ngraham added a comment. @ervin and @dvratil, any remaining concerns? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin, mlaurent Cc: dfaure, ervin, usta, mlaurent, dvratil, ngraham,

D8698: Fix KProtolInfoTest if krusader is installed

ngraham added a comment. Is the same problem present in the non-test code? I just noticed https://bugs.kde.org/show_bug.cgi?id=384991, which seems to report a similar or identical issue. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8698 To: elvisangelaccio, dfaure C

KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 135 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/135/ Project: Frameworks plasma-framework kf5-qt5 XenialQt5.7 Date of build: Tue, 07 Nov 2017 20:19:20 + Build duration: 10 min and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 139 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/139/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 07 Nov 2017 20:19:20 + Build duration: 4 min 14 sec and counting

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

ngraham added a comment. IMO popup completion is rendered obsolete by the new filter behavior, which is much nicer. We might consider just removing it. REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #fr

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz marked an inline comment as done. simgunz added a comment. > @simgunz If you have no further changes planned for this Diff and https://phabricator.kde.org/D8670, I could land both on your behalf. Contact information of non-developers are private by default on identity.kde.org, but I

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

ngraham accepted this revision. REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

rkflx accepted this revision. rkflx added a comment. @dfaure Could we get your green (for real, on Phab :) light from a Frameworks point of view for this Diff? @simgunz If you have no further changes planned for this Diff and https://phabricator.kde.org/D8670, I could land both on your b

D8652: Add supported transformations to OutputDevice

sebas accepted this revision. sebas added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > outputdevice.h:244 > + * @returns The transformations supported on this OutputDevice > + * @since 5.XX > + * @see supportedTransformationAdded 5.40 I guess :)

D8696: Don't autoremove empty temp file

elvisangelaccio created this revision. elvisangelaccio added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Since 5.10 (commit 0dee566e98 in qtbase) Qt complains if we make a system call with an em

D8698: Fix KProtolInfoTest if krusader is installed

elvisangelaccio created this revision. elvisangelaccio added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Krusader has a `krarc` ioslave that handles zip files. If krusader is installed, `testPro

D8697: Don't check whether an empty filename exists

elvisangelaccio created this revision. elvisangelaccio added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Since 5.10 (commit 0dee566e98 in qtbase) Qt complains if we make a system call with an em

D8691: add some metadata

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH phab/moduledata REVISION DETAIL https://phabricator.kde.org/D8691 To: mart, #plasma, davidedmundson Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, al

D8691: add some metadata

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY accessible by the qml implementations TEST PLAN the properties kcm.name and kcm.descriptio

D8281: Allow to use IcoTool for Windows icons

cgiboudeaux added inline comments. INLINE COMMENTS > FindIcoTool.cmake:1 > +# Copyright 2017 Vincent Pinon > +include(${CMAKE_CURRENT_LIST_DIR}/ECMFindModuleHelpersStub.cmake) This module doesn't have any license and doesn't provide any doc. > FindIcoTool.cmake:3 > +include(${CMAKE_CURRENT_LIS

Re: Python bindings using cppyy (was: An update on Python bindings)

I have made an attempt to get roughly all the bindings I was previously attempting with SIP to be (a) generated and (b) built. As of now, we have: - Customisations with a diffstat that reads "21 files changed, 20 insertions(+), 48 deletions(-)". - All but 5-6 of the formal tier 1, 2 and 3 framewo

D8281: Allow to use IcoTool for Windows icons

apol added a reviewer: Windows. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8281 To: vpinon, dfaure, apol, kfunk, #windows Cc: #frameworks, #build_system

D8689: Fix the result of KDesktopFile::sortOrder()

volkov added a reviewer: Frameworks. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8689 To: volkov, #frameworks Cc: #frameworks

D8689: Fix the result of KDesktopFile::sortOrder()

volkov created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY KDesktopFile::sortOrder() returns the value of SortOrder key as a string whithout parsing it as a list. But according to Desktop Entry Spe

D8173: Use readelf to find project dependencies

mart added a comment. +1 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8173 To: apol, #frameworks, #build_system, aacid Cc: mart