Zren added a reviewer: apol.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D8636
To: Zren, apol
Cc: #frameworks
Zren edited the test plan for this revision.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D8636
To: Zren
Cc: #frameworks
Zren edited the test plan for this revision.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D8636
To: Zren
Cc: #frameworks
Zren created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Implementing the feature request in BUG #385429.
https://bugs.kde.org/show_bug.cgi?id=385429
LookAndFeels introduced the ability to set d
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:19a313ecc90c: fix createKMessageBox focus widget
inconsistency (authored by emateli, committed by ngraham).
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D78
ngraham added a comment.
I think we've got enough thumbs up. I'm gonna land this.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D7828
To: emateli, #frameworks, ngraham, aacid, #vdg, rkflx, subdiff
Cc: elvisangelaccio, rkflx, abetts, subdiff, ngraham, aacid, #
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R303 KInit
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8633
To: dfaure, davidedmundson
Cc: #plasma, #frameworks
Albert,
On 2 November 2017 at 21:43, Albert Astals Cid wrote:
> El dijous, 2 de novembre de 2017, a les 18:22:38 CET, Shaheed Haque va
> escriure:
>> A progress update...
>>
>> On 24 October 2017 at 13:05, Shaheed Haque wrote:
>> > Hi all,
>> >
>> > I have a preliminary version of the Cppyy bind
elvisangelaccio added a comment.
@kossebau Ping?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D8336
To: elvisangelaccio, kossebau, dfaure
Cc: apol, #frameworks
dfaure created this revision.
dfaure added a reviewer: davidedmundson.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
ksmserver takes care of it (and no longer calls this code) since August
2016, see
https://phabrica
El dijous, 2 de novembre de 2017, a les 18:22:38 CET, Shaheed Haque va
escriure:
> A progress update...
>
> On 24 October 2017 at 13:05, Shaheed Haque wrote:
> > Hi all,
> >
> > I have a preliminary version of the Cppyy bindings generator CMake
> >
> > support available here:
> > https://b
dfaure created this revision.
dfaure added a reviewer: davidedmundson.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Not needed anymore since June 2016 (b6058a0 in plasma-workspace, i.e. Plasma
5.7).
Originally
renatoo updated this revision to Diff 21808.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8348?vs=21759&id=21808
REVISION DETAIL
https://phabricator.kde.org/D8348
AFFECTED FILES
autotests/kfileplacesmodelte
renatoo marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham,
ervin, mlaurent
Cc: ervin, usta, mlaurent, dvratil, ngraham, #frameworks
renatoo updated this revision to Diff 21809.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8434?vs=21760&id=21809
REVISION DETAIL
https://phabricator.kde.org/D8434
AFFECTED FILES
autotests/kfileplacesmodelte
renatoo updated this revision to Diff 21807.
renatoo added a comment.
Added warning message for invalid search:// urls
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8332?vs=21758&id=21807
REVISION DETAIL
https://phabricator.kde.org/D8332
AFFECTED FILES
a
mgallien added a comment.
Sorry for the delay, currently I have no easy access to a development
computer running Windows.
David, I am afraid I have not understood correctly your suggestion. Did you
suggest to make mMetadataExtractor have its thread as Qt parent ?
REPOSITORY
R286 KFileMet
A progress update...
On 24 October 2017 at 13:05, Shaheed Haque wrote:
> Hi all,
>
> I have a preliminary version of the Cppyy bindings generator CMake
> support available here:
>
>
> https://bitbucket.org/wlav/cppyy-backend/pull-requests/6/an-interim-experimental-version-of-a/diff
>
> There
rjvbb updated this revision to Diff 21793.
rjvbb marked an inline comment as done.
rjvbb added a comment.
Updated as requested.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8544?vs=21724&id=21793
REVISION DETAIL
https://phabricator.kde.org/D8544
AFFECTED FILES
src/utils/kateg
rjvbb set the repository for this revision to R39 KTextEditor.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D8544
To: rjvbb, #frameworks
Cc: kfunk, dhaumann, cullmann, kde-frameworks-devel, kevinapavew, demsking,
head7, sars
rjvbb marked 2 inline comments as done.
rjvbb added inline comments.
INLINE COMMENTS
> kfunk wrote in kateglobal.cpp:106
> Minor: "... set to 1" would be sufficient. You're setting it yourself right
> before, so you can presume it is set (=> no need for `qgetenv(...)`.
I know that of course, bu
subdiff accepted this revision.
subdiff added a comment.
Looked at the code and I think @rkflx explained the situation quite well (if
we should force passing a parent or not - better - for the QDialogButtonBox).
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/132/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 02 Nov 2017 16:49:21 +
Build duration:
1 min 11 sec and counting
JUnit Tests
emateli added a comment.
Ping @subdiff @abetts does this iteration work for you guys? It's marked as
ready to land but I feel that we should get an overall opinion on this.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D7828
To: emateli, #frameworks, ngraham
ngraham added a comment.
@mlaurent would you mind changing your approval status then? :)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham,
ervin, mlaurent
Cc: ervin, usta, mlaurent, dvrati
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
Could you add camera:/ devices to this section too? That way we could also
take care of https://bugs.kde.org/show_bug.cgi?id=386060
REPOSITORY
R241 KIO
REVISION DETAIL
http
mlaurent updated this revision to Diff 21779.
mlaurent added a comment.
Remove virtual keyword when we have override
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8619?vs=21778&id=21779
REVISION DETAIL
https://phabricator.kde.org/D8619
AFFECTED FILES
src/filewidgets/kfileplace
mlaurent updated this revision to Diff 21778.
mlaurent added a comment.
Const'ify + use more static_cast
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8619?vs=21776&id=21778
REVISION DETAIL
https://phabricator.kde.org/D8619
AFFECTED FILES
src/filewidgets/kfileplacesview.cpp
T
apol updated this revision to Diff 21777.
apol added a comment.
Make sure we get the dependencies from the prefix as well
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8173?vs=20434&id=21777
BRANCH
arcpatch-D8173
REVISION DETAIL
https://p
mlaurent created this revision.
mlaurent added reviewers: Frameworks, ervin.
REVISION SUMMARY
Remove duplicate code.
Use static_cast when we don't test result from dynamic_cast
Remove unused variable
TEST PLAN
compile/test
REPOSITORY
R342 KIO AudioCD
REVISION DETAIL
https://phabric
usta added inline comments.
INLINE COMMENTS
> kfileplacesview.cpp:1348
> +searchUrl = searchUrlForType(QStringLiteral("Video"));
> +}
> +
won't be nice to add an else statement? (for the sake of searchUrl )
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
mlaurent added a comment.
+1 for me
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham,
ervin, mlaurent
Cc: ervin, usta, mlaurent, dvratil, ngraham, #frameworks
mlaurent accepted this revision.
mlaurent added a comment.
Seems good for me
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent
Cc: elvisangelaccio, mwolff, mlaurent, #frameworks
renatoo added a comment.
In https://phabricator.kde.org/D8366#163427, @ngraham wrote:
> Is this dependent on any of the other patches floating around?
Probably not, but that will affect (possible conflicts) with all patches
REVISION DETAIL
https://phabricator.kde.org/D8366
To:
ngraham added a comment.
Is this dependent on any of the other patches floating around?
REVISION DETAIL
https://phabricator.kde.org/D8366
To: mlaurent, renatoo, ervin, franckarrecot
Cc: ervin, ngraham, mlaurent, #frameworks
dhaumann added a comment.
By limited amount of time I mean we can remove it once the required Qt
version of KDE Frameworks is 5.9. (I thought this was obvious :))
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D8544
To: rjvbb, #frameworks
Cc: kfunk, dhaumann, cul
kfunk added inline comments.
INLINE COMMENTS
> kateglobal.cpp:104
> +// disable the QML JIT compiler as a protection against an unknown bug
> +// in Qt's V4 engine which can provoke a crash in certain of our scripts.
> +qputenv("QV4_FORCE_INTERPRETER", QByteArrayLiteral("1"));
Please
rjvbb added a comment.
Good, I'll push this sometime tonight (I'm waiting for some feedback via the
Qt bug report ticket, but won't mind if someone beats me to it0.
> I agree with this patch. It will not hurt and is clearly only relevant
for a limited amount of time. So +1 from me.
dhaumann added a comment.
I agree with this patch. It will not hurt and is clearly only relevant for a
limited amount of time. So +1 from me.
And thanks a lot René and Christoph for this work. It will make the next
Frameworks release better, which is alraedy tagged in 2 days.
REPOSITORY
ervin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8566
To: amantia, #plasma, ervin, dvratil, mlaurent, hein, davidedmundson
Cc: broulik, plasma-devel, dhauman
renatoo accepted this revision.
REVISION DETAIL
https://phabricator.kde.org/D8366
To: mlaurent, renatoo, ervin, franckarrecot
Cc: ervin, ngraham, mlaurent, #frameworks
renatoo updated this revision to Diff 21759.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8348?vs=21648&id=21759
REVISION DETAIL
https://phabricator.kde.org/D8348
AFFECTED FILES
autotests/kfileplacesmodelte
renatoo updated this revision to Diff 21760.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8434?vs=21757&id=21760
REVISION DETAIL
https://phabricator.kde.org/D8434
AFFECTED FILES
autotests/kfileplacesmodelte
renatoo updated this revision to Diff 21758.
renatoo added a comment.
Fixed code style
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8332?vs=21647&id=21758
REVISION DETAIL
https://phabricator.kde.org/D8332
AFFECTED FILES
autotests/CMakeLists.txt
autote
renatoo marked 5 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham,
ervin, mlaurent
Cc: ervin, usta, mlaurent, dvratil, ngraham, #frameworks
renatoo updated this revision to Diff 21757.
renatoo added a comment.
Fixed code style
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8434?vs=21697&id=21757
REVISION DETAIL
https://phabricator.kde.org/D8434
AFFECTED FILES
autotests/kfileplacesmodeltest.cp
mlaurent updated this revision to Diff 21755.
mlaurent added a comment.
Remove commented code. Rename methods
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=21752&id=21755
REVISION DETAIL
https://phabricator.kde.org/D8367
AFFECTED FILES
autotests/kfileplacesmodeltest.cp
mlaurent marked 2 inline comments as done.
REVISION DETAIL
https://phabricator.kde.org/D8367
To: mlaurent, renatoo, ngraham, franckarrecot, ervin
Cc: ngraham, mlaurent, #frameworks
ervin accepted this revision.
This revision is now accepted and ready to land.
REVISION DETAIL
https://phabricator.kde.org/D8450
To: mlaurent, ngraham, renatoo, franckarrecot, ervin
Cc: #frameworks
ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.
Couple more changes needed.
INLINE COMMENTS
> kfileplacesmodel.cpp:79-83
> +//static const QHash
> s_groupTypeToStateName
> +//{
> +//return *s_groupTypeToStateName;
> +//}
> +
ervin accepted this revision.
This revision is now accepted and ready to land.
REVISION DETAIL
https://phabricator.kde.org/D8366
To: mlaurent, renatoo, ervin, franckarrecot
Cc: ervin, ngraham, mlaurent, #frameworks
mlaurent updated this revision to Diff 21752.
mlaurent added a comment.
Rebase against master + other top patchs :)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=21645&id=21752
REVISION DETAIL
https://phabricator.kde.org/D8367
AFFECTED FILES
autotests/kfileplacesmodelt
If the external process gets started then it is indeed weird.
Dbus-monitor (or bustle) will be the best tools here, they'll show the
traffic between the test and test helper.
On 1 Nov 2017 23:18, "Hartmut Goebel" wrote:
> Hallo,
>
> I'm packaging krunner 5.39.0 for GNU Guix [1]. GNU Guix builds
cullmann added a comment.
I could live with that change.
It at least will avoid random crashs for the time being until we perhaps have
a better solution.
Other opinions?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D8544
To: rjvbb, #frameworks
Cc: cullmann,
mlaurent updated this revision to Diff 21750.
mlaurent added a comment.
Rebase it
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8366?vs=21646&id=21750
REVISION DETAIL
https://phabricator.kde.org/D8366
AFFECTED FILES
autotests/kfileplacesmodeltest.cpp
To: mlaurent, renatoo, er
mlaurent requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham,
ervin, mlaurent
Cc: ervin, usta, mlaurent, dvratil
mlaurent added inline comments.
INLINE COMMENTS
> kfileplacesviewtest.cpp:2
> +/* This file is part of the KDE project
> +Copyright (C) 2007 Kevin Ottens
> +
? I don't think that you are kevin ottens :) and we are in 2017 :)
> kfileplacesviewtest.cpp:20
> +
> +#include
> +#include
QtCo
57 matches
Mail list logo
