D7810: Add missing icon sizes

ngraham added a subscriber: hein. ngraham added a comment. @hein, it looks like you might have some context, based on https://cgit.kde.org/breeze-icons.git/commit/?id=3e3eaaa82169f48ae849b2349c1e981b8b542ba6 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D7810

D8296: Use Ctrl+Shift+, as the standard shortcut for "Configure "

ngraham retitled this revision from "Use Ctrl+Shift+. as the standard shortcut for "Configure "" to "Use Ctrl+Shift+, as the standard shortcut for "Configure "". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAI

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

ngraham updated this revision to Diff 21542. ngraham added a comment. Ctrl+Shift+Comma FTW REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8296?vs=21531&id=21542 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8296 AFFECTED FILES src/gui/

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

ngraham added a comment. In https://phabricator.kde.org/D8296#161574, @rkflx wrote: > In https://phabricator.kde.org/D8296#161570, @rkflx wrote: > > > Possibly the conflict detection is broken? > > > Turns out it's not, the shortcut is actually defined for the "Light Table". How

D8536: Add more hashing algorithms to KPropertiesDialog

petermajchrak edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio Cc: bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks

D8536: Add more hashing algorithms to KPropertiesDialog

petermajchrak updated this revision to Diff 21535. petermajchrak added a comment. Convert to only combobox based layout REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8536?vs=21495&id=21535 REVISION DETAIL https://phabricator.kde.org/D8536 AFFECTED FILES

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

ilic added a comment. `KStandardShortcut::Preferences` label is being overridden in KConfigWidgets's `src/kstandardaction_p.h` to `"&Configure %1..."` and %1 substituted with current application name. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

rkflx added a comment. In https://phabricator.kde.org/D8296#161570, @rkflx wrote: > Possibly the conflict detection is broken? Turns out it's not, the shortcut is actually defined for the "Light Table". However, there the shortcut is listed twice and works the same (for me at lea

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

rkflx added a comment. In https://phabricator.kde.org/D8296#161566, @ngraham wrote: > Digikam, which is as far as I can tell the only one using Ctrl+Shift+, Is it, though? I don't see it here: F5456767: digikam.png There might actually

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

ngraham added a comment. @rkflx If we need to change one app, we could also target Digikam, which is as far as I can tell the only one using Ctrl+Shift+, @ilic Actually the problem is that this string--whatever it is in the code--is being changed for English to "Configure System Sett

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

ilic added a comment. "Configure Application" does sound better than "Preferences", but that's just my opinion as a random translator, no link to my i18n plumber's hat :) REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, r

D8351: API dox: add note about calling setApplicationDomain after QApp creation

ilic added a comment. Well... it's a tough situation. It is not by design that `i18n` calls should in any way depend on creation of `QApplication`, and also any library may place an `i18n` call before the main program creates `QApplication`. The only solution I see is that environment is rec

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

ngraham planned changes to this revision. ngraham added a comment. Urgh, didn't find it because it's defined in Konsole like this: `Konsole::ACCEL + Qt::SHIFT + Qt::Key_Period` REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg,

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

rkflx added a comment. In https://phabricator.kde.org/D8296#161557, @rkflx wrote: > Let's hope nobody finds any obscure place where this is used already... Hm, conflicts in Konsole. However, can we change Konsole? At least, you could use this to improve your lxr search, so maybe m

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

rkflx added a subscriber: ilic. rkflx added a comment. Was confused and it took me a while to figure out how this will end up for different keyboard layouts. Turns out using the KCM combines [⇧] + [key], while `arc patch` results in all three keys shown in the menu. This means that [.] i

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

ngraham added a comment. So as for changing the name... I notice that this uses `QT_TRANSLATE_NOOP3()` instead of `i18n`. It seems that the English string at least is simply a bad translation, likely caused by the poorly-chosen base string, which I've changed to be a bit more descriptive.

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

ngraham updated this revision to Diff 21531. ngraham added a comment. Improved translation string to provide a better hint about what this really is REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8296?vs=21530&id=21531 BRANCH master REVISION DETAIL ht

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

ngraham retitled this revision from "Use Ctrl+Alt+, as the standard shortcut for "Configure "" to "Use Ctrl+Shift+. as the standard shortcut for "Configure "". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

ngraham updated this revision to Diff 21530. ngraham added a comment. Amazingly, Ctrl+Shift+. isn't taken! REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8296?vs=21507&id=21530 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8296 AFFECTED

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

rkflx added a comment. Well, that's more of a list than a well-explained guideline. This is quite good (grep for "system reserved shortcuts", but also see general reasoning): https://developer.gnome.org/hig/stable/keyboard-input.html.en REPOSITORY R237 KConfig REVISION DETAIL https://ph

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

abetts added a comment. We don't seem to have anything against it. My only request is that if we do shortcuts, make them use 2 hands instead of just one. If the keys are too close together, this makes it harder to enter. Possibly harder for people with disabilities as well. So, space the set

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

rkflx added a comment. Try typing that on a non-US keyboard layout :) REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

ngraham added a comment. I agree, @rkflx. Shame Ctrl+Shift+, is taken. Ctrl+Shift+\, maybe? That's not taken. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: abetts, elvisangelaccio, aacid, argonel, kfunk,

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

rkflx added a comment. Is there any other menu action which has [Meta] in its shortcut? If not, this might be an indication that we are heading in the wrong direction. I find [Meta] more appropriate for global shortcuts (virtual desktops, activities, window management, Kickoff, …), where it

D8545: kio: fix handling of KCookieAdvice::AcceptForSession

dfaure accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D8545 To: schwab, dfaure Cc: #frameworks

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

abetts added a comment. If you assume that most computers that run linux will have a windows key, I would call it just windows. Everyone else uses exceptions really. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx

D8427: Allow cross compiling resource file

vkrause added a task: T6715: Add cross compilation support for breeze-icons QRC generator. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D8427 To: vpinon, apol, kfunk Cc: #frameworks, bartoloni, benjaminnelan, afarid, fernandoteles, mardelle

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

ngraham added a comment. That would work, and it's not taken, but I worry that this wouldn't help a lot of users, because outside of seasoned Linux users, Meta isn't a well known description for the Windows/super/Command key (depending on the keyboard hardware). REPOSITORY R237 KConfig R

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

abetts added a comment. What about Windows/Meta + Something, let's say , comma? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, #frame

D8545: kio: fix handling of KCookieAdvice::AcceptForSession

schwab updated this revision to Diff 21528. schwab added a comment. Accidentally attached the wrong diff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8545?vs=21521&id=21528 REVISION DETAIL https://phabricator.kde.org/D8545 AFFECTED FILES src/kcms/kio/kcookiespolicyselectiondl

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

ngraham added a comment. In https://phabricator.kde.org/D8296#161367, @rkflx wrote: > > Just checked: It's already there in Standard Shortcuts, where it can be changed. > > Well, it says Configure System Settings…, so I even discarded this when first looking for it. As a soon-to-be s

D6829: Add ability to use the new kauth helper in file ioslave

chinmoyr reopened this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6829 To: chinmoyr, dfaure, #frameworks Cc: #frameworks

D6197: Add kauth helper to file ioslave

chinmoyr reopened this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6197 To: chinmoyr, elvisangelaccio, #frameworks, dfaure

D6709: [RFC] Add support for sharing file descriptor between KIO slave and KAuth helper

chinmoyr reopened this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6709 To: chinmoyr, thiago, #frameworks, dfaure Cc: dfaure, davidedmundson, elvisangelaccio, shortstheory

D8545: kio: fix handling of KCookieAdvice::AcceptForSession

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcookiespolicyselectiondlg.h:54 > > if (advice == QLatin1String ("accept")) > return KCookieAdvice::Accept; Oh, nasty, the kconfig key

D8546: Add Aztec code generator

vkrause created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Needed e.g. for boarding pass rendering in https://phabricator.kde.org/D8395. REPOSITORY R280 Prison BRANCH master REVISION DETAIL h

D8545: kio: fix handling of KCookieAdvice::AcceptForSession

schwab added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8545 To: schwab, dfaure Cc: #frameworks

D8545: kio: fix handling of KCookieAdvice::AcceptForSession

schwab created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Commit https://phabricator.kde.org/R241:23874cab9d192a12f3f9f0b261fc6e0784354c1f broke the handling of KCookieAdvice::AcceptForSession bec

D8544: KTextEditor : avoiding QML crashes

rjvbb marked an inline comment as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D8544 To: rjvbb, #frameworks Cc: kde-frameworks-devel, kevinapavew, demsking, head7, cullmann, kfunk, sars, dhaumann

D8544: KTextEditor : avoiding QML crashes

rjvbb added inline comments. INLINE COMMENTS > cstyle.js:518 > +} else if (currentLine == 0 || lineDelimiter == 0) { > +return indentation; > } `indentation` should always equal -1 here (so no need to add the dbg() statement). REPOSITORY R39 KTextEdit

D8544: KTextEditor : avoiding QML crashes

rjvbb created this revision. rjvbb added a reviewer: Frameworks. rjvbb added a project: KTextEditor. Restricted Application added projects: Kate, Frameworks. REVISION SUMMARY The transition from QtScript to QML introduced a propensity to crashing somewhere deep in Qt (in the V4 JIT engine to be

D8188: Remove PreferCache from network requests

This revision was automatically updated to reflect the committed changes. Closed by commit R304:ed62ee204e4d: Remove PreferCache from network requests (authored by aacid). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8188?vs=20463&id=21513 REVISION DETAIL

KDE CI: Frameworks baloo kf5-qt5 XenialQt5.7 - Build # 35 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/35/ Project: Frameworks baloo kf5-qt5 XenialQt5.7 Date of build: Sun, 29 Oct 2017 07:39:20 + Build duration: 2 hr 14 min and counting JUnit Tests Name:

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

dfaure added a comment. Looks good, just some coding style issues. INLINE COMMENTS > kopenwithdialog.cpp:195 > d->fillNode(QString(), d->root); > +for (int i=0; i +fetchAll(index(i,0)); spaces around '=' and '<' I would put rowCount() into a local var, the compiler can't op

D8296: Use Ctrl+Alt+, as the standard shortcut for "Configure "

rkflx added a comment. > Just checked: It's already there in Standard Shortcuts, where it can be changed. Well, it says Configure System Settings…, so I even discarded this when first looking for it. As a soon-to-be shortcut expert, do you see a chance this could be changed to Configure

D8528: Consider DjVu files to be documents

rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. I'd say this can land. Perhaps best to wait until Monday evening, so Frameworks people not spending their weekend at the computer have a chance to weigh in? REPOSITORY R293 Baloo BRANCH

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.7/52/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 29 Oct 2017 07:16:08 + Build duration: 9 min 41 sec and counting J