BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20XenialQt5.7/28/
Project:
Frameworks kservice kf5-qt5 XenialQt5.7
Date of build:
Thu, 26 Oct 2017 05:10:27 +
Build duration:
7 min 8 sec and counting
JUnit Tests
safaalfulaij added a comment.
In https://phabricator.kde.org/D7660#158479, @ngraham wrote:
> @safaalfulaij, any progress on the latest comments?
Not really. I was busy with college. I'll try finishing it in the coming week.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://p
Zren added a comment.
Another note: `plasmoidviewer` is unaffected by this patch. Meaning
-
`devpath/contents/locale/fr_CA/LC_MESSAGES/plasma_applet_org.kde.plasma.eventcalendar.mo`
will not show translations in plasmoidviewer, but if you install to
-
`/.local/share/plasma/plas
Zren added a comment.
This worked
-
`~/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr_CA/LC_MESSAGES/plasma_applet_org.kde.plasma.eventcalendar.mo`
These didn't work
-
`~/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/f
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kunitconversion%20kf5-qt5%20AndroidQt5.9/4/
Project:
Frameworks kunitconversion kf5-qt5 AndroidQt5.9
Date of build:
Thu, 26 Oct 2017 00:31:45 +
Build duration:
1 min 27 sec and counting
ngraham planned changes to this revision.
ngraham added a comment.
Oh, great idea.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D8296
To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik,
#fr
abetts added a comment.
Could this also be added to global shortcuts if it is not there already? That
the user can define the keys to use for Preferences?
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D8296
To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: abetts,
On Wed, Oct 25, 2017 at 1:44 AM, Harald Sitter wrote:
> On Wed, Oct 25, 2017 at 10:35 AM, laurent Montel wrote:
>> Hi,
>> I send this email to kde-frameworks-devel
>>
>> It's the correct ML for having an answer about it
>>
>> Regards.
Hi Laurent, I thought that frameworks-devel was being depreca
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20AndroidQt5.9/2/
Project:
Frameworks kconfig kf5-qt5 AndroidQt5.9
Date of build:
Wed, 25 Oct 2017 23:09:37 +
Build duration:
3 min 57 sec and counting
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:a07822207374: Don't build the kconfig_compiler tests
when crosscompiling (authored by apol).
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8457?vs=21267&id=21342
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R237 KConfig
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8457
To: apol, #frameworks, davidedmundson
ngraham added a comment.
Thanks for your comments, @rkflx. I have no strong opinions on what the
shortcut should be.
Side note: if KMail and Kontact don't get this change automatically, that's a
sign that they're not using `KStandardAction::Preferences()` and should be.
REPOSITORY
R23
rkflx added a comment.
Since @ngraham added me as reviewer, here are my 2 cents. Trying the patch, I
made those observations:
- [Alt] often is released by the user only after the dialog is shown already,
resulting in the (normally hidden) accelerators ("_") of the dialog showing and
the
rkflx added a comment.
In general, having a default button while setting the initial focus elsewhere
is mainly useful for larger dialogs like our various standard configuration
dialogs, where this provides a way to accept without tabbing forever. For
smaller dialogs like a messagebox this is
ngraham accepted this revision.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8437
To: rjvbb, #frameworks, kfunk, ngraham
Cc: cfeck, ngraham
rjvbb edited the summary of this revision.
rjvbb edited the test plan for this revision.
rjvbb set the repository for this revision to R236 KWidgetsAddons.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8437
To: rjvbb, #frameworks, kfunk
Cc: cfeck, ngraham
rjvbb updated this revision to Diff 21340.
rjvbb added a comment.
patch cleaned up as requested.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8437?vs=21188&id=21340
REVISION DETAIL
https://phabricator.kde.org/D8437
AFFECTED FILES
src/kpassworddialog.ui
To: rjvbb, #frameworks
aacid added a comment.
In https://phabricator.kde.org/D7828#160029, @ngraham wrote:
> In other words, it seems intentional that the button marked default will
always receive focus.
No, open kate->settings->configure kate
Ok is the default button and it is not supposed to have
emateli added a comment.
I think this is getting a bit out of hand here. Please try to read my last
message where I explain why I decided to submit this patch and why I think it's
a bug (the whole parent widget thing).
Given the new information on why this occurs the whole focus by force
ngraham added a comment.
In https://phabricator.kde.org/D7828#160028, @aacid wrote:
> In https://phabricator.kde.org/D7828#160018, @ngraham wrote:
>
> > Once you press tab the focus moves elsewhere and hitting return or enter
will press whatever's selected rather than the original def
aacid added a comment.
In https://phabricator.kde.org/D7828#160018, @ngraham wrote:
> Once you press tab the focus moves elsewhere and hitting return or enter
will press whatever's selected rather than the original default button. So
really the concept of a "Default Button" in our world
ngraham added a comment.
Once you press tab the focus moves elsewhere and hitting return or enter will
press whatever's selected rather than the original default button. So really
the concept of a "Default Button" in our world seems to mostly be synonymous
with "the button that receives focu
aacid added a comment.
In https://phabricator.kde.org/D7828#159598, @ngraham wrote:
> In https://phabricator.kde.org/D7828#159556, @abetts wrote:
>
> > If you have two highlights, how do you know what's going to be activated
when hitting enter?
>
>
> My thoughts exactly.
apol added a comment.
In https://phabricator.kde.org/D7194#159878, @kossebau wrote:
> @apol Was this patch created due to some bug seen, or perhaps only of the
kind oh-that-seems-wrong-lets-be-nice-and-prevent-things? If the latter that
might be handy :)
I had some issue where I
franckarrecot added a comment.
I will add pics soonish
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8450
To: franckarrecot, ngraham, renatoo, mlaurent
Cc: #frameworks
kossebau added a comment.
@leinir I now completely gave up on the patch which tried to adapt to the
non-shared EntryInternal. As the screenshot loading code and the payload
download code rely on the explicitly shared data to attach the fetched
screenshots resp. update the download state, th
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/132/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 25 Oct 2017 13:10:40 +
Build duration:
13 min and counting
JUni
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/128/
Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
Date of build:
Wed, 25 Oct 2017 13:10:40 +
Build duration:
4 min 13 sec and counting
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:c52a6c574869: [PlasmaComponents Menu] Add ungrabMouseHack
(authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8445?vs=21232&id=
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/134/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Wed, 25 Oct 2017 11:47:45 +
Build duration:
1 min 49 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/128/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 25 Oct 2017 11:47:45 +
Build duration:
1 min 17 sec and counting
JUnit Tests
ChALkeR edited the summary of this revision.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D8451
To: ChALkeR, #framework_syntax_highlighting
Cc: #frameworks
renatoo updated this revision to Diff 21297.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8434?vs=21238&id=21297
REVISION DETAIL
https://phabricator.kde.org/D8434
AFFECTED FILES
autotests/kfileplacesmodelte
renatoo marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8348
To: renatoo, #dolphin, #frameworks, #vdg
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks
renatoo updated this revision to Diff 21296.
renatoo added a comment.
Used new connect API
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8348?vs=21228&id=21296
REVISION DETAIL
https://phabricator.kde.org/D8348
AFFECTED FILES
autotests/kfileplacesmodeltes
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/133/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Wed, 25 Oct 2017 10:43:44 +
Build duration:
4 min 58 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/127/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 25 Oct 2017 10:43:44 +
Build duration:
44 sec and counting
JUnit Tests
Na
franckarrecot updated this revision to Diff 21291.
franckarrecot added a comment.
updated according to comments
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8450?vs=21244&id=21291
REVISION DETAIL
https://phabricator.kde.org/D8450
AFFECTED FILES
src/file
franckarrecot updated this revision to Diff 21290.
franckarrecot added a comment.
updated according to comments
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=21243&id=21290
REVISION DETAIL
https://phabricator.kde.org/D8367
AFFECTED FILES
autotest
franckarrecot updated this revision to Diff 21289.
franckarrecot added a comment.
switch removable after regular devices
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8366?vs=20973&id=21289
REVISION DETAIL
https://phabricator.kde.org/D8366
AFFECTED FILES
franckarrecot retitled this revision from "WIP: User can now hide an entire
places group" to "User can now hide an entire places group".
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8450
To: franckarrecot, ngraham, renatoo, mlaurent
Cc: #frameworks
franckarrecot retitled this revision from "User can now hide an entire places
group" to "User can now hide an entire places group from KFilePlacesView".
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8450
To: franckarrecot, ngraham, renatoo, mlaurent
Cc: #frameworks
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
seems ok for me
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8366
To: franckarrecot, renatoo, mlaurent
Cc: mlaurent, #frameworks
mlaurent added inline comments.
INLINE COMMENTS
> kfileplacesview.cpp:297
> +const QModelIndexList indexesGroup =
> placesModel->groupIndexes(placesModel->groupType(index));
> +
> +for (const QModelIndex &idx : indexesGroup) {
m_disappearingItems.reserve(m_disappearingItems.count() + in
On Wed, Oct 25, 2017 at 10:35 AM, laurent Montel wrote:
> Hi,
> I send this email to kde-frameworks-devel
>
> It's the correct ML for having an answer about it
>
> Regards.
>
> Le mercredi 25 octobre 2017, 09:29:58 CEST Valorie Zimmerman a écrit :
>> Hello folks, with my Kubuntu release manager ha
Hi,
I send this email to kde-frameworks-devel
It's the correct ML for having an answer about it
Regards.
Le mercredi 25 octobre 2017, 09:29:58 CEST Valorie Zimmerman a écrit :
> Hello folks, with my Kubuntu release manager hat on, I was filling in
> the calendar for the next 6 months. For Framew
emateli added a comment.
Hey @subdiff, thanks for your input on this. Whether this patch goes in or
not, I still think that this "odd" behaviour is something that the frameworks
should fix or change rather than relying on the developer of each application
to do this.
However I never exp
leinir added a subscriber: sitter.
leinir added a comment.
Damn... Well spotted, @kossebau. Right, so immediate (at least temporary
solution) to make things not broken would annoyingly enough be to revert the
patch, yes... I am now thinking that another oddity noticed by @sitter last
week wa
genethomas created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
I have added support for mult-iline @"verbatim strings"
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.
mlaurent added inline comments.
INLINE COMMENTS
> kfileplacesmodel.cpp:596
> +const QHash groupStates = groupStateHidden(root);
> +for (KFilePlacesItem *item : items) {
> +if (bool hasToBeHidden = groupStates.value(item->groupType())) {
for(... : qAsConst(items)) {
}
REPOSITORY
mlaurent added inline comments.
INLINE COMMENTS
> kfileplacesitem.cpp:354
> +if (m_access) {
> +connect(m_access, SIGNAL(accessibilityChanged(bool,QString)),
> +this, SLOT(onAccessibilityChanged(bool)));
could you use new connect api please ?
REPOSITORY
51 matches
Mail list logo
