KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 123 - Still Unstable!

2017-10-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/123/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 20 Oct 2017 02:33:12 + Build duration: 14 min and counting JUnit Tests Na

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7 - Build # 49 - Still Unstable!

2017-10-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.7/49/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 20 Oct 2017 02:32:57 + Build duration: 13 min and counting JUnit T

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 129 - Still Unstable!

2017-10-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/129/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Fri, 20 Oct 2017 02:33:12 + Build duration: 3 min 29 sec and counting JUnit Tests

D8371: Support for underscores in numeric literals (Python 3.6)

2017-10-19 Thread Christoph Feck
cfeck added a reviewer: Kate. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D8371 To: januz, #kate Cc: #frameworks, cullmann, vkrause, dhaumann

D8371: Support for underscores in numeric literals (Python 3.6)

2017-10-19 Thread Christoph Feck
cfeck edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D8371 To: januz Cc: #frameworks, cullmann, vkrause, dhaumann

D8371: Support for underscores in numeric literals (Python 3.6)

2017-10-19 Thread Diego Gangl
januz created this revision. januz added a project: Framework: Syntax Highlighting. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This patch adds support for underscores in numeric literals for Python 3.6 (from PEP 51

D8173: Use readelf to find project dependencies

2017-10-19 Thread Albert Astals Cid
aacid requested changes to this revision. aacid added a comment. This revision now requires changes to proceed. This breaks KTuberling build for me, libKF5ConfigCore.so is not added to the apk anymore. Two random guesses since i'm not sure i understood the code enough: - does readelf

D8367: WIP: Hidding Group from KFilePlacesModel

2017-10-19 Thread Nathaniel Graham
ngraham added a comment. This solves https://bugs.kde.org/show_bug.cgi?id=300247; can you add "BUG: 300247" into the Summary? Also yeah, please add "Depends on https://phabricator.kde.org/D8243";. Finally... screenshots! We need screenshots! :) What does this look like in Dolphin? H

D8243: Implement support for categories on KfilesPlacesView

2017-10-19 Thread Renato Oliveira Filho
renatoo marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8243 To: renatoo, #frameworks, dfaure, ervin, #vdg Cc: ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8243: Implement support for categories on KfilesPlacesView

2017-10-19 Thread Nathaniel Graham
ngraham added a comment. @renatoo, can you update any remaining Not Done inline comments that are done now (including the discussion ones)? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8243 To: renatoo, #frameworks, dfaure, ervin, #vdg Cc: ngraham, mlaurent, ervin, a

D8332: Added baloo urls into places model

2017-10-19 Thread Nathaniel Graham
ngraham added a comment. @dvratil, any remaining objections? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg Cc: usta, mlaurent, dvratil, ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-19 Thread Renato Oliveira Filho
renatoo updated this revision to Diff 20987. renatoo marked 2 inline comments as done. renatoo added a comment. Fixed code style REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=20953&id=20987 REVISION DETAIL https://phabricator.kde.org/D8348 AFFECTED

D8354: Remove check for SNI hosts when chosing

2017-10-19 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R289:588151c5e000: Remove check for SNI hosts when chosing whether to use legacy mode (authored by davidedmundson). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D8367: WIP: Hidding Group from KFilePlacesModel

2017-10-19 Thread Renato Oliveira Filho
renatoo added a comment. Could add "Depends on https://phabricator.kde.org/D8332"; into the summary. I think something like: root.setMetaDataItem("hiden-groups", "[]") its is way more simple and do not need to export new groups. REPOSITORY R241 KIO REVISION DETAIL https:/

D8367: WIP: Hidding Group from KFilePlacesModel

2017-10-19 Thread Laurent Montel
mlaurent requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8367 To: franckarrecot, renatoo, mlaurent Cc: mlaurent, #frameworks

D8367: WIP: Hidding Group from KFilePlacesModel

2017-10-19 Thread Laurent Montel
mlaurent added inline comments. INLINE COMMENTS > kfileplacesmodeltest.cpp:83 > > +bool isFileIndexingEnabled; > QMap m_interfacesMap; m_isFileIndexingEnabled > kfileplacesmodeltest.cpp:89 > { > return > QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) +

D8347: KIO::PreviewJob::defaultPlugins() function

2017-10-19 Thread Kai Uwe Broulik
broulik added a comment. 5.39 was just released so it will be 5.40 REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8347 To: ngraham, #frameworks, broulik, #dolphin, markg Cc: markg, anthonyfieroni, elvisangelaccio, #frameworks

D8347: KIO::PreviewJob::defaultPlugins() function

2017-10-19 Thread Nathaniel Graham
ngraham marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8347 To: ngraham, #frameworks, broulik, #dolphin, markg Cc: markg, anthonyfieroni, elvisangelaccio, #frameworks

D8347: KIO::PreviewJob::defaultPlugins() function

2017-10-19 Thread Nathaniel Graham
ngraham marked an inline comment as done. ngraham added inline comments. INLINE COMMENTS > markg wrote in previewjob.h:198 > You miss an @since line. I've updated the header documentation with @returns and @since, as well as updated the documentation for the above availablePlugins() to help dis

D8347: KIO::PreviewJob::defaultPlugins() function

2017-10-19 Thread Nathaniel Graham
ngraham updated this revision to Diff 20975. ngraham added a comment. Updating header documentation with @returns and @since REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8347?vs=20927&id=20975 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8

D8367: WIP: Hidding Group from KFilePlacesModel

2017-10-19 Thread Franck Arrecot
franckarrecot created this revision. franckarrecot added a reviewer: renatoo. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This give an implemenation to the places model to hidde an entire group of places. The model

D8366: Factoring out lists of url data within KFilePlacesModelTest

2017-10-19 Thread Franck Arrecot
franckarrecot created this revision. franckarrecot added a reviewer: renatoo. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Instead of reusing the same string lists all over the place we factor them out, easier to re