BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.7/48/
Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 18 Oct 2017 06:10:48 +
Build duration:
10 min and counting
JUnit T
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/127/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Wed, 18 Oct 2017 05:54:47 +
Build duration:
1 min 44 sec and counting
JUnit Tests
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfileplacesmodeltest.cpp:323
> +// Trying move the remote at the end of the list, should move it to the
> end of places section instead
> +// too keep
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/121/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 18 Oct 2017 05:54:47 +
Build duration:
59 sec and counting
JUnit Tests
Na
anthonyfieroni added inline comments.
INLINE COMMENTS
> previewjob.cpp:740
> +{
> +QStringList blacklist = QStringList()
> +<< QStringLiteral("textthumbnail");
const QStringList blackList = { QStringLiteral("textthumbnail") };
REPOSITORY
R241 KIO
REVISION DETA
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
I support this change, for the additional reason that it's appropriate for
the "move to trash" icon to be black, because red icons are for destructive
changes, and moving something to the
ngraham edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8347
To: ngraham, #frameworks, broulik, #dolphin
Cc: elvisangelaccio, #frameworks
ngraham edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8347
To: ngraham, #frameworks, broulik, #dolphin
Cc: elvisangelaccio, #frameworks
ngraham added a dependent revision: D8352: Use
KIO::PreviewJob::defaultPlugins().
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8347
To: ngraham, #frameworks, broulik, #dolphin
Cc: elvisangelaccio, #frameworks
ngraham created this revision.
ngraham added a reviewer: Frameworks.
REVISION SUMMARY
Use KIO::PreviewJob::defaultPlugins() instead of hardcoding plugin list.
Depends on https://phabricator.kde.org/D8347
TEST PLAN
Compiles fine in KDE Neon.
REPOSITORY
R320 KIO Extras
BRANCH
master
kossebau added a comment.
Another option might be to split off a data structure where the application
domain string is stored separately, and thus delay the initialization of the
KLocalizedStringPrivateStatics instance to the first i18n call. Though given
that the initialisation sets global
kossebau created this revision.
kossebau added reviewers: Frameworks, ilic, ltoscano.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
The current implementation of KLocalizedString::setApplicationDomain()
will trigger the creation of the KLocalizedStringPrivateStatics inst
ngraham marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8347
To: ngraham, #frameworks, broulik, #dolphin
Cc: elvisangelaccio, #frameworks
ngraham updated this revision to Diff 20927.
ngraham added a comment.
Whitespace fix
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8347?vs=20926&id=20927
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8347
AFFECTED FILES
src/widgets/previe
ngraham updated this revision to Diff 20926.
ngraham marked an inline comment as done.
ngraham added a comment.
Style improvements/corrections
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8347?vs=20923&id=20926
BRANCH
master
REVISION DETAIL
https://phab
ngraham marked 3 inline comments as done.
ngraham added inline comments.
INLINE COMMENTS
> elvisangelaccio wrote in previewjob.cpp:740-741
> Shouldn't the blacklist be user-configurable?
In fact, the whole list of plugins to enable is user-configurable in Dolphin.
The blacklist just defines whi
elvisangelaccio added inline comments.
INLINE COMMENTS
> previewjob.cpp:740-741
> +{
> +QStringList blacklist = QStringList()
> +<< QStringLiteral("textthumbnail");
> +
Shouldn't the blacklist be user-configurable?
> previewjob.cpp:745
> +foreach (const QStri
ngraham added a comment.
@aacid, all good now?
REVISION DETAIL
https://phabricator.kde.org/D7828
To: emateli, #frameworks
Cc: ngraham, aacid, #frameworks
renatoo added a comment.
In https://phabricator.kde.org/D8348#156659, @ngraham wrote:
> Can you put the screenshot in the Summary section above, and list the
dependencies there too? Also put dependency information there, in the following
form:
>
>
> Depends on D8243
> Depends o
ngraham added a reviewer: VDG.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg
Cc: usta, mlaurent, dvratil, ngraham, #frameworks
ngraham added a reviewer: VDG.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8243
To: renatoo, #frameworks, dfaure, ervin, #vdg
Cc: ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks
broulik added a reviewer: VDG.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8348
To: renatoo, #dolphin, #frameworks, #vdg
Cc: ngraham, #frameworks
renatoo added a dependent revision: D8332: Added baloo urls into places model.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8243
To: renatoo, #frameworks, dfaure, ervin
Cc: ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks
renatoo edited the summary of this revision.
renatoo added a dependency: D8243: Implement support for categories on
KfilesPlacesView.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil
Cc: usta, mlaurent, dvra
renatoo added a dependent revision: D8348: Add a section for removable devices.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil
Cc: usta, mlaurent, dvratil, ngraham, #frameworks
renatoo edited the summary of this revision.
renatoo added dependencies: D8243: Implement support for categories on
KfilesPlacesView, D8332: Added baloo urls into places model.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8348
To: renatoo, #dolphin, #frameworks
Cc: ngrah
renatoo added a dependent revision: D8348: Add a section for removable devices.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8243
To: renatoo, #frameworks, dfaure, ervin
Cc: ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks
renatoo edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8348
To: renatoo, #dolphin, #frameworks
Cc: ngraham, #frameworks
ngraham added a comment.
FWIW, I don't have a lot to offer on the code itself, but I strongly support
the change itself. It's always bothered me that Open/Save dialogs were lacking
these very useful sections
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8243
To: rena
renatoo edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil
Cc: usta, mlaurent, dvratil, ngraham, #frameworks
ngraham added a comment.
Can you put the screenshot in the Summary section above, and list the
dependencies there too? Also put dependency information there, in the following
form:
Depends on D8243
Depends on D8332
This special syntax marks them as dependencies.
REPOSITORY
renatoo edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8243
To: renatoo, #frameworks, dfaure, ervin
Cc: ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks
ngraham added a comment.
Screenshots, my man! Screenshots! Add them to the Summary section so people
can see what they're getting if this gets merged. :)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8243
To: renatoo, #frameworks, dfaure, ervin
Cc: ngraham, mlaurent,
renatoo added a comment.
In https://phabricator.kde.org/D8348#156653, @ngraham wrote:
> Is there a bugzilla ticket tracking this? And can you include a screenshot
showing what it looks like now?
There is no bugzilla, I can create one if that will helps.
A preview can be find
ngraham added a comment.
Is there a bugzilla ticket tracking this? And can you include a screenshot
showing what it looks like now?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8348
To: renatoo, #dolphin, #frameworks
Cc: ngraham, #frameworks
renatoo added reviewers: Dolphin, Frameworks.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8348
To: renatoo, #dolphin, #frameworks
Cc: #frameworks
renatoo marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil
Cc: usta, mlaurent, dvratil, ngraham, #frameworks
renatoo marked an inline comment as not done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil
Cc: usta, mlaurent, dvratil, ngraham, #frameworks
ngraham updated this revision to Diff 20923.
ngraham added a comment.
Updating comments/documentation
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8347?vs=20916&id=20923
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8347
AFFECTED FILES
s
cfeck added inline comments.
INLINE COMMENTS
> kautosavefiletest.cpp:87
> +QVERIFY(saveFile.open(QIODevice::ReadWrite));
> +saveFile.write(QStringLiteral("testdata").toUtf8());
> +// Make sure the stale file is found
saveFile.write("testdata") is sufficient.
REPOSITORY
R244 KCoreA
renatoo marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil
Cc: usta, mlaurent, dvratil, ngraham, #frameworks
renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Show removable devices in a different section
TEST PLAN
From any kde app try to open/save a file.
Plug any removable device in your comp
renatoo updated this revision to Diff 20918.
renatoo added a comment.
Typo fixed
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8332?vs=20906&id=20918
REVISION DETAIL
https://phabricator.kde.org/D8332
AFFECTED FILES
autotests/kfileplacesmodeltest.cpp
sr
ngraham added a dependent revision: D7440: Turn on Dolphin icon previews by
default.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8347
To: ngraham, #frameworks, broulik, #dolphin
Cc: #frameworks
ngraham added reviewers: Frameworks, broulik, Dolphin.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8347
To: ngraham, #frameworks, broulik, #dolphin
Cc: #frameworks
ngraham created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Adds a new KIO::PreviewJob::defaultPlugins() function that returns all
available plugins minus ones specified in an internal blacklist. This
davidedmundson added a comment.
I've realised there's much more to do:
The existing code has some super weird behaviour.
Find there's an SNI watcher, but no host (i.e kded but no plasmashell) -
that's fine, we don't check and create one anyway
But if a host gets added/removed - the
xuetianweng added inline comments.
INLINE COMMENTS
> kstatusnotifieritem.cpp:882
> +
> +QDBusPendingReply pendingReply =
> statusNotifierWatcher->connection().call(call);
> +auto watcher = new QDBusPendingCallWatcher(pendingReply);
The template is not necessary here. Maybe auto
davidedmundson planned changes to this revision.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D8346
To: davidedmundson
Cc: xuetianweng, #frameworks
xuetianweng added inline comments.
INLINE COMMENTS
> kstatusnotifieritem.cpp:879
> +} else {
> +QDBusMessage call =
> QDBusMessage::createMethodCall(statusNotifierWatcher->service(),
> statusNotifierWatcher->path(),
> QStringLiteral("org.freedesktop.DBus.Properties."), QStringLiter
davidedmundson created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
BUG: 385867
TEST PLAN
Ran test
killed plasmashell
SNI restored when plasmashell came back
REPOSITORY
R289 KNotifications
BR
usta added inline comments.
INLINE COMMENTS
> kfileplacesmodel.cpp:151
>
> +// if baloo is enabled, add new ulrs even if the bookmark file is not
> empty
> +if (d->fileIndexingEnabled &&
typo: ulrs
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renato
davidedmundson added a comment.
Trace is different, so ...progress!
I don't think there's anything specifically wrong with this patch in itself.
I'll fix that and review the rest of this class.
Sorry, Thanks for the quick feedback.
REPOSITORY
R289 KNotifications
REVISION DETAIL
graesslin added a comment.
I'm sorry but it still deadlocks, see
https://bugs.kde.org/show_bug.cgi?id=385867
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D8321
To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliez
ngraham added a comment.
Any objections to Alt+, ?
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D8296
To: ngraham, #frameworks, #vdg
Cc: aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks
renatoo marked 2 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil
Cc: mlaurent, dvratil, ngraham, #frameworks
renatoo updated this revision to Diff 20906.
renatoo added a comment.
Fixed typos
Use QStringLiteral when possible
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8332?vs=20905&id=20906
REVISION DETAIL
https://phabricator.kde.org/D8332
AFFECTED FILES
aut
renatoo updated this revision to Diff 20905.
renatoo marked 5 inline comments as done.
renatoo added a comment.
Fixed typos
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8332?vs=20879&id=20905
REVISION DETAIL
https://phabricator.kde.org/D8332
AFFECTED FILE
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/86/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 17 Oct 2017 11:47:08 +
Build duration:
17 min and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:92ec63dd1b07: - Increase size of trailing mark (authored
by helio).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7884?vs=20330&id=20903
REVISION DETAIL
https
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Then I would say => merge it.
And thanks for the work!
REPOSITORY
R39 KTextEditor
BRANCH
big_trailing
REVISION DETAIL
https://phabricator.kde.org/D7884
To: helio, mwolff, kfun
helio added a comment.
In https://phabricator.kde.org/D7884#154232, @sars wrote:
> I'm OK with an option for this. The only problem, with the option in the
screen-shot, is that it could be interpreted as also effecting the tabulator
mark.
I did not changed the current behavior, i
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/85/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 17 Oct 2017 09:34:42 +
Build duration:
17 min and counting
JUnit Tests
mlaurent added inline comments.
INLINE COMMENTS
> kfileplacesview.cpp:1303
> +const int day = date.day();
> +timelineUrl = QUrl("timeline:/" + timelineDateString(year, month) +
> + '/' + timelineDateString(year, month, day));
Add QStringLiteral and QLatin1Char('/') t
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.7/47/
Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 17 Oct 2017 07:43:37 +
Build duration:
5 min 49 sec and counting
J
This revision was automatically updated to reflect the committed changes.
Closed by commit R239:9a990c69c606: Make kssl compile against OpenSSL 1.1.0
(authored by dvratil).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6665?vs=16613&id=20890#toc
REPOSITORY
R239 KDELibs4Support
CHANGE
dvratil requested changes to this revision.
dvratil added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfileplacesmodel.cpp:151
>
> +// if baloo is enabled, add new ulrs even if the bookbark file is not
> empty
> +if (d->fileIndexingEnabled &&
typo
davidk added a comment.
In https://phabricator.kde.org/D8330#156180, @mgallien wrote:
> I am not sure about the qWarning.
> I would prefer another opinion on that.
Some other extractors also print warnings. I think it's the only way a user
can spot such problems. But let's wait
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:800908eaec7a: Only check for legacy system tray icons if
we're going to make one (authored by davidedmundson).
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/
69 matches
Mail list logo
