dhaumann added a comment.
Looks already quite good. Btw, are there any bug reports in the Kate or
frameworks-ktexteditor product on bugs.kde.org that you fix here?
INLINE COMMENTS
> spellcheckdialog.cpp:198
>
> -
> m_currentSpellCheckRange.setRange(KTextEditor::Range(replacementStartCu
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/112/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Fri, 06 Oct 2017 03:02:10 +
Build duration:
2 min 23 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/106/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 06 Oct 2017 03:02:10 +
Build duration:
1 min 20 sec and counting
JUnit Tests
croick added inline comments.
INLINE COMMENTS
> spellcheckbar.cpp:146
> d->deleteProgressDialog(false); // this method can be called in response
> to
> +d->replaceAllMap.clear();
> // pressing 'Cancel' on the dialog
This might have been a feature, but without clearing the map, the
croick created this revision.
croick added a reviewer: KTextEditor.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
- empty document does not resize bar widget when spell check is started
without effect
- replaci
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/79/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 05 Oct 2017 20:07:42 +
Build duration:
9 min 54 sec and counting
JUnit Tes
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/78/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 05 Oct 2017 19:56:04 +
Build duration:
11 min and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:9d1a97532ce3: Use QActionGroup for input mode selection
(authored by croick).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8147?vs=20359&id=20377
REVISION DETA
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:9a77f365de57: Fix missing spell check bar (authored by
croick).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8148?vs=20360&id=20376
REVISION DETAIL
https://p
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/111/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Thu, 05 Oct 2017 16:16:41 +
Build duration:
1 min 4 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/105/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 05 Oct 2017 16:16:41 +
Build duration:
42 sec and counting
JUnit Tests
Na
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20WindowsMSVCQt5.9/11/
Project:
Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.9
Date of build:
Thu, 05 Oct 2017 15:53:53 +
Build duration:
32 sec and counting
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20XenialQt5.7/11/
Project:
Frameworks qqc2-desktop-style kf5-qt5 XenialQt5.7
Date of build:
Thu, 05 Oct 2017 15:53:53 +
Build duration:
41 sec and counting
CONS
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20FreeBSDQt5.7/11/
Project:
Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 05 Oct 2017 15:53:53 +
Build duration:
36 sec and counting
CO
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/110/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Thu, 05 Oct 2017 15:49:52 +
Build duration:
1 min 13 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/104/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 05 Oct 2017 15:49:52 +
Build duration:
1 min 33 sec and counting
JUnit Tests
rjvbb added a comment.
Seems I found a crasher:
https://bugs.kde.org/show_bug.cgi?id=385398
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D6914
To: carewolf, cullmann, dhaumann, #frameworks
Cc: rjvbb, dfaure, cullmann, #frameworks
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/109/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Thu, 05 Oct 2017 13:45:14 +
Build duration:
1 min 4 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/103/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 05 Oct 2017 13:45:14 +
Build duration:
38 sec and counting
JUnit Tests
Na
dfaure added a comment.
Ah right, my comment was wrong, it assumed that `text` was the current text
of `tb`, but it's not (necessarily).
So your patch is ok, it's just that I'd rather remove all this code with my
other patch instead ;)
But until it's approved, let's have yours in...
R
mgallien added a comment.
The problem is that, on Windows, internal objects of QMediaPlayer need to be
destroyed in the context of the thread where they have been created. I am not
sure making mMetadataExtractor have mRunnerThread as its parent will help on
that.
I can test but have no Win
mardelle added a comment.
So did some more tests, and the loop is caused by the tb->settext() call. The
QAbstractButton setText method checks if :
d->text == text
But d->text contains the & accel marker and not text, so we end up comparing
'ren&der' with 'render' on paint, thus the loo
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/108/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Thu, 05 Oct 2017 12:36:05 +
Build duration:
1 min 16 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/102/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 05 Oct 2017 12:36:05 +
Build duration:
51 sec and counting
JUnit Tests
Na
nicolasfella abandoned this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8146
To: nicolasfella, #plasma
Cc: mart, davidedmundson, plasma-devel, #frameworks, #plasma, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, seb
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/107/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Thu, 05 Oct 2017 11:32:37 +
Build duration:
1 min 9 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/101/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 05 Oct 2017 11:32:37 +
Build duration:
43 sec and counting
JUnit Tests
Na
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/100/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 05 Oct 2017 11:19:21 +
Build duration:
2 min 1 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/106/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Thu, 05 Oct 2017 11:19:21 +
Build duration:
1 min 47 sec and counting
JUnit Tests
chinmoyr updated this revision to Diff 20367.
chinmoyr added a comment.
Added correct header
Removed the `openMode` variable. `FileProtocol::tryOpen` takes care of file
mode.
Newline changes
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6831?vs=19170&id=20367
BRANCH
master
chinmoyr updated this revision to Diff 20366.
chinmoyr added a comment.
used the new header and method
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6830?vs=19167&id=20366
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6830
AFFECTED FILES
src/ioslaves/file/file
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Can't you just parent the extractor to the mRunnerThread?
Would be all round cleaner
REPOSITORY
R286 KFileMetaData
BRANCH
master
REVISION DETAIL
https://phabricator
mgallien added a comment.
Ping
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D6317
To: mgallien, #frameworks
Cc: #frameworks
mart added a comment.
yes, this should stay.
this was done in order to have labels automatically vertically align with
other controls with just a Row (before RowLayout and Layout.alignment was a
thing)
as David says, will get rid of those once all is ported to new controls
REPOSITORY
R
fvogt added a comment.
In https://phabricator.kde.org/D8077#152371, @broulik wrote:
> Despite just having built p-f from git I still get
>
> > Error loading QML file:
file:///usr/share/plasma/plasmoids/org.kde.plasma.fuzzyclock/contents/ui/main.qml:51:34:
Type PlasmaCalendar.MonthVie
35 matches
Mail list logo
