KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 94 - Still Unstable!

2017-09-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/94/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Sun, 01 Oct 2017 03:11:56 + Build duration: 5 min 6 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 89 - Still Unstable!

2017-09-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/89/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 01 Oct 2017 03:11:56 + Build duration: 2 min 1 sec and counting JUnit Tests

KDE CI: Frameworks baloo kf5-qt5 XenialQt5.7 - Build # 31 - Still Unstable!

2017-09-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/31/ Project: Frameworks baloo kf5-qt5 XenialQt5.7 Date of build: Sat, 30 Sep 2017 20:00:01 + Build duration: 11 min and counting JUnit Tests Name: (root

D7330: Don't enter test subdirectories if BUILD_TESTING=OFF

2017-09-30 Thread Andreas Sturmlechner
asturmlechner closed this revision. asturmlechner added a comment. Thanks! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D7330 To: asturmlechner, #frameworks, dfaure, mgallien

D8042: Fix invalid itemData references of 57 highlighting files

2017-09-30 Thread Dominik Haumann
dhaumann closed this revision. dhaumann added a comment. Closed with https://commits.kde.org/syntax-highlighting/164cac777fdf6911a52aba440277bc1d25406bc4 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D8042 To: dhaumann, vkrause, cullmann Cc: #frameworks

D8076: nfs: Skip mounts with no permission

2017-09-30 Thread Luca Weiss
z3ntu edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D8076 To: z3ntu, #frameworks, dfaure, davidedmundson Cc: ltoscano, ngraham

D7771: Fix memory leak

2017-09-30 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R279 ThreadWeaver REVISION DETAIL https://phabricator.kde.org/D7771 To: aacid, mirko, davidedmundson Cc: #frameworks

D8043: KDirWatch : make methods virtual

2017-09-30 Thread René J . V . Bertin
rjvbb abandoned this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D8043 To: rjvbb, #frameworks, mwolff, dfaure Cc: dhaumann, cfeck, dfaure, mwolff, kde-frameworks-devel

D8077: Fix org.kde.plasma.calendar with Qt 5.10

2017-09-30 Thread Fabian Vogt
fvogt created this revision. fvogt added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Module internal types are not implicitly available anymore simply by placing them inside the module's

D8076: nfs: Skip mounts with no permission

2017-09-30 Thread Luigi Toscano
ltoscano added a comment. As mentioned on IRC, this is a starting point but maybe the logic should be changed so that there is no error on connection is at least a mount point is accessible; the error should be on access. PS: changes to the commit message in the git patch are not reflect

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-09-30 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I gave this a shot and it's an excellent change--a huge improvement over the status quo. I have two suggestions for further ergonomic refinement: - When the text field has f

D8076: nfs: Skip mounts with no permission

2017-09-30 Thread Luca Weiss
z3ntu updated this revision to Diff 20163. z3ntu added a comment. Add the bug keyword REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8076?vs=20160&id=20163 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8076 AFFECTED FILES nfs/nfsv3.

D8076: nfs: Skip mounts with no permission

2017-09-30 Thread Luca Weiss
z3ntu added a comment. Well as we don't add failed mounts to the `failList` (if they fail because of 13 / MNT3ERR_ACCES) so the line `if (failList.size() == exportsCount) {` won't work then. Will add the bug keyword. Didn't know BugZilla and Phabricator were connected :) REPOSITORY R

D8076: nfs: Skip mounts with no permission

2017-09-30 Thread Nathaniel Graham
ngraham added reviewers: Frameworks, dfaure, davidedmundson. ngraham added a comment. Thanks for the patch! Instead of a bugzilla link, you can just use a special keyword: "BUG: 375249" This will ensure that the bug gets closed once the patch is accepted and merged. REPOSITORY R320 KI

D8064: Correct installation of start_kdeinit when DESTDIR and libcap are used together

2017-09-30 Thread Elvis Angelaccio
elvisangelaccio added a reviewer: dfaure. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D8064 To: awilcox, dfaure Cc: #frameworks

D7771: Fix memory leak

2017-09-30 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R279 ThreadWeaver BRANCH master REVISION DETAIL https://phabricator.kde.org/D7771 To: aacid, mirko, davidedmundson Cc: #frameworks

KDE CI: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 - Build # 31 - Still Unstable!

2017-09-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20XenialQt5.7/31/ Project: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 Date of build: Sat, 30 Sep 2017 13:07:50 + Build duration: 10 min and counting JUnit Tests

KDE CI: Frameworks kpty kf5-qt5 FreeBSDQt5.7 - Build # 24 - Still Unstable!

2017-09-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.7/24/ Project: Frameworks kpty kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 30 Sep 2017 13:13:45 + Build duration: 1 min 38 sec and counting JUnit Tests Name:

D8070: Fix build with Qt 5.10

2017-09-30 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R291:baad91bc2c45: Fix build with Qt 5.10 (authored by fvogt). REPOSITORY R291 KPty CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8070?vs=20145&id=20151 REVISION DETAIL https://phabricator.k

KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.7 - Build # 30 - Still Unstable!

2017-09-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.7/30/ Project: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 30 Sep 2017 13:07:50 + Build duration: 3 min 48 sec and counting JUnit

D8069: Fix build with Qt 5.10

2017-09-30 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R278:ec6eec156604: Fix build with Qt 5.10 (authored by fvogt). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8069?vs=20144&id=20150 REVISION DETAIL https://phab

D8070: Fix build with Qt 5.10

2017-09-30 Thread Luca Beltrame
lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. LGTM. REPOSITORY R291 KPty BRANCH master REVISION DETAIL https://phabricator.kde.org/D8070 To: fvogt, #frameworks, lbeltrame Cc: lbeltrame, #frameworks

D8069: Fix build with Qt 5.10

2017-09-30 Thread Luca Beltrame
lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. Trivial change, LGTM. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D8069 To: fvogt, #frameworks, graesslin, lbeltrame Cc: lbeltrame,

D7330: Don't enter test subdirectories if BUILD_TESTING=OFF

2017-09-30 Thread Matthieu Gallien
mgallien accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D7330 To: asturmlechner, #frameworks, dfaure, mgallien

D7330: Don't enter test subdirectories if BUILD_TESTING=OFF

2017-09-30 Thread Andreas Sturmlechner
asturmlechner added a reviewer: dfaure. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D7330 To: asturmlechner, #frameworks, dfaure

D8070: Fix build with Qt 5.10

2017-09-30 Thread Fabian Vogt
fvogt created this revision. fvogt added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY QByteArray does not include QString anymore, but QString is used in k_pty.h TEST PLAN Did not build before, now does. REPOSITORY R291 KPty BRANCH master

D8069: Fix build with Qt 5.10

2017-09-30 Thread Fabian Vogt
fvogt created this revision. fvogt added reviewers: Frameworks, graesslin. Restricted Application added a project: Frameworks. REVISION SUMMARY QByteArray does not include QString anymore, but that is needed in kxerrorhandler.cpp due to usage of operator overloads. TEST PLAN Did not build b

D7771: Fix memory leak

2017-09-30 Thread Albert Astals Cid
aacid added a comment. Ping, i'll commit this in two weeks unless anyone disagrees. REPOSITORY R279 ThreadWeaver REVISION DETAIL https://phabricator.kde.org/D7771 To: aacid, mirko Cc: #frameworks

D7771: Fix memory leak

2017-09-30 Thread Albert Astals Cid
aacid retitled this revision from "Fix leak in autotests/ThreadWeaverQueueTests" to "Fix memory leak". aacid edited the test plan for this revision. REPOSITORY R279 ThreadWeaver REVISION DETAIL https://phabricator.kde.org/D7771 To: aacid, mirko Cc: #frameworks