mardelle added a comment.
Not sure how to test this accelerator thing properly for a review but I would
really love to get rid of the ktoolbar hack . Can we get this patch in time for
frameworks 5.39 release, or should I commit my workaround
https://phabricator.kde.org/D7954 as a temporary f
dhaumann added a comment.
@rjvbb you are changing the memory layout of instances of this class. All
applications that use this class / library will break without recompiling.
The KDE Frameworks guarantee binary compatibility backwards. See:
https://community.kde.org/Policies/Binary_Comp
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/90/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Fri, 29 Sep 2017 02:57:09 +
Build duration:
1 min 27 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/86/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 29 Sep 2017 02:57:09 +
Build duration:
59 sec and counting
JUnit Tests
Nam
cfeck added a comment.
ABI is broken for any derived class, because the added virtual increases the
size of the object. The changed offsets would require all code that uses the
derived class to be recompiled.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D8043
rjvbb added a comment.
In a (big) nutshell: https://phabricator.kde.org/D7995.
KDevelop currently uses a single KDirWatch per open project that is fed with
a single `addDir` call which adds all folders under the project directory (and
all files, which it shouldn't).
This is fine on Lin
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
This allows a server to filter which globals are visible and b
rjvbb added a comment.
TBH I was indeed expecting all kinds of hell raining down when I rebuilt the
framework with this change, in the form of mysterious linker errors about
virtual thunks and what have you.
Not so, no symbols are missing from libKF5CoreAddons because of this patch,
so exa
dfaure requested changes to this revision.
dfaure added a comment.
In addition to being BIC, this is not the way to add thread safety. Either
the class should be threadsafe (and then it should use mutexes internally) or
it doesn't need to be threadsafe (and that can just be documented).
Why
dfaure added a comment.
Proper fix submitted in https://phabricator.kde.org/D7829 -- now with
unittests.
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D6233
To: dfaure, graesslin
Cc: broulik, martinkostolny, bcooksley, graesslin, #frameworks
dfaure updated this revision to Diff 20066.
dfaure added a comment.
Restricted Application added a project: Frameworks.
Reworked the fix completely.
Now fixes Meta+Shift+Print too.
REPOSITORY
R278 KWindowSystem
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7829?vs=19544&id=2
mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.
this is not abi compatible, cannot be done -2
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D8043
To: rjvbb, #frameworks, mwolff
Cc: mwolff, kde-fra
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/119/
Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
Date of build:
Thu, 28 Sep 2017 21:06:20 +
Build duration:
9 min 34 sec and counting
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/123/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 28 Sep 2017 21:06:20 +
Build duration:
4 min 39 sec and counting
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:bb6b17051673: [FrameSvgItem] Iterate child nodes properly
(authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8046?vs=20061&id=
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8046
To: broulik, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Documentation says "Children are stored internally as a linked list, so
iterating over
rjvbb set the repository for this revision to R244 KCoreAddons.
rjvbb added a subscriber: kde-frameworks-devel.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D8043
To: rjvbb, #frameworks
Cc: kde-frameworks-devel
rjvbb updated this revision to Diff 20056.
rjvbb edited the test plan for this revision.
rjvbb added a comment.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8043?vs=20046&id=20056
REVISION DETAIL
https://phabricator.kde.org/D8043
AFFECTED FILES
src/lib/io/kdirwatch.h
To: rj
rjvbb created this revision.
rjvbb added a reviewer: Frameworks.
rjvbb added a project: Frameworks.
REVISION SUMMARY
KDirWatch is not current thread-safe which can cause problems when feeding or
deleting directories in a multi-threaded approach. In addition, the class uses
a single QFileSystem
dhaumann created this revision.
dhaumann added reviewers: vkrause, cullmann.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Many highlightig files reference with attribute="xzy" non-existing
itemDatas. This was found
ngraham edited reviewers, added: aacid; removed: Okular.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D8007
To: flameeyes, #frameworks, aacid
Cc: #frameworks
ngraham added reviewers: Frameworks, Okular.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D8007
To: flameeyes, #frameworks, #okular
Cc: #frameworks
cfeck accepted this revision.
cfeck added a comment.
This revision is now accepted and ready to land.
I have to admit that I feel not comfortable with overriding properties. But
if this is the only way to fix unit tests (and those are supposed to reveal
bugs in our code), then please commit i
rkflx added a comment.
As the CI keeps sending me mails with "BUILD UNSTABLE", I'd love to get this
fix in.
If it takes you more time to think about this and we'll miss 5.39, that's
fine too. Just tell me and I can at least disable the test in the meantime.
REPOSITORY
R236 KWidgetsAdd
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20XenialQt5.7/44/
Project:
Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7
Date of build:
Thu, 28 Sep 2017 16:44:22 +
Build duration:
8 min 11 sec and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.7/44/
Project:
Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 28 Sep 2017 16:44:22 +
Build duration:
7 min 41 sec and counting
JUn
ngraham closed this revision.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8029
To: ngraham, #frameworks, #vdg, dfaure, rkflx, davidedmundson, cfeck
Cc: cfeck, #frameworks
ngraham closed this revision.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D8036
To: ngraham, davidedmundson, #frameworks, cfeck
Cc: #frameworks
dhaumann closed this revision.
dhaumann added a comment.
Fixed with
https://commits.kde.org/syntax-highlighting/2292368aa3aa19210c3569b213fd0c7647a836aa
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D8028
To: nibags, #framework_syntax_highlighting, dhau
dhaumann accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
update-apparmor-syntax (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D8028
To: nibags, #framework_syntax_highlighting, dhaumann
Cc: #frameworks
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/51/
Project:
Frameworks kcoreaddons kf5-qt5 XenialQt5.7
Date of build:
Thu, 28 Sep 2017 15:57:26 +
Build duration:
6 min 51 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/46/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 28 Sep 2017 15:57:26 +
Build duration:
1 min 48 sec and counting
JUnit Tes
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:9b3849050e1d: add overflow-menu icon (authored by mart).
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8034?vs=20040&id=20044
REVISION DETAIL
https://phabri
cfeck accepted this revision.
cfeck added a comment.
This revision is now accepted and ready to land.
REPOSITORY
R236 KWidgetsAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8029
To: ngraham, #frameworks, #vdg, dfaure, rkflx, davidedmundson, cfeck
Cc: cfeck, #framewor
cfeck accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R252 Framework Integration
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8036
To: ngraham, davidedmundson, #frameworks, cfeck
Cc: #frameworks
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/89/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Thu, 28 Sep 2017 15:40:43 +
Build duration:
1 min 20 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/85/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 28 Sep 2017 15:40:43 +
Build duration:
52 sec and counting
JUnit Tests
Nam
ngraham added a comment.
Submitted a patch for that, too: https://phabricator.kde.org/D8036
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8029
To: ngraham, #frameworks, #vdg, dfaure, rkflx, davidedmundson
Cc: cfeck, #frameworks
ngraham created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Make KStandardGuiItem::discard match QDialogButtonBox::Discard, which is
being changed in https://phabricator.kde.org/D8029
Completenes
ngraham added a comment.
Agreed.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8029
To: ngraham, #frameworks, #vdg, dfaure, rkflx, davidedmundson
Cc: cfeck, #frameworks
ngraham added reviewers: davidedmundson, Frameworks.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D8036
To: ngraham, davidedmundson, #frameworks
Cc: #frameworks
andreaska accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R266 Breeze Icons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8034
To: mart, andreask, andreaska
Cc: #frameworks
davidedmundson added a comment.
I think it's important that KStandardGuiItem::discard matches
QDialogButtonBox::Discard
You've cited what Qt does, but we override it in kstyle.cpp:374 with
dialog-cancel
If we go with this (and I really don't object) we should adjust KStyle too.
REP
ngraham added a reviewer: davidedmundson.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8029
To: ngraham, #frameworks, #vdg, dfaure, rkflx, davidedmundson
Cc: cfeck, #frameworks
davidedmundson abandoned this revision.
davidedmundson added a comment.
Edit. Didn't see that Ngraham had changed this also.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8024
To: davidedmundson, cfeck
Cc: ngraham, #frameworks
ngraham added a comment.
Hmm, I think edit-delete is the correct icon here, for two reasons:
1. That's what upstream Qt defaults to
2. dialog-cancel is more appropriate for a Cancel button (in fact that's what
cancel is already using). But Discard is a more destructive action than Cance
mart added a reviewer: andreask.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D8034
To: mart, andreask
Cc: #frameworks
mart created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Add the overflow menu which is used a lot especially in mobile apps.
It's a 3 dot icon called aso the "kebab" menu
BUG:385171
TEST PLAN
t
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/118/
Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
Date of build:
Thu, 28 Sep 2017 14:14:59 +
Build duration:
9 min 19 sec and counting
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/122/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 28 Sep 2017 14:14:59 +
Build duration:
4 min 3 sec and counting
cfeck added a comment.
Conflicts with https://phabricator.kde.org/D8024 which I had approved before
I was aware of the bug report.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8029
To: ngraham, #frameworks, #vdg, dfaure, rkflx
Cc: cfeck, #frameworks
ngraham edited the test plan for this revision.
ngraham added reviewers: Frameworks, VDG, dfaure, rkflx.
ngraham removed a project: Frameworks.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8029
To: ngraham, #frameworks, #vdg, dfaure, rkflx
Cc: #frameworks
ngraham created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
BUG: 385158
Use edit-delete icon for buttons that execute destructive discard actions.
This is what Upstream Qt originally had, but we
cfeck added a comment.
Hm, bug 385158 says we should use "edit-delete". Not sure who is right.
REPOSITORY
R236 KWidgetsAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8024
To: davidedmundson, cfeck
Cc: #frameworks
nibags added a reviewer: Framework: Syntax Highlighting.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D8028
To: nibags, #framework_syntax_highlighting
Cc: #frameworks
nibags created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This small update only modifies the highlighting of the keyword "name" in the
DBus rules.
Previously, the keyword "name" used the "Other
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/121/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 28 Sep 2017 12:10:57 +
Build duration:
7 min 45 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/117/
Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
Date of build:
Thu, 28 Sep 2017 12:10:57 +
Build duration:
3 min 49 sec and counting
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:cab8fd916079: [Containment Interface] Don't add
containment actions to applet actions on… (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabri
mart accepted this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8009
To: broulik, #plasma, hein, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
davidedmundson added a comment.
Thanks cfeck!
REPOSITORY
R114 Plasma Addons
BRANCH
launch-change
REVISION DETAIL
https://phabricator.kde.org/D7648
To: maxrd2, #plasma, davidedmundson
Cc: cfeck, #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff,
lesliezhai, ali-mohamed, je
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:284fc3ada24f: Fix ksysguard not starting on plasmoid
click (authored by maxrd2, committed by davidedmundson).
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7
cfeck added a comment.
David, the beta was released.
REPOSITORY
R114 Plasma Addons
BRANCH
launch-change
REVISION DETAIL
https://phabricator.kde.org/D7648
To: maxrd2, #plasma, davidedmundson
Cc: cfeck, #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff,
lesliezhai, ali-moha
cfeck accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R236 KWidgetsAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8024
To: davidedmundson, cfeck
Cc: #frameworks
davidedmundson created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
In frameworkintegration/src/kstyle/kstyle.cpp it is set to dialog-cancel
But here the standard item defaults to something else
broulik added a comment.
> If it were done that way, I could agree to the patch.
Agreed.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8021
To: ngraham, #frameworks, elvisangelaccio, broulik, dfaure
Cc: rkflx, #frameworks
rkflx added a comment.
In https://phabricator.kde.org/D8021#149796, @broulik wrote:
> I don't fully understand the bug report.
The key point from the bug report is probably this:
> If the config option 'editable location bar' is used
This patch disables `Esc` unconditiona
rkflx added a comment.
-1 from me. It's a feature, not a bug. `Esc` is the standard way to return to
previous GUI states, you use this subconsciously without needing to actively
think about some other way (at least I do). In addition, Windows Explorer also
does it the same way.
> Client
broulik added a comment.
The question is: why? I find Escape a natural way to exit editing and never
used Ctrl+L. I don't fully understand the bug report. If Ctrl+L should only
switch to edit mode, how would you exit again if you remove Escape handling?
INLINE COMMENTS
> kurlnavigator.h:454
70 matches
Mail list logo
