D7461: Add syntax highlighting for AppArmor Profiles.

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Thanks, I am fine with this now. Shall I push this for you, or do you have commit access as well? REPOSITORY R216 Syntax Highlighting BRANCH add-apparmor-syntax (branched from mast

D7461: Add syntax highlighting for AppArmor Profiles.

nibags added a comment. Ready! I've updated the license. If you need me to change something else (or if there is something you don't like), let me know. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7461 To: nibags, #kate, #framework_syntax_highlightin

D7461: Add syntax highlighting for AppArmor Profiles.

nibags updated this revision to Diff 19578. nibags added a comment. - License is changed to MIT REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7461?vs=18983&id=19578 BRANCH add-apparmor-syntax (branched from master) REVISION DETAIL https:/

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 73 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/73/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 16 Sep 2017 03:00:44 + Build duration: 27 min and counting JUnit Tests

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

marten marked an inline comment as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7823 To: marten, #frameworks, #build_system Cc: cgiboudeaux, cfeck, heikobecker

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

marten updated this revision to Diff 19576. marten marked an inline comment as done. marten added a comment. Updated as per review comments. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7823?vs=19570&id=19576 REVISION DETAIL https://phabric

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

marten marked 17 inline comments as done. marten added a comment. Diff updated. INLINE COMMENTS > cgiboudeaux wrote in FindPulseAudio.cmake:8-19 > It's a new module, change PULSEAUDIO to PulseAudio to match the module name. PULSEAUDIO -> PulseAudio changed throughout REPOSITORY R240 Extra

D7840: Fix trailing space visualization for RTL lines.

bcooksley added a comment. The hook doesn't cause the immediate closure of a diff. The hook asks Phabricator's background processes to initiate an update of the repository. When those commits are processed, the review gets closed. Depending on how busy Phabricator is processing other c

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

cgiboudeaux added inline comments. INLINE COMMENTS > FindGLIB2.cmake:10 > +# True if the GLib2 library is available > +# ``GLIB2_INCLUDE_DIR`` > +# The GLib2 include directory Call it GLIB2_INCLUDE_DIRS. > FindGLIB2.cmake:43 > +# > +# For details see the accompanying COPYING-CMAKE-SCRIP

D7837: Show kioslave names in the debug output

This revision was automatically updated to reflect the committed changes. Closed by commit R241:589ee216b091: Show kioslave names in the debug output (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7837?vs=19558&id=19572 REVISION DET

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/72/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 15 Sep 2017 16:20:05 + Build duration: 20 min and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 105 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/105/ Project: Frameworks kio kf5-qt5 XenialQt5.7 Date of build: Fri, 15 Sep 2017 16:29:33 + Build duration: 10 min and counting JUnit Tests Name: (root) F

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

marten updated this revision to Diff 19570. marten added a comment. Modules updated with standard header, documentation and copyright; endif() used throughout. Yes, Phonon does not use ECM but the modules there are very different to those in ECM anyway. Within Plasma+applications thes

D7840: Fix trailing space visualization for RTL lines.

safaalfulaij added a comment. Sorry, my mistake. The post-commit trigger thing didn't close this, maybe because the #post part is there /me how come I didn't notice! :| https://cgit.kde.org/ktexteditor.git/commit/?id=bb328146ecd64f97710eb09f568001cd4d40f622 REPOSITORY R39 KTextEditor RE

D7840: Fix trailing space visualization for RTL lines.

This revision was automatically updated to reflect the committed changes. Closed by commit R39:bb328146ecd6: Fix trailing space visualization for RTL lines. (authored by safaalfulaij). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7840?vs=19564&id=19568 R

D7461: Add syntax highlighting for AppArmor Profiles.

dhaumann added a comment. From what I can tell, the xml file looks quite good, although it contains many rules so it is hard to completely review this. With respect to MIT: We were discussing licensing last Akademy conference (this year), and the issue with LGPL is that we are not even s

D7841: kioexec: Do not start to watch a temporary copy until after the copy is complete

marten created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY As described in bug https://bugs.kde.org/show_bug.cgi?id=384500, there appears to be a problem when the receiving application of a file needs a temporary copy to be made (because of %F/%f in its

D7840: Fix trailing space visualization for RTL lines.

safaalfulaij added a comment. In https://phabricator.kde.org/D7840#146110, @kfunk wrote: > Indeed, thanks for those fixes. /me can see a nice blog post coming a long...? :) Not yet maybe There are other visualizations that are not working for RTL lines, like non-printable space

D7840: Fix trailing space visualization for RTL lines.

kfunk added a comment. Indeed, thanks for those fixes. /me can see a nice blog post coming a long...? :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7840 To: safaalfulaij, #ktexteditor, cullmann Cc: cullmann, kfunk, #frameworks, sars, dhaumann

D7840: Fix trailing space visualization for RTL lines.

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. In deed, looks correct now and bogus before. Please commit. Could you perhaps add the link to this https://phabricator.kde.org/D7840 to the comment in the code? then we can eas

D7840: Fix trailing space visualization for RTL lines.

safaalfulaij added a comment. Before: F3912046: Screenshot_٢٠١٧٠٩١٥_١٧٥٣٥٦.png After: F3912047: Screenshot_٢٠١٧٠٩١٥_١٧٥٦٢٨.png REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7

D7840: Fix trailing space visualization for RTL lines.

cullmann added a comment. Yeah, +1 ;=) Without screeny, we can't judge. In any case: thanks for taking care! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7840 To: safaalfulaij, #ktexteditor Cc: cullmann, kfunk, #frameworks, sars, dhaumann

D7840: Fix trailing space visualization for RTL lines.

kfunk added a comment. Could you add before/after screenshots for this? I think this could also help non-RTL users understand what you're fixing. Would be super helpful for me at least :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7840 To: safaalfulaij,

D7840: Fix trailing space visualization for RTL lines.

safaalfulaij created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Fix trailing space visualization for RTL lines. It was getting paint on top of the character (to the right of the cursor). TEST

D7839: Fix trailing space visualization for RTL lines

safaalfulaij abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7839 To: safaalfulaij Cc: kwrite-devel, #frameworks, cullmann, sars, dhaumann

D7839: Fix trailing space visualization for RTL lines

safaalfulaij created this revision. safaalfulaij added a project: Frameworks. Restricted Application added a project: Kate. REVISION SUMMARY Fix trailing space visualization for RTL lines. TEST PLAN N/A REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.

D7827: Syntax indexer: Catch invalid a-Z/A-Z ranges in regexps

dhaumann closed this revision. dhaumann added a comment. Committed with https://commits.kde.org/syntax-highlighting/dae1c761dd739a586fcd6d957510711bc5daff26 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7827 To: dhaumann, #framework_syntax_highlighting

D6233: KKeyServer: fix handling of KeypadModifier.

graesslin added a comment. In https://phabricator.kde.org/D6233#145981, @dfaure wrote: > Qt (at shortcut recording time) sees this as Meta+Shift+Print while KWindowSystem (xcbKeyPressEventToQt) sees it as Meta+Shift+SysReq. > > Qt does xkb_state_key_get_one_sym( state=51 , code=6b )

D7829: Fix kglobalaccel regression on Alt+Shift+arrowkey.

graesslin added a comment. How do we know that this doesn't break other code? This code is for example used in KWin's Alt+Tab handling which is it's own fair beast. Any changes here might break the code as it might be bug-to-bug compatible. We had the changes one month in master and nobo

KDE CI: Frameworks kparts kf5-qt5 WindowsMSVCQt5.9 - Build # 11 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kparts%20kf5-qt5%20WindowsMSVCQt5.9/11/ Project: Frameworks kparts kf5-qt5 WindowsMSVCQt5.9 Date of build: Fri, 15 Sep 2017 12:35:41 + Build duration: 35 min and counting JUnit Tests

KDE CI: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9 - Build # 26 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.9/26/ Project: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9 Date of build: Fri, 15 Sep 2017 12:35:36 + Build duration: 34 min and counting

D7837: Show kioslave names in the debug output

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. One can also put %{appname} in his $QT_MESSAGE_PATTERN for this :-) But yeah, in this case it's good to have it in for users too, who wouldn't think of that. REPOSITORY R241 KIO BRA

D7837: Show kioslave names in the debug output

elvisangelaccio created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This makes clear which kioslaves need fixing. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

cgiboudeaux added a comment. -1. They don't match the ECM coding style and code quality (doc, license, endif(), pkgconfig...) And : > kdelibs4support/cmake/modules/FindGLIB2.cmake > ecm/attic/modules/FindGLIB2.cmake These two are there for legacy purpose. > phonon/cmake/

Re: Translations on Mac (was Translations)

On Saturday September 09 2017 00:18:09 Jasem Mutlaq wrote: I'd say "anything is possible", including reproducing an "XDG-compliant" tree structure inside a Mac app bundle or a MSWin install directory. For app bundles it's not uncommon in other projects, AFAIK, configuring with something like --

D7827: Syntax indexer: Catch invalid a-Z/A-Z ranges in regexps

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks reasonable, one consistency check more is always good! (hehe, and even found already things) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/