dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Good catch. We will also increase the version number, run and possibly update
the unit tests, and push this later this day. Thanks!
REPOSITORY
R216 Syntax Highlighting
REVISION DETAI
wojnilowicz added a comment.
In https://phabricator.kde.org/D7787#145222, @cfeck wrote:
> This is for KWidgetsAddons, right?
Yes.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D7787
To: wojnilowicz, #frameworks
Cc: cfeck, tbaumgart, #kmymo
graesslin added a comment.
This seems to be a big problem. Kglobalaccell got more new bugs reported this
week, than normally in a year.
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D6233
To: dfaure, graesslin
Cc: broulik, martinkostolny, bcooksley, graesslin
gregsteuck created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Originally found and fixed by Sam Allen.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7792
AFFE
Mh
> set(CMAKE_LIBRARY_OUTPUT_DIRECTORY
I don't think that will do for production. "This property specifies
the directory into which library target files should be built.
Multi-configuration generators (VS, Xcode) append a per-configuration
subdirectory to the specified directory."
I *think* the
broulik added a comment.
Confirmed. I just today experienced the "Rectangular screenshot" keyboard
shortcut (Meta+Shift+PrintScreen) having stopped working on two machines.
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D6233
To: dfaure, graesslin
Cc: broulik,
martinkostolny added a comment.
Sorry, to be a bit late, but after updating to kwindowsystem 5.38, global
shortcuts "meta+shift+" and "alt+shift+" stopped
working on my system (Arch Linux). They can be configured no-problem (they are
recognized and saved in configuration), but they do nothin
El dimarts, 12 de setembre de 2017, a les 22:11:14 CEST, Marco Martin va
escriure:
> this is a quick and dirty attempt at this..
> i don't know how much it would break, but i think in order to have a
> correct import usable without install it should do something along the
> lines
Do I read correc
this is a quick and dirty attempt at this..
i don't know how much it would break, but i think in order to have a
correct import usable without install it should do something along the
lines
On Tue, Sep 12, 2017 at 8:49 PM, Marco Martin wrote:
> On Mon, Sep 11, 2017 at 4:59 PM, Harald Sitter wrot
bruns updated this revision to Diff 19458.
bruns added a comment.
Remove erroneous const, takeFirst requires a mutable list
REPOSITORY
R245 Solid
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7774?vs=19418&id=19458
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D
cfeck added a comment.
This is for KWidgetsAddons, right?
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D7787
To: wojnilowicz, #frameworks
Cc: cfeck, tbaumgart, #kmymoney
wojnilowicz created this revision.
wojnilowicz added a project: Frameworks.
REVISION SUMMARY
sizeHintForIndex returns lower value than sizeHintForColumn and because
of that horizontal scrollbar appears which is unnecessary.
Hardcoded 25 value has been changed to `vertical scrollbar width + 5
On Mon, Sep 11, 2017 at 4:59 PM, Harald Sitter wrote:
> Another option I can think of is "installing" to the build directory
> during cmake stage (i.e. construct a qml import path in
> $CMAKE_BINARY_DIR). That's only more complicated and altogether meh
> though, compared to simply adjusting the so
mgallien updated this revision to Diff 19450.
mgallien added a comment.
remove duplicated code
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7750?vs=19416&id=19450
BRANCH
fixPluginDelete
REVISION DETAIL
https://phabricator.kde.org/D7750
AFFECT
kossebau added a comment.
In https://phabricator.kde.org/D7580#144557, @dfaure wrote:
> In https://phabricator.kde.org/D7580#144518, @kossebau wrote:
>
> > When I read this initially, I guessed this method is just about the view
state. But is also bound to data-pulling by the kpart, g
kossebau updated this revision to Diff 19446.
kossebau added a comment.
add support for state restoring via BrowserExtension
REPOSITORY
R383 SVGPart
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7580?vs=19091&id=19446
BRANCH
supportstreamandreload
REVISION DETAIL
https://ph
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R245 Solid
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7774
To: bruns, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, a
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R245 Solid
BRANCH
arc1
REVISION DETAIL
https://phabricator.kde.org/D7773
To: bruns, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abe
anthonyfieroni added inline comments.
INLINE COMMENTS
> extractor.cpp:39-46
> +if (d) {
> +if (d->m_pluginLoader.isLoaded()) {
> +d->m_pluginLoader.unload();
> +} else {
> +delete d->m_plugin;
> +}
> +}
Make a method to call it, here and in
19 matches
Mail list logo
