zrax updated this revision to Diff 19256.
zrax added a comment.
Updated original patch with fixes for @dhaumann
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7699?vs=19253&id=19256
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org
safaalfulaij added inline comments.
INLINE COMMENTS
> broulik wrote in ProgressBar.qml:33
> That's pretty clever, actually,
>
> > A negative scale causes the item to be mirrored when rendered.
>
> However, not sure we can just blatantly mirror that graphic
Actually, it’s used in default QQC2 s
broulik added inline comments.
INLINE COMMENTS
> davidedmundson wrote in ProgressBar.qml:33
> I don't understand what this is doing?
That's pretty clever, actually,
> A negative scale causes the item to be mirrored when rendered.
However, not sure we can just blatantly mirror that graphic
REP
davidedmundson added inline comments.
INLINE COMMENTS
> ProgressBar.qml:33
> contentItem: Item {
> +scale: control.mirrored ? -1 : 1
> PlasmaCore.FrameSvgItem {
I don't understand what this is doing?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://p
safaalfulaij added a comment.
One widget I didn't know how to fix is the TabBar (The blue line that flows
from left to right for the first item.)
Other widgets are behaving the same as QQC2 ones, like BusyIndicator and
Dial, so I didn't change them. Not sure if they should be flipped or not
safaalfulaij created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Some widgets are missed up in RTL mode, this should fix it.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REV
zrax added a comment.
Sorry, I missed some of the later discussion when updating the patch... I'm
fine with either solution, I just want to know which is preferred :)
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7699
To: zrax, #kate, #framework_synta
zrax updated this revision to Diff 19253.
zrax added a comment.
Rework to search :/org.kde.syntax-highlighting/syntax-extra and
:<...>/themes-extra resource paths instead of introducing a new API.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D
zrax added a comment.
@cullmann, I like that suggestion better... It's closer to what I originally
tried, but was unable to because of the index cache. Are the resource paths
documented anywhere that I should update?
INLINE COMMENTS
> dhaumann wrote in syntaxrepository_test.cpp:18
> Is th
dhaumann added a comment.
@vkrause Would the solution Christoph proposes also work for all the cases in
the pim world, or is it not good enough?
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7699
To: zrax, #kate, #framework_syntax_hightlighting, dhauma
cullmann added a comment.
> That would also be an option. Note, though, that the current patch also
would allow that: repository.addCustomSearchPath(":/my-app-resource"); So with
this API, you have both, folders on disk, and support for custom resource files.
That is true, the question i
dhaumann added a comment.
That would also be an option. Note, though, that the current patch also would
allow that: repository.addCustomSearchPath(":/my-app-resource"); So with this
API, you have both, folders on disk, and support for custom resource files.
REPOSITORY
R216 Syntax Highlight
elvisangelaccio accepted this revision.
elvisangelaccio added a comment.
This revision is now accepted and ready to land.
In https://phabricator.kde.org/D6197#142588, @dfaure wrote:
> (strange that Phabricator still says "Needs Review" when this has two
approvals)
Probably because
cullmann added a comment.
Hmm, I think the idea is good.
But instead of adding API, could we not just define that an additional
resource dir is searched always?
e.g. like:
loadSyntaxFolder(repo,
QStringLiteral(":/org.kde.syntax-highlighting/syntax-extra"));
or something li
dhaumann added a comment.
Ok, I guess with your reasoning given this patch indeed makes sense.
To me, this patch along with the unit test already looks very good. I only
have minor comments, then this is good to go.
@vkrause Any comments from your side?
INLINE COMMENTS
> syntaxrepo
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7711
To: apol, #frameworks, mart, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesl
apol created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7711
AFFECTED FILES
org.kde.desktop/TextArea
rkflx planned changes to this revision.
rkflx added a comment.
Thanks for looking at this so quickly, Christoph! I believe you inspired me
to find a good solution. I'll submit updates over the weekend.
If you are interested in the backstory, read on:
> I probably miss the big picture
zrax added a comment.
@dhaumann yes, your guess is correct. I was experimenting with replacing a
difficult-to-maintain qscintilla fork with some custom syntax lexers with
QTextEdit + KSyntaxHighlighting + easier-to-maintain custom Kate-style syntax
definitions, in a non-KDE application. On
zrax updated this revision to Diff 19243.
zrax added a comment.
Add input files for new test case.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7699?vs=19242&id=19243
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7699
AFFEC
zrax updated this revision to Diff 19242.
zrax added a comment.
Adjust naming based on review comments; add test case for custom path.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7699?vs=19213&id=19242
BRANCH
master
REVISION DETAIL
http
habacker created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
see title
REPOSITORY
R303 KInit
BRANCH
temp
REVISION DETAIL
https://phabricator.kde.org/D7708
AFFECTED FILES
src/kdeinit/kinit_w
habacker edited the summary of this revision.
habacker added a reviewer: cfeck.
REPOSITORY
R303 KInit
REVISION DETAIL
https://phabricator.kde.org/D7707
To: habacker, cfeck
Cc: #frameworks
habacker created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
BUG:382920
REPOSITORY
R303 KInit
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7707
AFFECTED FILES
src/klauncher/kl
habacker created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REPOSITORY
R303 KInit
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7706
AFFECTED FILES
src/kdeinit/kinit_win.cpp
To: habacker
Cc: #fr
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130209/#review103691
---
Please use https://phabricator.kde.org/differential/diff/cre
vkrause added a comment.
I was actually thinking about adding this for the recent KMail template
highlighting patch, but decided to install the custom XML file into the default
path but mark it as hidden, as that was the immediately available solution. A
custom search path would be the clean
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130209/
---
Review request for KDE Frameworks.
Bugs: 382920
https://bugs.kde.org/
On Fri, Sep 1, 2017 at 3:02 PM, Marco Martin wrote:
> On Thu, Aug 31, 2017 at 5:06 PM, Marco Martin wrote:
>> any objection into pulling it into a framework? anything particular for the
>> procedure?
>
> as an update to that, i've update its cmake files and metadata files
> to be coherent with ot
dhaumann added subscribers: cullmann, vkrause, dhaumann.
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.
First of all, could you provide more details about why you need this
functionality? Is it in some other KDE app, or som
ilic added a comment.
I can't say about QtScript to QtQML conversion, but wrt. those FIXMEs,
removing variable argument lists obviously breaks compatibility, and especially
the acall function makes no sense without it.
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D7
kfunk added a comment.
Could someone fluent in QtScript/QtQML review this so we can merge it?
INLINE COMMENTS
> ktranscript.cpp:96
> // Interface functions.
> -Q_INVOKABLE QScriptValue load(); // actually has variable length
> argument list
> -Q_INVOKABLE QScriptValue setcall(co
32 matches
Mail list logo
